From patchwork Thu Oct 5 15:41:09 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 821901 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3y7H9g67k3z9sDB for ; Fri, 6 Oct 2017 02:43:35 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3y7H9g1VKFzDrJR for ; Fri, 6 Oct 2017 02:43:35 +1100 (AEDT) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=users.sourceforge.net (client-ip=212.227.17.11; helo=mout.web.de; envelope-from=elfring@users.sourceforge.net; receiver=) Received: from mout.web.de (mout.web.de [212.227.17.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3y7H784BD4zDrC6 for ; Fri, 6 Oct 2017 02:41:23 +1100 (AEDT) Received: from [192.168.1.2] ([77.181.51.69]) by smtp.web.de (mrweb101 [213.165.67.124]) with ESMTPSA (Nemesis) id 0McFTf-1dh5qi2amd-00JZPu; Thu, 05 Oct 2017 17:41:11 +0200 Subject: [PATCH 1/2] powerpc/oprofile/cell: Delete an error message for a failed memory allocation in three functions From: SF Markus Elfring To: linuxppc-dev@lists.ozlabs.org, oprofile-list@lists.sf.net, Al Viro , Benjamin Herrenschmidt , Michael Ellerman , Paul Mackerras , Robert Richter References: <596db1f4-5965-d6f8-af02-38b570b10d8a@users.sourceforge.net> Message-ID: Date: Thu, 5 Oct 2017 17:41:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <596db1f4-5965-d6f8-af02-38b570b10d8a@users.sourceforge.net> Content-Language: en-GB X-Provags-ID: V03:K0:Es2nF1ZBJ//ML3FBthVgI5NhcHZt3jrft9b+z8WZAwqr3QkME/o 9EM9DFN2mSOfD5hgs3YLJR6Uonk4h5OdUhpDvPtm/XNYNkhh00TKsc1GAgUa2cAh/h98BLr Y4ni+UU5/XBlp17CgKWzt42MYXcInLZoxaFKhZjlK8JxRrFGYGH9tjou7K13fCalxTSmhuF Ra0RmvwmwbSV044Nbg+3g== X-UI-Out-Filterresults: notjunk:1; V01:K0:u7bZmajNMTc=:mdDrMkZW9+Sj8aqw4XgXha a27v8PeW+OCmqNpanWp+ZMfkxWLeL6rQhtoSJU5JO9bkIpTZ9tgsymfzgtq+tJMhKCg/eY9lN 5Q3fzXoqVeWFxKwCF9gQiayoENR0otwNXixjofFG9pnvq8o5UjQAS6dDnOz+h0SNS68cfogU+ kLrx1HlfRNyKS7Mr1Hp3fecEBPb/HcrkjFq7J3e24uQlbXu6MMgwpxq3Khcns24ju1EvE4YQB ZfZGlAeoSDy75lj8rgaLptBTbSkfLM2+2fuD9JhYaWygw7qG/DVL61RS50Nhyn+X1JQEPIOmJ zmwGnEk/alZ8Imh4T53/QR4jBjnDnlBhpHToRkUA+/0aIWft4KQsDpOvuq+WVQSjxOTPH1OVh J/lmehZE0ryMlZQmMlHSgkdPNCB8ecStcXTu0Tea68ZgEh2yWUlNFZSRMevBzYjITKpOer27e 9B5ninRdmOXiMziOhRbMguwx5ti/4El92vP+AiCeOv/RvoLsfU2B/Mkoz2LTO761RLUmqsTma JAF57KLOkvPeqx3N2+Zjgcr/3msw/SOSyISPQZtLqAem1cY0un+hl10f3wT13nbgHh54aGusE 5uovp9Zxx4Y3N3lQHpAfG9qrmSs1SIjLBLf+AR/14OIUsSHBoUjTuLBln5WMzUVYXfDyHB/is +41GabY1OcKx+XLmgr1NllP+jCSwVIbGXuPwzeu9mwixeUbFmr6MvT2qvHyI9IZVSThZNLf6B cyM3Uj+SwnUlgXB7KPzSOFYJ3P+xbX3+WuYznjFYrGG/Ie157/qCOjlIdOZUolI3QONCKxHLe /ajUpFoT9L9jzaVv/1MH4BMf2udhGwtFbnldDZZRGm1sPnbaVU= X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, LKML Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Markus Elfring Date: Thu, 5 Oct 2017 17:10:11 +0200 Omit extra messages for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- arch/powerpc/oprofile/cell/spu_task_sync.c | 8 -------- arch/powerpc/oprofile/cell/vma_map.c | 2 -- 2 files changed, 10 deletions(-) diff --git a/arch/powerpc/oprofile/cell/spu_task_sync.c b/arch/powerpc/oprofile/cell/spu_task_sync.c index 44d67b167e0b..f1dd732b2998 100644 --- a/arch/powerpc/oprofile/cell/spu_task_sync.c +++ b/arch/powerpc/oprofile/cell/spu_task_sync.c @@ -210,9 +210,6 @@ prepare_cached_spu_info(struct spu *spu, unsigned long objectId) */ info = kzalloc(sizeof(struct cached_info), GFP_KERNEL); if (!info) { - printk(KERN_ERR "SPU_PROF: " - "%s, line %d: create vma_map failed\n", - __func__, __LINE__); retval = -ENOMEM; goto err_alloc; } @@ -481,11 +478,6 @@ static int oprofile_spu_buff_create(void) GFP_KERNEL); if (!spu_buff[spu].buff) { - printk(KERN_ERR "SPU_PROF: " - "%s, line %d: oprofile_spu_buff_create " - "failed to allocate spu buffer %d.\n", - __func__, __LINE__, spu); - /* release the spu buffers that have been allocated */ while (spu >= 0) { kfree(spu_buff[spu].buff); diff --git a/arch/powerpc/oprofile/cell/vma_map.c b/arch/powerpc/oprofile/cell/vma_map.c index c579b16845da..a115d9ede053 100644 --- a/arch/powerpc/oprofile/cell/vma_map.c +++ b/arch/powerpc/oprofile/cell/vma_map.c @@ -72,8 +72,6 @@ vma_map_add(struct vma_to_fileoffset_map *map, unsigned int vma, struct vma_to_fileoffset_map *new = kzalloc(sizeof(struct vma_to_fileoffset_map), GFP_KERNEL); if (!new) { - printk(KERN_ERR "SPU_PROF: %s, line %d: malloc failed\n", - __func__, __LINE__); vma_map_free(map); return NULL; } From patchwork Thu Oct 5 15:42:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 821902 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3y7HCN57mdz9rxm for ; Fri, 6 Oct 2017 02:45:04 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3y7HCN4GlrzDrCQ for ; Fri, 6 Oct 2017 02:45:04 +1100 (AEDT) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=users.sourceforge.net (client-ip=212.227.17.12; helo=mout.web.de; envelope-from=elfring@users.sourceforge.net; receiver=) Received: from mout.web.de (mout.web.de [212.227.17.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3y7H8W1nXNzDrCp for ; Fri, 6 Oct 2017 02:42:34 +1100 (AEDT) Received: from [192.168.1.2] ([77.181.51.69]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0M7KN0-1d3L642acY-00x5QQ; Thu, 05 Oct 2017 17:42:10 +0200 Subject: [PATCH 2/2] powerpc/oprofile/cell: Improve a size determination in two functions From: SF Markus Elfring To: linuxppc-dev@lists.ozlabs.org, oprofile-list@lists.sf.net, Al Viro , Benjamin Herrenschmidt , Michael Ellerman , Paul Mackerras , Robert Richter References: <596db1f4-5965-d6f8-af02-38b570b10d8a@users.sourceforge.net> Message-ID: <8c013b7f-a0b0-26e8-ef4a-76f5a48d73c8@users.sourceforge.net> Date: Thu, 5 Oct 2017 17:42:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <596db1f4-5965-d6f8-af02-38b570b10d8a@users.sourceforge.net> Content-Language: en-GB X-Provags-ID: V03:K0:xYiRymURZzvd5a83U4Lss/q/uUArdHjeJy7oHILh6v/kQDQae6x 0am/3BkrkPU4HVQ35m47jayzs7pYiNjMDKId16GmWBgSMZ3rmaIXJEWZsULSt3hw4o6/Xnb gHIQ+BItW+nrpeyg1GmvpO5IBi1ci3T7ZUc2bZVAQbfb3XMZxzCQhlM+MSW8e9dT95gtxgx NL5s16VBYIV3vQ/UJFTBg== X-UI-Out-Filterresults: notjunk:1; V01:K0:PJ+gAINSMxA=:9mnagR0Gys5dqFwFB0opJr BXvCAA+ui/MjxUg9urXhrv+TB72YPR+RDQ4yv5Uv8MISyjUSNDYOUBk9kKrF3174NFKzC9S3n 1NFDUTyV/xZY6KdM0TMWdjGZbMZr2Xz6eVoais72RVQcjn5dTOnql056Tk7yDn8ZgZ5dP+Nhy lO1KX1nRgiYfqNHO0MUJiHKdS8ZKgEIZB2TYU7SIU75WvDBPpYvnJhIhuET5bkGpeviLVMBp7 +hlaZVhFZuTVt9G8k7Z0ArjBM587q4vlTEbkiOpxTsOGTiUNvHrmTI3FQoyVKvk7cvWtL6sUE jXOAmdKxacEGG+/vUpX2zd1ZsPjqQimRw+D8HYnUBLBeZNFIsRDd6cTXainYzkJ0rUaLj+l9y Ga58FAaJsuACd+82aYI7MhqJXk4PASjs5WmLhdFTWLSq7Y/uBcXwANIiYfkVExbaeIK9NiYPv weNIT/BUNt1plvcjp/EJ6CX7QZBFmWyJW5yOYYzXoiRTGYuXF29rr97U/lu9cdzTv9LPRhAWf munCdv3MtqYRLS0+2fEzI9jglhoNgam0d3CowniwOtCX/IoR824DD8i5Y8D246J0UNzZfgbjr NOz96Y+y2C5np8hyZQC1HL7kino0kFk+IM5uGQjHGs2XLtuLr+3EnhR5UANe+Zt2yftMNNoJI lglDqw2W5cCD92Eq8JBoFOtNeKtFT67Bat3ZfB90fx+bCgko9vvHVvxFTHgcmLw2lJs8lca3c 27YAaPTyT9sukz3FbX5wZHneSJzpYGqvx/UskPLDtsoB07jV8KVRhwGtJxP07oa7n/TApKFRZ Fl88xM5RopdNPqeH9Uzl4WpfApyN5pg2n0yw3R9kW177Vjx8yQ= X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, LKML Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Markus Elfring Date: Thu, 5 Oct 2017 17:18:33 +0200 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- arch/powerpc/oprofile/cell/spu_task_sync.c | 2 +- arch/powerpc/oprofile/cell/vma_map.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/oprofile/cell/spu_task_sync.c b/arch/powerpc/oprofile/cell/spu_task_sync.c index f1dd732b2998..8ab442925296 100644 --- a/arch/powerpc/oprofile/cell/spu_task_sync.c +++ b/arch/powerpc/oprofile/cell/spu_task_sync.c @@ -208,7 +208,7 @@ prepare_cached_spu_info(struct spu *spu, unsigned long objectId) /* Create cached_info and set spu_info[spu->number] to point to it. * spu->number is a system-wide value, not a per-node value. */ - info = kzalloc(sizeof(struct cached_info), GFP_KERNEL); + info = kzalloc(sizeof(*info), GFP_KERNEL); if (!info) { retval = -ENOMEM; goto err_alloc; diff --git a/arch/powerpc/oprofile/cell/vma_map.c b/arch/powerpc/oprofile/cell/vma_map.c index a115d9ede053..03de415a377c 100644 --- a/arch/powerpc/oprofile/cell/vma_map.c +++ b/arch/powerpc/oprofile/cell/vma_map.c @@ -69,8 +69,8 @@ vma_map_add(struct vma_to_fileoffset_map *map, unsigned int vma, unsigned int size, unsigned int offset, unsigned int guard_ptr, unsigned int guard_val) { - struct vma_to_fileoffset_map *new = - kzalloc(sizeof(struct vma_to_fileoffset_map), GFP_KERNEL); + struct vma_to_fileoffset_map *new = kzalloc(sizeof(*new), GFP_KERNEL); + if (!new) { vma_map_free(map); return NULL;