From patchwork Tue Sep 11 15:04:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Bauer X-Patchwork-Id: 968592 X-Patchwork-Delegate: hauke@hauke-m.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=david-bauer.net Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="C3nWSrvL"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 428pBc3gngz9s2P for ; Wed, 12 Sep 2018 01:05:44 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:Message-Id: Date:To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=ufYx+1gMtcwv2l0IoV10IGYyMfpuJLykuDGXt5pOFTo=; b=C3nWSrvLQauvks ylX1yXqd8o4zTOSroF7+gVrWoni84dOLiFOBrErvQW1ohXLUQQpVw24iemjngi8g1Fhmu9ZtIpMun +fXfv5jIBBrHmlZQYDMDL+763rxNf8E+HwP6IicfcXhK/hZ+GiMdZ0sJfRkvbbyg4Oa3sTgX9BSg1 jfn4sWCG87qD83MyfAu6SFoH9Gy/XNBnYcywTIo+si09zWJ0Zu8zGllSpdAIGBuqEnlYFYFeZY5vy LUyXn0Kkv4rL/5zBVJvhYx+WfGLjpiFEDTjPsvriLa+gfbI7djJ0bA5lttV7LnZtx0DkgU0ZCF4np qGMLgMCVCu7KY9JMQWig==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fzkET-0002X2-Ry; Tue, 11 Sep 2018 15:05:37 +0000 Received: from mars.blocktrron.ovh ([51.254.112.43] helo=mail.blocktrron.ovh) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fzkDo-0000t3-Ux for openwrt-devel@lists.openwrt.org; Tue, 11 Sep 2018 15:04:59 +0000 Received: from localhost.localdomain (p20030071CF0CF900AAD771D25AF29F21.dip0.t-ipconnect.de [IPv6:2003:71:cf0c:f900:aad7:71d2:5af2:9f21]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.blocktrron.ovh (Postfix) with ESMTPSA id DAD811E2B1; Tue, 11 Sep 2018 17:04:41 +0200 (CEST) From: David Bauer To: openwrt-devel@lists.openwrt.org Date: Tue, 11 Sep 2018 17:04:16 +0200 Message-Id: <20180911150417.13983-1-mail@david-bauer.net> X-Mailer: git-send-email 2.18.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180911_080457_176441_A8748955 X-CRM114-Status: UNSURE ( 9.98 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.0 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record Subject: [OpenWrt-Devel] [PATCH 1/2] ar71xx: flag FritzBox 4020 buttons as active low X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igor.scheller@igorshp.de, David Bauer MIME-Version: 1.0 Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org Buttons of AVM FritzBox 4020 are incorrectly flagged as active high. This was an oversight as RFKill button was working as expected even with incorrectly flagged GPIO. Signed-off-by: David Bauer --- This commit should also be applied to the openwrt-18.06 branch as the issue is also present there. target/linux/ar71xx/files/arch/mips/ath79/mach-fritz4020.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/linux/ar71xx/files/arch/mips/ath79/mach-fritz4020.c b/target/linux/ar71xx/files/arch/mips/ath79/mach-fritz4020.c index ed7f9a8b3e..c00cf681b2 100644 --- a/target/linux/ar71xx/files/arch/mips/ath79/mach-fritz4020.c +++ b/target/linux/ar71xx/files/arch/mips/ath79/mach-fritz4020.c @@ -169,7 +169,7 @@ static struct gpio_keys_button fritz4020_gpio_keys[] __initdata = { .code = KEY_RFKILL, .debounce_interval = FRITZ4020_KEYS_DEBOUNCE_INTERVAL, .gpio = FRITZ4020_GPIO_BTN_WLAN, - .active_low = 0, + .active_low = 1, }, { .desc = "WPS button", @@ -177,7 +177,7 @@ static struct gpio_keys_button fritz4020_gpio_keys[] __initdata = { .code = KEY_WPS_BUTTON, .debounce_interval = FRITZ4020_KEYS_DEBOUNCE_INTERVAL, .gpio = FRITZ4020_GPIO_BTN_WPS, - .active_low = 0, + .active_low = 1, }, }; From patchwork Tue Sep 11 15:04:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Bauer X-Patchwork-Id: 968591 X-Patchwork-Delegate: hauke@hauke-m.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=david-bauer.net Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YOoxm440"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 428pB45MRSz9s2P for ; Wed, 12 Sep 2018 01:05:14 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:References: In-Reply-To:Message-Id:Date:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=33S+TosxrTJdgzHqcZ7n4VfuvluQxFnvNpY1uKKpWSs=; b=YOoxm440vLtLIX BuCuF9a6Q5e1wbPaT39ILwyZzvoOldSppM/QPR57ZMG8+XSG0iLIAKYh4Whm4aglwHybMFjrhBysO YP7Fpes6rtuaJnS/LK6wwM3ra6JTMoEhtoMjSdR5VGESgSSpBL9BVgsorMLvbJnCtN8S5FN9fFJ+B vFPLOY1ekEQkJ67cot7sp0voDB1FsbMZi5y07D1XMkbM8Gun05LYrDkrdeV77QHag/cDyaITj1Kr0 wNiz1MI1ZjDx0h6SxlV6/2kQLzSvsQIlq4FdNasstZ50sz73aHSgdzHo7MTk6TnIacYV0nZOyLTQ/ xICPsgRM62IkzlpiUzbQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fzkDt-00015J-IU; Tue, 11 Sep 2018 15:05:01 +0000 Received: from mars.blocktrron.ovh ([51.254.112.43] helo=mail.blocktrron.ovh) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fzkDp-00010T-M4 for openwrt-devel@lists.openwrt.org; Tue, 11 Sep 2018 15:04:59 +0000 Received: from localhost.localdomain (p20030071CF0CF900AAD771D25AF29F21.dip0.t-ipconnect.de [IPv6:2003:71:cf0c:f900:aad7:71d2:5af2:9f21]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.blocktrron.ovh (Postfix) with ESMTPSA id 8B11D1F0AA; Tue, 11 Sep 2018 17:04:45 +0200 (CEST) From: David Bauer To: openwrt-devel@lists.openwrt.org Date: Tue, 11 Sep 2018 17:04:17 +0200 Message-Id: <20180911150417.13983-2-mail@david-bauer.net> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180911150417.13983-1-mail@david-bauer.net> References: <20180911150417.13983-1-mail@david-bauer.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180911_080457_879600_F36823C6 X-CRM114-Status: UNSURE ( 9.20 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.0 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record Subject: [OpenWrt-Devel] [PATCH 2/2] ath79: flag FritzBox 4020 buttons as active low X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igor.scheller@igorshp.de, David Bauer MIME-Version: 1.0 Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org Buttons of AVM FritzBox 4020 are incorrectly flagged as active high. This was an oversight as RFKill button was working as expected even with incorrectly flagged GPIO. Signed-off-by: David Bauer --- target/linux/ath79/dts/qca9561_avm_fritz4020.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/linux/ath79/dts/qca9561_avm_fritz4020.dts b/target/linux/ath79/dts/qca9561_avm_fritz4020.dts index 6b30c036ea..8489c8a1e6 100644 --- a/target/linux/ath79/dts/qca9561_avm_fritz4020.dts +++ b/target/linux/ath79/dts/qca9561_avm_fritz4020.dts @@ -96,13 +96,13 @@ wps_button { label = "WPS button"; linux,code = ; - gpios = <&gpio 2 GPIO_ACTIVE_HIGH>; + gpios = <&gpio 2 GPIO_ACTIVE_LOW>; }; wlan_button { label = "WLAN button"; linux,code = ; - gpios = <&gpio 21 GPIO_ACTIVE_HIGH>; + gpios = <&gpio 21 GPIO_ACTIVE_LOW>; }; }; };