From patchwork Tue Sep 11 14:54:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: jun qian X-Patchwork-Id: 968582 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-i2c-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=163.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=163.com header.i=@163.com header.b="PdekQRhr"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 428ny93lRBz9s4V for ; Wed, 12 Sep 2018 00:54:57 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726876AbeIKTye (ORCPT ); Tue, 11 Sep 2018 15:54:34 -0400 Received: from m12-15.163.com ([220.181.12.15]:38899 "EHLO m12-15.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726622AbeIKTye (ORCPT ); Tue, 11 Sep 2018 15:54:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=IT2fj+Ts6vAYZSMAC4 J7058Hi64sfKtjDNC9p+i7Smw=; b=PdekQRhrLwlUW7CW35mWU3XVbMcBxHSefz PpuQxAMgUHmG50yvRSkltCDPpWKJxIOuICRYTJPCvAJhriveEnKduNbTGyZW0UEC Z66tqVFe6Eeq8AClkPtIovQkW3E6cqQWChFnR4kzIawUfJnnRxCDRkvWsRG4AGwG WzfOPCA4M= Received: from localhost (unknown [183.134.187.192]) by smtp11 (Coremail) with SMTP id D8CowAC3Nco315dbQ+qNGw--.31967S5; Tue, 11 Sep 2018 22:54:49 +0800 (CST) From: jun qian To: Laxman Dewangan , Thierry Reding , Jonathan Hunter Cc: linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, jun qian Subject: [PATCH] i2c: i2c-tegra: replace spin_lock_irqsave with spin_lock in ISR Date: Tue, 11 Sep 2018 07:54:46 -0700 Message-Id: <20180911145446.53621-1-hangdianqj@163.com> X-Mailer: git-send-email 2.17.1 X-CM-TRANSID: D8CowAC3Nco315dbQ+qNGw--.31967S5 X-Coremail-Antispam: 1Uf129KBjvdXoW7Jr1rAF4xAFWUKr17CryfWFg_yoWkKFX_tw 4Uu3srZF1jywn8Ar17JryfZryjgFnYgr1xWrZ2yasIk34jq3WDJF4DZryfCrWUX3ZFka1a q34q9F1xursxtjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUbeOJ5UUUUU== X-Originating-IP: [183.134.187.192] X-CM-SenderInfo: pkdqwvpldq1yi6rwjhhfrp/1tbiJxm+R1XloCtc8AAAsQ Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org As you are already in ISR, it is unnecessary to call spin_lock_irqsave. Signed-off-by: jun qian Reviewed-by: Dmitry Osipenko Acked-by: Thierry Reding --- drivers/i2c/busses/i2c-tegra.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index 60c8561fbe65..59f31d3a508f 100644 --- a/drivers/i2c/busses/i2c-tegra.c +++ b/drivers/i2c/busses/i2c-tegra.c @@ -608,11 +608,10 @@ static irqreturn_t tegra_i2c_isr(int irq, void *dev_id) u32 status; const u32 status_err = I2C_INT_NO_ACK | I2C_INT_ARBITRATION_LOST; struct tegra_i2c_dev *i2c_dev = dev_id; - unsigned long flags; status = i2c_readl(i2c_dev, I2C_INT_STATUS); - spin_lock_irqsave(&i2c_dev->xfer_lock, flags); + spin_lock(&i2c_dev->xfer_lock); if (status == 0) { dev_warn(i2c_dev->dev, "irq status 0 %08x %08x %08x\n", i2c_readl(i2c_dev, I2C_PACKET_TRANSFER_STATUS), @@ -670,7 +669,7 @@ static irqreturn_t tegra_i2c_isr(int irq, void *dev_id) complete(&i2c_dev->msg_complete); done: - spin_unlock_irqrestore(&i2c_dev->xfer_lock, flags); + spin_unlock(&i2c_dev->xfer_lock); return IRQ_HANDLED; }