From patchwork Mon Sep 3 18:02:28 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Alex G." X-Patchwork-Id: 965521 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pci-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="IqwcvWw5"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4242Hn0qysz9sSX for ; Tue, 4 Sep 2018 06:53:41 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727368AbeICWYT (ORCPT ); Mon, 3 Sep 2018 18:24:19 -0400 Received: from mail-oi0-f65.google.com ([209.85.218.65]:40269 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727271AbeICWYT (ORCPT ); Mon, 3 Sep 2018 18:24:19 -0400 Received: by mail-oi0-f65.google.com with SMTP id l202-v6so2249320oig.7; Mon, 03 Sep 2018 11:03:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=P8070j0pHB8FWga0Ow2mDVroSkOVwLt7/K7gOaS7NoM=; b=IqwcvWw5xjRsU9a6k/euqg2vuXmsZW+BrOI6gKcrP5U/+5LttCMgeJq/cBoEyiF4iN fdt6l5vBB/ZAeVGY0xFf044Zx1JynUidYKUmJGYAn/EyQViicVy7/7W18r1GjZY8Bwsp 5NeQbegFUjD4z35dnRtu/qnJEyISCkvn4DyS8qRoitTHHiBjlOvMXnYhEC8jkNLCjQ8d e47rcLsT/TrJFgSUWRjoAhMGtSgV7rTUaquNzVDK8EywQepOVpC3XRjtgsMBhqQEbFUI tL0UE5YtSHGSfuafNvis7wAbXJ+lJRqKDar2kWcKdte6Y4c7daC+C3jinTRpIeGZzGb7 VHFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=P8070j0pHB8FWga0Ow2mDVroSkOVwLt7/K7gOaS7NoM=; b=SII0H03n2uqMqFaXnxGEQPXlfPmjBVP/STnOWUqwREHZzBEpvdI41sXhmp12r5WboL uypy2HnZGnrW0rwzFSVQCnRHDryvZDJESUKJZDfvz5k18hHafQ5wIHI8R7//cani5sNu hyiUm6Q7UfPDIfoZUoQsBdnDjl6g7o4vOl2TPt9dp6g7RoQd6kzvzW2AIOu7edK1qXJE fQ7P4ch5RWBCD6oYO15mm7a448H2OgqEsstPcB8TxfDScFJ5NNFDDHZu/Xy2pTOixFCQ J0N9uMWOiIMc9owfCywQAp1ol8nF6u2OWKNvuC3i1iXny531pLm1GmYBgBew0SyK1/SK jXZg== X-Gm-Message-State: APzg51BafY1VmPda4ZvMvhzmVz1Q6D3WwX4M1lwGoA1ZvGL9dsxKN50x UjSjGemnylXZOdbn/8XY+A4YJwJA6oM= X-Google-Smtp-Source: ANB0VdZpO2FfJq10Tc9XyyBRe0tbkdGETay7ed6FYojvwe8I8b/SN8T+5gmPDQRvUl1qKgrHWsjxAg== X-Received: by 2002:aca:bdc4:: with SMTP id n187-v6mr19765754oif.3.1535997781153; Mon, 03 Sep 2018 11:03:01 -0700 (PDT) Received: from nuclearis2-1.lan (c-98-195-139-126.hsd1.tx.comcast.net. [98.195.139.126]) by smtp.gmail.com with ESMTPSA id q124-v6sm15785737oif.8.2018.09.03.11.03.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Sep 2018 11:03:00 -0700 (PDT) From: Alexandru Gagniuc To: linux-pci@vger.kernel.org, bhelgaas@google.com Cc: keith.busch@intel.com, alex_gagniuc@dellteam.com, austin_bolen@dell.com, shyam_iyer@dell.com, Alexandru Gagniuc , Ariel Elior , everest-linux-l2@cavium.com, "David S. Miller" , Michael Chan , Ganesh Goudar , Jeff Kirsher , Tariq Toukan , Saeed Mahameed , Leon Romanovsky , Jakub Kicinski , Dirk van der Merwe , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, oss-drivers@netronome.com Subject: [PATCH 1/9] PCI: sysfs: Export available PCIe bandwidth Date: Mon, 3 Sep 2018 13:02:28 -0500 Message-Id: <20180903180242.14504-2-mr.nuke.me@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180903180242.14504-1-mr.nuke.me@gmail.com> References: <20180903180242.14504-1-mr.nuke.me@gmail.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org For certain bandwidth-critical devices (e.g. multi-port network cards) it is useful to know the available bandwidth to the root complex. This information is only available via the system log, which doesn't account for link degradation after probing. With a sysfs attribute, we can computes the bandwidth on-demand, and will detect degraded links. Signed-off-by: Alexandru Gagniuc --- drivers/pci/pci-sysfs.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c index 9ecfe13157c0..6658e927b1f5 100644 --- a/drivers/pci/pci-sysfs.c +++ b/drivers/pci/pci-sysfs.c @@ -218,6 +218,18 @@ static ssize_t current_link_width_show(struct device *dev, } static DEVICE_ATTR_RO(current_link_width); +static ssize_t available_bandwidth_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct pci_dev *pci_dev = to_pci_dev(dev); + u32 bw_avail; + + bw_avail = pcie_bandwidth_available(pci_dev, NULL, NULL, NULL); + + return sprintf(buf, "%u.%03u Gb/s\n", bw_avail / 1000, bw_avail % 1000); +} +static DEVICE_ATTR_RO(available_bandwidth); + static ssize_t secondary_bus_number_show(struct device *dev, struct device_attribute *attr, char *buf) @@ -786,6 +798,7 @@ static struct attribute *pcie_dev_attrs[] = { &dev_attr_current_link_width.attr, &dev_attr_max_link_width.attr, &dev_attr_max_link_speed.attr, + &dev_attr_available_bandwidth.attr, NULL, }; From patchwork Mon Sep 3 18:02:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Alex G." X-Patchwork-Id: 965522 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pci-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="FUVH1QzP"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4242Hp0j1bz9sML for ; Tue, 4 Sep 2018 06:53:42 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727538AbeICWY0 (ORCPT ); Mon, 3 Sep 2018 18:24:26 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:46399 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727271AbeICWYZ (ORCPT ); Mon, 3 Sep 2018 18:24:25 -0400 Received: by mail-oi0-f68.google.com with SMTP id y207-v6so2185598oie.13; Mon, 03 Sep 2018 11:03:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Fg2A3DvOXX8NgTgO2joawBOfX3jENRiRELhCGPGFnmQ=; b=FUVH1QzPclM7FuFFutpHbB8g6/ZDBvlTSRivruOhDh/cl50fkuxEvCZaAR6CdL6n4i z55fEilhKZUAT82/nPe8xBi889/2AhyqQpmE3eUlWJjAsh2XdzSZ/P9z/nPwloeheU9o VubQYGgFZfmg19l9ZSFJhkVvTBMMh1iZenAmLpCs3hNWKuOuWXGE/K8+/DLgThgWAsZU r4fxUcy6ZT/HwZ/+WTNm6YlLhtaDA+Zpp3/wmPwtfcQLZ144UNKfID8UjQcDJUGOCmuv hScBgdT/ZMFnYl/MJL/6Y5XE6LUPh+JYOmcvYst+AxoOuBDENNDJE1Zxh4F6oNdZ9cUN Ozgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Fg2A3DvOXX8NgTgO2joawBOfX3jENRiRELhCGPGFnmQ=; b=f9V5RGWBK6RB2IAVV2Cf7pORdLQDnKMOGkSriP2a6L3w3ja5Dufyv0PYF8yWrZzx/Z DdxG0hNaNFmHulJTYeVUC63u2DQKbsYHDnvXpCirn7H+8qHZEN848jjcOHBV+8JnW6jI ZbVjFHwzaOo0cEpNZRszCWXvFiRVbLwoLNifRRlRHhanIbwebzsnDuYct94nYdhtTc2M 1s/xDOBBHQMVInyZxMA2rr4p7KygqslwPi4rxSpepJYEuZV4wIfL3RfSO05L8/cyMppl FroENW7LsahmJp0h6BtCzLJ32wi524RbOdO4DPyxPyWu2CG4y1n3qlzTWxOAQkSlIV54 zx3A== X-Gm-Message-State: APzg51DWLInMR0PrMTJo+EEfvkS11izkuGsDdXVvMYyarH0hOA4XYK2d ar2BvX31GuRyEdWw05vuE0nS+XO9HNE= X-Google-Smtp-Source: ANB0VdYtc/2GklzEV/Fv5McahDTZEEyTiC2FkM0CbLsEMnKOgM3MmJnvGFINCb8jnz1cj9r0kcTsQw== X-Received: by 2002:aca:4dca:: with SMTP id a193-v6mr19653879oib.343.1535997787495; Mon, 03 Sep 2018 11:03:07 -0700 (PDT) Received: from nuclearis2-1.lan (c-98-195-139-126.hsd1.tx.comcast.net. [98.195.139.126]) by smtp.gmail.com with ESMTPSA id q124-v6sm15785737oif.8.2018.09.03.11.03.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Sep 2018 11:03:07 -0700 (PDT) From: Alexandru Gagniuc To: linux-pci@vger.kernel.org, bhelgaas@google.com Cc: keith.busch@intel.com, alex_gagniuc@dellteam.com, austin_bolen@dell.com, shyam_iyer@dell.com, Alexandru Gagniuc , Ariel Elior , everest-linux-l2@cavium.com, "David S. Miller" , Michael Chan , Ganesh Goudar , Jeff Kirsher , Tariq Toukan , Saeed Mahameed , Leon Romanovsky , Jakub Kicinski , Dirk van der Merwe , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, oss-drivers@netronome.com Subject: [PATCH 2/9] bnx2x: Do not call pcie_print_link_status() Date: Mon, 3 Sep 2018 13:02:29 -0500 Message-Id: <20180903180242.14504-3-mr.nuke.me@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180903180242.14504-1-mr.nuke.me@gmail.com> References: <20180903180242.14504-1-mr.nuke.me@gmail.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org This is now done by the PCI core to warn of sub-optimal bandwidth. Signed-off-by: Alexandru Gagniuc --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c index 71362b7f6040..9bd0852d9a66 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c @@ -14100,7 +14100,6 @@ static int bnx2x_init_one(struct pci_dev *pdev, board_info[ent->driver_data].name, (CHIP_REV(bp) >> 12) + 'A', (CHIP_METAL(bp) >> 4), dev->base_addr, bp->pdev->irq, dev->dev_addr); - pcie_print_link_status(bp->pdev); bnx2x_register_phc(bp); From patchwork Mon Sep 3 18:02:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Alex G." X-Patchwork-Id: 965523 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pci-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Y6mlmfty"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4242Hq3gCLz9sPC for ; Tue, 4 Sep 2018 06:53:43 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727626AbeICWYd (ORCPT ); Mon, 3 Sep 2018 18:24:33 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:44031 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727271AbeICWYd (ORCPT ); Mon, 3 Sep 2018 18:24:33 -0400 Received: by mail-oi0-f68.google.com with SMTP id b15-v6so2210256oib.10; Mon, 03 Sep 2018 11:03:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=2rUDCjn6Un8uQ3UH5Wl+sVjayMg0FP/H65oHDzFkYLI=; b=Y6mlmftytGWcArgfLjvCYn18LzaWx7ey9Jnil/5Rca8XNVU1nPxGr3nqbRzqUSHhWD SUz7+c1OIKf4yxD4SIfkQZdgCFRBDAnc6e0OE4hPoHBUygWWAYAUXeNwEULd/YW/PQwa isx5wbrhp6dPhXWaYH+a96i4LEHDfnP+CpVSL0823wx1YGiT+Bzz1CP39V8FDqmezhC+ kTAJBw0cza+PBqqynDbwifELtUP/u6ZMvKxF4gOKXEH8zM2gsoxHlXb2w1nEB5TeN/20 txLESNR0kmxITEOOHZ/p1szfnoewMREfnd+yeSH3XJr7lGZRxlR7Gt3OkqeU9OV/aoA+ u2lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=2rUDCjn6Un8uQ3UH5Wl+sVjayMg0FP/H65oHDzFkYLI=; b=OZuAXTeHhOwlN9ZztYgNDjuDXOVUB16N8M8pQrnziQneaMgKssHAU+zWekWW3TDWcq 5YCoaXQ9ruJv68VGUFtKN1TpISb2iubpuNu8N+1TJO0EpdFVvJF4YYR2kJNYsIouu7FT RBitYoAphov/1hxJKjiM6x7K6BEQicF6+uR26vSSJlZda3dGrGVVdyuO3yO6AanD1633 JNLRCODHhgkuB5Es7HaooAjDJ1/4mxg+fHUZn3O9qYUeD4tA8c696IYJFYBnSC3llKr8 NfW45B1iljuft317QqZj4VIuSsXkG+T5HwCMiayj5FjGspfvLoI541r24b4KSdZOCpSy 6Bfg== X-Gm-Message-State: APzg51Dup5rbBfue8nb4gs+zDCQbRuc5mLw3N/7dya+5HRrwpK47TiLV 60X0BiH4gYrhZ1+mde1hJtp5WbZ6j8k= X-Google-Smtp-Source: ANB0VdaUzvMqWdaVmCDorcwjwyyFVEUSzY5P1g3ks5wsUZp0UDJky+aB0o8h6rKdqqwbww28OKr6cw== X-Received: by 2002:aca:68d8:: with SMTP id o85-v6mr19516302oik.96.1535997794788; Mon, 03 Sep 2018 11:03:14 -0700 (PDT) Received: from nuclearis2-1.lan (c-98-195-139-126.hsd1.tx.comcast.net. [98.195.139.126]) by smtp.gmail.com with ESMTPSA id q124-v6sm15785737oif.8.2018.09.03.11.03.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Sep 2018 11:03:14 -0700 (PDT) From: Alexandru Gagniuc To: linux-pci@vger.kernel.org, bhelgaas@google.com Cc: keith.busch@intel.com, alex_gagniuc@dellteam.com, austin_bolen@dell.com, shyam_iyer@dell.com, Alexandru Gagniuc , Ariel Elior , everest-linux-l2@cavium.com, "David S. Miller" , Michael Chan , Ganesh Goudar , Jeff Kirsher , Tariq Toukan , Saeed Mahameed , Leon Romanovsky , Jakub Kicinski , Dirk van der Merwe , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, oss-drivers@netronome.com Subject: [PATCH 3/9] bnxt_en: Do not call pcie_print_link_status() Date: Mon, 3 Sep 2018 13:02:30 -0500 Message-Id: <20180903180242.14504-4-mr.nuke.me@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180903180242.14504-1-mr.nuke.me@gmail.com> References: <20180903180242.14504-1-mr.nuke.me@gmail.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org This is now done by the PCI core to warn of sub-optimal bandwidth. Signed-off-by: Alexandru Gagniuc --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 8bb1e38b1681..246f33d2cc9c 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -9046,7 +9046,6 @@ static int bnxt_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) netdev_info(dev, "%s found at mem %lx, node addr %pM\n", board_info[ent->driver_data].name, (long)pci_resource_start(pdev, 0), dev->dev_addr); - pcie_print_link_status(pdev); return 0; From patchwork Mon Sep 3 18:02:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Alex G." X-Patchwork-Id: 965524 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pci-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="UPqhKZfJ"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4242Hr3wzBz9sSk for ; Tue, 4 Sep 2018 06:53:44 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727802AbeICWYj (ORCPT ); Mon, 3 Sep 2018 18:24:39 -0400 Received: from mail-oi0-f65.google.com ([209.85.218.65]:42868 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727271AbeICWYi (ORCPT ); Mon, 3 Sep 2018 18:24:38 -0400 Received: by mail-oi0-f65.google.com with SMTP id k81-v6so2219897oib.9; Mon, 03 Sep 2018 11:03:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=0pKk19a77AZmp6dTLVE6bJItbn+Qw+XrfFzeKgl/8eY=; b=UPqhKZfJFxiwmF6qssCOQd+/MEEXz8Dde+ndyDS0qDAXg+B4rQcbmEePg4PeZWNk90 SS5/o+zc6/g9AjI76perBmw+xXYWuEQUJ6gj0ls/irYsxqsAj3+M4vwev0U+La7d5iy4 O7SEsO/5C+dM9ZkRiiOYkbpK4to4x63GydT34M3syY2xkquDlro1mzZ9xjtJkC/Bdb5N cx736mkCK3l1oXrRrvb3laJTHZwybhvCPZh0cgLWNVbvCVfRypdzzcSVjtIoj8kLEr0U xo7lLB5lsaCXVl3yOO005SvlI3omWRi9BzYlPeyRjMPRtSYsOHqZiObHdk8OIFjksZy8 6i9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=0pKk19a77AZmp6dTLVE6bJItbn+Qw+XrfFzeKgl/8eY=; b=V4sIyASbSgXoQrHNRLpBnPv6WhALix70nCxSj7Dx/aeXc6p3jERoKd/kVYc9y8Qgmq 0KNvTBFp5GNFtKd2fidcLSXf1MwnXykNNxfTEyCkHi0BIqGU8SfewaryK3csilRW+TL+ 9xzrnBZpc2qI26eROldwOIlBcPTj6jPfbIJp/90Vx64IZvjTvpzNiQRti7bsuiuBv6cX hlODRz2s+I2Qnjgynm2CbiqHb/WegXZxHGJRDi3xHujox76kgfUys7GzpOwelodOCAnE vAGUphEZYdLANCUtHQXmwp07YrHaeF3xYnemB70Ehx1Pu1fZMtPy1QMTDAQLPaK5ujKJ zw1Q== X-Gm-Message-State: APzg51A4FeMRoAFVTuvJN9ZkzUOat68ZZge/ISaAG4bPQgVOjS7tUdxX VtgWz88nJnSAmo3vt+H3aa1+ChK4yp4= X-Google-Smtp-Source: ANB0VdZDOBlNihU6ejxtxglTSj88MYSxfpMzfewsdovFY+5epjfVqrIuCunZtZl//z/0Cx/2HblfmQ== X-Received: by 2002:aca:2808:: with SMTP id 8-v6mr4193351oix.7.1535997800250; Mon, 03 Sep 2018 11:03:20 -0700 (PDT) Received: from nuclearis2-1.lan (c-98-195-139-126.hsd1.tx.comcast.net. [98.195.139.126]) by smtp.gmail.com with ESMTPSA id q124-v6sm15785737oif.8.2018.09.03.11.03.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Sep 2018 11:03:19 -0700 (PDT) From: Alexandru Gagniuc To: linux-pci@vger.kernel.org, bhelgaas@google.com Cc: keith.busch@intel.com, alex_gagniuc@dellteam.com, austin_bolen@dell.com, shyam_iyer@dell.com, Alexandru Gagniuc , Ariel Elior , everest-linux-l2@cavium.com, "David S. Miller" , Michael Chan , Ganesh Goudar , Jeff Kirsher , Tariq Toukan , Saeed Mahameed , Leon Romanovsky , Jakub Kicinski , Dirk van der Merwe , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, oss-drivers@netronome.com Subject: [PATCH 4/9] cxgb4: Do not call pcie_print_link_status() Date: Mon, 3 Sep 2018 13:02:31 -0500 Message-Id: <20180903180242.14504-5-mr.nuke.me@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180903180242.14504-1-mr.nuke.me@gmail.com> References: <20180903180242.14504-1-mr.nuke.me@gmail.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org This is now done by the PCI core to warn of sub-optimal bandwidth. Signed-off-by: Alexandru Gagniuc --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c index 961e3087d1d3..1deb68c99a63 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c @@ -5782,9 +5782,6 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent) free_msix_info(adapter); } - /* check for PCI Express bandwidth capabiltites */ - pcie_print_link_status(pdev); - err = init_rss(adapter); if (err) goto out_free_dev; From patchwork Mon Sep 3 18:02:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Alex G." X-Patchwork-Id: 965525 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pci-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ZwV98YB6"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4242Hs2l7Yz9sML for ; Tue, 4 Sep 2018 06:53:45 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727827AbeICWYo (ORCPT ); Mon, 3 Sep 2018 18:24:44 -0400 Received: from mail-oi0-f65.google.com ([209.85.218.65]:37523 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727271AbeICWYo (ORCPT ); Mon, 3 Sep 2018 18:24:44 -0400 Received: by mail-oi0-f65.google.com with SMTP id p84-v6so2270045oic.4; Mon, 03 Sep 2018 11:03:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6ffzopQXccTuXo2gTw9Fy1V9dviCucvVy+ObNtSf4IU=; b=ZwV98YB63d9YbkVBKdu3sPV7CxQ0FNWcTForlLN0/gRKhsopWeEyOsJnPY72OJuI8Y zw6h621CJzhqAIycGVu9pFf/TxsQ9OrPUcD10muYksWYdA5RYpFca0zxikpl4Lmcm5jb kNPkt7RyDlpZPKTdd9gBMth31DhJ1pCQ5/oYmMrjOw/k9N54AD+YVd4PV87joPnXUXg2 9ML/tommEcrJIh4u3qRVw9u50BHEY7IojqFhhU59RKwq3GQy9nwYVqROHXarkmz887JX Zfr32yFVb62WqPlr4m9ayUxlAVBxVaRAd+rQRAOgaMWdxT+PHrRdjvM3NvZNy51w05Yo zHLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6ffzopQXccTuXo2gTw9Fy1V9dviCucvVy+ObNtSf4IU=; b=Vm7rK1BWjzGqDwrs07rJLfzEeMln0bkWHOmV5Crh3EWASpHNtAo0KU+9vCxKfm57Kf uL4Mx0blc1mEXcOJRP/zMlRNp3QxyKeu9IqBofiprcBIt8gnd8pZy8VifrK5DOThwQcT kYY87IFJ5ayj+Z8Sw8CC8LIQXF2YtB1HBi7nLcDedhHoiuy7p3SbqajS+24K7ax5QpQP Y7YAfoV4WUpQcgZdTaqb7BVIQVukc2PMf3YSYhChdDwoH2pIrMJ2ODVzq2+VI8af6A88 YP+XDadHrOIZevVn5klLQnSBUdC3H/jC7Shk78iDRwnsC/LppvfnKpYQ2WvYa8YixBAe zqiw== X-Gm-Message-State: APzg51DoPDkxpC8q3lufDj4H0ebJnC1PRx0oND8kHKjpHctyIRAemkOf 41y99kLArbffURMRYmeeuhwf/31fJCY= X-Google-Smtp-Source: ANB0VdZQU6fMtSfGvwkaZeV39sMOYopHUPadaDGBG40SZ9w2C6eupe8W1StYB6Um9SUhT9wA9TVTsA== X-Received: by 2002:aca:3254:: with SMTP id y81-v6mr19459024oiy.317.1535997805841; Mon, 03 Sep 2018 11:03:25 -0700 (PDT) Received: from nuclearis2-1.lan (c-98-195-139-126.hsd1.tx.comcast.net. [98.195.139.126]) by smtp.gmail.com with ESMTPSA id q124-v6sm15785737oif.8.2018.09.03.11.03.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Sep 2018 11:03:25 -0700 (PDT) From: Alexandru Gagniuc To: linux-pci@vger.kernel.org, bhelgaas@google.com Cc: keith.busch@intel.com, alex_gagniuc@dellteam.com, austin_bolen@dell.com, shyam_iyer@dell.com, Alexandru Gagniuc , Ariel Elior , everest-linux-l2@cavium.com, "David S. Miller" , Michael Chan , Ganesh Goudar , Jeff Kirsher , Tariq Toukan , Saeed Mahameed , Leon Romanovsky , Jakub Kicinski , Dirk van der Merwe , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, oss-drivers@netronome.com Subject: [PATCH 5/9] fm10k: Do not call pcie_print_link_status() Date: Mon, 3 Sep 2018 13:02:32 -0500 Message-Id: <20180903180242.14504-6-mr.nuke.me@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180903180242.14504-1-mr.nuke.me@gmail.com> References: <20180903180242.14504-1-mr.nuke.me@gmail.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org This is now done by the PCI core to warn of sub-optimal bandwidth. Signed-off-by: Alexandru Gagniuc --- drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c index 15071e4adb98..079fd3c884ea 100644 --- a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c +++ b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c @@ -2224,9 +2224,6 @@ static int fm10k_probe(struct pci_dev *pdev, const struct pci_device_id *ent) /* kick off service timer now, even when interface is down */ mod_timer(&interface->service_timer, (HZ * 2) + jiffies); - /* print warning for non-optimal configurations */ - pcie_print_link_status(interface->pdev); - /* report MAC address for logging */ dev_info(&pdev->dev, "%pM\n", netdev->dev_addr); From patchwork Mon Sep 3 18:02:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Alex G." X-Patchwork-Id: 965526 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pci-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="W8cVEYyy"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4242Ht1q53z9sPH for ; Tue, 4 Sep 2018 06:53:46 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728059AbeICWYu (ORCPT ); Mon, 3 Sep 2018 18:24:50 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:38310 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727271AbeICWYt (ORCPT ); Mon, 3 Sep 2018 18:24:49 -0400 Received: by mail-oi0-f67.google.com with SMTP id x197-v6so2252199oix.5; Mon, 03 Sep 2018 11:03:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=od+FfEhfZ2c4L0WVWY/ZAmVtThCFnh9arWHU9+Uiz+s=; b=W8cVEYyyRcTk6UAfP6KB4nwVa+GxHzJMwwozVrkD0k5xF5dXd/J6/C899Sm8ZUJvF1 LLjPyFcq19xUqQqqGgPPFJt4RzMOaOBDv1pmEceRFHW9bBc5/SF0mYnWt4wrDo6ULRCw O3k2xH1OnGwIOSRzaevRlr9/xhQ/iwuOzGY1xG5j+xHC8MvEPRQOSayiJfX0JZNlKDYw iosmVZfA5LD7g25Xhzi2r1UhGPQ3WvUkp1A174sb801OQbZxdjb0TmXpOaO0KuyEr/Yq VdWZCnY9kieJFZYXUdPrW9toFwZqHMcZVNEQ6kKYroH5wboUnMNScIAwgLNW7CNp5GpQ O/mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=od+FfEhfZ2c4L0WVWY/ZAmVtThCFnh9arWHU9+Uiz+s=; b=tWp+phQ1RwiUkETmmzW0W9cQw6hWL8ejszI9zt9A56Rtxj40tvynJA4osiQzptiNRe 18zzwBC2jiwPy2r3YjNJyPowCHR10XkdZwo4/2M7FiKlVXDOYRptydlR76zatO3yi22J PybEVWQKoxsqACiH+FY7o8WoEu5asBliKvl3bI9EH1I+DTvcMa6lh/y4TGfixNCWst+1 zrJ4Xq/c6m8BYejlfEeUrwGkY6yDP/+e99Fcbf91Ira8w028ek29z1KSS//5dZ9HBaBn 0ZFmsond526xk3hOXSXSxeV9onUwXysLbIgbshwf0WH5c8zpvx/cQ3zV71PA+aFbOJGG S/OA== X-Gm-Message-State: APzg51DEa3++F5AFSWBwWbE01bG/5+tJXolSXbsjZM18w1C3Otc/BTqC 6C9W7gPQKJstSINsaXeWyQTX6Lj/1Mc= X-Google-Smtp-Source: ANB0VdbQHYS/neIj1baACG1VOSsbiJVtsTcha+gOVQvhtOxz2rEqLRTQGqTTh3ezCDx+aOurnNuqNg== X-Received: by 2002:aca:b985:: with SMTP id j127-v6mr19741517oif.257.1535997811674; Mon, 03 Sep 2018 11:03:31 -0700 (PDT) Received: from nuclearis2-1.lan (c-98-195-139-126.hsd1.tx.comcast.net. [98.195.139.126]) by smtp.gmail.com with ESMTPSA id q124-v6sm15785737oif.8.2018.09.03.11.03.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Sep 2018 11:03:31 -0700 (PDT) From: Alexandru Gagniuc To: linux-pci@vger.kernel.org, bhelgaas@google.com Cc: keith.busch@intel.com, alex_gagniuc@dellteam.com, austin_bolen@dell.com, shyam_iyer@dell.com, Alexandru Gagniuc , Ariel Elior , everest-linux-l2@cavium.com, "David S. Miller" , Michael Chan , Ganesh Goudar , Jeff Kirsher , Tariq Toukan , Saeed Mahameed , Leon Romanovsky , Jakub Kicinski , Dirk van der Merwe , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, oss-drivers@netronome.com Subject: [PATCH 6/9] ixgbe: Do not call pcie_print_link_status() Date: Mon, 3 Sep 2018 13:02:33 -0500 Message-Id: <20180903180242.14504-7-mr.nuke.me@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180903180242.14504-1-mr.nuke.me@gmail.com> References: <20180903180242.14504-1-mr.nuke.me@gmail.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org This is now done by the PCI core to warn of sub-optimal bandwidth. Signed-off-by: Alexandru Gagniuc --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 26 ------------------- 1 file changed, 26 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c index 9a23d33a47ed..9663419e0ceb 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c @@ -241,28 +241,6 @@ static inline bool ixgbe_pcie_from_parent(struct ixgbe_hw *hw) } } -static void ixgbe_check_minimum_link(struct ixgbe_adapter *adapter, - int expected_gts) -{ - struct ixgbe_hw *hw = &adapter->hw; - struct pci_dev *pdev; - - /* Some devices are not connected over PCIe and thus do not negotiate - * speed. These devices do not have valid bus info, and thus any report - * we generate may not be correct. - */ - if (hw->bus.type == ixgbe_bus_type_internal) - return; - - /* determine whether to use the parent device */ - if (ixgbe_pcie_from_parent(&adapter->hw)) - pdev = adapter->pdev->bus->parent->self; - else - pdev = adapter->pdev; - - pcie_print_link_status(pdev); -} - static void ixgbe_service_event_schedule(struct ixgbe_adapter *adapter) { if (!test_bit(__IXGBE_DOWN, &adapter->state) && @@ -10792,10 +10770,6 @@ static int ixgbe_probe(struct pci_dev *pdev, const struct pci_device_id *ent) break; } - /* don't check link if we failed to enumerate functions */ - if (expected_gts > 0) - ixgbe_check_minimum_link(adapter, expected_gts); - err = ixgbe_read_pba_string_generic(hw, part_str, sizeof(part_str)); if (err) strlcpy(part_str, "Unknown", sizeof(part_str)); From patchwork Mon Sep 3 18:02:34 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Alex G." X-Patchwork-Id: 965527 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pci-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="X/DJrNib"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4242Hv0qq1z9sSk for ; Tue, 4 Sep 2018 06:53:47 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728200AbeICWY4 (ORCPT ); Mon, 3 Sep 2018 18:24:56 -0400 Received: from mail-oi0-f65.google.com ([209.85.218.65]:37550 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727271AbeICWYz (ORCPT ); Mon, 3 Sep 2018 18:24:55 -0400 Received: by mail-oi0-f65.google.com with SMTP id p84-v6so2270778oic.4; Mon, 03 Sep 2018 11:03:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=qKYr8O6ZndeZ8QF5YqTgpTdYV2iOFBHSVMs0kcFJX4Q=; b=X/DJrNibMaD21hNKQRI0BjHbRpTp+iqtUQU9KfIwiS8SZnIVR6f47MAGB+++L1zdSa hmWdAjuKw1sywjnpwyWxD1EItrG1pHt2HZvlAipM0j6sAyOlR+J8uMr9FG5rr3y7oZf7 R3wufW9D+MVLj/VG0S5mFqJfBO6C/S+zRgoC8WmoFN3cFmpxY5AsWreTwBvCeRRFgew7 SHMjZBnSL07ouz8KBj7of92wZGtnvd0qZpAPUELVBmAbpjj6hKd6xu7Ac7+NUhr0N8fV gefEnsPWMtvAXZg7AT+QK6SebfNVbEwDPUyt4eu9UOV/+Jzeb13juDMZ2zZXLhHI9uJD 6QOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=qKYr8O6ZndeZ8QF5YqTgpTdYV2iOFBHSVMs0kcFJX4Q=; b=Dn24FpTvW2oXM8cRuTLQ2+dKNReW4b+u1UFudEc+ehtQ+UWXKAnTpUhv8m6UnUbKzi Xeh9pcn7CNN6A7NU1YXW2wn7Ygr3K5JNiqXx8C8dma2UaI9OYhl2W3GaGDFj/2kCrhLb 8oa4KM0OH4C5LdNgA7V40zt5SSgG5akWc3APtRrA2djwHRis2IyYAQHUnCmvhGg2TZDJ yR6gdmJr+ySQaMzq8/PfuCHBbhv0+s57E9dvDP2SBycfIPoWfF66o2JSlVDTctwQW8Xw LG3TCyWkvELx0gljH/ygUGFEqLjW87ITPc+3wV0eI5QgBKFHuErUG9VwhmfM9fXiGK89 UCcw== X-Gm-Message-State: APzg51ASEwn0WyM0Im3qfAOFD+GQoxZ4sf2RxeS4CFsNkpQuwWDIDFRy Wj+ModiC4eWC6EUE5pEEXonq71t0Z28= X-Google-Smtp-Source: ANB0VdaJU3MuJ//4MSJDXwrOw6CR6IXZb2o+ISnr3hNlH5J+fRUIQXKGfwvBvzkAsW9GMyPHh/7Ijg== X-Received: by 2002:aca:5cd4:: with SMTP id q203-v6mr19325196oib.217.1535997817362; Mon, 03 Sep 2018 11:03:37 -0700 (PDT) Received: from nuclearis2-1.lan (c-98-195-139-126.hsd1.tx.comcast.net. [98.195.139.126]) by smtp.gmail.com with ESMTPSA id q124-v6sm15785737oif.8.2018.09.03.11.03.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Sep 2018 11:03:36 -0700 (PDT) From: Alexandru Gagniuc To: linux-pci@vger.kernel.org, bhelgaas@google.com Cc: keith.busch@intel.com, alex_gagniuc@dellteam.com, austin_bolen@dell.com, shyam_iyer@dell.com, Alexandru Gagniuc , Ariel Elior , everest-linux-l2@cavium.com, "David S. Miller" , Michael Chan , Ganesh Goudar , Jeff Kirsher , Tariq Toukan , Saeed Mahameed , Leon Romanovsky , Jakub Kicinski , Dirk van der Merwe , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, oss-drivers@netronome.com Subject: [PATCH 7/9] net/mlx4: Do not call pcie_print_link_status() Date: Mon, 3 Sep 2018 13:02:34 -0500 Message-Id: <20180903180242.14504-8-mr.nuke.me@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180903180242.14504-1-mr.nuke.me@gmail.com> References: <20180903180242.14504-1-mr.nuke.me@gmail.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org This is now done by the PCI core to warn of sub-optimal bandwidth. Signed-off-by: Alexandru Gagniuc Acked-by: Leon Romanovsky --- drivers/net/ethernet/mellanox/mlx4/main.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c index d2d59444f562..9902fa3a2c13 100644 --- a/drivers/net/ethernet/mellanox/mlx4/main.c +++ b/drivers/net/ethernet/mellanox/mlx4/main.c @@ -3525,13 +3525,6 @@ static int mlx4_load_one(struct pci_dev *pdev, int pci_dev_data, } } - /* check if the device is functioning at its maximum possible speed. - * No return code for this call, just warn the user in case of PCI - * express device capabilities are under-satisfied by the bus. - */ - if (!mlx4_is_slave(dev)) - pcie_print_link_status(dev->persist->pdev); - /* In master functions, the communication channel must be initialized * after obtaining its address from fw */ if (mlx4_is_master(dev)) { From patchwork Mon Sep 3 18:02:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Alex G." X-Patchwork-Id: 965528 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pci-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="n+XVCXoH"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4242Hv6sYRz9sPH for ; Tue, 4 Sep 2018 06:53:47 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728306AbeICWZB (ORCPT ); Mon, 3 Sep 2018 18:25:01 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:41612 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727271AbeICWZA (ORCPT ); Mon, 3 Sep 2018 18:25:00 -0400 Received: by mail-oi0-f66.google.com with SMTP id k12-v6so2241489oiw.8; Mon, 03 Sep 2018 11:03:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=zriiPzad5Qk4dHUu080egLe114u9/QRfPO9Vvq1gkMQ=; b=n+XVCXoHalOwH/vVji/0SgOKJtge/iQxScQxhJnsTmur5W8at4kkgD0VAtkDcHH/1V EvwgCJlSz9QMmr9NQ9YczVQQYXYwN3AjWYUVoVqsNL2ykeDW9WdR9S9oL4+GLEu9P9G5 BafmRluYoVG+7BI2iyRU5FqWO9ne3c79+DRtfrikg/zbY4pirnoo8l8FJ8KfbHIryIkB wfADYm5TbzQCbpdQFXObHWPPqkA/W/p6Jhcpxmd6WA0vsTetNF5D0InG2pzcmiY9Cmtb tt654w484Ff3njhjifzDABbCX66fkn29Tid/ZAM1edebHwfe9hKIk4txnOXsuNrdFJXL Mqew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=zriiPzad5Qk4dHUu080egLe114u9/QRfPO9Vvq1gkMQ=; b=ffQuHX7z799CLCGJCoJHBkeqYmkZpjiQpH6yHL0PfUkKRHNCx0A3bIZvGCaLLC+izs FjzM1hPvX6Qg3vNLtvCdZf0iBxj588l8oBumKP8On6j95hgzfjwWRIwKZ/2nMjT/xX8a x44ST53cDG6mOm/Tf6bgyrK4zgtQFp4kD5+HHlFFxtt7sjc1vwULpVrtEX5gRqytUJEw QLo0hgLjDnCgUQpBn3hXzQ83rCbJj2jTqH51wozvE3qZD3zxHBX28uYI09LvzwBwynM9 yLkyYAMdGqEg4y1ISh/adMe3AC1Bo0XXNNuZL6T7IuJ4GlJkEV8yQTxXx2Kkp+AlNDIf RurA== X-Gm-Message-State: APzg51BOkdVep24uGtbR2EP4c8DWw1icQcKgvVQl+QNN1RJI85df9TxV sVWja5PxBXptCdhYJ7c6aSDPt2IG/3g= X-Google-Smtp-Source: ANB0VdbNTBHi0BY1qVvokutvR5J+H6H0CjgkYNP4EVrpJrnWwKMPPBhYJ3lKBqhsDySQHzWz2k1hLg== X-Received: by 2002:aca:3254:: with SMTP id y81-v6mr19459950oiy.317.1535997822925; Mon, 03 Sep 2018 11:03:42 -0700 (PDT) Received: from nuclearis2-1.lan (c-98-195-139-126.hsd1.tx.comcast.net. [98.195.139.126]) by smtp.gmail.com with ESMTPSA id q124-v6sm15785737oif.8.2018.09.03.11.03.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Sep 2018 11:03:42 -0700 (PDT) From: Alexandru Gagniuc To: linux-pci@vger.kernel.org, bhelgaas@google.com Cc: keith.busch@intel.com, alex_gagniuc@dellteam.com, austin_bolen@dell.com, shyam_iyer@dell.com, Alexandru Gagniuc , Ariel Elior , everest-linux-l2@cavium.com, "David S. Miller" , Michael Chan , Ganesh Goudar , Jeff Kirsher , Tariq Toukan , Saeed Mahameed , Leon Romanovsky , Jakub Kicinski , Dirk van der Merwe , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, oss-drivers@netronome.com Subject: [PATCH 8/9] net/mlx5: Do not call pcie_print_link_status() Date: Mon, 3 Sep 2018 13:02:35 -0500 Message-Id: <20180903180242.14504-9-mr.nuke.me@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180903180242.14504-1-mr.nuke.me@gmail.com> References: <20180903180242.14504-1-mr.nuke.me@gmail.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org This is now done by the PCI core to warn of sub-optimal bandwidth. Signed-off-by: Alexandru Gagniuc Acked-by: Leon Romanovsky --- drivers/net/ethernet/mellanox/mlx5/core/main.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c index cf3e4a659052..888af98694f8 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/main.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c @@ -1056,10 +1056,6 @@ static int mlx5_load_one(struct mlx5_core_dev *dev, struct mlx5_priv *priv, dev_info(&pdev->dev, "firmware version: %d.%d.%d\n", fw_rev_maj(dev), fw_rev_min(dev), fw_rev_sub(dev)); - /* Only PFs hold the relevant PCIe information for this query */ - if (mlx5_core_is_pf(dev)) - pcie_print_link_status(dev->pdev); - /* on load removing any previous indication of internal error, device is * up */ From patchwork Mon Sep 3 18:02:36 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Alex G." X-Patchwork-Id: 965529 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pci-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="pqDJUMKl"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4242Hw69q6z9sSk for ; Tue, 4 Sep 2018 06:53:48 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728379AbeICWZI (ORCPT ); Mon, 3 Sep 2018 18:25:08 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:45196 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727271AbeICWZH (ORCPT ); Mon, 3 Sep 2018 18:25:07 -0400 Received: by mail-oi0-f68.google.com with SMTP id t68-v6so2196370oie.12; Mon, 03 Sep 2018 11:03:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Al/mS7lVdpKUEvF7vrO6otIVTS22X8nx5MPa3QEsinE=; b=pqDJUMKlIxmP5dge09YgTMfYlrmN1CCUu2haOOpBk8yMriwXVh6KJn+TSalBAy+gsK KrH2v7cS1T9ax+7jChmVoo/Awa7yOEeEgSdS9ndP3EIzXXQP83L1+sWGSQLth102Y2rb DhFauLkYo3CfzTCOvpfkas/tLLxE1nJqucPmsteW6kPOf6y4xGtpbPBHp+h8HYY0jPvu 6P7tVzBpY9Nsze9YBpOyv/9+OHgSJrqiNDH2OAIAbIe4zlMnX4zpTIUvWIcM10axTw+5 M/6xuB7d7rPh4xDZnwld3F2+NT9qlwuZJpi98tqVoZYlrxqrSmOxfCnykW/Wm2RytFa0 OlFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Al/mS7lVdpKUEvF7vrO6otIVTS22X8nx5MPa3QEsinE=; b=mlj9nG/RvX+bxCCsw7bDdRAGxn5bfmX5WrZJtIWTAc95vAdzgZK43zv9iPif9RnmrI ALsdK/lT9nai5KU8rn6h6dyDpXP7Yst4JJ05iGNXVFDgr5i414NWUNjfCLnU7kRntGpD 6lEfkRobOkARivO+QfL4DQH0AY9ixpFZA7tsFU9q5mmEALVOtYwnFJT5js7FSpnJiM08 Kx6qGil8N5phumbbCDM9lNZW2l2u/c+y5fyNL+mMlOsHvlBP3NkFn7coPjUcJ8h4EqqM ibRXdnBhNBTNP+Vr3oBUh9xIw97HW3X+AwlwG9OCYyrALlSqVarlCoV6ZzUOLz49fCjc yNYg== X-Gm-Message-State: APzg51DDaBRHFo2mKacNMl8zoKNc+9IwA+KbkMPb6MO8xW3eiprWzx1u NepeeDvvhm9khNywr9tr49pC3MdwfAE= X-Google-Smtp-Source: ANB0VdYUe8YdRqBExTmFv2cu7Z49WuQSObxS3S3uob1OSWgR0YiOX2Z5uiM0ObM4AB0X6T4VPLVhvA== X-Received: by 2002:aca:470b:: with SMTP id u11-v6mr19564879oia.197.1535997828586; Mon, 03 Sep 2018 11:03:48 -0700 (PDT) Received: from nuclearis2-1.lan (c-98-195-139-126.hsd1.tx.comcast.net. [98.195.139.126]) by smtp.gmail.com with ESMTPSA id q124-v6sm15785737oif.8.2018.09.03.11.03.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Sep 2018 11:03:48 -0700 (PDT) From: Alexandru Gagniuc To: linux-pci@vger.kernel.org, bhelgaas@google.com Cc: keith.busch@intel.com, alex_gagniuc@dellteam.com, austin_bolen@dell.com, shyam_iyer@dell.com, Alexandru Gagniuc , Ariel Elior , everest-linux-l2@cavium.com, "David S. Miller" , Michael Chan , Ganesh Goudar , Jeff Kirsher , Tariq Toukan , Saeed Mahameed , Leon Romanovsky , Jakub Kicinski , Dirk van der Merwe , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, oss-drivers@netronome.com Subject: [PATCH 9/9] nfp: Do not call pcie_print_link_status() Date: Mon, 3 Sep 2018 13:02:36 -0500 Message-Id: <20180903180242.14504-10-mr.nuke.me@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180903180242.14504-1-mr.nuke.me@gmail.com> References: <20180903180242.14504-1-mr.nuke.me@gmail.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org This is now done by the PCI core to warn of sub-optimal bandwidth. Signed-off-by: Alexandru Gagniuc --- drivers/net/ethernet/netronome/nfp/nfpcore/nfp6000_pcie.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp6000_pcie.c b/drivers/net/ethernet/netronome/nfp/nfpcore/nfp6000_pcie.c index c8d0b1016a64..87dde0f787e9 100644 --- a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp6000_pcie.c +++ b/drivers/net/ethernet/netronome/nfp/nfpcore/nfp6000_pcie.c @@ -1328,7 +1328,6 @@ struct nfp_cpp *nfp_cpp_from_nfp6000_pcie(struct pci_dev *pdev) /* Finished with card initialization. */ dev_info(&pdev->dev, "Netronome Flow Processor NFP4000/NFP6000 PCIe Card Probe\n"); - pcie_print_link_status(pdev); nfp = kzalloc(sizeof(*nfp), GFP_KERNEL); if (!nfp) {