From patchwork Fri Aug 17 13:00:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Barry Song <21cnbao@gmail.com> X-Patchwork-Id: 958803 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41sNg46Pztz9s3x for ; Fri, 17 Aug 2018 23:03:28 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Lfb7DIgR"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 41sNg44wlVzDr5t for ; Fri, 17 Aug 2018 23:03:28 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Lfb7DIgR"; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:400e:c01::241; helo=mail-pl0-x241.google.com; envelope-from=21cnbao@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Lfb7DIgR"; dkim-atps=neutral Received: from mail-pl0-x241.google.com (mail-pl0-x241.google.com [IPv6:2607:f8b0:400e:c01::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 41sNcM4q6hzDqm6 for ; Fri, 17 Aug 2018 23:01:03 +1000 (AEST) Received: by mail-pl0-x241.google.com with SMTP id a4-v6so200751plm.13 for ; Fri, 17 Aug 2018 06:01:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=VNCkgJ9itB8TQC6SbBaxgHvFVYuf+um7lOzVMExziKM=; b=Lfb7DIgR3E1Lp1wolMAQZAJBlX2dO3ciWUEnl1yt6yenZPnlu9MWpXXBRD02+jqhja s/1unrumVzSo1qTAOKQDlv33ncRyNvNKPwtIX6fgmlREvE6JM5ZALv3i4pRFlTg7bGbj 6Wtql/Ad/Sm04p9eWQItTkGxgQwmlNuBq32Qd7cA1f7e30x2Xiv91Bn2AeY2578UPzkE qaCUAa2/34w2ZiuX6wl//ozOTsZaVXFmS6/9lb6WIKZRmqqscIu/3Mb3fQbgbk8cC2yi KCnPCR/4U1ErEcR+aA8jYPjpEJX6lMTF8+d753brZlpY71xSQL9XPIeV/5rlQdHlKijH e7iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=VNCkgJ9itB8TQC6SbBaxgHvFVYuf+um7lOzVMExziKM=; b=nVMoLPM9Dak9IO9FMnQwC3Gbd9xVocJGcdDjU/HRmO+/RpVqWsY7fpfqvrxRW3StcD vF8RlEnerZva8U+wavsMGRJ1FiYwm4gfGvBcuCRnbQwZ+jKRkerczdrUc1KdB7X7zMyS FIn7Ew3Bz7z+VCqoHMoBlS6Hv1VoUZqwZtOCl2il8UnAYclS50ncSu539T+TtIksRhyt Ki7Yt+sbYMEguhCm7BUKOqAtjiTH4rf73wig/bfGeA7nwyp3quXanduzKcg85sweuFdz RP1HjZy7Hv4EAbF7y3uM3764vjP9WfM/I0AT25Jzvsmu8nSQIuQSVgOQtOroHHk/8jiG oInQ== X-Gm-Message-State: AOUpUlGIXcq2HtRl4IUWPbY3SW6BbVTrfJoR5Ch4fjZvKKakPh2/w7tt 4qhqraR/mWogNLxdFvU6c9o= X-Google-Smtp-Source: AA+uWPyBcjybpU3eEeKhLvTV77TWiUiEfWAltWVMhp8BXtz/Rdc+k89+hZT1/h+6RwdcOULgRR5LZQ== X-Received: by 2002:a17:902:44a4:: with SMTP id l33-v6mr33487121pld.134.1534510862087; Fri, 17 Aug 2018 06:01:02 -0700 (PDT) Received: from localhost.localdomain ([47.88.150.209]) by smtp.gmail.com with ESMTPSA id g5-v6sm2398301pfh.63.2018.08.17.06.00.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 17 Aug 2018 06:01:00 -0700 (PDT) From: Barry Song <21cnbao@gmail.com> To: leoyang.li@nxp.com, zw@zh-kernel.org, dan.j.williams@intel.com, vkoul@kernel.org, linuxppc-dev@lists.ozlabs.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] dmaengine: fsldma: move spin_lock_bh to spin_lock in tasklet Date: Fri, 17 Aug 2018 06:00:26 -0700 Message-Id: <1534510826-7603-1-git-send-email-21cnbao@gmail.com> X-Mailer: git-send-email 2.7.4 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Barry Song <21cnbao@gmail.com> Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" as you are already in a tasklet, it is unnecessary to call spin_lock_bh. Signed-off-by: Barry Song <21cnbao@gmail.com> --- drivers/dma/fsldma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c index 1117b51..9d360a3 100644 --- a/drivers/dma/fsldma.c +++ b/drivers/dma/fsldma.c @@ -987,7 +987,7 @@ static void dma_do_tasklet(unsigned long data) chan_dbg(chan, "tasklet entry\n"); - spin_lock_bh(&chan->desc_lock); + spin_lock(&chan->desc_lock); /* the hardware is now idle and ready for more */ chan->idle = true; @@ -995,7 +995,7 @@ static void dma_do_tasklet(unsigned long data) /* Run all cleanup for descriptors which have been completed */ fsldma_cleanup_descriptors(chan); - spin_unlock_bh(&chan->desc_lock); + spin_unlock(&chan->desc_lock); chan_dbg(chan, "tasklet exit\n"); }