From patchwork Fri Aug 10 17:10:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 956346 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=208.118.235.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="CVI4imOx"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41nBVr4KYHz9s4Z for ; Sat, 11 Aug 2018 03:11:48 +1000 (AEST) Received: from localhost ([::1]:57336 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1foAx0-00075o-9Q for incoming@patchwork.ozlabs.org; Fri, 10 Aug 2018 13:11:46 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56464) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1foAwO-00074l-QA for qemu-devel@nongnu.org; Fri, 10 Aug 2018 13:11:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1foAwM-0007if-IZ for qemu-devel@nongnu.org; Fri, 10 Aug 2018 13:11:08 -0400 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:38829) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1foAwM-0007he-Ag for qemu-devel@nongnu.org; Fri, 10 Aug 2018 13:11:06 -0400 Received: by mail-wr1-x444.google.com with SMTP id v14-v6so8907442wro.5 for ; Fri, 10 Aug 2018 10:11:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2eXeB+Wyf7wgOJHBuAPzz7OSzBQaxuieY7C29LSfD0w=; b=CVI4imOxjXzp2YVdIKpQmGomqm3qq4lEh7rL9K102lEQpw7Z127afh4pLKC8xv7sWe hsCyCJhywCLlERjnjkHPHKs8LuANutp2MzPPzScBZb0tvGR01OFNNYOUUbaz/Mymk1N7 +InUs/CmvsgtVxlH2h446aBF/nnR17kYa9IqI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2eXeB+Wyf7wgOJHBuAPzz7OSzBQaxuieY7C29LSfD0w=; b=SEmG367FcwT/uECU4TRvXLDJisLLfq1NSQmBBzdxYXtIENy3IaIPE3Lh30wHJE0D2Z qlMs0TCtzqWr1g9RYqr6jtpkUVrEwOlyOBGRrsTGRltZVuLnU2ma7llqgGMyIwwLbvgC D7sp08/j6WaT1KKXzzuieRH3VApy3d7flzfU25rprEOA8p5gjvrXJzW+GF/cHPbm9TPV CU9Gte8pd1C03hBGX4FRoL4/bhuJKOYTbo9w11zM7uvapJKXFdsoRKkqrpoi14ebrzFL UeIwGtgltkTXQ6eVwp/PuRgrG8xKsbkn8GXKxP9yBkXIdgNYsY7uMczcYDj1boA4VK6w 3k/A== X-Gm-Message-State: AOUpUlHv8e0U/Qcsnh514CtCLW0lArxtGlkUQBCeBTXtjCZy3mYANT1O airtGuU/JR8eRibY2an1RDcfwg== X-Google-Smtp-Source: AA+uWPyaoL9dTIRO9qjk2aEFf02SxZoXri3iCjQbfkHRVNcXwxk5awOyyR4Di1+oD+fdGUW/xEo6xQ== X-Received: by 2002:adf:e34d:: with SMTP id n13-v6mr4950209wrj.158.1533921065284; Fri, 10 Aug 2018 10:11:05 -0700 (PDT) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id w9-v6sm12525695wrk.28.2018.08.10.10.11.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 10 Aug 2018 10:11:02 -0700 (PDT) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 21CE03E0625; Fri, 10 Aug 2018 18:11:02 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Fri, 10 Aug 2018 18:10:59 +0100 Message-Id: <20180810171102.16451-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180810171102.16451-1-alex.bennee@linaro.org> References: <20180810171102.16451-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::444 Subject: [Qemu-devel] [RFC PATCH 1/3] HACKING: mention the C GNU extensions we use X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" QEMU is not a pure C99 code-base as anyone attempting to build with -std=c99 will find out. Signed-off-by: Alex Bennée --- HACKING | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/HACKING b/HACKING index 0fc3e0fc04..e042dd1f4f 100644 --- a/HACKING +++ b/HACKING @@ -189,6 +189,11 @@ In addition, QEMU assumes that the compiler does not use the latitude given in C99 and C11 to treat aspects of signed '<<' as undefined, as documented in the GNU Compiler Collection manual starting at version 4.0. +Finally QEMU also uses some GNU extensions to the C language including +making extensive use of the typeof keyword for type inference. While +typeof() is a GCC extension it is fairly widely understood by other +compilers. + 7. Error handling and reporting 7.1 Reporting errors to the human user From patchwork Fri Aug 10 17:11:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 956344 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=208.118.235.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="HNLKluqW"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41nBVq0yx5z9s4Z for ; Sat, 11 Aug 2018 03:11:46 +1000 (AEST) Received: from localhost ([::1]:57335 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1foAwy-00075H-Qq for incoming@patchwork.ozlabs.org; Fri, 10 Aug 2018 13:11:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56466) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1foAwO-00074n-QV for qemu-devel@nongnu.org; Fri, 10 Aug 2018 13:11:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1foAwN-0007jd-LK for qemu-devel@nongnu.org; Fri, 10 Aug 2018 13:11:08 -0400 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:35630) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1foAwN-0007io-Ea for qemu-devel@nongnu.org; Fri, 10 Aug 2018 13:11:07 -0400 Received: by mail-wm0-x244.google.com with SMTP id o18-v6so2651756wmc.0 for ; Fri, 10 Aug 2018 10:11:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gPBdu0wEcFDRIRZUQIUU4OmBFrIksOlD2TFE3XFjfkw=; b=HNLKluqWyQvxVIIFXQI56Jn52lbVYTUlDtDdwbg6JtmoktzowUcwE342Z/SvKMpT7n H+ehCRmcilZW9Z36qdHhXrbjuBDHqECGEtw5Nfy48o1t1Vah41fO8BDa2yTfL5ddEbej ko+YhEuGJZPnfbp98uHYebP8ciVg4ChbPnNQU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gPBdu0wEcFDRIRZUQIUU4OmBFrIksOlD2TFE3XFjfkw=; b=WOdg3P0r+qqyZUocha2UpC5AUiwABwbtsItUoEnS0lx5WIAqhBORV3TspaCIxC8qoP tLyb6mRhGZaOdYZKx1JNV7Q1jGw7nOu4iwBJNbu0gebn4V1USKPymldOcg88NSWZ6TPs TG/sUkL1FOGG6bjD2Xcy4BACEdImWnyo0X8ZSVv1E1ktR4Nn0Oo5hGzIr/5py4sS8Vjd V0GbnNwlWBPbYOSH86N0FV8kmKhzLGtZ3n+Cix0L6SHah7aOdrEEqM2doVZPRnyd+nBt XSgppA3dU2XCU5wI6eSGDNxnF0aHROPLSIGn8TXzoeyP+PJOj+RYGKpRVjOvt9y3cB8D qGKg== X-Gm-Message-State: AOUpUlGtLc0CYsZ2wWxuPWJqP+11U5Az3xyTo2jCL2EmyaFzgaIdyWAn 6a2rFvJxNTiQA0Ygs15DfD3gMA== X-Google-Smtp-Source: AA+uWPxMlwLqhFvkDJm2viislyY0lVfbkfGb4zqXEQA7iKfnREQpEvq4/J3sYIORS+7OJMlOtuuydg== X-Received: by 2002:a1c:a6cc:: with SMTP id p195-v6mr2201925wme.76.1533921066132; Fri, 10 Aug 2018 10:11:06 -0700 (PDT) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id 9-v6sm20479397wrb.48.2018.08.10.10.11.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 10 Aug 2018 10:11:03 -0700 (PDT) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 3444B3E062B; Fri, 10 Aug 2018 18:11:02 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Fri, 10 Aug 2018 18:11:00 +0100 Message-Id: <20180810171102.16451-3-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180810171102.16451-1-alex.bennee@linaro.org> References: <20180810171102.16451-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::244 Subject: [Qemu-devel] [RFC PATCH 2/3] qemu-seccomp: manually expand SCMP_A1 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Otubo , =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" The expansion of ((struct scmp_arg_cmp){1, SCMP_CMP_NE, 5}) doesn't work with -std=gnu99. Signed-off-by: Alex Bennée Acked-by: Eduardo Otubo --- qemu-seccomp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-seccomp.c b/qemu-seccomp.c index 9cd8eb9499..4dc1c22924 100644 --- a/qemu-seccomp.c +++ b/qemu-seccomp.c @@ -39,7 +39,7 @@ struct QemuSeccompSyscall { }; const struct scmp_arg_cmp sched_setscheduler_arg[] = { - SCMP_A1(SCMP_CMP_NE, SCHED_IDLE) + {1, SCMP_CMP_NE, SCHED_IDLE} }; static const struct QemuSeccompSyscall blacklist[] = { From patchwork Fri Aug 10 17:11:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 956345 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=208.118.235.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="YY2o8mFs"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41nBVr3Xfqz9s5b for ; Sat, 11 Aug 2018 03:11:48 +1000 (AEST) Received: from localhost ([::1]:57337 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1foAx0-00076C-5Y for incoming@patchwork.ozlabs.org; Fri, 10 Aug 2018 13:11:46 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56475) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1foAwP-00074o-6b for qemu-devel@nongnu.org; Fri, 10 Aug 2018 13:11:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1foAwO-0007kO-5w for qemu-devel@nongnu.org; Fri, 10 Aug 2018 13:11:09 -0400 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:54902) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1foAwO-0007jL-0f for qemu-devel@nongnu.org; Fri, 10 Aug 2018 13:11:08 -0400 Received: by mail-wm0-x243.google.com with SMTP id c14-v6so2634992wmb.4 for ; Fri, 10 Aug 2018 10:11:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0OA0SwdDN07sFJaNhSWmebyG1GQbLnSIMecL479MM7s=; b=YY2o8mFs819K/vNRTJGtRfm5cDVlQl/+0P5jHlQOWSHtyNVBQofiDlI1NyvmxWH4NJ sFo/N1w9QKFGaHQ/wZhCF57gGYLOuPGqFJo7jOXlQHnE3sSNz+XTemdHBzhH4QH/+RcY beE0LM10gpr1gUMlnE9T7iTKwMyKvA+LvUQQU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0OA0SwdDN07sFJaNhSWmebyG1GQbLnSIMecL479MM7s=; b=SS9sQGTbJHchd43zbswmcWjXCqu+80r4ffK1/ZteC1bEu9wCl2bvl2FEdr59C+5i96 y6zuxIFP7SXfBOMhoh5vtEqc6j7lqriuFQ4ZCbd8T43M45XxTYYnUHcb9SQT54exjOyj Gitw4nnXXy/gZa6VAPr53Svz9JlGxxKSHAaHISnk5Z4WlrqcI9KotniCX5Jb9eYu7nx/ aWJgxjBWxznjQaQvvT3sbY63V3ZIN/SVUnP78mTsWjsRSoAeUqaVPXg5iaoVjnclr8ny n71qjFcAEjnbdVRVjZPXR1XwwxV7nU8l1fHzRdXWK/nojTEheQJGDrKl34uSBnmjr2C/ 3ILQ== X-Gm-Message-State: AOUpUlEUkzyxLI23XwtdclN27QJUBwnq4fdCUfbYVbioTd4d3TyNbyMC 0p9ChwxhWpgc7i0XduaOKEt9Fw== X-Google-Smtp-Source: AA+uWPxVfkpy4JIDW6eK4ygGlfYwHOn4cjan6gfrfxbCGtDx5actl+HpVZpap6TKdRupwWs3L3hlsA== X-Received: by 2002:a1c:4489:: with SMTP id r131-v6mr1967389wma.128.1533921066996; Fri, 10 Aug 2018 10:11:06 -0700 (PDT) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id b22-v6sm2768838wme.48.2018.08.10.10.11.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 10 Aug 2018 10:11:03 -0700 (PDT) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 46C923E063A; Fri, 10 Aug 2018 18:11:02 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Fri, 10 Aug 2018 18:11:01 +0100 Message-Id: <20180810171102.16451-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180810171102.16451-1-alex.bennee@linaro.org> References: <20180810171102.16451-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::243 Subject: [Qemu-devel] [RFC PATCH 3/3] .travis.yml: ensure we support C99 on old compilers X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , =?utf-8?q?Alex_Benn=C3=A9e?= , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" The default Travis gcc is so old it default to -std=gnu89 which will fall over on some c99ism you are allowed to use in the QEMU source tree. As we also use some GNU extensions make it -std=gnu99 instead of -std=c99. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 95be6ec59f..9c61750be0 100644 --- a/.travis.yml +++ b/.travis.yml @@ -72,7 +72,7 @@ before_install: - git submodule update --init --recursive capstone dtc ui/keycodemapdb before_script: - mkdir -p ${BUILD_DIR} && cd ${BUILD_DIR} - - ${SRC_DIR}/configure ${CONFIG} || { cat config.log && exit 1; } + - ${SRC_DIR}/configure ${CONFIG} --extra-cflags=-std=gnu99 || { cat config.log && exit 1; } script: - make ${MAKEFLAGS} && ${TEST_CMD} matrix: