From patchwork Thu Aug 9 12:43:12 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcelo Henrique Cerri X-Patchwork-Id: 955532 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41mSbp5Gcmz9s1c; Thu, 9 Aug 2018 22:43:34 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1fnkHi-0005iJ-Fh; Thu, 09 Aug 2018 12:43:22 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.86_2) (envelope-from ) id 1fnkHh-0005iC-LD for kernel-team@lists.ubuntu.com; Thu, 09 Aug 2018 12:43:21 +0000 Received: from mail-qk0-f197.google.com ([209.85.220.197]) by youngberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1fnkHh-0004zT-BN for kernel-team@lists.ubuntu.com; Thu, 09 Aug 2018 12:43:21 +0000 Received: by mail-qk0-f197.google.com with SMTP id y130-v6so5614648qka.1 for ; Thu, 09 Aug 2018 05:43:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=QRVTfjtYzo8qByRnvLXUJp610GMfmrR6x/WwUgZaxsc=; b=Nwbuw7soAabNHelS/1czkQkPvsrNsDgB80qx8i1/Wgr7X6qNiFnt5GOCI47yOyBvqS epsUekQMTNzhPZKuu5DGUd3WfFlk4JwqHrGzP75L3wDZOFMAuQhlRJlvYhiHCfteb9sg k0xWQ6MiLP4yiibSA5NtyXNzd2r7kz7w0xBbM+/LZzcVYlpHdXiLWtc/aDtP7lTH1pNJ xaIpnqE6NnDMENZfg2trOW5ojB0oLtifJv26ywdUn2IGwFLppiLVEtksQxNxaFeg4fRm yfROB9v7fYU2Tfv0JRWcTWywUXENlF47EQWoQtuZ5jx9ZzjwGyFNqodTuGMrO/bNpFgr ucWQ== X-Gm-Message-State: AOUpUlGzFdkQfcjasFa3pHUcL8fEnH5ZdJXyRRb6ywfyYiyFzOuFE0d+ L5RxFM1QoVFefAOCaVqQcm/OYmjwCxd9Ni56m4qW5FMqxv93eVtlGLIXXxKbAo19cPLguJB7O2s jDQf4CUtM4r9sVjieoXtTWmlfaBg4tnteIvMQgqZP X-Received: by 2002:a37:a417:: with SMTP id n23-v6mr1591677qke.42.1533818600063; Thu, 09 Aug 2018 05:43:20 -0700 (PDT) X-Google-Smtp-Source: AA+uWPw3i9nPENxnqzMLGvvglTex/vJD5mjIy3zSjIQxqSKmVrpiV9ZWhCiC49XGq3DX16tWUvq5lQ== X-Received: by 2002:a37:a417:: with SMTP id n23-v6mr1591661qke.42.1533818599824; Thu, 09 Aug 2018 05:43:19 -0700 (PDT) Received: from localhost.localdomain (189-19-124-4.dsl.telesp.net.br. [189.19.124.4]) by smtp.gmail.com with ESMTPSA id i68-v6sm4361568qkf.87.2018.08.09.05.43.16 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Aug 2018 05:43:17 -0700 (PDT) From: Marcelo Henrique Cerri To: kernel-team@lists.ubuntu.com Subject: [bionic][PATCH] smb3: on reconnect set PreviousSessionId field Date: Thu, 9 Aug 2018 09:43:12 -0300 Message-Id: <20180809124312.2018-1-marcelo.cerri@canonical.com> X-Mailer: git-send-email 2.17.1 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Steve French BugLink: http://bugs.launchpad.net/bugs/1786110 The server detects reconnect by the (non-zero) value in PreviousSessionId of SMB2/SMB3 SessionSetup request, but this behavior regressed due to commit 166cea4dc3a4f66f020cfb9286225ecd228ab61d ("SMB2: Separate RawNTLMSSP authentication from SMB2_sess_setup") CC: Stable CC: Sachin Prabhu Signed-off-by: Steve French Reviewed-by: Ronnie Sahlberg (cherry picked from commit b2adf22fdfba85a6701c481faccdbbb3a418ccfc) Signed-off-by: Marcelo Henrique Cerri Acked-by: Stefan Bader Acked-by: Kamal Mostafa --- fs/cifs/smb2pdu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c index 18bf0b9f19ed..f942827ca0cb 100644 --- a/fs/cifs/smb2pdu.c +++ b/fs/cifs/smb2pdu.c @@ -1181,6 +1181,7 @@ SMB2_sess_setup(const unsigned int xid, struct cifs_ses *ses, sess_data->ses = ses; sess_data->buf0_type = CIFS_NO_BUFFER; sess_data->nls_cp = (struct nls_table *) nls_cp; + sess_data->previous_session = ses->Suid; while (sess_data->func) sess_data->func(sess_data);