From patchwork Mon Aug 6 23:25:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Alex G." X-Patchwork-Id: 954309 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=osuosl.org (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="KShT0vAS"; dkim-atps=neutral Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41kv5H1qvdz9s4v for ; Tue, 7 Aug 2018 09:30:10 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 6D3AE84EF0; Mon, 6 Aug 2018 23:30:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eLnpBD-nWYLe; Mon, 6 Aug 2018 23:30:08 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 4334A84E94; Mon, 6 Aug 2018 23:30:08 +0000 (UTC) X-Original-To: intel-wired-lan@lists.osuosl.org Delivered-To: intel-wired-lan@lists.osuosl.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 0D1D11C3F86 for ; Mon, 6 Aug 2018 23:26:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 0A118861E0 for ; Mon, 6 Aug 2018 23:26:23 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JBUIz-ZXOALs for ; Mon, 6 Aug 2018 23:26:22 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-oi0-f66.google.com (mail-oi0-f66.google.com [209.85.218.66]) by hemlock.osuosl.org (Postfix) with ESMTPS id D9D09861D6 for ; Mon, 6 Aug 2018 23:26:21 +0000 (UTC) Received: by mail-oi0-f66.google.com with SMTP id b15-v6so25244746oib.10 for ; Mon, 06 Aug 2018 16:26:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=2WXbpsYMTz/QG1vzL3x5MJRxezLdU4OG6c9SB+TpFWA=; b=KShT0vAS5hdq8cmK7p8xAxvFu3GTtkHqyiyOhMk3kF3ZqC81EslEflDrsAFnSN/YI/ BGa6s6HkJiekjU/j4+xd26gWrMfB2h0X1LB1J7dWFb/2aOs1MvDY88W4nn7ve0YW1pFW 8iJLbjZEVZzvg9Mz+Msi1vS5h5xZmdar9mebyCKKQKtCsHvhRegcKWVgPsWqrrFQfB+e J21rrtssA+i2kQQTZ9s54nt67p4nVvPs7PLLjo4TIsgb110om0+O2bdd4Rm5LMoy0bs/ jyRx9nCf94AG5R8OxEVd0bfFMBa8NUAfNnhhTTEsSEIVRDNGXyMmfxlF/OsyisXMh88p VCrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=2WXbpsYMTz/QG1vzL3x5MJRxezLdU4OG6c9SB+TpFWA=; b=NtjQ2/fV99CIj8MkNmYA+N+1EEItVFIPBsZ0XUSjAPC9d2ARIXhQlx7KQMykbff8Pw XyPC0WXYrq7zebfd9d+od4CQvgGiWv+ke+4cvtYCVgST8e3zH/risQw1oKt+CHbf+G7x cFiSQS3xVIaFHPnj6a/ApSnQQMBIPBIZj3rtWgnIt9C7hCN29FxEMzEc4CeOK+UH157V Qte+U9ASplXMp3CNyBC1vSeJsuLy7r8qXXIsIWh9Me4dw7nGeUFQIfXDxoH2hu5FR5ix qsKYsUxbQd4Dr2WxulpDxa7Y1a08zINeTui2ODR/E4cHNLiNqWwr561g/ZzKoHDNqWwq 1buQ== X-Gm-Message-State: AOUpUlF+DEK3DTRyMS5rj66VBmuwmfYjs54J5+0rvRalR0UsObyj+Ri8 RtLmMtbYWlnnltrgV8B2iQo= X-Google-Smtp-Source: AAOMgpcqOUA/kNzkVMbDdq5HkfCHfTJrwB4RWKrpc/P5ByRsBSjCYn4QtKuK5YdKRDODlfCDhs4ckQ== X-Received: by 2002:aca:a641:: with SMTP id p62-v6mr17010358oie.151.1533597981033; Mon, 06 Aug 2018 16:26:21 -0700 (PDT) Received: from nuclearis2-1.lan (c-98-195-139-126.hsd1.tx.comcast.net. [98.195.139.126]) by smtp.gmail.com with ESMTPSA id w13-v6sm10613328oiw.51.2018.08.06.16.26.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Aug 2018 16:26:19 -0700 (PDT) From: Alexandru Gagniuc To: linux-pci@vger.kernel.org, bhelgaas@google.com, jakub.kicinski@netronome.com Date: Mon, 6 Aug 2018 18:25:35 -0500 Message-Id: <20180806232600.25694-1-mr.nuke.me@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: X-Mailman-Approved-At: Mon, 06 Aug 2018 23:30:06 +0000 Subject: [Intel-wired-lan] [PATCH v6 1/9] PCI: Check for PCIe downtraining conditions X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex_gagniuc@dellteam.com, Dirk van der Merwe , Tariq Toukan , Leon Romanovsky , linux-rdma@vger.kernel.org, netdev@vger.kernel.org, oss-drivers@netronome.com, shyam_iyer@dell.com, Michael Chan , linux-kernel@vger.kernel.org, keith.busch@intel.com, Saeed Mahameed , Ariel Elior , intel-wired-lan@lists.osuosl.org, Alexandru Gagniuc , austin_bolen@dell.com, everest-linux-l2@cavium.com, "David S. Miller" , Ganesh Goudar MIME-Version: 1.0 Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" PCIe downtraining happens when both the device and PCIe port are capable of a larger bus width or higher speed than negotiated. Downtraining might be indicative of other problems in the system, and identifying this from userspace is neither intuitive, nor straightforward. The easiest way to detect this is with pcie_print_link_status(), since the bottleneck is usually the link that is downtrained. It's not a perfect solution, but it works extremely well in most cases. Signed-off-by: Alexandru Gagniuc Acked-by: David S. Miller --- drivers/pci/pci.c | 22 ++++++++++++++++++---- drivers/pci/probe.c | 21 +++++++++++++++++++++ include/linux/pci.h | 1 + 3 files changed, 40 insertions(+), 4 deletions(-) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 316496e99da9..414ad7b3abdb 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -5302,14 +5302,15 @@ u32 pcie_bandwidth_capable(struct pci_dev *dev, enum pci_bus_speed *speed, } /** - * pcie_print_link_status - Report the PCI device's link speed and width + * __pcie_print_link_status - Report the PCI device's link speed and width * @dev: PCI device to query + * @verbose: Be verbose -- print info even when enough bandwidth is available. * * Report the available bandwidth at the device. If this is less than the * device is capable of, report the device's maximum possible bandwidth and * the upstream link that limits its performance to less than that. */ -void pcie_print_link_status(struct pci_dev *dev) +void __pcie_print_link_status(struct pci_dev *dev, bool verbose) { enum pcie_link_width width, width_cap; enum pci_bus_speed speed, speed_cap; @@ -5319,11 +5320,11 @@ void pcie_print_link_status(struct pci_dev *dev) bw_cap = pcie_bandwidth_capable(dev, &speed_cap, &width_cap); bw_avail = pcie_bandwidth_available(dev, &limiting_dev, &speed, &width); - if (bw_avail >= bw_cap) + if (bw_avail >= bw_cap && verbose) pci_info(dev, "%u.%03u Gb/s available PCIe bandwidth (%s x%d link)\n", bw_cap / 1000, bw_cap % 1000, PCIE_SPEED2STR(speed_cap), width_cap); - else + else if (bw_avail < bw_cap) pci_info(dev, "%u.%03u Gb/s available PCIe bandwidth, limited by %s x%d link at %s (capable of %u.%03u Gb/s with %s x%d link)\n", bw_avail / 1000, bw_avail % 1000, PCIE_SPEED2STR(speed), width, @@ -5331,6 +5332,19 @@ void pcie_print_link_status(struct pci_dev *dev) bw_cap / 1000, bw_cap % 1000, PCIE_SPEED2STR(speed_cap), width_cap); } + +/** + * pcie_print_link_status - Report the PCI device's link speed and width + * @dev: PCI device to query + * + * Report the available bandwidth at the device. If this is less than the + * device is capable of, report the device's maximum possible bandwidth and + * the upstream link that limits its performance to less than that. + */ +void pcie_print_link_status(struct pci_dev *dev) +{ + __pcie_print_link_status(dev, true); +} EXPORT_SYMBOL(pcie_print_link_status); /** diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index 611adcd9c169..1c8c26dd2cb2 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -2205,6 +2205,24 @@ static struct pci_dev *pci_scan_device(struct pci_bus *bus, int devfn) return dev; } +static void pcie_check_upstream_link(struct pci_dev *dev) +{ + if (!pci_is_pcie(dev)) + return; + + /* Look from the device up to avoid downstream ports with no devices. */ + if ((pci_pcie_type(dev) != PCI_EXP_TYPE_ENDPOINT) && + (pci_pcie_type(dev) != PCI_EXP_TYPE_LEG_END) && + (pci_pcie_type(dev) != PCI_EXP_TYPE_UPSTREAM)) + return; + + /* Multi-function PCIe share the same link/status. */ + if (PCI_FUNC(dev->devfn) != 0 || dev->is_virtfn) + return; + + __pcie_print_link_status(dev, false); +} + static void pci_init_capabilities(struct pci_dev *dev) { /* Enhanced Allocation */ @@ -2240,6 +2258,9 @@ static void pci_init_capabilities(struct pci_dev *dev) /* Advanced Error Reporting */ pci_aer_init(dev); + /* Check link and detect downtrain errors */ + pcie_check_upstream_link(dev); + if (pci_probe_reset_function(dev) == 0) dev->reset_fn = 1; } diff --git a/include/linux/pci.h b/include/linux/pci.h index c133ccfa002e..d212de231259 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -1087,6 +1087,7 @@ int pcie_set_mps(struct pci_dev *dev, int mps); u32 pcie_bandwidth_available(struct pci_dev *dev, struct pci_dev **limiting_dev, enum pci_bus_speed *speed, enum pcie_link_width *width); +void __pcie_print_link_status(struct pci_dev *dev, bool verbose); void pcie_print_link_status(struct pci_dev *dev); int pcie_flr(struct pci_dev *dev); int __pci_reset_function_locked(struct pci_dev *dev); From patchwork Mon Aug 6 23:25:36 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Alex G." X-Patchwork-Id: 954308 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=osuosl.org (client-ip=140.211.166.133; helo=hemlock.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="iKwLYIWQ"; dkim-atps=neutral Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41kv5G2ZNNz9s4c for ; Tue, 7 Aug 2018 09:30:10 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id E1DA685C6A; Mon, 6 Aug 2018 23:30:08 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gTihTrLUSz-d; Mon, 6 Aug 2018 23:30:08 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 7A7C28541F; Mon, 6 Aug 2018 23:30:08 +0000 (UTC) X-Original-To: intel-wired-lan@lists.osuosl.org Delivered-To: intel-wired-lan@lists.osuosl.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 552A41C3F86 for ; Mon, 6 Aug 2018 23:26:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 529AD861E0 for ; Mon, 6 Aug 2018 23:26:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XAFRwWkUweYP for ; Mon, 6 Aug 2018 23:26:32 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-oi0-f65.google.com (mail-oi0-f65.google.com [209.85.218.65]) by hemlock.osuosl.org (Postfix) with ESMTPS id D299E861D6 for ; Mon, 6 Aug 2018 23:26:31 +0000 (UTC) Received: by mail-oi0-f65.google.com with SMTP id s198-v6so25220679oih.11 for ; Mon, 06 Aug 2018 16:26:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=mCBhyT7m82JCvv9Qmq19HGSyTY8I4ZV8neCBY0l2Uko=; b=iKwLYIWQXSuIciJDCA4EF5lho2Mo06rNV3Ln80Pj5ty6C8RTztYhy82u8itZUC7rpe Fr5HDzk2OBNwW1WwDZGVemoma9tapURt+rPrJW/K4ZSeDNCmHUWUxR3dPke3mLFCyd7v ckJZUB7NhFoH+2BA68IfDmIrQ1F1WvaBm8pULofjoJdYfGoCJZ9Fm74ag5MLyeNNP+eg qAy4bV1f9LCZx4/JUQhB+3VUtRMX/biFIKXkPrL+8avdGahINUb6Ri+tLwpl6oS1/EsP GE9DIXZD6bZDq4BFSTdvRg0BHCK6uYKUySxhgW2Ndl96g2ZyerSbDgn1PtGp0S+P0Ilz ZSJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=mCBhyT7m82JCvv9Qmq19HGSyTY8I4ZV8neCBY0l2Uko=; b=Cv6I56OrSjBybGwJ6iD2PjaTv4y5x4W9ZAIw4Pe3pLQRNJ560x9/i1gkjROIs9zBv4 GIg1qI2+EfHSqnIHdYTEfdLf6H7lFrx5N2ICVX3OCfee0cUOPEvAqW7Ypb70rVYvgIh5 Vps61fMGtbII0+E228XheUapiS7w0kpX1LIfd0mN2Ufz0JpgQbPKlG3ojK52UXnFQ0/Z ESIygWm8Rrv7GbO1bLGgr+C3kz2qQxll4IEO1mbs/l3d8hG+OUmdf4RfIWfrygfFQPKT 3AmhRbQ8zhm+efjIoAOSlHQtx0ocLzY9z0gGPRGwPYqu5vB9AOVVNVew0bLvPRUSFQ99 6suQ== X-Gm-Message-State: AOUpUlGwHVQxC/a8zJds3+GQbDhToJgCoN5RQJIL5BRXdzDneN5AlLZo /xmovm6Gteo2JCD8Fe2BDXY= X-Google-Smtp-Source: AA+uWPyuPmBsvoqrTYHPT3nFTU2RL9puB9Bl5t/8AqCHT0iTvF/rFT8lnWVS4552IRzt15LXYv9Ebg== X-Received: by 2002:aca:cd84:: with SMTP id d126-v6mr17849769oig.325.1533597991176; Mon, 06 Aug 2018 16:26:31 -0700 (PDT) Received: from nuclearis2-1.lan (c-98-195-139-126.hsd1.tx.comcast.net. [98.195.139.126]) by smtp.gmail.com with ESMTPSA id w13-v6sm10613328oiw.51.2018.08.06.16.26.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Aug 2018 16:26:30 -0700 (PDT) From: Alexandru Gagniuc To: linux-pci@vger.kernel.org, bhelgaas@google.com, jakub.kicinski@netronome.com Date: Mon, 6 Aug 2018 18:25:36 -0500 Message-Id: <20180806232600.25694-2-mr.nuke.me@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180806232600.25694-1-mr.nuke.me@gmail.com> References: <20180806232600.25694-1-mr.nuke.me@gmail.com> X-Mailman-Approved-At: Mon, 06 Aug 2018 23:30:07 +0000 Subject: [Intel-wired-lan] [PATCH v6 2/9] bnx2x: Do not call pcie_print_link_status() X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex_gagniuc@dellteam.com, Dirk van der Merwe , Tariq Toukan , Leon Romanovsky , linux-rdma@vger.kernel.org, netdev@vger.kernel.org, oss-drivers@netronome.com, shyam_iyer@dell.com, Michael Chan , linux-kernel@vger.kernel.org, keith.busch@intel.com, Saeed Mahameed , Ariel Elior , intel-wired-lan@lists.osuosl.org, Alexandru Gagniuc , austin_bolen@dell.com, everest-linux-l2@cavium.com, "David S. Miller" , Ganesh Goudar MIME-Version: 1.0 Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" This is now done by the PCI core to warn of sub-optimal bandwidth. Signed-off-by: Alexandru Gagniuc --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c index 57348f2b49a3..3eadd6201dff 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c @@ -14100,7 +14100,6 @@ static int bnx2x_init_one(struct pci_dev *pdev, board_info[ent->driver_data].name, (CHIP_REV(bp) >> 12) + 'A', (CHIP_METAL(bp) >> 4), dev->base_addr, bp->pdev->irq, dev->dev_addr); - pcie_print_link_status(bp->pdev); bnx2x_register_phc(bp); From patchwork Mon Aug 6 23:25:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Alex G." X-Patchwork-Id: 954311 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=osuosl.org (client-ip=140.211.166.138; helo=whitealder.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="n8sdHqYA"; dkim-atps=neutral Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41kv5J2wD8z9s4c for ; Tue, 7 Aug 2018 09:30:12 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id D937585250; Mon, 6 Aug 2018 23:30:10 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RYze6A-q2lhY; Mon, 6 Aug 2018 23:30:08 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id B2F3984DBD; Mon, 6 Aug 2018 23:30:08 +0000 (UTC) X-Original-To: intel-wired-lan@lists.osuosl.org Delivered-To: intel-wired-lan@lists.osuosl.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id EFC331C3F86 for ; Mon, 6 Aug 2018 23:26:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id ECA8C84DB8 for ; Mon, 6 Aug 2018 23:26:37 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mi0e6tp6TKSQ for ; Mon, 6 Aug 2018 23:26:37 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-oi0-f67.google.com (mail-oi0-f67.google.com [209.85.218.67]) by whitealder.osuosl.org (Postfix) with ESMTPS id 4D21084D59 for ; Mon, 6 Aug 2018 23:26:37 +0000 (UTC) Received: by mail-oi0-f67.google.com with SMTP id q11-v6so25216078oic.12 for ; Mon, 06 Aug 2018 16:26:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Dr6bD/jWDLVzyDzhBEQSjBVlycw+s4X4ei2OzivsGgY=; b=n8sdHqYAskbg7CtaoFIf/aRhbfv6sCO1+02+aW1s19U38v3nTSZMJzJC3ziw4IzRGp SsZAJ4+mYocxH6PNi3ZyYy/CHok1SZ1sMjAA3zpZk+L+BLilc0veqytXofjxLRFQPJG+ ysWAoQAgnms00rq2XfkbVMTbGrQBEo6fKzdxGmTQ+Kb20HMwaMjb8H3N2/Qoy9yKFHpa e0jysm4TAsQMkmHo+BBK4nDsEaV7iZiEaSUxb7w9XlCj5fygYlEkKPrXqHgnqWkb5wBL ZCthrWPN8sfrT7kPo8QUXpbsBZ/0p4Fsr83OTNBbqkpDJhnTNtiXkifwoIUHRWq6dnG6 OgmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Dr6bD/jWDLVzyDzhBEQSjBVlycw+s4X4ei2OzivsGgY=; b=WDl7dOW6Njf1cFHuSiivbepFxvQdz/tGfIqR/X6kNnkFIcuRYT63aVKBJtX624EWFo oZqC6SoMuuaJR6XLkfTOA6A3DV3nntHAAKRT/OTjizRXO/eOfrL3nq7tOn6IAeGyCQDW Dz9WLCHRZAC5LU6wXiQiKo+S/ihFgeO1lsmfC0jrDzaExggsurG82t071JqxXaOdJmK+ TLfli5Wfx7FuqkWepcYp8vZ9GF5NNom5a2Kj+jlQLm3j786FcIDAzUQjOCuyFGNM2V9d KnfmaYdkIZhakbi67P72+xmVzDfBMp6hZ1ApqnLHVD5ZPlWKLInAbtMFm7xNHvcqaC3m eGsg== X-Gm-Message-State: AOUpUlHRqjbiCcTEiZD10APd0Xi0JjlMQXIr+40+h7WYBc56hzwMrfgi HTpdv1VcbzDVMuBjnMuVw4I= X-Google-Smtp-Source: AAOMgpeNTL+cRNAu8Zdz1+IUcwIa2wgZRxCGTZYNzLJLv3i0coa8OkRSkrx+LlQWL9pd9Wh5l/8prA== X-Received: by 2002:a54:4f94:: with SMTP id g20-v6mr17342767oiy.130.1533597996617; Mon, 06 Aug 2018 16:26:36 -0700 (PDT) Received: from nuclearis2-1.lan (c-98-195-139-126.hsd1.tx.comcast.net. [98.195.139.126]) by smtp.gmail.com with ESMTPSA id w13-v6sm10613328oiw.51.2018.08.06.16.26.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Aug 2018 16:26:36 -0700 (PDT) From: Alexandru Gagniuc To: linux-pci@vger.kernel.org, bhelgaas@google.com, jakub.kicinski@netronome.com Date: Mon, 6 Aug 2018 18:25:37 -0500 Message-Id: <20180806232600.25694-3-mr.nuke.me@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180806232600.25694-1-mr.nuke.me@gmail.com> References: <20180806232600.25694-1-mr.nuke.me@gmail.com> X-Mailman-Approved-At: Mon, 06 Aug 2018 23:30:07 +0000 Subject: [Intel-wired-lan] [PATCH v6 3/9] bnxt_en: Do not call pcie_print_link_status() X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex_gagniuc@dellteam.com, Dirk van der Merwe , Tariq Toukan , Leon Romanovsky , linux-rdma@vger.kernel.org, netdev@vger.kernel.org, oss-drivers@netronome.com, shyam_iyer@dell.com, Michael Chan , linux-kernel@vger.kernel.org, keith.busch@intel.com, Saeed Mahameed , Ariel Elior , intel-wired-lan@lists.osuosl.org, Alexandru Gagniuc , austin_bolen@dell.com, everest-linux-l2@cavium.com, "David S. Miller" , Ganesh Goudar MIME-Version: 1.0 Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" This is now done by the PCI core to warn of sub-optimal bandwidth. Signed-off-by: Alexandru Gagniuc --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 4394c1162be4..4b3928c89076 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -8909,7 +8909,6 @@ static int bnxt_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) netdev_info(dev, "%s found at mem %lx, node addr %pM\n", board_info[ent->driver_data].name, (long)pci_resource_start(pdev, 0), dev->dev_addr); - pcie_print_link_status(pdev); return 0; From patchwork Mon Aug 6 23:25:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Alex G." X-Patchwork-Id: 954310 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=osuosl.org (client-ip=140.211.166.136; helo=silver.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="jmHGRLdi"; dkim-atps=neutral Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41kv5H41fYz9s5K for ; Tue, 7 Aug 2018 09:30:11 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id B147C2283F; Mon, 6 Aug 2018 23:30:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AjOMfBUrhUti; Mon, 6 Aug 2018 23:30:08 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id EE7BA22850; Mon, 6 Aug 2018 23:30:08 +0000 (UTC) X-Original-To: intel-wired-lan@lists.osuosl.org Delivered-To: intel-wired-lan@lists.osuosl.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 5CA891C3F86 for ; Mon, 6 Aug 2018 23:26:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 5885884C29 for ; Mon, 6 Aug 2018 23:26:43 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3cs_qGsZQP8k for ; Mon, 6 Aug 2018 23:26:43 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-oi0-f67.google.com (mail-oi0-f67.google.com [209.85.218.67]) by fraxinus.osuosl.org (Postfix) with ESMTPS id D4C1384BE5 for ; Mon, 6 Aug 2018 23:26:42 +0000 (UTC) Received: by mail-oi0-f67.google.com with SMTP id k12-v6so25233241oiw.8 for ; Mon, 06 Aug 2018 16:26:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=4xvs0w0N34TXyC9C+D5prP5itXqvnv+RfR86wouk0kk=; b=jmHGRLdipkwGcIVNGZSA/5abo4KZz9QoJ2CujiDhYmjx7S5vhKy1m7EbttvWkFOSbI bQy7spZ0zFAnY1ajUUglsSasOpC5E8C3aLfZEoDIWQyK0xfJfgQxCUdldjL8RFzn3PJr O9oFhh4nqv7ZFEveR6ITOnOrHPHqyyJSg5QC9w6X6YJGDriaEzKO7KZtLSvAjb1hM8VK Bf4TS4Y/R3Kl5qHm836cnvbx6RNZcCouI47P3Q7/WC/MBXA5lsX2zaCrQMe4pkFmSAb/ 0deO0tGjHjOfPQd8elnfEbH+CShDPXrSUSobuEBjos8qwELw6Z/I0AzmhOScP/2aWEZg FbaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=4xvs0w0N34TXyC9C+D5prP5itXqvnv+RfR86wouk0kk=; b=AouuHiZjdQHwk8Uc1WrrvJK3egVvwGtarpBEqRYxDIwoc8yYic0LwNmTn+VAI8x7cy WHysKIVVAMpdpMsVYKgE6teiPfpHkkFdrP8dKAh4SsBmB9CysKI8X1DgMAI2HCdMGeIc rFJ4sEQkvFA+df8/q97fNeyrfS0p2X7184yaokz+kGy3lmTqDm8a2b0qM0QEm38uZsc6 X2POjAeWi5StZZE6wy5UnzWKgUJW6ORNAGAQuyteQclzTcS+VmVJGwhD97I2FXy2u0bf 9CdFuR3DytPBSZQdPG984C4m+7F5+d5xa499yf1lrBgZgW6H3sjBEhMzEp3jfL4tYa6p jtmA== X-Gm-Message-State: AOUpUlEmL2VakcesL2bf+36uo95kDcENqq5JCGyp4R/e+yLjjQyEnBZy p7AR/M7rSiBkZ6rt0mOlmYc= X-Google-Smtp-Source: AA+uWPybWOBtCGsptH4SXYTvRhwz1Sf4nFnZmWUZ0PHWrU1XYI/lhZX1mdk+y8qbZ4ZWQgK8CEeCYw== X-Received: by 2002:aca:d0cc:: with SMTP id j73-v6mr15607295oiy.255.1533598002124; Mon, 06 Aug 2018 16:26:42 -0700 (PDT) Received: from nuclearis2-1.lan (c-98-195-139-126.hsd1.tx.comcast.net. [98.195.139.126]) by smtp.gmail.com with ESMTPSA id w13-v6sm10613328oiw.51.2018.08.06.16.26.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Aug 2018 16:26:41 -0700 (PDT) From: Alexandru Gagniuc To: linux-pci@vger.kernel.org, bhelgaas@google.com, jakub.kicinski@netronome.com Date: Mon, 6 Aug 2018 18:25:38 -0500 Message-Id: <20180806232600.25694-4-mr.nuke.me@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180806232600.25694-1-mr.nuke.me@gmail.com> References: <20180806232600.25694-1-mr.nuke.me@gmail.com> X-Mailman-Approved-At: Mon, 06 Aug 2018 23:30:07 +0000 Subject: [Intel-wired-lan] [PATCH v6 4/9] cxgb4: Do not call pcie_print_link_status() X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex_gagniuc@dellteam.com, Dirk van der Merwe , Tariq Toukan , Leon Romanovsky , linux-rdma@vger.kernel.org, netdev@vger.kernel.org, oss-drivers@netronome.com, shyam_iyer@dell.com, Michael Chan , linux-kernel@vger.kernel.org, keith.busch@intel.com, Saeed Mahameed , Ariel Elior , intel-wired-lan@lists.osuosl.org, Alexandru Gagniuc , austin_bolen@dell.com, everest-linux-l2@cavium.com, "David S. Miller" , Ganesh Goudar MIME-Version: 1.0 Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" This is now done by the PCI core to warn of sub-optimal bandwidth. Signed-off-by: Alexandru Gagniuc --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c index a8926e97935e..049958898c17 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c @@ -5726,9 +5726,6 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent) free_msix_info(adapter); } - /* check for PCI Express bandwidth capabiltites */ - pcie_print_link_status(pdev); - err = init_rss(adapter); if (err) goto out_free_dev; From patchwork Mon Aug 6 23:25:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Alex G." X-Patchwork-Id: 954316 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=osuosl.org (client-ip=140.211.166.138; helo=whitealder.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="iKmZIRGf"; dkim-atps=neutral Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41kv5K4W8Xz9s82 for ; Tue, 7 Aug 2018 09:30:13 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id DBD10852B3; Mon, 6 Aug 2018 23:30:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2QOCd+DCP1Oa; Mon, 6 Aug 2018 23:30:09 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 3600085317; Mon, 6 Aug 2018 23:30:09 +0000 (UTC) X-Original-To: intel-wired-lan@lists.osuosl.org Delivered-To: intel-wired-lan@lists.osuosl.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id A2A0D1C3F86 for ; Mon, 6 Aug 2018 23:26:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 9ED8A84DB8 for ; Mon, 6 Aug 2018 23:26:48 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qDyTLIVDilYD for ; Mon, 6 Aug 2018 23:26:48 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-oi0-f66.google.com (mail-oi0-f66.google.com [209.85.218.66]) by whitealder.osuosl.org (Postfix) with ESMTPS id 33E4184D59 for ; Mon, 6 Aug 2018 23:26:48 +0000 (UTC) Received: by mail-oi0-f66.google.com with SMTP id 8-v6so25340556oip.0 for ; Mon, 06 Aug 2018 16:26:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6ffzopQXccTuXo2gTw9Fy1V9dviCucvVy+ObNtSf4IU=; b=iKmZIRGfXgDKB9oSLC7FEPEbdY/XzOBNWfksKcwspfJ5G7Rj0ZPEA24fwh7F08JdTw by4uoy2qnaqKaFsREEH4xw1aTdL4NRfNmjo3iA7nFqPjJoW441mfZu6d8ULQYeBNuOAl gt6dox8ESElqOEVmJGiw99dBhML/EdXhDoDKNVfXfxcV2TgCdqtmnhIpsT91jFKWJMeF m2ENA73PjomI14CCBJOULlPqd/BksSSbZ/1xLVua9M+VIrDFkJ5JTW0WCK6KIKIeDfXT QlUk8GbpW0SkEZLL+CqdC45lN5lTFMZKuVfNN697pbE8aSPYhvs0b5wNSvYQfVv3Y0p0 yzpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6ffzopQXccTuXo2gTw9Fy1V9dviCucvVy+ObNtSf4IU=; b=FPr7ySLAjunq+NcAYrn3RPbRGtV8odpNPr19czEH0fHlcT88amUfNAJMEwkFIgeMUN TlyBkv5M9QGzxXRiXNXtTZXbKEFPATOAoLqkjZY77wGw55nEqoZoRRVV3f1m5kJaqoFp 0zPK2QZOVUSAxOr8SVJtvhDx/nDW4L7/K61ONxYKK5qME41ONhbNnuuEQTWew+dH7mMw 9y5w5/565/J3NU31bApXPZR39T+3DH+oS+5BsCGSMe9Lv3F/bxPAWI7DFI8p7Wm2NGrM vSZb3m2kQgyAWPxg8xLcBCXeT6D18EFuA0i3GJR64URUzZ8Ri/ksYsOKaZWXDNCL4h0P n2ew== X-Gm-Message-State: AOUpUlGaycRprIivKewdAOD+2tjU69RLxF0wDGwCHjWkxTfM3HSxwkAX hDeICeAR1Vszvj663RKR4Jw= X-Google-Smtp-Source: AA+uWPyoIcpOy7uJom0I5L4MC7SyIt5AiuJTfORTCTbNw+SVMpFR6Ewwb3eRMyGLDbNmJ1wbBOxeJQ== X-Received: by 2002:aca:cf87:: with SMTP id f129-v6mr17472388oig.258.1533598007425; Mon, 06 Aug 2018 16:26:47 -0700 (PDT) Received: from nuclearis2-1.lan (c-98-195-139-126.hsd1.tx.comcast.net. [98.195.139.126]) by smtp.gmail.com with ESMTPSA id w13-v6sm10613328oiw.51.2018.08.06.16.26.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Aug 2018 16:26:47 -0700 (PDT) From: Alexandru Gagniuc To: linux-pci@vger.kernel.org, bhelgaas@google.com, jakub.kicinski@netronome.com Date: Mon, 6 Aug 2018 18:25:39 -0500 Message-Id: <20180806232600.25694-5-mr.nuke.me@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180806232600.25694-1-mr.nuke.me@gmail.com> References: <20180806232600.25694-1-mr.nuke.me@gmail.com> X-Mailman-Approved-At: Mon, 06 Aug 2018 23:30:07 +0000 Subject: [Intel-wired-lan] [PATCH v6 5/9] fm10k: Do not call pcie_print_link_status() X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex_gagniuc@dellteam.com, Dirk van der Merwe , Tariq Toukan , Leon Romanovsky , linux-rdma@vger.kernel.org, netdev@vger.kernel.org, oss-drivers@netronome.com, shyam_iyer@dell.com, Michael Chan , linux-kernel@vger.kernel.org, keith.busch@intel.com, Saeed Mahameed , Ariel Elior , intel-wired-lan@lists.osuosl.org, Alexandru Gagniuc , austin_bolen@dell.com, everest-linux-l2@cavium.com, "David S. Miller" , Ganesh Goudar MIME-Version: 1.0 Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" This is now done by the PCI core to warn of sub-optimal bandwidth. Signed-off-by: Alexandru Gagniuc Acked-by: Jeff Kirsher --- drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c index 15071e4adb98..079fd3c884ea 100644 --- a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c +++ b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c @@ -2224,9 +2224,6 @@ static int fm10k_probe(struct pci_dev *pdev, const struct pci_device_id *ent) /* kick off service timer now, even when interface is down */ mod_timer(&interface->service_timer, (HZ * 2) + jiffies); - /* print warning for non-optimal configurations */ - pcie_print_link_status(interface->pdev); - /* report MAC address for logging */ dev_info(&pdev->dev, "%pM\n", netdev->dev_addr); From patchwork Mon Aug 6 23:25:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Alex G." X-Patchwork-Id: 954313 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=osuosl.org (client-ip=140.211.166.138; helo=whitealder.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="LpOzeXpz"; dkim-atps=neutral Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41kv5K0yDxz9s5K for ; Tue, 7 Aug 2018 09:30:12 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 6E84685433; Mon, 6 Aug 2018 23:30:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yh7eU3QD7wPf; Mon, 6 Aug 2018 23:30:10 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 69A078543C; Mon, 6 Aug 2018 23:30:09 +0000 (UTC) X-Original-To: intel-wired-lan@lists.osuosl.org Delivered-To: intel-wired-lan@lists.osuosl.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 652F81C3F86 for ; Mon, 6 Aug 2018 23:26:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 61F9F84DB8 for ; Mon, 6 Aug 2018 23:26:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KGDJyNER1ZMI for ; Mon, 6 Aug 2018 23:26:55 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-oi0-f66.google.com (mail-oi0-f66.google.com [209.85.218.66]) by whitealder.osuosl.org (Postfix) with ESMTPS id D6D2E84D59 for ; Mon, 6 Aug 2018 23:26:54 +0000 (UTC) Received: by mail-oi0-f66.google.com with SMTP id d189-v6so25249435oib.6 for ; Mon, 06 Aug 2018 16:26:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=UCl4Lu6W1ZfIHNMUiiyuRZb9LsAG6du1KMvhVVIhXLw=; b=LpOzeXpzqzwoDKrcKx07OhhdknYQUOCebniUOF5i8Iie9C1feMfGSE4gz2/l4Wautc V7wYz4A8AaNvSFxSUBwkiZZU4wC8PLBQ2bAHAb6ZvCWQTidvVLEYNso0vLxWPGJa5Uy4 tN2zGsfRJXKzvTQ7F5IzLo3QAcyMMY2bBRYhymx0/KVtnbDwM+goY0UInUz34iqaHBP2 rqdExl8EW9h0/CHNMDLIfAC5gu0PlKK2qsDDScKxPiUjKABLxko2+sq642Rwnx590LRE XHkKRvMcgosvUaAQfCEhOaMuTiIq52QzpMetsj6tNz0Pp/8geIVDitNSzbscPMi8b1Ms tO9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=UCl4Lu6W1ZfIHNMUiiyuRZb9LsAG6du1KMvhVVIhXLw=; b=EG8qGLi91C9FX9kp5DMJnfUB7/M7qqTpSGdjPi431GpQhAjkiopLWDi24b6AuYd6ic pFWA9ze3P3+OkgyrJWZkVBVYPUZsUI3yWZ8w3ZPAjWJpC43g76bxiiaEi663Ji2I01di Deo42+RDD3Ft1CKLlzemH8mAJ3V3mdQmajujfouhGT/zd/38opnEsekmTw7FVg8492uy qq79UNEPMb5hCPUY4lOMn7FY5W4TVpNAv8xcmDGmOE7/CqEM1qNGUWNktpjTXw86KWGE ljwYND3HE4BxXzZHr8PIP5oA0w3GfOX+VyBSUEDG0U9jIX74Dk7AfgMXdTfvhMkMPQkM r6Gw== X-Gm-Message-State: AOUpUlH4S+1AoHac0YNrkRNyKaFFZkLWReyso7UdQ4RmoBSRTp6dGNI2 BuRP+3fitM6e4ymjA/HKPnM= X-Google-Smtp-Source: AA+uWPyWBaHlOBuson6UpSvREg5kVhqrpQFG4HoivVCwQ0d/9xUL04GO5wOkJI4318I5BZFofZn3Sg== X-Received: by 2002:aca:cd84:: with SMTP id d126-v6mr17850955oig.325.1533598014177; Mon, 06 Aug 2018 16:26:54 -0700 (PDT) Received: from nuclearis2-1.lan (c-98-195-139-126.hsd1.tx.comcast.net. [98.195.139.126]) by smtp.gmail.com with ESMTPSA id w13-v6sm10613328oiw.51.2018.08.06.16.26.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Aug 2018 16:26:53 -0700 (PDT) From: Alexandru Gagniuc To: linux-pci@vger.kernel.org, bhelgaas@google.com, jakub.kicinski@netronome.com Date: Mon, 6 Aug 2018 18:25:40 -0500 Message-Id: <20180806232600.25694-6-mr.nuke.me@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180806232600.25694-1-mr.nuke.me@gmail.com> References: <20180806232600.25694-1-mr.nuke.me@gmail.com> X-Mailman-Approved-At: Mon, 06 Aug 2018 23:30:07 +0000 Subject: [Intel-wired-lan] [PATCH v6 6/9] ixgbe: Do not call pcie_print_link_status() X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex_gagniuc@dellteam.com, Dirk van der Merwe , Tariq Toukan , Leon Romanovsky , linux-rdma@vger.kernel.org, netdev@vger.kernel.org, oss-drivers@netronome.com, shyam_iyer@dell.com, Michael Chan , linux-kernel@vger.kernel.org, keith.busch@intel.com, Saeed Mahameed , Ariel Elior , intel-wired-lan@lists.osuosl.org, Alexandru Gagniuc , austin_bolen@dell.com, everest-linux-l2@cavium.com, "David S. Miller" , Ganesh Goudar MIME-Version: 1.0 Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" This is now done by the PCI core to warn of sub-optimal bandwidth. Signed-off-by: Alexandru Gagniuc Acked-by: Jeff Kirsher --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 26 ------------------- 1 file changed, 26 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c index 62e57b05a0ae..7ecdc6c03a66 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c @@ -241,28 +241,6 @@ static inline bool ixgbe_pcie_from_parent(struct ixgbe_hw *hw) } } -static void ixgbe_check_minimum_link(struct ixgbe_adapter *adapter, - int expected_gts) -{ - struct ixgbe_hw *hw = &adapter->hw; - struct pci_dev *pdev; - - /* Some devices are not connected over PCIe and thus do not negotiate - * speed. These devices do not have valid bus info, and thus any report - * we generate may not be correct. - */ - if (hw->bus.type == ixgbe_bus_type_internal) - return; - - /* determine whether to use the parent device */ - if (ixgbe_pcie_from_parent(&adapter->hw)) - pdev = adapter->pdev->bus->parent->self; - else - pdev = adapter->pdev; - - pcie_print_link_status(pdev); -} - static void ixgbe_service_event_schedule(struct ixgbe_adapter *adapter) { if (!test_bit(__IXGBE_DOWN, &adapter->state) && @@ -10585,10 +10563,6 @@ static int ixgbe_probe(struct pci_dev *pdev, const struct pci_device_id *ent) break; } - /* don't check link if we failed to enumerate functions */ - if (expected_gts > 0) - ixgbe_check_minimum_link(adapter, expected_gts); - err = ixgbe_read_pba_string_generic(hw, part_str, sizeof(part_str)); if (err) strlcpy(part_str, "Unknown", sizeof(part_str)); From patchwork Mon Aug 6 23:25:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Alex G." X-Patchwork-Id: 954314 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=osuosl.org (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="GuUdyovG"; dkim-atps=neutral Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41kv5K38whz9s4c for ; Tue, 7 Aug 2018 09:30:13 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 59CEA84FC9; Mon, 6 Aug 2018 23:30:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4JCDgitI1X3q; Mon, 6 Aug 2018 23:30:10 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id A8E6684EF6; Mon, 6 Aug 2018 23:30:09 +0000 (UTC) X-Original-To: intel-wired-lan@lists.osuosl.org Delivered-To: intel-wired-lan@lists.osuosl.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 837D81C3F86 for ; Mon, 6 Aug 2018 23:27:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 7C1F184DB8 for ; Mon, 6 Aug 2018 23:27:01 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gIW9nq8Lrz6e for ; Mon, 6 Aug 2018 23:27:01 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-oi0-f67.google.com (mail-oi0-f67.google.com [209.85.218.67]) by whitealder.osuosl.org (Postfix) with ESMTPS id DD02E84D59 for ; Mon, 6 Aug 2018 23:27:00 +0000 (UTC) Received: by mail-oi0-f67.google.com with SMTP id b16-v6so11899134oic.9 for ; Mon, 06 Aug 2018 16:27:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=2bZ3Se4cgyGCiwuPr3El/TGVU5z5CMKd0ds0GHiAfTw=; b=GuUdyovGPckoK8zDcbACzemz3VMUxYLJ4C8kkYY2IvYBB/q9CLbiHBQwwLpnA5uYvc 608LeCsU3olh0nPqNFfdnKFArd655QmiT+oDi7GvfuQCh/RrXPGK5cI2anlc6pUC+feW Mi3Pms71GszwJMcY3uuLewF3iBRjwKjsWit6BcLHqATJlgNSwzFr/t5gK4dhkp/w5mNu d7FdJpVQ2CgXhWfvGjPtKNHUTtXIQU8CVIhz/eSUsdyTvb1mSvb/GXReoggjQTK7D+0t 8y6njYZyCnRh3clmTbvqBCHIAgCczr7AlPaFhzrOU7vo/Rs6snCCb274UbX0hxjd/I21 Y3Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=2bZ3Se4cgyGCiwuPr3El/TGVU5z5CMKd0ds0GHiAfTw=; b=YA/8XcIaGiZ9QiSGmUUkwJUs3IT3iyaEK2k+qH54/3y22qyEK343Yvdcj9G2mW4m9G +YBwe9CxqIp6ZZzKamrIAoor+AhOVEFr+JQQ3vhM88e4x8gVd3HqlsS7F40GayV2AjcQ MWRirjKCX/5uKodE7Sz82UlqIN4UxgcECSmmBx/ZihvbfBiLKXSCuJCWCdqBmSVOeO4d +J9UKjc7SmwyVIsEB/GZNnRtZknXF4U8dsY/ZmJKrvHgNwbpjojAf4IbakJJtEXGLXCI 0px4vy04w898pO0Mo8d0BhSKzY3G+hXFrva8zPBMj4TSloO/T8c/e60k4Ybilm/F4dqB 7UdA== X-Gm-Message-State: AOUpUlEjR/k9ZvycD+XMhqxVe9uff6KsjQB/1j32A0mNs7NjZ2Sdi5ff utLsTLUcXkhyHskvzIwngBI= X-Google-Smtp-Source: AAOMgpeGISPLlKhVIqJgDC21UC9nd5l+l/0Kp71SpYw3ac98GEdfCzo3mejCOWHDqAXHXDcJZ1eivA== X-Received: by 2002:aca:4204:: with SMTP id p4-v6mr15426647oia.242.1533598020198; Mon, 06 Aug 2018 16:27:00 -0700 (PDT) Received: from nuclearis2-1.lan (c-98-195-139-126.hsd1.tx.comcast.net. [98.195.139.126]) by smtp.gmail.com with ESMTPSA id w13-v6sm10613328oiw.51.2018.08.06.16.26.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Aug 2018 16:26:59 -0700 (PDT) From: Alexandru Gagniuc To: linux-pci@vger.kernel.org, bhelgaas@google.com, jakub.kicinski@netronome.com Date: Mon, 6 Aug 2018 18:25:41 -0500 Message-Id: <20180806232600.25694-7-mr.nuke.me@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180806232600.25694-1-mr.nuke.me@gmail.com> References: <20180806232600.25694-1-mr.nuke.me@gmail.com> X-Mailman-Approved-At: Mon, 06 Aug 2018 23:30:07 +0000 Subject: [Intel-wired-lan] [PATCH v6 7/9] net/mlx4: Do not call pcie_print_link_status() X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex_gagniuc@dellteam.com, Dirk van der Merwe , Tariq Toukan , Leon Romanovsky , linux-rdma@vger.kernel.org, netdev@vger.kernel.org, oss-drivers@netronome.com, shyam_iyer@dell.com, Michael Chan , linux-kernel@vger.kernel.org, keith.busch@intel.com, Saeed Mahameed , Ariel Elior , intel-wired-lan@lists.osuosl.org, Alexandru Gagniuc , austin_bolen@dell.com, everest-linux-l2@cavium.com, "David S. Miller" , Ganesh Goudar MIME-Version: 1.0 Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" This is now done by the PCI core to warn of sub-optimal bandwidth. Signed-off-by: Alexandru Gagniuc Reviewed-by: Leon Romanovsky --- drivers/net/ethernet/mellanox/mlx4/main.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c index 872014702fc1..da4d54195853 100644 --- a/drivers/net/ethernet/mellanox/mlx4/main.c +++ b/drivers/net/ethernet/mellanox/mlx4/main.c @@ -3398,13 +3398,6 @@ static int mlx4_load_one(struct pci_dev *pdev, int pci_dev_data, } } - /* check if the device is functioning at its maximum possible speed. - * No return code for this call, just warn the user in case of PCI - * express device capabilities are under-satisfied by the bus. - */ - if (!mlx4_is_slave(dev)) - pcie_print_link_status(dev->persist->pdev); - /* In master functions, the communication channel must be initialized * after obtaining its address from fw */ if (mlx4_is_master(dev)) { From patchwork Mon Aug 6 23:25:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Alex G." X-Patchwork-Id: 954312 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=osuosl.org (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="vene/i5b"; dkim-atps=neutral Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41kv5J6f5Mz9s4v for ; Tue, 7 Aug 2018 09:30:12 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 0651E84F98; Mon, 6 Aug 2018 23:30:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3SaXHNry7MHi; Mon, 6 Aug 2018 23:30:10 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id D94C884F58; Mon, 6 Aug 2018 23:30:09 +0000 (UTC) X-Original-To: intel-wired-lan@lists.osuosl.org Delivered-To: intel-wired-lan@lists.osuosl.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id E738C1C3F86 for ; Mon, 6 Aug 2018 23:27:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id E461584EE2 for ; Mon, 6 Aug 2018 23:27:06 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OoezP0Zd1MV6 for ; Mon, 6 Aug 2018 23:27:06 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-oi0-f68.google.com (mail-oi0-f68.google.com [209.85.218.68]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 5148C84BE5 for ; Mon, 6 Aug 2018 23:27:06 +0000 (UTC) Received: by mail-oi0-f68.google.com with SMTP id j205-v6so25291632oib.4 for ; Mon, 06 Aug 2018 16:27:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=hmTl8/1fRiYZPHtNk6ThTZh2VqXnVbDxTlqsL3JkjaA=; b=vene/i5bbGvykssAvZFw0/PWoB9Ma7/wBHYXcIfp0z1kKroMtjf+bOoQLGEG8Mi638 WMqQEsBMrLA29DzYiEAHzGa2R+9DK5pc3kanO5o4hJRgRUhp9K4CSsqtePVYKQpWSLIa wY6KT6uEgzlqeqr+an8uf/yNWWIeGmOeg6cwIHWtrqPrxb0YSu9lvoZJfhYOKOzKfxfH ZfBrug+CTEsV2Od9lR3fYMcy5LLK3nn9Onag5rJjdyp6nFwqyuUitpI6YCfR+UN9g5UA wlEGJJh2Koa4NfgOjll3KZHO2s1eaDcxP8eZovRhh2vtGpAQOt0gcqb0hbJFjrlleUG3 4yJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=hmTl8/1fRiYZPHtNk6ThTZh2VqXnVbDxTlqsL3JkjaA=; b=jCiSjwTSaX8qYRBe3BWO1BnhDA46P4ovM5QJyz0COYEKUNe910PCaf4lR0YMJ6Jczv q43mCYjapULuW5g2LFyUsY+UZ1v1R6KrjNZjbXwVS3WVOHynqoq3qaW9J6n+xMExVmkP 3LTH51vXgJ6Q09oVlTzG/8IzRMoI9QGsT5wN7UZEZ8k5lHjSzb+arJyKei4Hwk1kjVBy VXdGFjorpUHCqdbdluPFLl4CY5jiFgsg1emYvAYH1tnFX/EA2afq343b9sX4JCnxnKtn gQqqe8PiqhXBYms2sJhL93znOTgbcjdl2BqG0+vGE+c/gUG2mNRjcuQVxer/ch5Vj12W VqDw== X-Gm-Message-State: AOUpUlFDZlJ55zCeAvq0db6tqQeBEc2Uay/K8Y7JDpQEbOXAsJiht4cd HE35cadfMUljZ6szw7/fi9w= X-Google-Smtp-Source: AAOMgpewaBmZ3Hx9zpVKNq6Ibe5ag++4mpSRQyPOTkZUlk6p8Vmg8wWx1x+DWynbGTI7w4yAS9H9dw== X-Received: by 2002:aca:bec2:: with SMTP id o185-v6mr17721451oif.22.1533598025648; Mon, 06 Aug 2018 16:27:05 -0700 (PDT) Received: from nuclearis2-1.lan (c-98-195-139-126.hsd1.tx.comcast.net. [98.195.139.126]) by smtp.gmail.com with ESMTPSA id w13-v6sm10613328oiw.51.2018.08.06.16.27.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Aug 2018 16:27:05 -0700 (PDT) From: Alexandru Gagniuc To: linux-pci@vger.kernel.org, bhelgaas@google.com, jakub.kicinski@netronome.com Date: Mon, 6 Aug 2018 18:25:42 -0500 Message-Id: <20180806232600.25694-8-mr.nuke.me@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180806232600.25694-1-mr.nuke.me@gmail.com> References: <20180806232600.25694-1-mr.nuke.me@gmail.com> X-Mailman-Approved-At: Mon, 06 Aug 2018 23:30:07 +0000 Subject: [Intel-wired-lan] [PATCH v6 8/9] net/mlx5: Do not call pcie_print_link_status() X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex_gagniuc@dellteam.com, Dirk van der Merwe , Tariq Toukan , Leon Romanovsky , linux-rdma@vger.kernel.org, netdev@vger.kernel.org, oss-drivers@netronome.com, shyam_iyer@dell.com, Michael Chan , linux-kernel@vger.kernel.org, keith.busch@intel.com, Saeed Mahameed , Ariel Elior , intel-wired-lan@lists.osuosl.org, Alexandru Gagniuc , austin_bolen@dell.com, everest-linux-l2@cavium.com, "David S. Miller" , Ganesh Goudar MIME-Version: 1.0 Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" This is now done by the PCI core to warn of sub-optimal bandwidth. Signed-off-by: Alexandru Gagniuc Reviewed-by: Leon Romanovsky --- drivers/net/ethernet/mellanox/mlx5/core/main.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c index 615005e63819..e10f9c2bea3b 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/main.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c @@ -1045,10 +1045,6 @@ static int mlx5_load_one(struct mlx5_core_dev *dev, struct mlx5_priv *priv, dev_info(&pdev->dev, "firmware version: %d.%d.%d\n", fw_rev_maj(dev), fw_rev_min(dev), fw_rev_sub(dev)); - /* Only PFs hold the relevant PCIe information for this query */ - if (mlx5_core_is_pf(dev)) - pcie_print_link_status(dev->pdev); - /* on load removing any previous indication of internal error, device is * up */ From patchwork Mon Aug 6 23:25:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Alex G." X-Patchwork-Id: 954315 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=osuosl.org (client-ip=140.211.166.133; helo=hemlock.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="YOk4W9Ij"; dkim-atps=neutral Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41kv5K3NsTz9s5c for ; Tue, 7 Aug 2018 09:30:13 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id CE87185B67; Mon, 6 Aug 2018 23:30:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MFhmP6gRIeAM; Mon, 6 Aug 2018 23:30:10 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 1B097856F2; Mon, 6 Aug 2018 23:30:10 +0000 (UTC) X-Original-To: intel-wired-lan@lists.osuosl.org Delivered-To: intel-wired-lan@lists.osuosl.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id D51471C3F86 for ; Mon, 6 Aug 2018 23:27:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id D1E5322848 for ; Mon, 6 Aug 2018 23:27:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Vbs6CmGd8zWW for ; Mon, 6 Aug 2018 23:27:15 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-oi0-f67.google.com (mail-oi0-f67.google.com [209.85.218.67]) by silver.osuosl.org (Postfix) with ESMTPS id B1ED22283F for ; Mon, 6 Aug 2018 23:27:11 +0000 (UTC) Received: by mail-oi0-f67.google.com with SMTP id b15-v6so25247289oib.10 for ; Mon, 06 Aug 2018 16:27:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=/X5lGKWH77cyPJBOOmZPH/w7I6UAHHh4sZCzwZv18W0=; b=YOk4W9IjxiLVZkHPnCsVCW6pZQTlqCsPM3piMt++EZLeB1xyr7EHr0N6RBwh5mK/GE A1uuW77ZWCKJFsRmoncRcjJLm4L8QY8JByRFXvsepLQQ+QcLF7/MqwMPGHzdVWP6VbVP KbOqPr7yaHTBfGwCxr1H5CjlAct/PEmiDiCG3uwzUb10Czo2gZDpEiRN+qO6DkcNZrgA JsVysaJ3v/OF9h40p9Sp01SOKZhK+H5qG26qx2Z45mK7b2NCpaioPQx4MLJajDgb4ulp Cwnu6aTKIA8n+UlyjyAKdbpjSgttOUHJFPWEJldjffPE+1mh+1CDmz1bg6wzLFsBNAK/ q8fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=/X5lGKWH77cyPJBOOmZPH/w7I6UAHHh4sZCzwZv18W0=; b=tRX98a4FJZXr2R1/e6OGl2Fmupbkoox3xVcyCCvSm57O/TITgTlMEbrKrO8I9KmnbS 0nkJMCdE8Jv6z1VQd1ZitB5wWl1LwcpaDe18Cd22eaq44NGW5ZBvOUaZG9r0mBKKvOzT /BTBLdh0TGFnVLJiTIDOL97pswrzWXDT9FPMqL/6eWA45Oni+74zVcP/l4FxyCS3pO+V SdTxOY/a5F/h08NFjMYVsKsD679Nnf45ghNaf8py8Sbl84f5Fv4M2WKpd1Uj7jkQFsqH w6C9bwTw2f8DFDNjiZSkbqEUiDdWK9tmoGhwN0nPIwMS9M1JMOCYJmBIRYZYYdtHYeKw QQGQ== X-Gm-Message-State: AOUpUlFGI6PHgy6KruQu7sQ+3Yqff+75N8vn/7BJ/ILXjhVypL6+ZvJZ ZJj21/MlYQA8PC0x0ox/nfU= X-Google-Smtp-Source: AA+uWPyqepO3ACjQR+JzgMAiiErDXisUOThTd206MbmgwkSaf+BQ+HDjA/D/CYTgGPuwEQ1pJTCjcQ== X-Received: by 2002:aca:cd84:: with SMTP id d126-v6mr17851662oig.325.1533598030946; Mon, 06 Aug 2018 16:27:10 -0700 (PDT) Received: from nuclearis2-1.lan (c-98-195-139-126.hsd1.tx.comcast.net. [98.195.139.126]) by smtp.gmail.com with ESMTPSA id w13-v6sm10613328oiw.51.2018.08.06.16.27.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Aug 2018 16:27:10 -0700 (PDT) From: Alexandru Gagniuc To: linux-pci@vger.kernel.org, bhelgaas@google.com, jakub.kicinski@netronome.com Date: Mon, 6 Aug 2018 18:25:43 -0500 Message-Id: <20180806232600.25694-9-mr.nuke.me@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180806232600.25694-1-mr.nuke.me@gmail.com> References: <20180806232600.25694-1-mr.nuke.me@gmail.com> X-Mailman-Approved-At: Mon, 06 Aug 2018 23:30:07 +0000 Subject: [Intel-wired-lan] [PATCH v6 9/9] nfp: Do not call pcie_print_link_status() X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex_gagniuc@dellteam.com, Dirk van der Merwe , Tariq Toukan , Leon Romanovsky , linux-rdma@vger.kernel.org, netdev@vger.kernel.org, oss-drivers@netronome.com, shyam_iyer@dell.com, Michael Chan , linux-kernel@vger.kernel.org, keith.busch@intel.com, Saeed Mahameed , Ariel Elior , intel-wired-lan@lists.osuosl.org, Alexandru Gagniuc , austin_bolen@dell.com, everest-linux-l2@cavium.com, "David S. Miller" , Ganesh Goudar MIME-Version: 1.0 Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" This is now done by the PCI core to warn of sub-optimal bandwidth. Signed-off-by: Alexandru Gagniuc --- drivers/net/ethernet/netronome/nfp/nfpcore/nfp6000_pcie.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp6000_pcie.c b/drivers/net/ethernet/netronome/nfp/nfpcore/nfp6000_pcie.c index 749655c329b2..0324f99bd1a7 100644 --- a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp6000_pcie.c +++ b/drivers/net/ethernet/netronome/nfp/nfpcore/nfp6000_pcie.c @@ -1324,7 +1324,6 @@ struct nfp_cpp *nfp_cpp_from_nfp6000_pcie(struct pci_dev *pdev) /* Finished with card initialization. */ dev_info(&pdev->dev, "Netronome Flow Processor NFP4000/NFP6000 PCIe Card Probe\n"); - pcie_print_link_status(pdev); nfp = kzalloc(sizeof(*nfp), GFP_KERNEL); if (!nfp) {