From patchwork Mon Aug 6 22:53:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ashish Varma X-Patchwork-Id: 954287 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="s3VxwQPq"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41ktK24v13z9s4v for ; Tue, 7 Aug 2018 08:55:18 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id D29D4EF0; Mon, 6 Aug 2018 22:55:16 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 03FA7ED9 for ; Mon, 6 Aug 2018 22:55:16 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id A54E4766 for ; Mon, 6 Aug 2018 22:55:15 +0000 (UTC) Received: by mail-pf1-f193.google.com with SMTP id a26-v6so7553906pfo.4 for ; Mon, 06 Aug 2018 15:55:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=Rpwdpqto5/D5dgffkQmOeXgtH/EuKH603sVFu3B6lq8=; b=s3VxwQPqHJDe4nIn5XELHmJwdMzC4B3bB223qwiF74gqZ5ZNvDM89ankPeXP+l2IJf NC9awUfqS9hjKSRfiGqaIe5C8TIUh6OYwjaN6zObvha9gw6ig+G/gcSkzqfc63MOUHic rwvqQrpOeCWPPtK8khwlhF9msmA7HfLieM4vtsf24M+oKDFzUzKgApMoryBDe1vpy+aU R9+vxQbBhCY1BVzXUbaFRFOnnAZnBAmCExsMhBx3DVk93daruK2LILmY69qrnYqH7Mj+ wurTJt7S0iuAorfC1V/Y48IPlaAQu7PsrcVoipI8YbiOUx1noBP7Gcddy8VAFqPXZmK3 uohA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=Rpwdpqto5/D5dgffkQmOeXgtH/EuKH603sVFu3B6lq8=; b=HGiIUtel9ua+wRTDDM+GMDzOjeIWglMhbFr6um730eLDt9KaHEApGGZFKhs3WmqDeo LiW+Pvvmxq3LYfguvUiJtU5uBBSimZSBdgh6QC82bfKbYvcbVVoD57Sx89OjbQJcIqpE huFYRyGQr+QEWKFHdUt49mUGVkc4WGXAkqo4njoIqH//fi5fL5c5HNMiF6u+J/7RjWl/ eG1uNLo43eGVOJTTI4p7CWTOH1JVUoSWpnJpeOXoOyb0e5Qf/I9/dPwt3kDoB9rWoQXw 84b/tSUDngvQyqXb7wel80iryv04mzNe0j/vj4ZOx5ooMD5hmWqHE5anGm88kVBz1ftA t2TA== X-Gm-Message-State: AOUpUlH3u//hIH2f0jwTVHvSvUlYTjTifN+GgKNSbWy5fm1+dXPeND7E Sx+ytm3lmatXDXVs4F4xPy17wq6K X-Google-Smtp-Source: AAOMgpfHy/+lqf/fTBttIyHe+Ol8EfTs/N4xElcCugwS33LTdHOD66wYqX3CwVXIcTUDBqjiRKxKLw== X-Received: by 2002:a63:e206:: with SMTP id q6-v6mr16149291pgh.223.1533596115097; Mon, 06 Aug 2018 15:55:15 -0700 (PDT) Received: from ashish-Ubuntu-WorkStation.eng.vmware.com ([66.170.99.1]) by smtp.gmail.com with ESMTPSA id w13-v6sm12210518pgs.89.2018.08.06.15.55.14 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 06 Aug 2018 15:55:14 -0700 (PDT) From: Ashish Varma To: dev@openvswitch.org Date: Mon, 6 Aug 2018 15:53:37 -0700 Message-Id: <1533596017-30635-1-git-send-email-ashishvarma.ovs@gmail.com> X-Mailer: git-send-email 2.7.4 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH v3] tests: Test for ovs-ofctl snoop command X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org Added test for snoop command to check for the initial handshake messages when a bridge connects to a controller via 'unix' connection method. Signed-off-by: Ashish Varma --- v2-v3: Moved 'on_exit kill" command before the start of the command to avoid the race condition between start of the process and registering to have it killed on interrupt. Removed deletion of snoopbr0.txt to debug any failure. Cleaner shell re-direct. --- tests/ovs-ofctl.at | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/tests/ovs-ofctl.at b/tests/ovs-ofctl.at index 06597d7..21a576a 100644 --- a/tests/ovs-ofctl.at +++ b/tests/ovs-ofctl.at @@ -3184,3 +3184,30 @@ AT_CHECK([grep -q "ct_dpif|DBG|.*ct_flush: zone 123" ovs-vswitchd.log]) OVS_VSWITCHD_STOP AT_CLEANUP + + +AT_SETUP([ovs-ofctl snoop-unix-connection]) +OVS_VSWITCHD_START + +dnl setup controller for br0 before starting the controller +AT_CHECK([ovs-vsctl -vsyslog:off set-controller br0 unix:testcontroller]) + +dnl then start listening on the '.snoop' connection +on_exit 'kill `cat ovs-ofctl-snoop.pid`' +AT_CHECK([ovs-ofctl -vsyslog:off --detach --pidfile=ovs-ofctl-snoop.pid snoop br0 > snoopbr0.txt 2>&1]) + +dnl finally start the controller +on_exit 'kill `cat ovs-testcontroller.pid`' +AT_CHECK([ovs-testcontroller -vsyslog:off --detach --pidfile punix:testcontroller], [0], [ignore]) +OVS_WAIT_UNTIL([test -e testcontroller]) + +dnl check for some of the initial handshake messages +OVS_WAIT_UNTIL([egrep "OFPT_FEATURES_REQUEST" snoopbr0.txt 1> /dev/null 2>&1]) +OVS_WAIT_UNTIL([egrep "OFPT_FEATURES_REPLY" snoopbr0.txt 1> /dev/null 2>&1]) +OVS_WAIT_UNTIL([egrep "OFPT_SET_CONFIG" snoopbr0.txt 1> /dev/null 2>&1]) + +dnl need to suppress the 'connection failed' WARN message in ovs-vswitchd +dnl because we need ovs-vswitchd to have the controller config before starting +dnl the controller to 'snoop' the OpenFlow messages from beginning +OVS_VSWITCHD_STOP(["/connection failed (No such file or directory)/d"]) +AT_CLEANUP