From patchwork Fri Aug 3 00:22:34 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zak Whittington X-Patchwork-Id: 953021 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="mLhOc49P"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41hWlt1KfCz9s4V for ; Fri, 3 Aug 2018 12:51:53 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id A9845D5B; Fri, 3 Aug 2018 00:23:12 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id C3144C9A for ; Fri, 3 Aug 2018 00:23:11 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-ua0-f194.google.com (mail-ua0-f194.google.com [209.85.217.194]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 5BE48713 for ; Fri, 3 Aug 2018 00:23:11 +0000 (UTC) Received: by mail-ua0-f194.google.com with SMTP id h1-v6so2689483uao.8 for ; Thu, 02 Aug 2018 17:23:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=R06n53lkzUTG2OptMMmD5NerPKPRUr3JdNy3+OyGY3c=; b=mLhOc49PziD738A7pHzIRn0vw885f1bt1tcssybiRo6jFngSH7jVq7N3AED9IwZYWT UTIR0fNyqJj0lvEfur8Kq3RKCNFHSmvTQ64lFnlWNkFN+/3ha2/L7MoGo5h22W/Xgdn0 PyA4wfUTXeX3c+thpebZVWUGTMlAWsLJtgTB0CbFvHCfvfymAwbOXJtS2dZOOrdfBgwG YgZmUB4/0DgD5nWD8sDIpyJ3/LKlyRW++9HNhItQyTxxCLRfJgRV05PwAiL3e8CSJZyU Qb7SCZrwsMK1apyoRb8CS1WymlzzOkE+A+0eFeJoOqzCsd98Pb8qUCpvMRIqLrtVWkNK Fcog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=R06n53lkzUTG2OptMMmD5NerPKPRUr3JdNy3+OyGY3c=; b=ugm1kUmx4ATADAWqFrCqEaMDu2PYczYwkOZYdzwtf85ytx5/6uaWVklKeoJfCbYXGq AwrVM91u80yPXm1DQMo0ecYle3mmCU4XHOf0E+loPdOy+hXm4O6eojQ3Nqo3tMtvfqtD pLJshv57p7YI3N1h2Wu6wwWztZoqdRg5ngm4RVLUeAsBlAZzYihLRFb7LXfirbgU+OSP XqX0f25TZDEM5d+tCvPLirrYYKKzkVs4F9xOGceLGOQVprCDjaJMwz8DhsA46d+nIoZN F3UUkxII8ucJR6PlSlXURjcOo0LuP4ViLrjD+I8FDmzaXupxHDLvlXoqPRFoop5PNMyC t+kQ== X-Gm-Message-State: AOUpUlH0uaw4tkftLhYT9dz6qNltY5p6l40GXDg+wnvaE7rcM3MTo8z3 hjQW7AqL+jCf5jvOQld5xVJk2Xs2UbOWsFmfDlggm9R4 X-Google-Smtp-Source: AAOMgpcLOijrSaKii/8ac7CotY/kgwb5hw4fhRDqiWafVaDx5xXywOzuLYMOCatCH+qIKPkaysOzhWSkIQcWni0jK6E= X-Received: by 2002:a9f:31c6:: with SMTP id w6-v6mr1245719uad.131.1533255790413; Thu, 02 Aug 2018 17:23:10 -0700 (PDT) MIME-Version: 1.0 From: Zak Whittington Date: Thu, 2 Aug 2018 17:22:34 -0700 Message-ID: To: dev@openvswitch.org X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, HTML_MESSAGE, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org X-Content-Filtered-By: Mailman/MimeDel 2.1.12 Subject: [ovs-dev] [PATCH] ofproto-dpif: Add logging when sending out an in_port X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org This patch adds a log message to warn when sending out an in_port. VMware-BZ: #2158607 Signed-off-by: Zak Whittington --- ofproto/ofproto-dpif-xlate.c | 4 ++++ 1 file changed, 4 insertions(+) } break; @@ -5092,6 +5094,8 @@ xlate_output_trunc_action(struct xlate_ctx *ctx, ctx->xout->slow |= SLOW_ACTION; } } else { + static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5); + VLOG_INFO_RL(&rl, "skipping output to input port"); xlate_report(ctx, OFT_WARN, "skipping output to input port"); } break; diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c index 01f1faf..93fbee5 100644 --- a/ofproto/ofproto-dpif-xlate.c +++ b/ofproto/ofproto-dpif-xlate.c @@ -5007,6 +5007,8 @@ xlate_output_action(struct xlate_ctx *ctx, ofp_port_t port, if (port != ctx->xin->flow.in_port.ofp_port) { compose_output_action(ctx, port, NULL, is_last_action, truncate); } else { + static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5); + VLOG_INFO_RL(&rl, "skipping output to input port"); xlate_report(ctx, OFT_WARN, "skipping output to input port");