From patchwork Thu Aug 2 22:55:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 953000 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-483076-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="svItAkha"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41hQWq0rkBz9s4V for ; Fri, 3 Aug 2018 08:56:05 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:reply-to:mime-version :content-type; q=dns; s=default; b=hIIYUXG17ZNeT2IpzWFuEBOUeYaHY xdAp4KNIIqRoNCECJZj4uToUY385wwAaHjrxpZeDkhURZ6BgBna7YrXy1+dfoC3t i7s7DOf3gb/qIE3Jm4rUCAeipt3iWPEpH5rIZ3fAp6Macfmw6v9+9rgyFza8IwDh S3HIen0d8xHjRQ= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:reply-to:mime-version :content-type; s=default; bh=CNWuvxJdeddbTDZpRdWkRkj4vNQ=; b=svI tAkhaBbqzgCxHtKk5rXrj0K8eUYHsNrZtdeBmHt+oMmy1jaEjFJ/oA0S/bsuDWdl LsX3rlV9pp2BGTQXwpUa9SlK2tuVnDJEsI2hGDY3R/Urarc8PHpdH/UTWdo9qPTI U6TWhCD1s1sygMtAtvT9n1Yb2dogMDzq012EfQjc= Received: (qmail 66306 invoked by alias); 2 Aug 2018 22:55:58 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 66292 invoked by uid 89); 2 Aug 2018 22:55:57 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.9 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY, NO_DNS_FOR_FROM autolearn=ham version=3.3.2 spammy=mavx X-HELO: mga17.intel.com Received: from mga17.intel.com (HELO mga17.intel.com) (192.55.52.151) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 02 Aug 2018 22:55:56 +0000 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Aug 2018 15:55:54 -0700 Received: from gnu-cfl-1.sc.intel.com ([172.25.70.237]) by orsmga002.jf.intel.com with ESMTP; 02 Aug 2018 15:55:48 -0700 Received: by gnu-cfl-1.sc.intel.com (Postfix, from userid 1000) id BF4DE440C7B; Thu, 2 Aug 2018 15:55:48 -0700 (PDT) Date: Thu, 2 Aug 2018 15:55:48 -0700 From: "H.J. Lu" To: gcc-patches@gcc.gnu.org Cc: Uros Bizjak Subject: [PATCH] i386: Always set cfun->machine->max_used_stack_alignment Message-ID: <20180802225548.GA1730@intel.com> Reply-To: "H.J. Lu" MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) We should always set cfun->machine->max_used_stack_alignment if the maximum stack slot alignment may be greater than 64 bits. Tested on i686 and x86-64. OK for master and backport for GCC 8? Thanks. H.J. ---- gcc/ PR target/86386 * config/i386/i386.c (ix86_finalize_stack_frame_flags): Set cfun->machine->max_used_stack_alignment if needed. gcc/testsuite/ PR target/86386 * gcc.target/i386/pr86386.c: New file. --- gcc/config/i386/i386.c | 6 +++--- gcc/testsuite/gcc.target/i386/pr86386.c | 26 +++++++++++++++++++++++++ 2 files changed, 29 insertions(+), 3 deletions(-) create mode 100644 gcc/testsuite/gcc.target/i386/pr86386.c diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c index ee409cfe7e4..4a0a050b3a2 100644 --- a/gcc/config/i386/i386.c +++ b/gcc/config/i386/i386.c @@ -13281,12 +13281,12 @@ ix86_finalize_stack_frame_flags (void) recompute_frame_layout_p = true; } } - else if (crtl->max_used_stack_slot_alignment - > crtl->preferred_stack_boundary) + else if (crtl->max_used_stack_slot_alignment > 64) { /* We don't need to realign stack. But we still need to keep stack frame properly aligned to satisfy the largest alignment - of stack slots. */ + of stack slots if the maximum stack slot alignment may be + greater than 64 bits. */ if (ix86_find_max_used_stack_alignment (stack_alignment, true)) cfun->machine->max_used_stack_alignment = stack_alignment / BITS_PER_UNIT; diff --git a/gcc/testsuite/gcc.target/i386/pr86386.c b/gcc/testsuite/gcc.target/i386/pr86386.c new file mode 100644 index 00000000000..a67cf45444e --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr86386.c @@ -0,0 +1,26 @@ +/* PR target/86386 */ +/* { dg-do run { target { avx_runtime && int128 } } } */ +/* { dg-options "-Os -fno-tree-dce -mstringop-strategy=vector_loop -mavx" } */ + +unsigned c, d, e, f; + +unsigned __attribute__((noipa)) +foo (unsigned char g, unsigned short h, unsigned i, unsigned long long j, + unsigned char k, unsigned short l, unsigned m, unsigned __int128 n) +{ + __builtin_memset (&e, 0, 3); + n <<= m; + __builtin_memcpy (&m, 2 + (char *) &n, 1); + m >>= 0; + d ^= __builtin_mul_overflow (l, n, &m); + return m; +} + +int +main () +{ + unsigned __int128 x = foo (0, 0, 0, 0, 0, 4, 1, 3); + if (x != 24) + __builtin_abort (); + return 0; +}