From patchwork Fri Aug 3 00:34:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vishal Deep Ajmera X-Patchwork-Id: 952897 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=ericsson.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ericsson.com header.i=@ericsson.com header.b="OXt8xRzO"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ericsson.com header.i=@ericsson.com header.b="QtztpUSN"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41hH2y1rlfz9s89 for ; Fri, 3 Aug 2018 03:19:06 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 634E1DB5; Thu, 2 Aug 2018 17:19:03 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 2F1BB25A for ; Thu, 2 Aug 2018 17:19:02 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from sessmg23.ericsson.net (sessmg23.ericsson.net [193.180.251.45]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 6CCC2782 for ; Thu, 2 Aug 2018 17:19:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1533227612; h=From:Sender:Reply-To:Subject:Date:Message-Id:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=/Xik0geM9ck5yVnGhVwhfAr6Vr5L/wD+GxKBrW3kleU=; b=OXt8xRzOLyjhzcp2fQCCosWhddvScvIW2wCil6hhMLHn6J9c8yuqup/xR+7lXfBU BsLackg/bbXCrlAxV2j1zt6ov78OAleOZGZj6E78SWTp10lRjlFD8iMNg8qFXlTz 8O2jieH+6VgaiAmtmApYZ+06I5MJXTKhfkiiFkWqR/I=; X-AuditID: c1b4fb2d-5ecb19c0000055ff-38-5b63325cd360 Received: from ESESSMB501.ericsson.se (Unknown_Domain [153.88.183.119]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id 4B.29.22015.C52336B5; Thu, 2 Aug 2018 18:33:32 +0200 (CEST) Received: from ESESBMB505.ericsson.se (153.88.183.172) by ESESSMB501.ericsson.se (153.88.183.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Thu, 2 Aug 2018 18:33:32 +0200 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB505.ericsson.se (153.88.183.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Thu, 2 Aug 2018 18:33:32 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eWh6gz4VD0hJd0B+W3Y7BFbPQhFgXyrM1HBdwjzEIRU=; b=QtztpUSNOMES4Ku5v6w8RW50BiNX+dZSXvejfW3kMgHsw17T7EHYw+kIPnTYzJMCAwV9SudqebAEvbGcTh6G3wQezp4K8F/VebQmVJeBq9iVTDwz4uwwYMh+Z8wHWhzBCR1nOJnCFMZgc9PS0tb4te6t99whVSTs1fvH/2a43IY= Received: from localhost.localdomain (125.16.128.122) by AM5PR0701MB2692.eurprd07.prod.outlook.com (2603:10a6:203:75::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1017.8; Thu, 2 Aug 2018 16:33:30 +0000 From: Vishal Deep Ajmera To: Date: Fri, 3 Aug 2018 06:04:23 +0530 Message-Id: <1533256463-21018-1-git-send-email-vishal.deep.ajmera@ericsson.com> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 X-Originating-IP: [125.16.128.122] X-ClientProxiedBy: PN1PR0101CA0068.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:d::30) To AM5PR0701MB2692.eurprd07.prod.outlook.com (2603:10a6:203:75::18) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: af5b47d7-7c6f-471d-a770-08d5f895aeb3 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600074)(711020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:AM5PR0701MB2692; X-Microsoft-Exchange-Diagnostics: 1; AM5PR0701MB2692; 3:4VebedomG0Q7An0rMKTBkuAVPn92y7TWdws6EpNkYl1I36x87QlhNgBVttQnOWvwY3TkTfQ/RNtDwUiMYpcl0pJmx/R2niw7UeikG0BqhMK6VeRK4zCkBXZEtJNFFNd4qZTbjlc+0Q4MBHy7LcGnmaPlJYS8B8GOBQVjP2AYSofrZMyXG0SSHcLZhrTglcKLRcO79ydYoJWdtrojeGNCxuqYCMkFsXH0c1V4Dvn2aMZmP7UA1244V3OnGgX3VmBF; 25:UKenpCXZ3019rWlnjgKNn55kP4jvD9RtRyexDX+11lhzsUUAQU82JIX3rcbXPWv94cDJ2/+6QHx5LDIb7CpWLx6/b/BBxKzaC3Bd6hW2ValEZ4Mogd4MtGV7bUNg+pRmIeE7jT+jnzz7lEzkQZnr1BlWHQ7jbVkSFZh9xcVRjc9jca9bU5BZb36K5gB80IFbgzSxAGlH8jq7xMlXNi1KCSc+80FXb7PtILHw/vCd27bfuBAflwFmHmZL+dgzFJwpXJyEE3xIGlkH6OO0r4nGQZLryyDqlBsdrttyEaVBUyECIy03rNHMxNlx8oAtCY0NQbVXoTn93UILy43Ma/V+vA==; 31:Wki77ieVSpuH/5+DJ6MM65HO/5Cfk6QVR44hTuIq1dIQaxGuo06e9pKbYbYtWYdhYD9rvGOpYfIvM7Gm1mcAA6D1n9bfAEtEGPC1RV4CKaMhb6oTKR7uxNi8t7Tcybo9PEc7mRnoZgZ9/KVsA0sFMo1tia00tkfMG8SH9DIDzmnBqHNSMvbfa4uxfm78QsXkS+Gdg669qPre1C24330b+w8xZasiCA/1SaFpp3IEHIc= X-MS-TrafficTypeDiagnostic: AM5PR0701MB2692: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=vishal.deep.ajmera@ericsson.com; X-Microsoft-Exchange-Diagnostics: 1; AM5PR0701MB2692; 20:5rvieN+BaN5tkt7q5dC4oCMONk+6gBVPZzzBykXJKEfNAjz/2Qvsz68Vzt73HMqB5IJQpZA/02GbTwX7+krv5zk+nGaGpmaNDIU+ZZqRepcawjGQJBch55wBnIRDz6csWbG4XSbAEQ/OTlh3pCTAJhxAMrvRj48dj/uRJUrWmvWrzkRqABKF12OuFWCo/tAGepU1EWfCKnPZsajXRo3NKPmvGoO2s+yEDJSSnfcjpo/5YodU1FN6h0pv+xvK+sJv0OV4SLaBsXl42we2E0AC5jlQWVo8RN9ylSafNGMNxPBnQb4vGAlW9BfuYX3a0fUVtGFma+/ZBAXgD63QPzx1eYhqoTz60IXhoVgYgrhKwR4j+PMqFs5t3uYJ7PrqvmtpeMYEOmusxIRJicOgtJ54V+rekISRLRpanebqL7cGBFd2yfXDnG+EjY4srZtcG8vVbGTqrylaYJLm9Mh75K8GBIKtl5bOtZ3rvds8+oJn7ovD82r6KA4ImKNaqqUtGJoA; 4:uOytIsfzhQiTrj4xZC4HGmscO5RpCs6YzsUpCWzd8G9KcGz/QPIObM01fORGzJnThDKhg8TeJN0N0Si+/yKygS/rGiw+Mk/iAIwLn4JOMvkTjwtEk0MXd7DVkbvLfssthIEUFbJAMaJhszckl2/NRg8UTEU8cRb8PXMconJh91qBYXneNQJ/RFVfxgnwd5DWCs3uya5SND2fvwoJOrhViqQH7ymOGgiYUP7YWGh/t9Qw13uwRRc4KO70G+GIx7/vKZ7HLjqySnXBhQip7ferDc1p22ekLKaU22lYON6dnQPalcQ88qFC8Md57DWG2ByK0ijpknGhaUJpZi3lGWucU9usuJY9WY6FEukHxyh9fR0= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(37575265505322)(248295561703944); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(823301018)(3231311)(944501410)(52105095)(3002001)(93006095)(93001095)(10201501046)(149027)(150027)(6041310)(20161123560045)(20161123558120)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:AM5PR0701MB2692; BCL:0; PCL:0; RULEID:; SRVR:AM5PR0701MB2692; X-Forefront-PRVS: 07521929C1 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6069001)(396003)(376002)(346002)(136003)(39860400002)(366004)(189003)(199004)(16586007)(6666003)(478600001)(50466002)(476003)(86362001)(97736004)(2351001)(105586002)(68736007)(36756003)(7736002)(6916009)(316002)(48376002)(305945005)(47776003)(2616005)(956004)(5660300001)(50226002)(8676002)(81156014)(386003)(3846002)(486006)(6506007)(14444005)(8936002)(26005)(81166006)(1857600001)(4326008)(6116002)(16526019)(186003)(2361001)(66066001)(107886003)(106356001)(52116002)(53936002)(51416003)(6486002)(6512007)(25786009)(55236004)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0701MB2692; H:localhost.localdomain; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM5PR0701MB2692; 23:Iz9/ic6S4aZzcAoG5UTjAx3K9LdU9Z5f5Xmqrlq?= Dt7DP80f6MY1JLLFbWDbiZwfX/TxkitiEQsMVFqu+grQgHnxXkSNTjasQHop+1/94LKJcFa3s8TZrONd7+AmWA7JMqWh7xR0u0GiFdhNrXplR/f45ZbQqtLvoX+WvxBajzH73RmL7TdRCYppTW1H8ksFhjMWc5H6JE/DWS5nfZk3CX+4EC1ql/st84vFidb+kFXgJib7CsFHtkYhECLgfT3A6R+z9mlAFU65vnJ5ovyrAEuP6dbV4eFIcAbW/ZIZ6kDjUVrf7nd/VupIgNX+aTdEkp39r3YmuUlpOBW64b+h+3Eekw4cCi1VQJ9puqq0uh3QkU8TIuMYw6A0nsC/5vLQlHdI7Kqbjc1/zWE5vA0d0NVP8aIRP8cQ3PN5FbcJoIj0b1JXNmelzZ3NNvlHsKQsmfruKq7V+gYHnu2bC/M8ugqIdrBvjO9JJfag7F71Aqk0zjprr8gistkyB6M4buolPzxZujB1cnIhDyMgVQJlivpK+VQ8y7LRxJMxgZrDe3sFGZm66nnDFIeGT3++iI+D94hamVcJRM5TU+zi9HVOficK6ReiNnkAPDaFDmhfu2H7EZPgqB3XBdbz+LOLSqVUomHIYYoozVeOb8203KSj7P/Ck0G/aszhUvufxpc/c8vXipO73fT4g0o52z5UQS5qzztoQINvBOq82BbaemV2b1WII3ALq22qCBQezaeVF+0hIOukHCJUMXO69G80t7Nds5UfPduiuL5wXyPkB5bKh77X0KJjl+hbfhGenLaiFmIouY5qxWxU3btpqNu5sD6IQnNJWgO/VgHMnbkZgTQI10qdkbPLUrF6bqS49KiBOBVvLHO03OPhjaW7JJAdoayxqR8AJr1Qovg2Xx2ovZmcsUGH86KMQLEPEZcX2JdWyDeXiOB0ZXS2Xxs0tb8tOsuLUueVZsY/Cfz7lda3x5H27pQpFYl34Yosrwku2jGfZwZc2ALnPtjza10vO26YCfrUDSjrtyBZM96YuXqGTbbHAeZqBjgs003eo+p7AfrKakCOokvZ0gzwc/pdwXFJKFA7Iv46RN8QX4YLTpra2iwBDAJ3ujGt0eoZtSnbzBwGxDGMDfrw//tIzUYPKBE8UE6I3TiIKyFYXDw1AL0FV58kxBc8x1DWdZXbvs8UqGJDyKIoSCz9ellGU3Ot0elwGo2zsbXl2eGArnnfzsFURYmTT+RSW1E3pvQc3dLwBbOLn0N8= X-Microsoft-Antispam-Message-Info: iA/vPQgui+r6eerK+qbu46qt2AWaGX72MYGCmat8RvPCBmyvfWJ06bDG/F08fPFPZivUPVY96gt0zxthg8NO4VF8kRn+LzIhXSaA7SLzUSGrdzhB/t6zjT7ROguzd0D1jjberi4WVHkhgCc9jz/DEVRQ2RLEJgZjmN7n4mjAHQNb0qu+x6qQSV9HEQwjMo1p7yPjhU66k6GfxBl7+nZvkFeYMT218QPc1k5iBPeeI9rEW+x/70S0obTfeCqGu9uR6wzxvnuslcaES0QTj/HtvCyVQfMJlHnESLWWXbhYnHr5JY7R8xUS2q95vBfchHUocXTLeBzfad1GphpAl0QrvKKc4A2sGnfYMH1oVsKuF7w= X-Microsoft-Exchange-Diagnostics: 1; AM5PR0701MB2692; 6:HMRfTreLTAszmStCdFhKYm962IsWNHgNIC2N9DuWhYxfsysmsacwgxRtdcx5N0es7pxEWZs25rTfvWUwFoA9NnKwvFGC1OAWpK8uu9ADHY8v4QPlQcdwDqdemK9aX5EuP//znjtNFhiTf4ONMUUmVL2O0I1vn9HlSHCL61+DlwaIVvbt7bgFutFro9tK36twiFCGbu39cISYoC+Ib4EHwVLTqHSm3dBoUp+N1QA8mYp6nif+0AsKTAHqoBrSbsma71Fyc/xTf0Av12K5JLr2v8UU0oI2tmwMoEd8iDdYWleQ2HjMz8f4nTYghvbjht1H+y0tJ818rkG0/CoVaiqIc3ewSCp2u+RvuBdLo2rvbxT4ot0/jwekuYuEVlYHadJAt/aM5jPqkEhfQhwzRnpB2XRy7QgsZ8wGOKPoln795pZdd20y2Dx641XbPku2sXnFFHbzRr2EIyRmajJ/EpTW/w==; 5:MtYEcZR80ICNRq7tHKlMD9/iwNP9KNvN7q5XeavKPaDzIQ7Wwhz8gp10ro836zixzopToNPatMYDO6IOcjZRdDOmWwjTjFlS+5pXRTvX47dAc+qjHQGHa7j4CL9a4A6TbDP+NmjAtmXdlq2+crHr+4MPyQ0pAO5c4P6RoUSmKoU=; 7:nJZrMXKZlckB1v3UeB7RMXoI7VVBPYRGR3umCqLGFF9aumfD5Xv/EucE5n8AmQqr39/bxff6TMSzJ2iJIuMhrNQv6l7ESmyGLBIeSu1t7/UN2iBTSgfKH1zDhzt2QhwiL/xR5wJhhxILgmbZx/fEWpi++bx5YV2HKMwX116JEdwGCjqTzl2d3Mm2eE2NV+08/nYkgJp253/QQ4c7C+lK6A8V8tqCkBDH0v6/t/J3dLkCiNpXZDi6TTUj6tAqO6Cz SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2018 16:33:30.1693 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: af5b47d7-7c6f-471d-a770-08d5f895aeb3 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0701MB2692 X-OriginatorOrg: ericsson.com X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrIIsWRmVeSWpSXmKPExsUyM2J7uW6MUXK0waf1GhZHT+9hdmD0eHbz P2MAYxSXTUpqTmZZapG+XQJXxs77L9kK2ngrDk3ayNLAeJOzi5GTQ0LARGLBh7mMILaQwFFG iVtdal2MXED2V0aJN8+bWCASi5kkXs0RALFZBCYwS6z8IwIR72aSaJovAWKzCVhJ/JrSD1Yv IiAp8W/xFjYQm1nAQuLm/Z1gC4QFfCXuPF7MAjFHVeLCuXXsIDavgL/E1HtzWSEOkpM4eWwy K0RcUOLkzCcsEHMkJA6+eMEMUaMksWvzfWaQQyUEZjFKbPq0DOoDHYlTz69DDZKVOHp2DguE 7Svx8MUGRoiGS4wSz+89ZYNwmtglFj+YDDVWR2LjkmtMXYwcHIwCSRIPXlpA1Cxjl1jycBYb SFxCIF/izRp2iHJviXM7bsNdfar3HBOEfZZZYvcUNwhbRuLjtM3sEHMOs0r82/KRCeLSVIkt N1rYJjBqz0Ly6Swkny5gZFrFKFqcWlycm25krJdalJlcXJyfp5eXWrKJERjxB7f81t3BuPq1 4yFGAQ5GJR5eBvnkaCHWxLLiytxDjBIczEoivM0eSdFCvCmJlVWpRfnxRaU5qcWHGKU5WJTE efVW7YkSEkhPLEnNTk0tSC2CyTJxcEo1MHIEvUh/e6LtmNfRQ9F195WD5qnVOv5KjNt6bsUx 5inqxkuWCH7cl5kS1bhZz2Bu+l/Xg55VCypf3GItdX87TeA54/IZKQ+09ve5nLxo7Lt/qhi3 1px514P451Zrv2Lpnn5EUj6a+bL6golJW7OK/GM/x/2YJXKW7Z6iv/eBlrxfZYy/3X+p7FVi Kc5INNRiLipOBADUJ7zi9AIAAA== X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, DATE_IN_FUTURE_06_12, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH] ofproto-dpif-upcall: Fix for flow limit issue in revalidator X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org When the revalidator thread takes a long time to dump data path flows (e.g. due to busy CPU), it reduces the maximum limit for new flows that can be added. This results in more upcalls for packets which do not find data path flows and temporarily reduces overall throughput. When the situation improves and the revalidator gets enough CPU cycles, it should increase the flow limit allowing more flows to get inserted. Currently the flow limit does not increase if the existing number of flows is less than 2000 and does not allow any new flows due to incorrect condition check. This results in a permanent drop in performance in OVS with no automatic recovery. This patch fixes the conditional check for increasing flow limit. Signed-off-by: Vishal Deep Ajmera --- ofproto/ofproto-dpif-upcall.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c index 85f5792..6222207 100644 --- a/ofproto/ofproto-dpif-upcall.c +++ b/ofproto/ofproto-dpif-upcall.c @@ -931,8 +931,8 @@ udpif_revalidator(void *arg) flow_limit /= duration / 1000; } else if (duration > 1300) { flow_limit = flow_limit * 3 / 4; - } else if (duration < 1000 && n_flows > 2000 - && flow_limit < n_flows * 1000 / duration) { + } else if (duration < 1000 && + flow_limit < n_flows * 1000 / duration) { flow_limit += 1000; } flow_limit = MIN(ofproto_flow_limit, MAX(flow_limit, 1000));