From patchwork Wed Aug 1 15:54:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Maximets X-Patchwork-Id: 952240 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="pzJx6Gzf"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41gdCB6d7Yz9s3q for ; Thu, 2 Aug 2018 01:53:58 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 8A941CE1; Wed, 1 Aug 2018 15:53:55 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id E5F07CBB for ; Wed, 1 Aug 2018 15:53:53 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 3B0987A3 for ; Wed, 1 Aug 2018 15:53:53 +0000 (UTC) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20180801155351euoutp02aa1c2b4533ffd38a414290d7a4c13d68~GzaTqG1Nw0283302833euoutp02o; Wed, 1 Aug 2018 15:53:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20180801155351euoutp02aa1c2b4533ffd38a414290d7a4c13d68~GzaTqG1Nw0283302833euoutp02o DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1533138831; bh=UgX9InzS4B9aef20beg6u4ZmPgB6iiuY8segj1mr5+o=; h=From:To:Cc:Subject:Date:References:From; b=pzJx6GzfqZs+/Jii25AXXJnGKilDT3utKH6PxeZTWVqXXePQ3vAJMsjAe6SnPrx1b CzGnc5x81+OOzBcrWvqfY5q89+1BcqvCUCkZKhYrG9YIOcVz5ai3D16KuDJu90E9r/ 0t62XCldbJG8N9lGHvm3R97wsNdFFrHR7C7u48Is= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20180801155350eucas1p1f10b3a9c27d5176213324ebc592059df~GzaStTZbl1128011280eucas1p1Z; Wed, 1 Aug 2018 15:53:50 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 91.60.04627.E87D16B5; Wed, 1 Aug 2018 16:53:50 +0100 (BST) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20180801155349eucas1p2df53034f04f48f30e2d51dce57c44f82~GzaRu3pW23253932539eucas1p2v; Wed, 1 Aug 2018 15:53:49 +0000 (GMT) X-AuditID: cbfec7f2-0d3ff70000021213-99-5b61d78e5e44 Received: from eusync1.samsung.com ( [203.254.199.211]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 7A.3B.04178.D87D16B5; Wed, 1 Aug 2018 16:53:49 +0100 (BST) Received: from imaximets.rnd.samsung.ru ([106.109.129.180]) by eusync1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0PCS00IJFHHKPQ80@eusync1.samsung.com>; Wed, 01 Aug 2018 16:53:49 +0100 (BST) From: Ilya Maximets To: ovs-dev@openvswitch.org Date: Wed, 01 Aug 2018 18:54:22 +0300 Message-id: <1533138862-6223-1-git-send-email-i.maximets@samsung.com> X-Mailer: git-send-email 2.7.4 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmplkeLIzCtJLcpLzFFi42LZduzned2+64nRBrv6mC1eTW5gtLjS/pPd YvKUx6wWcz89Z3Rg8Xh28z+jx/NrPSwefVtWMQYwR3HZpKTmZJalFunbJXBldO1Zy1Swl6di 37ftbA2MLzi7GDk5JARMJG6fu8HcxcjFISSwglHi7v89LBDOZ0aJW/92scFUdd18xQ6RWMYo 8WDmJFYIp5lJomfzGUaQKjYBHYlTq4+A2SIC0hKve9+wgtjMAmkSrx7MAYsLC3hIvPmwix3E ZhFQlZjQ/RishlfAVeLb8Y0sENvkJG6e6wS7SULgKKvE5JPnmCASLhIHnj5ihLCFJV4d38IO YctIdHYchKqpl7jf8pIRormDUWL6oX9QCXuJLa/PsUNcxCcxadt0oA0cQHFeiY42IYgSD4mD UzeBHSEkECvR/qaHaQKjxAJGhlWM4qmlxbnpqcWGeanlesWJucWleel6yfm5mxiBkXP63/FP Oxi/Xko6xCjAwajEw3uiOiFaiDWxrLgy9xCjBAezkgjv3trEaCHelMTKqtSi/Pii0pzU4kOM 0hwsSuK8d/rjooUE0hNLUrNTUwtSi2CyTBycUg2Mm20YK018p545d+bAJBfdyzP8X/Wvvild o165W2dupeql+7m+xxadeMppdSX7UGTIxncz1y+xPh50LKRC1SD4qfj5bSe+TYqpO6vB909i wv1Vd2MvzOEpXzJv1isN3Zm5EcYG73S8fzvIXe33dTw5YZ+Td8TxKX+nSzlMvsW0WSHQTEta bfGmO0osxRmJhlrMRcWJAK02wL6YAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrOJMWRmVeSWpSXmKPExsVy+t/xy7q91xOjDW4+4LJ4NbmB0eJK+092 i8lTHrNazP30nNGBxePZzf+MHs+v9bB49G1ZxRjAHMVlk5Kak1mWWqRvl8CV0bVnLVPBXp6K fd+2szUwvuDsYuTkkBAwkei6+Yq9i5GLQ0hgCaPE2SX3oZxWJokDvZ9YQKrYBHQkTq0+wghi iwhIS7zufcMKYjMLpEmcvn6HDcQWFvCQePNhFzuIzSKgKjGh+zFYDa+Aq8S34xtZILbJSdw8 18k8gZFrASPDKkaR1NLi3PTcYkO94sTc4tK8dL3k/NxNjEDvbjv2c/MOxksbgw8xCnAwKvHw FlQmRAuxJpYVV+YeYpTgYFYS4d1bmxgtxJuSWFmVWpQfX1Sak1p8iFGag0VJnPe8QWWUkEB6 YklqdmpqQWoRTJaJg1OqgTE5/OL+mITOlRtTLlt9um9xs1PDoPWzQ5myiqbHZNkje79NP+p3 2San3yHmUVFmr6B5891sd9lPi3723kjoNpwdrx/O76b3e9Fz612LHkdeEVPmF553XkdBWdm3 pHftxNcKS78esLSfX2yVe2bbt3X88ucV/NpuRiZ+EPtY2NHT9j3tylXWdUosxRmJhlrMRcWJ AC7jfx3qAQAA X-CMS-MailID: 20180801155349eucas1p2df53034f04f48f30e2d51dce57c44f82 X-Msg-Generator: CA CMS-TYPE: 201P X-CMS-RootMailID: 20180801155349eucas1p2df53034f04f48f30e2d51dce57c44f82 References: X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: Ilya Maximets Subject: [ovs-dev] [PATCH] ovs-vtep: Pass log level arguments to underlying utils. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org Control utils should be called with the same verbose level at least to manage output to system logs. For example, to disable unwanted syslog messages in unit tests or to enable higher debug levels if needed. New arguments added before '-vconsole:off' because it's still incovinient to have console output. Signed-off-by: Ilya Maximets --- This could be a part of syslog clean up patch-set [1], but it looks more like a separate independent feature. [1] https://mail.openvswitch.org/pipermail/ovs-dev/2018-August/350425.html vtep/ovs-vtep.in | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/vtep/ovs-vtep.in b/vtep/ovs-vtep.in index 98748e4..3383870 100755 --- a/vtep/ovs-vtep.in +++ b/vtep/ovs-vtep.in @@ -39,6 +39,7 @@ root_prefix = "" __pychecker__ = 'no-reuseattr' # Remove in pychecker >= 0.8.19. vlog = ovs.vlog.Vlog("ovs-vtep") +verbose_args = [] exiting = False ps_name = "" @@ -53,7 +54,7 @@ bfd_ref = {} def call_prog(prog, args_list): - cmd = [prog, "-vconsole:off"] + args_list + cmd = [prog] + verbose_args + ["-vconsole:off"] + args_list creationFlags = 0 if sys.platform == 'win32': creationFlags = 0x08000000 # CREATE_NO_WINDOW @@ -728,6 +729,10 @@ def main(): global ps_name ps_name = args.ps_name + global verbose_args + if args.verbose: + verbose_args = ['-v' + arg for arg in args.verbose] + ovs.daemon.daemonize() ovs.unixctl.command_register("exit", "", 0, 0, unixctl_exit, None)