From patchwork Wed Aug 1 14:17:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Rivshin X-Patchwork-Id: 952215 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pwm-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=awxrd.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=awxrd.com header.i=@awxrd.com header.b="WQ4iZrMN"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="rrRZLujf"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41gb4D4Y1sz9s3q for ; Thu, 2 Aug 2018 00:17:48 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389501AbeHAQDp (ORCPT ); Wed, 1 Aug 2018 12:03:45 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:36203 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389482AbeHAQDp (ORCPT ); Wed, 1 Aug 2018 12:03:45 -0400 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id C766021924; Wed, 1 Aug 2018 10:17:46 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 01 Aug 2018 10:17:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=awxrd.com; h=cc :date:from:message-id:subject:to:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=zkwOWw1tEXbDJdDRjz8pgI5K/EBCxaEpsvrpTI9xu CQ=; b=WQ4iZrMNWyWCpxqGaXBmQfdqq4Qh0MrmPoTZK5jOqIfYf7+SXavrHjjZX DOcCGAgRXs3C/oweX7OhMkCofdFw4ryjAfA0IPJXUFGrYPW5dTuzpfSm6WRME4DI JPMjyC8LUq3xRauVCeCoX0mUP7Xv94Jb79IQMl2UNWAlSLpe077jeLWjMuaKvsbW dkeDEMongqHFdpgzUb487HUhzxahVT7bdj7K7zAdo4Oegp+ZMEJR7gDorFUNIZ9q 3jWhMkBlEeXBrBCAqrx087C0pUm4BSHnQIxQKVZ6JUbJa63tmPi2j4BHUurke3+f bNhZKFYyhzq0NtxzRfRKJ5dG4OdWg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:message-id:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=zkwOWw1tEXbDJdDRj z8pgI5K/EBCxaEpsvrpTI9xuCQ=; b=rrRZLujfX7wy25LoNPBdtXt1NSbwaQJ2p 76kVbczQweel60urpiRRgZPJOyLSXxTr5FZNIccPUrFdyf+zzCkGyYyRdIa1R1nG eAYWJR/LHmq08dBesh6yli1e+aGh830KszBdISKSNBeXxk05OJpMVvWHZza8/Drn Zizfyf+jG4GoDZCby4IoKpdIqomaIKBtNqnMd1o82nMRxlrCW+iT6sy/63l3p/Pb d1m3X1/KzvC3qApqXLU3jy0P6388oi+83tTFShM2D+8U1wO0OplRoQPjEGNJK7UA MNQ2sgCgX0fqaTGiT9/We0nCRTmukaHGFMGxmh6qFN9RWoqnXBJ9Q== X-ME-Proxy: X-ME-Sender: Received: from drivshin-linux.inscitek.com (unknown [24.213.148.66]) by mail.messagingengine.com (Postfix) with ESMTPA id 545BDE4519; Wed, 1 Aug 2018 10:17:44 -0400 (EDT) From: David Rivshin To: Thierry Reding , Keerthy , Ladislav Michl , Neil Armstrong Cc: linux-pwm@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tony Lindgren , Thomas Gleixner , Pavel Machek , Andreas Kemnade , "H. Nikolaus Schaller" Subject: [PATCH v4] pwm: pwm-omap-dmtimer: return -EPROBE_DEFER if no dmtimer platform data Date: Wed, 1 Aug 2018 10:17:29 -0400 Message-Id: <20180801141729.2840-1-drivshin@awxrd.com> X-Mailer: git-send-email 2.17.1 Sender: linux-pwm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org From: David Rivshin If a pwm-omap-dmtimer is probed before the dmtimer it uses, the platform data won't be set yet. Fixes: ac30751df953 ("ARM: OMAP: pdata-quirks: Remove unused timer pdata") Cc: # 4.17+ Signed-off-by: David Rivshin Acked-by: Pavel Machek Tested-by: Pavel Machek Acked-by: Ladislav Michl Tested-by: Andreas Kemnade --- Changes in v4: * Added Ladislav's Acked-by [2] * Added Andreas's Tested-by [3] Changes in v3: * Changed dev_info to dev_dbg Changes in v2: * Added Pavel's Acked-by/Tested-by [1] [1] https://lkml.org/lkml/2018/7/16/346 [2] https://www.spinics.net/lists/arm-kernel/msg668768.html [3] https://www.spinics.net/lists/arm-kernel/msg669302.html drivers/pwm/pwm-omap-dmtimer.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) base-commit: acb1872577b346bd15ab3a3f8dff780d6cca4b70 diff --git a/drivers/pwm/pwm-omap-dmtimer.c b/drivers/pwm/pwm-omap-dmtimer.c index 665da3c8fbceb..f45798679e3c0 100644 --- a/drivers/pwm/pwm-omap-dmtimer.c +++ b/drivers/pwm/pwm-omap-dmtimer.c @@ -264,8 +264,9 @@ static int pwm_omap_dmtimer_probe(struct platform_device *pdev) timer_pdata = dev_get_platdata(&timer_pdev->dev); if (!timer_pdata) { - dev_err(&pdev->dev, "dmtimer pdata structure NULL\n"); - ret = -EINVAL; + dev_dbg(&pdev->dev, + "dmtimer pdata structure NULL, deferring probe\n"); + ret = -EPROBE_DEFER; goto put; }