From patchwork Wed Jul 11 19:34:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Jean-Fran=C3=A7ois_T=C3=AAtu?= X-Patchwork-Id: 942658 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.133; helo=hemlock.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=savoirfairelinux.com Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41Qq605HMRz9s19 for ; Thu, 12 Jul 2018 05:35:03 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 92715880A5; Wed, 11 Jul 2018 19:34:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LC6rWmC2+3jz; Wed, 11 Jul 2018 19:34:53 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id E23AD87ED7; Wed, 11 Jul 2018 19:34:53 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 60FBE1BFC53 for ; Wed, 11 Jul 2018 19:34:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 5EBED26CEA for ; Wed, 11 Jul 2018 19:34:52 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5WJ6MC-tCi-j for ; Wed, 11 Jul 2018 19:34:51 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.savoirfairelinux.com (mail.savoirfairelinux.com [208.88.110.44]) by silver.osuosl.org (Postfix) with ESMTPS id 4B42626C7E for ; Wed, 11 Jul 2018 19:34:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.savoirfairelinux.com (Postfix) with ESMTP id AC0019C1A13; Wed, 11 Jul 2018 15:34:49 -0400 (EDT) Received: from mail.savoirfairelinux.com ([127.0.0.1]) by localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id O5OGXgTwJeOq; Wed, 11 Jul 2018 15:34:45 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.savoirfairelinux.com (Postfix) with ESMTP id 8F04E9C314C; Wed, 11 Jul 2018 15:34:45 -0400 (EDT) X-Virus-Scanned: amavisd-new at mail.savoirfairelinux.com Received: from mail.savoirfairelinux.com ([127.0.0.1]) by localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id PuHNClAV_DZD; Wed, 11 Jul 2018 15:34:45 -0400 (EDT) Received: from jftetu-pc.mtl.sfl (unknown [192.168.48.241]) by mail.savoirfairelinux.com (Postfix) with ESMTPSA id 64A419C1A13; Wed, 11 Jul 2018 15:34:45 -0400 (EDT) From: =?utf-8?q?Jean-Fran=C3=A7ois_T=C3=AAtu?= To: buildroot@buildroot.org Date: Wed, 11 Jul 2018 15:34:52 -0400 Message-Id: <20180711193452.19461-1-jean-francois.tetu@savoirfairelinux.com> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 Subject: [Buildroot] [PATCH] package/squid: fix automake breakage X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.24 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Jean-Fran=C3=A7ois_T=C3=AAtu?= Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Much like e27ccbabc1, the recent bump in automake causes a build error. If the host automake is not the same version as the one used to generate the squid package, the build fails while building the copy of libltdl included in the package. This happens regardless of the Buildroot automake version since the included library is not reconfigured properly. The previous fix set the ACLOCAL and AUTOMAKE variables to the Buildroot generated aclocal and automake thereby ensuring that the subpackage would build correctly. What is needed is to make sure that both the squid configure script and the libltdl configure script are reconfigured following a change to either configure.ac files. This commit adds an option passed to autoreconf which ensures both configure scripts are regenerated with Buildroot's autotools. Fixes: http://autobuild.buildroot.net/results/83d/83d8fb0fc25205d6fb8c96a9877e5901275c6766 http://autobuild.buildroot.net/results/948/948737590ba648f7dbade1661c0e2e8d9db6522b CC: Gustavo Zacarias Signed-off-by: Jean-François Têtu --- package/squid/squid.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/package/squid/squid.mk b/package/squid/squid.mk index 2d21ad8858..06442157d6 100644 --- a/package/squid/squid.mk +++ b/package/squid/squid.mk @@ -12,6 +12,7 @@ SQUID_LICENSE = GPL-2.0+ SQUID_LICENSE_FILES = COPYING # For 0001-assume-get-certificate-ok.patch SQUID_AUTORECONF = YES +SQUID_AUTORECONF_OPTS = -fi configure.ac libltdl/configure.ac SQUID_DEPENDENCIES = libcap host-libcap host-pkgconf \ $(if $(BR2_PACKAGE_LIBNETFILTER_CONNTRACK),libnetfilter_conntrack) SQUID_CONF_ENV = \