From patchwork Wed Jul 11 07:17:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Mendoza-Jonas X-Patchwork-Id: 942345 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41QVtt2w7cz9s01 for ; Wed, 11 Jul 2018 17:24:22 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=mendozajonas.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=mendozajonas.com header.i=@mendozajonas.com header.b="exUQCyMX"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="QrjOupTO"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 41QVtt1Jl6zF35Q for ; Wed, 11 Jul 2018 17:24:22 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=mendozajonas.com Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=mendozajonas.com header.i=@mendozajonas.com header.b="exUQCyMX"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="QrjOupTO"; dkim-atps=neutral X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=mendozajonas.com (client-ip=64.147.123.25; helo=wout2-smtp.messagingengine.com; envelope-from=sam@mendozajonas.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=mendozajonas.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=mendozajonas.com header.i=@mendozajonas.com header.b="exUQCyMX"; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="QrjOupTO"; dkim-atps=neutral X-Greylist: delayed 378 seconds by postgrey-1.36 at bilbo; Wed, 11 Jul 2018 17:24:11 AEST Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 41QVtg5rkCzF35J for ; Wed, 11 Jul 2018 17:24:11 +1000 (AEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id EE46B2C9; Wed, 11 Jul 2018 03:17:47 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 11 Jul 2018 03:17:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= mendozajonas.com; h=cc:date:from:message-id:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=6fgCbVGlOlS0AZF5M Y4kSw6hawYQviBR5czaIh4y1Ec=; b=exUQCyMXA89gOfbCoGGn0iHuI7Gnlg/Ou XUe2IVSkLcyE5PbXsRXBiPnlN6nVtqQPfWRp3LLWNHTiNPbGzI5wC3go+JNqkn/k G53WDVBxAzTYn7J3RFNazUWQ2MJ8+KH8W7F1mhUflU4KtwIKrAS+bfKA3a6Qhfq7 ZDjV5s0lGXOOBO0aBhK8D0EGMRdO8BM/xKqvq9gwxOQFUCwY0j3hR/UBNC+pGDPW 1yB+KeMdlzkuLKSZEkOqfRRyzeyV6QgX5yvgqXd5TvCXYYaKJtHDF4OI1E4eu1dx 8pgt3NhL24gaEeS2mnxsL9KXbzf62HytCKczTOfxMj1xVtMim6S6Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:message-id:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=6fgCbVGlOlS0AZF5M Y4kSw6hawYQviBR5czaIh4y1Ec=; b=QrjOupTO6DuKIJYgDfzlczlbiXXSPVz0f cmCl4swCAVnOwxL0UIa57fH4z3q3SaCeskwwYJ+oRz9ySyYSE971d6AKMTsWPkAb RvJhPKAJ0A3qR8ThJ5mWpPbFQ6PsLpnudtgIdYrSBRxoc/6Gy7TECF7nsxtyPRYS 64CS53wSifljuRxp3tUc+ZPpgP+ofFHBMXo8t6OCxal9zelmfqGmfz/5YvMMjThJ 7JyRrrWxouMat4lcv2AyVQdkXZmmPj6mAtYpVxvxfzQzz8e/dGLCpPhrW4bce+Rs 6zrdT5yO9s2IoyKx28DAF57e1hJYHd9MDUm0QIQIhGfXFWG7pFTEQ== X-ME-Proxy: X-ME-Sender: Received: from v4.ozlabs.ibm.com (unknown [122.99.82.10]) by mail.messagingengine.com (Postfix) with ESMTPA id ACE2910269; Wed, 11 Jul 2018 03:17:45 -0400 (EDT) From: Samuel Mendoza-Jonas To: skiboot@lists.ozlabs.org Date: Wed, 11 Jul 2018 17:17:38 +1000 Message-Id: <20180711071738.18350-1-sam@mendozajonas.com> X-Mailer: git-send-email 2.18.0 Subject: [Skiboot] [PATCH] core/flash: Emit a warning if Skiboot version doesn't match X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Samuel Mendoza-Jonas MIME-Version: 1.0 Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" Signed-off-by: Samuel Mendoza-Jonas --- The message is very bikesheddable but this could be a useful sanity check on non-dev machines. core/flash.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/core/flash.c b/core/flash.c index e258fe17..8f00d85e 100644 --- a/core/flash.c +++ b/core/flash.c @@ -212,6 +212,10 @@ static void __flash_dt_add_fw_version(struct dt_node *fw_version, char* data) /* Increment past "key-" */ prop = data + version_len + 1; dt_add_property_string(fw_version, version_str[i], prop); + + if (strncmp(version_str[i], "skiboot", strlen("skiboot")) == 0) + if (strncmp(prop, version, strlen(version)) != 0) + prlog(PR_WARNING, "WARNING! Skiboot version does not match VERSION partition!\n"); } }