From patchwork Tue Jul 10 06:23:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 941817 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41PsgK2c6Mz9s1R for ; Tue, 10 Jul 2018 16:27:09 +1000 (AEST) Received: from localhost ([::1]:46011 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fcm79-0000Et-1w for incoming@patchwork.ozlabs.org; Tue, 10 Jul 2018 02:27:07 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48355) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fcm4W-0006ZX-WC for qemu-devel@nongnu.org; Tue, 10 Jul 2018 02:24:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fcm4S-0005ll-Iv for qemu-devel@nongnu.org; Tue, 10 Jul 2018 02:24:25 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:53170) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fcm4S-0005k5-6y for qemu-devel@nongnu.org; Tue, 10 Jul 2018 02:24:20 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue002 [212.227.15.167]) with ESMTPSA (Nemesis) id 0LeUyk-1gQzXL0rnC-00qVCN; Tue, 10 Jul 2018 08:24:09 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Tue, 10 Jul 2018 08:23:51 +0200 Message-Id: <20180710062352.9843-3-laurent@vivier.eu> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180710062352.9843-1-laurent@vivier.eu> References: <20180710062352.9843-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:OBfHqqKdu6ZcrFVuCuWGgI4C01l/EbIDfjxMgpIQyHfZ0vAThE0 UWVG+TV2drTvmfyoNh8Ug5LRLywx7o8JqqNwpQvAf1kOWvDa98TkrFZvVSVslvMZwZ5BX1/ xn91yt4kTnPx3ZwCrRLQBqPrxgFOb738D8Mxc49Z8virs6EzR1aOG1oXCmF9pjNS4UsO/5w AlGPkN82Y/Huue08oAS3g== X-UI-Out-Filterresults: notjunk:1; V01:K0:90E+geHcE2U=:cHmEVLucCRTxIG5Newe9GX 6edCDQJnqGtM5ENiOM5CqTfwXgx5QKiFfeiGclXiqcwfXK5Fb9czuA9GRztsrjesOy47DhZdX 66XTRcT6DU381sqGtuJAw1wv0bo6icbp/KICueuh21ziGYpNWhh1noxJ9jz4DMgmtGkBxDtnE /HBi19HVUw3+IJYvJSFqSG+sKSCQ4GXFyL0hznpakwmDHZeWcEgTVoJkoHMLP1Ohxz4HPb90R NdGfkvY98M1a9j/fzqlCMa6sT/1O2C0YwGfhPXs9bvEtFmzJJZ52cg6Oo4qKZFoJqJeK1fPuN gAqbmhRCE/KPWgnq2B0S4oK+Z5RnJVaUFT1FBeJV5BweCLJt6ifcUhbZ1BOpUJtZmHwTUXTSp EeGyZVOU2RdoxiFSh86VjXgVhqYD6BmFlCK5gusWVCBiy35iAyidgcW104BCuIGZyxzXdLsBl uZuJpjhyHolhh6zVU6DNNnIFOeja/wpiep1eoPfesdU0r1sRgnnWiX/zMC9QPr61L9vhjQaFC rtw2Rf0DMF/8MyESEZ9cYunbPFQf849xrRgXiDw/+/mCDgI6H1eozc9QVXXqG6mlpAb+HeZah pPLWxQs8DlciNu3RqRfNGH++1g2X08wA7ZiwcGxGOuE+Gm2f9w7qLkKGjgwaEyxqcOwiBBVDB 8Ap1oespFhI83tb50Wzw/eUUNYtBB6x/lwYxZiG+/fW/IfDJ/ZTm8k+fJhjMQ/4SEuoZnm5/7 UItgC9U3ZJ86DFuZ X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.126.131 Subject: [Qemu-devel] [PULL 2/3] linux-user: Do not report "syscall not implemented" by default X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Riku Voipio , Laurent Vivier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé This can still be reported using the "-d unimp" command line option. Code change produced with: git ls-files linux-user | \ xargs sed -i -E 's/fprintf\(stderr,\s?(".*not implemented\\n")\);/qemu_log_mask(LOG_UNIMP, \1);/g' Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20180706155127.7483-3-f4bug@amsat.org> Signed-off-by: Laurent Vivier --- linux-user/cris/signal.c | 4 ++-- linux-user/microblaze/signal.c | 4 ++-- linux-user/nios2/signal.c | 2 +- linux-user/sparc/signal.c | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/linux-user/cris/signal.c b/linux-user/cris/signal.c index 0b405247cf..1e02194377 100644 --- a/linux-user/cris/signal.c +++ b/linux-user/cris/signal.c @@ -146,7 +146,7 @@ void setup_rt_frame(int sig, struct target_sigaction *ka, target_siginfo_t *info, target_sigset_t *set, CPUCRISState *env) { - fprintf(stderr, "CRIS setup_rt_frame: not implemented\n"); + qemu_log_mask(LOG_UNIMP, "setup_rt_frame: not implemented\n"); } long do_sigreturn(CPUCRISState *env) @@ -183,6 +183,6 @@ badframe: long do_rt_sigreturn(CPUCRISState *env) { trace_user_do_rt_sigreturn(env, 0); - fprintf(stderr, "CRIS do_rt_sigreturn: not implemented\n"); + qemu_log_mask(LOG_UNIMP, "do_rt_sigreturn: not implemented\n"); return -TARGET_ENOSYS; } diff --git a/linux-user/microblaze/signal.c b/linux-user/microblaze/signal.c index 712ee522b2..80950c2181 100644 --- a/linux-user/microblaze/signal.c +++ b/linux-user/microblaze/signal.c @@ -200,7 +200,7 @@ void setup_rt_frame(int sig, struct target_sigaction *ka, target_siginfo_t *info, target_sigset_t *set, CPUMBState *env) { - fprintf(stderr, "Microblaze setup_rt_frame: not implemented\n"); + qemu_log_mask(LOG_UNIMP, "setup_rt_frame: not implemented\n"); } long do_sigreturn(CPUMBState *env) @@ -240,6 +240,6 @@ badframe: long do_rt_sigreturn(CPUMBState *env) { trace_user_do_rt_sigreturn(env, 0); - fprintf(stderr, "Microblaze do_rt_sigreturn: not implemented\n"); + qemu_log_mask(LOG_UNIMP, "do_rt_sigreturn: not implemented\n"); return -TARGET_ENOSYS; } diff --git a/linux-user/nios2/signal.c b/linux-user/nios2/signal.c index 4985dc2212..7d535065ed 100644 --- a/linux-user/nios2/signal.c +++ b/linux-user/nios2/signal.c @@ -203,7 +203,7 @@ give_sigsegv: long do_sigreturn(CPUNios2State *env) { trace_user_do_sigreturn(env, 0); - fprintf(stderr, "do_sigreturn: not implemented\n"); + qemu_log_mask(LOG_UNIMP, "do_sigreturn: not implemented\n"); return -TARGET_ENOSYS; } diff --git a/linux-user/sparc/signal.c b/linux-user/sparc/signal.c index 55e9d6f9b2..b4c60aa446 100644 --- a/linux-user/sparc/signal.c +++ b/linux-user/sparc/signal.c @@ -278,7 +278,7 @@ void setup_rt_frame(int sig, struct target_sigaction *ka, target_siginfo_t *info, target_sigset_t *set, CPUSPARCState *env) { - fprintf(stderr, "setup_rt_frame: not implemented\n"); + qemu_log_mask(LOG_UNIMP, "setup_rt_frame: not implemented\n"); } long do_sigreturn(CPUSPARCState *env) @@ -357,7 +357,7 @@ segv_and_exit: long do_rt_sigreturn(CPUSPARCState *env) { trace_user_do_rt_sigreturn(env, 0); - fprintf(stderr, "do_rt_sigreturn: not implemented\n"); + qemu_log_mask(LOG_UNIMP, "do_rt_sigreturn: not implemented\n"); return -TARGET_ENOSYS; } From patchwork Tue Jul 10 06:23:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 941815 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41Pscz5FTnz9s3R for ; Tue, 10 Jul 2018 16:25:07 +1000 (AEST) Received: from localhost ([::1]:45996 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fcm5B-0006bl-2d for incoming@patchwork.ozlabs.org; Tue, 10 Jul 2018 02:25:05 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48340) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fcm4V-0006ZR-QW for qemu-devel@nongnu.org; Tue, 10 Jul 2018 02:24:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fcm4R-0005jp-8b for qemu-devel@nongnu.org; Tue, 10 Jul 2018 02:24:23 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:51731) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fcm4Q-0005hy-TI for qemu-devel@nongnu.org; Tue, 10 Jul 2018 02:24:19 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue002 [212.227.15.167]) with ESMTPSA (Nemesis) id 0MRfyq-1fW9Jp30pc-00Seon; Tue, 10 Jul 2018 08:24:09 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Tue, 10 Jul 2018 08:23:52 +0200 Message-Id: <20180710062352.9843-4-laurent@vivier.eu> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180710062352.9843-1-laurent@vivier.eu> References: <20180710062352.9843-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:suHo//xEezCXPrbHc/FzJxKs5pW2IImUY5HSuH0ZP07w8bczww/ ljnALaSWwgeWeLeJofuRPOQUp4nx78kKpyqK48PUwz3nHqJOI9TE2j4jiWTTS8LkAFSk1+V pULPzcFlMBPL9S94NrrQ+GlJ+fIhwc9vAjIjuC01hiGyQobrKrAzEEl/WyaEcsZusUHnxlt hio7hAAzlc3f92qRWoPvQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:MiaV4Npj4Zs=:TBTjXWRxi/l4l9PQEhmTEn fZiET0fzcf0rTkDKYEyfocR1wTgyqaRAK8vdrKLOMXmBcqbKUhYmtyVfDFhVdXrkHrWrUtpup R2Mrv0rXbODrCSiqB8AhZm3ggavCJpl2naTW/c6vt5rvOYdEB/vFQKRuo/SL6rnucA9b9+OSE 5r5QVC5i91rqNrBtcv64InMV7U9YIZfboG3wI3rqsxUS5s6glI5Fs+CXbUnhOKYXOVDw9rrg7 u9AbXPI/Qm7g2fWABkvYZyfqWxkoSOW7kkH2lDd6vtOGmg2nlDCT5p6f4dowiAnBkNiI5Vg8W YtbnM1To9T1M4OirOB/5dmzl28j4X/i2O/hoNOrz0qdIOf8l4VXobd8nMhVg3X8OOoREY2/jb Tcjbkd9q/LLm/zW0PI9esEdCuVGqSW1ijOMOhBl9Yb3FUeb7OpSzdgkC80XpX8U/tek6f8WOf Wb8fFuJFfZm/WyViiNDflFDcTNjRbnIeC23Yu9nhxAHbZEFhxlbiDQCt37jZYUwDaKLSoTB8y 3gqgMA6wrbSz050w2jr9Lz+TdyeP+uQ8s6Wr3XCHzjYeoPU7ab67xNGbxDHSraJ1HdIYh2UV0 NY9iK756RwFkobRL+tn+P9W9T7HAumtiBtrRaSivkxLuJHcKRugZ86V3yB0112V/cw5WU0OIk OyZuyZgOhaiGw/Hue9iK+q/dS0/KH9YLAuPq1sriY4cNu2dGkIZ0lAHkZHqwkxE8M/VxoLbF1 yJ+ZP/DpaI1d71pR X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.126.130 Subject: [Qemu-devel] [PULL 3/3] linux-user: Report error message on stderr, rather than stdout X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Riku Voipio , Laurent Vivier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé Code change produced with: git ls-files linux-user | \ xargs sed -i -E 's/(\s+)printf\s*\(("Unhandled.*)\);/\1fprintf(stderr, \2);/g' Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Message-Id: <20180706155127.7483-4-f4bug@amsat.org> Signed-off-by: Laurent Vivier --- linux-user/alpha/cpu_loop.c | 2 +- linux-user/cris/cpu_loop.c | 2 +- linux-user/microblaze/cpu_loop.c | 6 +++--- linux-user/sh4/cpu_loop.c | 2 +- linux-user/sparc/cpu_loop.c | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/linux-user/alpha/cpu_loop.c b/linux-user/alpha/cpu_loop.c index b87fcaea87..c1a98c8cbf 100644 --- a/linux-user/alpha/cpu_loop.c +++ b/linux-user/alpha/cpu_loop.c @@ -196,7 +196,7 @@ void cpu_loop(CPUAlphaState *env) arch_interrupt = false; break; default: - printf ("Unhandled trap: 0x%x\n", trapnr); + fprintf(stderr, "Unhandled trap: 0x%x\n", trapnr); cpu_dump_state(cs, stderr, fprintf, 0); exit(EXIT_FAILURE); } diff --git a/linux-user/cris/cpu_loop.c b/linux-user/cris/cpu_loop.c index 1c5eca9f83..37bdcfa8cc 100644 --- a/linux-user/cris/cpu_loop.c +++ b/linux-user/cris/cpu_loop.c @@ -81,7 +81,7 @@ void cpu_loop(CPUCRISState *env) cpu_exec_step_atomic(cs); break; default: - printf ("Unhandled trap: 0x%x\n", trapnr); + fprintf(stderr, "Unhandled trap: 0x%x\n", trapnr); cpu_dump_state(cs, stderr, fprintf, 0); exit(EXIT_FAILURE); } diff --git a/linux-user/microblaze/cpu_loop.c b/linux-user/microblaze/cpu_loop.c index 5af12d5b21..2af93eb39a 100644 --- a/linux-user/microblaze/cpu_loop.c +++ b/linux-user/microblaze/cpu_loop.c @@ -105,8 +105,8 @@ void cpu_loop(CPUMBState *env) queue_signal(env, info.si_signo, QEMU_SI_FAULT, &info); break; default: - printf("Unhandled hw-exception: 0x%" PRIx64 "\n", - env->sregs[SR_ESR] & ESR_EC_MASK); + fprintf(stderr, "Unhandled hw-exception: 0x%" PRIx64 "\n", + env->sregs[SR_ESR] & ESR_EC_MASK); cpu_dump_state(cs, stderr, fprintf, 0); exit(EXIT_FAILURE); break; @@ -130,7 +130,7 @@ void cpu_loop(CPUMBState *env) cpu_exec_step_atomic(cs); break; default: - printf ("Unhandled trap: 0x%x\n", trapnr); + fprintf(stderr, "Unhandled trap: 0x%x\n", trapnr); cpu_dump_state(cs, stderr, fprintf, 0); exit(EXIT_FAILURE); } diff --git a/linux-user/sh4/cpu_loop.c b/linux-user/sh4/cpu_loop.c index 418833ea25..fdd348170b 100644 --- a/linux-user/sh4/cpu_loop.c +++ b/linux-user/sh4/cpu_loop.c @@ -84,7 +84,7 @@ void cpu_loop(CPUSH4State *env) arch_interrupt = false; break; default: - printf ("Unhandled trap: 0x%x\n", trapnr); + fprintf(stderr, "Unhandled trap: 0x%x\n", trapnr); cpu_dump_state(cs, stderr, fprintf, 0); exit(EXIT_FAILURE); } diff --git a/linux-user/sparc/cpu_loop.c b/linux-user/sparc/cpu_loop.c index 7c4796ca23..91f714afc6 100644 --- a/linux-user/sparc/cpu_loop.c +++ b/linux-user/sparc/cpu_loop.c @@ -285,7 +285,7 @@ void cpu_loop (CPUSPARCState *env) cpu_exec_step_atomic(cs); break; default: - printf ("Unhandled trap: 0x%x\n", trapnr); + fprintf(stderr, "Unhandled trap: 0x%x\n", trapnr); cpu_dump_state(cs, stderr, fprintf, 0); exit(EXIT_FAILURE); }