From patchwork Fri Jul 6 13:58:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 940524 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41Mc196TK5z9s4c for ; Sat, 7 Jul 2018 00:04:45 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=arndb.de Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 41Mc194rq6zDqgr for ; Sat, 7 Jul 2018 00:04:45 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=arndb.de X-Original-To: linux-aspeed@lists.ozlabs.org Delivered-To: linux-aspeed@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=none (mailfrom) smtp.mailfrom=arndb.de (client-ip=212.227.17.13; helo=mout.kundenserver.de; envelope-from=arnd@arndb.de; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=arndb.de X-Greylist: delayed 325 seconds by postgrey-1.36 at bilbo; Sat, 07 Jul 2018 00:04:40 AEST Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 41Mc1453RyzDqFG for ; Sat, 7 Jul 2018 00:04:39 +1000 (AEST) Received: from wuerfel.lan ([46.223.138.35]) by mrelayeu.kundenserver.de (mreue102 [212.227.15.145]) with ESMTPA (Nemesis) id 0LiCiR-1fwhOB1WLb-00nMs9; Fri, 06 Jul 2018 15:58:44 +0200 From: Arnd Bergmann To: Greg Kroah-Hartman Subject: [PATCH] [RESEND] usb/gadget: aspeed-vhub: add USB_LIBCOMPOSITE dependency Date: Fri, 6 Jul 2018 15:58:10 +0200 Message-Id: <20180706135840.908258-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K1:KvyuPYuai9obFLh/kvDcrI47KRwgDKX2E3Ry6HQ2dBsIhVuX7dQ GnQEqLXHO4OTJCdZsiz9niTIbGA6HxqeaiLlGNj7WbvO1eV9QwGmS86ME/ilzENDBPcv9qf 5eHbSD4fna0aFduZOtcZIrlNyv/WnMKDXHamac0CZXu076nSZOUwH7SpS/+/C3/py44no3H Ys9WDG19Q+CazmLKpqCaA== X-UI-Out-Filterresults: notjunk:1; V01:K0:lHZQjmiHGs8=:VYmC0h47OKuhJg3ez9HbVV bvLnbQIEDaxssAWuRbhQF+elOkqH3cI23YEImu95Y+oLRyUgeldGO8lVpRX9PbV2P3BEnzqFY 6vWNyUUQ9UYtmAvOWYPLiwCZ1uJI8Nsk5nfQW4Xt2mpDV5igYWu8lptHeEJgx/WjHTSpIwccp ySZuRruuvtMhm/ir6+S9efg3Y0mdoz953OvyqTPUtdti59bUn8wDW4xv5d2YiaxWgq8BJZ0Ff E7bc+xbphZqXSB09WZNEQmtfDQ3OmPsI7t7Qz9uy9hhouH2ozQUShHYjX1pF9iTxuvOe7hIE5 cULAnQk6lC5CVSi7QhdvwKoPVZZEn52ocvXkhad6ySz39m7uebDMth/PCfTv0rt7w/CYgHfxm C1KO7vlwpbIn/F/nzFYguFirJwJhegTX48X8FyeEO53C94grYrxCOXDnHI8bRJmNHtLgZxp1/ OoOtm/KoHRZJUw8GETRJDKeGlMdHrUO9Tm5UxFG7MKKv/vM7EgkH/Uzn5AycG7RcEymcGvXrS CSeh0NEuKXB5/83Nrpgd85FiIsqVG81KpchaUTIrCxEp1msVXcxNvSCMVnvVsHuSC0pIQsJ9v 0oNqmENXGxchoylCwVhSYaAJ5yRehVoMHNac49NvlievfB9sNWnCkpbZ+ehXBHvcdA+uhwGZO 6FeCpbLrJzPHdvhpgNSu8/8Sf4n9s1bQspfHmzGS39FMsPUGPAo9vo0C+ZlYGJXzLvyA= X-BeenThere: linux-aspeed@lists.ozlabs.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Linux ASPEED SoC development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , linux-aspeed@lists.ozlabs.org, Arnd Bergmann , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Errors-To: linux-aspeed-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Linux-aspeed" Without that option, we run into a link failure: drivers/usb/gadget/udc/aspeed-vhub/hub.o: In function `ast_vhub_std_hub_request': hub.c:(.text+0x5b0): undefined reference to `usb_gadget_get_string' Fixes: 7ecca2a4080c ("usb/gadget: Add driver for Aspeed SoC virtual hub") Acked-by: Felipe Balbi Signed-off-by: Arnd Bergmann --- Greg, as discussed in https://patchwork.kernel.org/patch/10427921/, please apply this as a bugfix for 4.18. Arnd --- drivers/usb/gadget/udc/aspeed-vhub/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/udc/aspeed-vhub/Kconfig b/drivers/usb/gadget/udc/aspeed-vhub/Kconfig index f0cdf89b8503..83ba8a2eb6af 100644 --- a/drivers/usb/gadget/udc/aspeed-vhub/Kconfig +++ b/drivers/usb/gadget/udc/aspeed-vhub/Kconfig @@ -2,6 +2,7 @@ config USB_ASPEED_VHUB tristate "Aspeed vHub UDC driver" depends on ARCH_ASPEED || COMPILE_TEST + depends on USB_LIBCOMPOSITE help USB peripheral controller for the Aspeed AST2500 family SoCs supporting the "vHub" functionality and USB2.0