From patchwork Wed Jul 4 07:41:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 939138 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-480988-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="Hq8nb2Kx"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41LCbr4Qp2z9s29 for ; Wed, 4 Jul 2018 17:41:28 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; q=dns; s=default; b=KjfjyHPzi3JyYUIc6z7OT/69S6TGNzVkod/xORDX2TFm3dKUcz D4Ra0KrIZurRlYultJi5D1VkYl35xAqLbWCaWLNF3VQoBKLiS7UH9HQLgK6TssCU tz95jsTQHEdgSIr6K4Y93Ax4CqVNd7/YtAyBJrt7+6onGB3cMtBIogVnQ= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; s= default; bh=UFvTXYzXZnUh13ZUicWFWmnIZ0E=; b=Hq8nb2Kxwu652YrOmeI4 cFjV0piD+dWTZ7DNmp7DcQVzMbVa3czgo0Q9SoUptzBzZcb995u1+ldRulcKWEHO bUNPsSIReO2T5RMpVs2XCVFkKt67huYwmta87REx43E2BzdXj9yZevpIfb9isGbR 1J44/FyIlS51o6CKGieaFkE= Received: (qmail 71352 invoked by alias); 4 Jul 2018 07:41:21 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 71334 invoked by uid 89); 4 Jul 2018 07:41:21 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_NUMSUBJECT, SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1713 X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 04 Jul 2018 07:41:20 +0000 Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 2A697AFB3; Wed, 4 Jul 2018 07:41:18 +0000 (UTC) Date: Wed, 4 Jul 2018 09:41:17 +0200 (CEST) From: Richard Biener To: gcc-patches@gcc.gnu.org cc: Jakub Jelinek , "Joseph S. Myers" Subject: [PATCH] Fix PR84829 Message-ID: User-Agent: Alpine 2.20 (LSU 67 2015-01-07) MIME-Version: 1.0 The following removes adding -lieee to the link command when -mieee-fp is specified for GNU targets as suggested by Joseph in the PR. It doesn't touch m32r so the fix may be incomplete depending on the C library used. I've added a testcase that makes sure we can link but not functional tests of -mieee-fp which I suppose exist already (eh...). Bootstrap and regtest is running on x86_64-unknown-linux-gnu with glibc 2.27 where the testcase fails before the patch. OK for trunk and active branches? Thanks, Richard. From a71f976df0f17790202c0a692920c9d67e009259 Mon Sep 17 00:00:00 2001 From: Richard Guenther Date: Wed, 4 Jul 2018 09:34:14 +0200 Subject: [PATCH] fix-pr84829 2018-07-04 Richard Biener PR target/84829 * config/gnu-user.h (GNU_USER_TARGET_NO_PTHREADS_LIB_SPEC): Remove -mieee-fp handling. * gcc.target/i386/pr84829.c: New testcase. diff --git a/gcc/config/gnu-user.h b/gcc/config/gnu-user.h index cba3c0b92e3..8620de3e42d 100644 --- a/gcc/config/gnu-user.h +++ b/gcc/config/gnu-user.h @@ -123,7 +123,7 @@ see the files COPYING3 and COPYING.RUNTIME respectively. If not, see #define GNU_USER_TARGET_NO_PTHREADS_LIB_SPEC \ "%{shared:-lc} \ - %{!shared:%{mieee-fp:-lieee} %{profile:-lc_p}%{!profile:-lc}}" + %{!shared:%{profile:-lc_p}%{!profile:-lc}}" #define GNU_USER_TARGET_LIB_SPEC \ "%{pthread:-lpthread} " \ diff --git a/gcc/testsuite/gcc.target/i386/pr84829.c b/gcc/testsuite/gcc.target/i386/pr84829.c new file mode 100644 index 00000000000..a63a49b1317 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr84829.c @@ -0,0 +1,7 @@ +/* { dg-do link } */ +/* { dg-options "-mieee-fp" } */ + +int main() +{ + return 0; +}