From patchwork Fri Jun 22 01:52:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhouyang Jia X-Patchwork-Id: 933035 X-Patchwork-Delegate: boris.brezillon@free-electrons.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hfBihzX8"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Q5exfV01"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41BhRG5BZ2z9s47 for ; Fri, 22 Jun 2018 11:52:55 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=zdIe1K1EcrrcfANG8qDE2SQaZ4F5Ly3bGfaiLeDeqwo=; b=hfBihzX8AYYCKBirHNgDp0wNP+ T/ELGUWSg5bvhcarZPy4TxOomp9XJfk8TipG7imFyITBbN6ZlhtrunLvsTuDD1IdK1PC12zlFJvHe e4bhYf6zuBZd9Kdquai/s3wb1n5NcZa5+wRew3hIw5RoaEgwQiT+MlF+ktp+O54Q+HYTWRv4wfP+P 5WqLn4gh+nnfZ02CvzQwK6pgjxAz3zsN3Dr1re/ShydVVI/kPUD6qkcWi7786OR1Vbhi6DV+gpPiG C9O+P/TpV8D6ElGlClfko7DjVHkdszy+ASRiyXdOhUEBDk43w7+yJP7PJrEqTeK3zlVwBUxxeir7i VgVeXK3g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fWBFn-0006gD-KE; Fri, 22 Jun 2018 01:52:47 +0000 Received: from mail-pg0-x244.google.com ([2607:f8b0:400e:c05::244]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fWBFl-0006fD-3g for linux-mtd@lists.infradead.org; Fri, 22 Jun 2018 01:52:46 +0000 Received: by mail-pg0-x244.google.com with SMTP id m5-v6so2237547pgd.3 for ; Thu, 21 Jun 2018 18:52:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=XrlY6cF/D9ECGN/lcBiooNvp63H0HkRywHeY06feTm4=; b=Q5exfV01tMEvE/MUi/G7Pw6o2ijN5J/mCrPkaY7T1aHXDC1fl46EgmVRvVJIK0/ypB diQI+C0wDzHwaBAQvtf0VozaIDNMUm2iXcqp4FoE/zH3pdVADyuDS9PeUEdWol+bswOU vgKp4QFcLrYTauzLxClKW5XhyVsXtAasPBTuDfnnV0qKaPOG5z5pmyxDQmNtXAOPd7Nj 6RXSLzCKklfFweiV+wLqmiadWIrSy1CLS2DBljud5SfAeW1SkAA32G9ITFqRuPMR5GIN o7p2IIjstk8lgHN6dW2wzuaGgf2w9q3RhVDi3oIG4TOEaOWCzcBuyhIC/oInrhuQOVeV bRLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=XrlY6cF/D9ECGN/lcBiooNvp63H0HkRywHeY06feTm4=; b=kx3sYBonYpgSrCL/Le1pp4TCFw+fG4KcMVZZaJgMj7bLp9OljWQibILSoMIFupaXUf cMZaHyzUOj8Uo4NfNickTA3gaGQ4c9cB39f2VL2dzKBiOL0rEtPCtFAV42/LRQeIB2kO mcpLnZudkzMsWPAFoFqZlBrWvrSxzvBLt5JSzhHDBHdJTQkBF5/PaA4K+NQTqTBokiMa i4XqJv4reafdWP9yxZKs4QGLMGaAohVJjufs8BmNMWq2WDskabeiXIL4j2MxlmYA+910 lJLmu1GEwhvMpqg86NYZJOaIVEZ0VsqZ30ouEMh3xCsnkWF/MNwzjXvYla5KA8LxEtwC dXDw== X-Gm-Message-State: APt69E3cottJNEBTWlrut2OrK25dGOml4ZhbboikAvlux5Dg3+FEGrXO QmWVP4U5HaRYQoswKvUpg9s= X-Google-Smtp-Source: ADUXVKIDqflEVp2PvUcF/vVlLm59Qe4Iu2fiUznS4xxXCS/oXF6zz4kjAlQrdDFT6bd6h2wCfxlfmA== X-Received: by 2002:a62:bd03:: with SMTP id a3-v6mr29575773pff.138.1529632352752; Thu, 21 Jun 2018 18:52:32 -0700 (PDT) Received: from localhost ([103.88.46.82]) by smtp.gmail.com with ESMTPSA id u1-v6sm9064024pfn.59.2018.06.21.18.52.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Jun 2018 18:52:32 -0700 (PDT) From: Zhouyang Jia To: Subject: [PATCH v2] mtd: gpio_flash: add error handling for ioremap_nocache Date: Fri, 22 Jun 2018 09:52:20 +0800 Message-Id: <1529632343-70907-1-git-send-email-jiazhouyang09@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1528773302-37265-1-git-send-email-jiazhouyang09@gmail.com> References: <1528773302-37265-1-git-send-email-jiazhouyang09@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180621_185245_154268_93DBF275 X-CRM114-Status: GOOD ( 14.38 ) X-Spam-Score: 0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:400e:c05:0:0:0:244 listed in] [list.dnswl.org] 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (jiazhouyang09[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (jiazhouyang09[at]gmail.com) -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zhouyang Jia , Boris Brezillon , Richard Weinberger , linux-kernel@vger.kernel.org, Marek Vasut , linux-mtd@lists.infradead.org, Brian Norris , David Woodhouse MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org When ioremap_nocache fails, the lack of error-handling code may cause unexpected results. This patch adds error-handling code after calling ioremap_nocache. Signed-off-by: Zhouyang Jia --- v1->v2: - Move the test just after the ioremap_nocache() call. --- drivers/mtd/maps/gpio-addr-flash.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mtd/maps/gpio-addr-flash.c b/drivers/mtd/maps/gpio-addr-flash.c index 385305e..9d97236 100644 --- a/drivers/mtd/maps/gpio-addr-flash.c +++ b/drivers/mtd/maps/gpio-addr-flash.c @@ -239,6 +239,9 @@ static int gpio_flash_probe(struct platform_device *pdev) state->map.bankwidth = pdata->width; state->map.size = state->win_size * (1 << state->gpio_count); state->map.virt = ioremap_nocache(memory->start, state->map.size); + if (!state->map.virt) + return -ENOMEM; + state->map.phys = NO_XIP; state->map.map_priv_1 = (unsigned long)state;