From patchwork Thu Jun 14 01:18:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Moger, Babu" X-Patchwork-Id: 929178 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=amd.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="pFw7lif+"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 415m763KRmz9s1B for ; Thu, 14 Jun 2018 11:21:54 +1000 (AEST) Received: from localhost ([::1]:37631 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTGxU-0003KC-3c for incoming@patchwork.ozlabs.org; Wed, 13 Jun 2018 21:21:52 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48664) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTGuW-0001I1-0Q for qemu-devel@nongnu.org; Wed, 13 Jun 2018 21:18:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fTGuR-0007hQ-Ar for qemu-devel@nongnu.org; Wed, 13 Jun 2018 21:18:47 -0400 Received: from mail-eopbgr700076.outbound.protection.outlook.com ([40.107.70.76]:10976 helo=NAM04-SN1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fTGuR-0007gd-5m for qemu-devel@nongnu.org; Wed, 13 Jun 2018 21:18:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5E+kbjk79JpXypuDEA+OmxmJc1DN7TrzskGF9TqZZLY=; b=pFw7lif+pCgdvzokf0kXr49ZatEvJlEqIn3yKvWPJhyZtIgh1wEuR+4swZLhJ3R/0hHwrNCVRl0cffeLI+H/6Wa/iYifzZXLSOZtE4ASywsBDF5VgKuOtccfK0WH3fnFOTxol+S8nVdtlSEplojl77t8eC+eX0UtuK+5yG54s94= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Babu.Moger@amd.com; Received: from linux-h3ml.amd.com (165.204.77.1) by SN1PR12MB2480.namprd12.prod.outlook.com (2603:10b6:802:29::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.841.14; Thu, 14 Jun 2018 01:18:40 +0000 From: Babu Moger To: mst@redhat.com, marcel.apfelbaum@gmail.com, pbonzini@redhat.com, rth@twiddle.net, ehabkost@redhat.com, mtosatti@redhat.com Date: Wed, 13 Jun 2018 21:18:22 -0400 Message-Id: <1528939107-17193-2-git-send-email-babu.moger@amd.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1528939107-17193-1-git-send-email-babu.moger@amd.com> References: <1528939107-17193-1-git-send-email-babu.moger@amd.com> MIME-Version: 1.0 X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SN4PR0201CA0064.namprd02.prod.outlook.com (2603:10b6:803:20::26) To SN1PR12MB2480.namprd12.prod.outlook.com (2603:10b6:802:29::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9334d472-2747-4fd1-8d0b-08d5d194c364 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(711020)(48565401081)(2017052603328)(7153060)(7193020); SRVR:SN1PR12MB2480; X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB2480; 3:l5V1EwuaJOJFjKGpBVHk+XYBiFdWdBHyM1xmGkwFOG5DZcuj0Za7Abhz9c0srr2PhhixCBMDLysBElN0TTT3+kh+3ef5z5kl6dntYRXbiHgInBm4z2i2lfG/+6jHJWJorJm+zm/1d8TKinpNH5OttHN4DjGcM4bUv8dfuvG0Gw/JuOuxPTwBCdKwCnLgFB+/aWArKJ4AyJgGMHwAwzNbpxAtPBFsi0Nb//XZGtE8VQEZhOX955QUpx/cfRmmi3h3; 25:zu2Yg014SqWjNFAFcGuJkB50MTGgEdf4R8ZfziT9Vhq/OBikUqVwhA9mHZ6d1AWZoHOwAiCJ32MigCbJxm1IID3B3wOWcjY+Ap5fOfOSyeGkwZLi42Il5J8XXWM/xpeIdt9D8O092NaaXmt7IDqy2xYZwvjXzkSHkqvkceKyfo3j2/lIemI41tviDE11TYUP2whODf+9W0chZGc+ivotDQB2L544XaP9iZHnFvZ8RvKDGSi6ru1eD4uRoc33l2t39avlilL2bSLqxaVDupUVBGoi392Gp9jA5FppAL16zKC/SgU3Rv/+fSaC5Tfg2eKdMhJIrmgJIEmf3ArWE8Sgpg==; 31:so4T5joB2rDH4cCnY+C/1y/9GFLkroYegRfvJqyAXYlCicBUh7Bdn/cFJ9ma8x460gWGCD69iDfcrlwQDUH6UeAfRWHOXZ4bqOtel7CkYHHYApQyHZSMJM7dTjoZEoGeeG6GAE/w8PvXj/Chi+3Vf4FMoohujvp0jLuxcj4NwHH6FdzavtytpHFgDB8bLgqD7EwMzjN7QhSn6JW4/tN13kGXN29flplMC7O3WpyXw4A= X-MS-TrafficTypeDiagnostic: SN1PR12MB2480: X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB2480; 20:htQuTq5e5XeM7A83fdUPaJ+IqAfz/i+UWQbbPl2J4oGGwwgFJ+42TUyoHRSp84VH4FML1mkz4a/RI/+aPB0NLCibM1deJttdBvE5rND9Sz13ZnNXAMjwMAyFNa5rgise92d7W5RHQHaN1SaQsLJAxPGKlID8n0XYFtSlhQewbkSIx7/D2+AZHwnUG39tUSE5AgJ8fo7dAhSUkSE/vv5OkqZh0wq4O78OoyRQpMZNAxROLkeRw2BzCyG/asuix0Wqz2GhRIulBoTAar9zfbg+K/nqrWjjCYdyh0uZ6W7tbHp5+nBG1CSWnZ8q9vXGNf4KrUm7iGktVpTpj9siQ8Xr761HDb8ISw/mUJOBMmvzSbHulc4cMAn5NzEJwE1syJIHnRefqVsCfKiKlnuWD/EW7no/BxyxGLKVf7k6+bYzKvq0wmmPSQxcN2VqujU6V0JE9SH2dyU2Xb0sn3AUmy8VFB8i50z8p2rqVhzNDXxOcLlOg945v8M7qTAaMZRLWDOf; 4:c8MHgtPlR0UnsadRbu9mYmTGwLDtIpP6zl0uQihEiKUtCrUDD523J5DjvBMReFfK0h4ONxSflIUUSaBM3MuXd27VfQO3hxM5VVmlx07nZIkvAlFQMf+MiY9ZwYk8ayQvLm6ArI7wNbaLTG+mjhC2ROqej6CCHYnsB7ebGLHn8jTVUFteXsvtqmMjmgnbZBOFZ6K8Jh2CBMxnCbdK7zOVFvtWpusZdmIMT+c5S5uvWgUX7XzvvPzF+G1Z8yk+slV68ic2u+MpwHhvfGUr8hIIIduA56hp6scPUAuMKV5gKhcXO4O2Gv3zv03DfGpRqzJa X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3231254)(944501410)(52105095)(3002001)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:SN1PR12MB2480; BCL:0; PCL:0; RULEID:; SRVR:SN1PR12MB2480; X-Forefront-PRVS: 0703B549E4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(396003)(39860400002)(366004)(376002)(39380400002)(189003)(199004)(68736007)(2906002)(25786009)(52116002)(7696005)(72206003)(51416003)(4720700003)(956004)(6666003)(2616005)(11346002)(44832011)(486006)(53936002)(7416002)(476003)(446003)(76176011)(6486002)(39060400002)(36756003)(478600001)(4326008)(6116002)(5660300001)(7736002)(305945005)(86362001)(575784001)(8676002)(186003)(97736004)(16586007)(66066001)(3846002)(53416004)(8936002)(16526019)(316002)(386003)(48376002)(26005)(81156014)(81166006)(50466002)(106356001)(50226002)(47776003)(105586002); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR12MB2480; H:linux-h3ml.amd.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN1PR12MB2480; 23:XpTai2jJeyZlN7HvNZxuv8ovIMgmohPEql7nrU3pF?= n6rOV+ynBpemJ4VynG71NdZbANtELj/h2IowmJWWUuQlrwof+X0njMlf6lNSC7ZXLhN5irPYKGaOVd+kBr4QgZt/j7iQ1kpgxXDEdHxdTsAgLpI+8qpRFIqeORoJJVLiWYibcGLNDhFGx4zQiAtOZTQzncu8RYZlakJxt03128gkzZsWTixtrbTgPY3f6P3Wtg3oKVRPu1dpa621aSLMENEkjZaR+gDbWbYoEUy2iaV1owCGmzy264eQSa6TBv2lYHzA07f3LWOBpnH8lfov6atdumPkjMbQV1qQSRf+ErASO6kfsI6NfHPjdXx2PK64Gf/oewDJyWPoo+W3SvnupJNqg51ffUQy4rCRBstMzer1ZirnYE3sSkgiX3AXqpVH1lLXVkWnM9k+ZXnPFyulQAooCedh8kHgAwkonH2RJicJjj7AHqNkOjXTzN7FlupSnc4sZEtApL8+vtRlOso0pDbodGxyAXRX03myCuVAVNwLmByVCo0mGFMoE+qxKWVEpicbP9a/zv/LRPy9NlMQOAymoRxhRwSA9zKQbBiWMbms1vQ9uTomLvl5XTsO7SrPaAXT3iFRITxVY6dZGqv8qGLspLoESGimxDvx4ORei01mHYvGSSxMtmlwlEAz9c3wHS1rtjT8G4AjHD6rzLh1rWMQgRwMVB0bqFe9qVqOARAnUzCwJti2RtnCyG3IrCk0lx9kXc5yUTEErQmDSzOHw+efA1bgPz4lFntfdqI7UZkPnJmzxy14/6hX5I/vMXLf9SmuACZ2rBJWuJ3iss+EsE2KQEAm2+cbbCvEHsHk87PLEyTRBJKm5oDnuRJq17C0IOmtxftyhOijNYbV0QsVKAZs8sq10Iih9pMSbGxu02Co6O9Azq9A/yGoHswwAzaMGoYfToTNF4lDmbZTQdKBpjz41LfJa3pEqx/BsFIasyfFOTqFgsjLXfoZxtFuTnfIPuKqJOOMJeq0vovhrureLKsvjhbyS/6crfpHVIr2zdn21QDV6eJLAcjT7tUfBNpMGBS7yzgjK7mLnO8LpFNNMzka7DOv+DR3PqdFZ6ymcxOTxniuONxz8f7OSCP59RxxIjoy0YWaty1Xa/0qAioGHqUewRvkUEZakPYcXYCPwqL+BrRmIXhxv5t4DUD0pnjNTh6JsjQ3xZV29+VTcPVFk2mapCPbaiBZx5U9/sxLejRktHbZJ4nZDxVgGuX8XVh5Zy3wInDI53ldtbN6iHVkWn6LG4ol2n2Kpft3w3tWAPt4A== X-Microsoft-Antispam-Message-Info: /fPVewVL83ZqERsdIY9YywNvMihGTz+8atYGDKggHMcEKpFHkM085ie4/Mt4DefKMqI9VkcVhMln4OaNTTrLywuwQmVAqriZXkUjLBtaFhFj2ME/zKWs+brm5QQa8WMs2dGEQXGpuW4CpeNoEz+0CFobJIe3u8L0dVdpkrujEYEMyFKdSV4uX5Ms7jUOFCYP X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB2480; 6:qRh01JFtLq7DIfDwPdQ7h2Oyf7Cwx3MplGdDjW0mcpyoqHHr5K/xoww5OzbbgaxuLX7+qaB56dBMEvACZYEHwRGM7wCA4Bpeg7b+mbcQy0AhiHREMHTlcl0PBxg4Ns/JzZvorpU3rdAiDlJ+nkU4FxRZ4Q00JJGY9uAM6KPsYr6uC4PgYYuCH5J5GfH62BUvpBTdSD9NUo+zLGgziWoRAoG6VyLZEKUuzz9RzMsBVGiy/ng6WJbIiV7VKpFSmJOuZAu3y7srS+CqznB1PExtWGe0YujxI3Q+db+7BGdwI13ORQcZDbf22i9FQsaOQ3qOHDulIKHoHKudcYVp7FZXKZ2RR6lN+ZV6OQa5kanPiMngFyjtla4KaHcpDuRoEUUVBeKg9xTNBrUSr/A+mwr5SyVywk4Qkhs4AZ2lTDNNMcPxg22uUXc2WyjW9Vrd/Pxg7FJ+DzCZHNBRFYg+DmMS+Q==; 5:WYARu/O2sxXO8C63rj3pimlIw175WvOyjaRZKBTU/2jbbrWR/OD1+pyv5LGeMPk9WCOfLoZ/yc+1YlLohtLn23U2nEuX7tLG8RWdBN809rK9yfvpK2Zu+yneH7Cj6CO0VzLYClOTOem0X0ZFo2CFtvDxy9WoESIYjw3qaC9wuJQ=; 24:T8r+ZrOJCAAIaFl1poiAdlYZkOUKIcTkFiYyqqGtZIkaGnAcZniE2Y1iMPlITXgqZuZ3xQ1x0tXwycKouSHAWMRHtg+Zm04iF2iCk9t3Hs0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB2480; 7:f870zvPwDJR25/eO5KYG4Pd1H1YL9OxpDjIxQwMwMG8rRml4bbz1DJYaUmq2IjBkaPHDJ1RaIhYrZGKivGL+Bn1byFoDc4fWT4lW7m3xIhD5PrTvB/iQWilGwpBgsjPkYKxEVYr15gC+KyTThia5pEe7QLDTm9nJN148Vh67d2uarV2TviyqXQA0QCMF4WrVSLl8hiGbuy6u9sCecQkgGbYSQQObcmTw4qjWA4jaBXA1Hal/qdJBk090Tj21m9nR; 20:qcKN2gaKljIIaFKV+EQY+Mw6bld7+WsSQjA9xsMRIumTI5zfsX2/PaDMkrQQdM1MQFuINFW+1oPhyCJx0INcZxq5yUNqbVX6UZjikmpUpgcnMXOCIJ13WDJDZkMK2mb4/ShwAYdTTadNU9RSKkQ4Xb/epJUUPsxgGfQBlQbnT5CBL3HTRteNDVuirC1YInXIyQYZmaS4nK+gVZ/GZwSJOn0YSgT9XRnLRAZUPsqAM96uDqiN9kCzck7k/eBv6GYa X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2018 01:18:40.2922 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9334d472-2747-4fd1-8d0b-08d5d194c364 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB2480 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 40.107.70.76 Subject: [Qemu-devel] [PATCH v14 1/6] i386: Set TOPOEXT unconditionally for comapatibility X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: geoff@hostfission.com, babu.moger@amd.com, kash@tripleback.net, qemu-devel@nongnu.org, kvm@vger.kernel.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Enabling TOPOEXT feature might cause compatibility issues if older kernels does not set this feature. Lets set this feature unconditionally. Signed-off-by: Babu Moger --- target/i386/kvm.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/target/i386/kvm.c b/target/i386/kvm.c index 445e0e0..6f2cca7 100644 --- a/target/i386/kvm.c +++ b/target/i386/kvm.c @@ -372,6 +372,12 @@ uint32_t kvm_arch_get_supported_cpuid(KVMState *s, uint32_t function, if (host_tsx_blacklisted()) { ret &= ~(CPUID_7_0_EBX_RTM | CPUID_7_0_EBX_HLE); } + } else if (function == 0x80000001 && reg == R_ECX) { + /* Enabling topoext feature might cause compatibility issues if + * older kernel does not set this feature. Lets set this feature + * unconditionally. + */ + ret |= CPUID_EXT3_TOPOEXT; } else if (function == 0x80000001 && reg == R_EDX) { /* On Intel, kvm returns cpuid according to the Intel spec, * so add missing bits according to the AMD spec: From patchwork Thu Jun 14 01:18:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Moger, Babu" X-Patchwork-Id: 929174 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=amd.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="AMwpDdvj"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 415m4K2BrCz9s01 for ; Thu, 14 Jun 2018 11:19:29 +1000 (AEST) Received: from localhost ([::1]:37615 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTGv8-0001JL-UE for incoming@patchwork.ozlabs.org; Wed, 13 Jun 2018 21:19:26 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48663) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTGuW-0001Hz-0R for qemu-devel@nongnu.org; Wed, 13 Jun 2018 21:18:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fTGuR-0007hd-IJ for qemu-devel@nongnu.org; Wed, 13 Jun 2018 21:18:47 -0400 Received: from mail-eopbgr700076.outbound.protection.outlook.com ([40.107.70.76]:10976 helo=NAM04-SN1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fTGuR-0007gd-Cb for qemu-devel@nongnu.org; Wed, 13 Jun 2018 21:18:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lz6qrv5B5zZbZzExwTxDWSxiox4MLAm2l2YttHxdHDM=; b=AMwpDdvjZKXLmb/2nZ5DEkd7t/YNyy/a8sDcNDizIhgoTS4egW69lQ0BqTPkK3vnlTPfa4/erIzIZEA9aC0qdr7JCGIDnJdjenXjlqu6eXwVE5U4egOuhx9JtaCrYh/X5mjTAHJdgISXCAONJwqWHQmByFEZnnNJSYyk8Q48l2s= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Babu.Moger@amd.com; Received: from linux-h3ml.amd.com (165.204.77.1) by SN1PR12MB2480.namprd12.prod.outlook.com (2603:10b6:802:29::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.841.14; Thu, 14 Jun 2018 01:18:40 +0000 From: Babu Moger To: mst@redhat.com, marcel.apfelbaum@gmail.com, pbonzini@redhat.com, rth@twiddle.net, ehabkost@redhat.com, mtosatti@redhat.com Date: Wed, 13 Jun 2018 21:18:23 -0400 Message-Id: <1528939107-17193-3-git-send-email-babu.moger@amd.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1528939107-17193-1-git-send-email-babu.moger@amd.com> References: <1528939107-17193-1-git-send-email-babu.moger@amd.com> MIME-Version: 1.0 X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SN4PR0201CA0064.namprd02.prod.outlook.com (2603:10b6:803:20::26) To SN1PR12MB2480.namprd12.prod.outlook.com (2603:10b6:802:29::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 31a42387-e6de-4fd9-1ef1-08d5d194c3c6 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(711020)(48565401081)(2017052603328)(7153060)(7193020); SRVR:SN1PR12MB2480; X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB2480; 3:mTaCs4CgGQ4PLkkNGBs98+ZY/o31WVOPn0mnMy/XYkKgPyjhHexQukF6TfDJFPynXZ0AR3xnC6u+qd+feWzREyHD0RjilswjraBzTFWULjzWlwTAtdW9tyZdPMTfJ5OxLZE9vtDAp1jih86X+9yFvDxiyG8DxsFZaF9yWoIC5xB41BGTxPgZnb95wpha7CObzww1CjCC3W1Sp4NgoBAYuDRpTSpiQSSdzbqBQHKNm41BpU6TELHEbcOSUKxCg+2q; 25:NElAayKOQ7Ye9I/WtRsgHDdxpOpzumt9xCY0hfegJdGGCoWK8aL8MZGrqcmRyZu0g79bHbbgM/+vok6b4bQzmZNzkiukf4+4LWXiReCW/cttcay/2USgryjPQfjAUrOScU56xnLBm4rJn9CBhFCXNxphC0OtSLUP0WVfdIAyjAs4GbuuT2b5Yn3bbBheSz2NZE4Xg0sj77pQm3TzB0SyTPcmN2nDZ5ijOWToyEO2snB6eqzBl2eXInqWkeZqXOSrThcNeOxy7VQi0QYIHPKaGHmGh0GQQy00X8CIq2jkUc/dnM15NyQHCC2fmXovfZPLpmR0WDrHTvoiGrYPSCXdPQ==; 31:pYk+rr7A3pcLSm7+65NAj7Mxt2//+fxe1OGmJM0pYM9nAzzA1pyJTs+eYYDhNaGBwcEYmDF+9HkjWMQrqpKQx28Aik3p/1jD9qWJmkXJc5kiIfW3T+RgtjZ5cT9NAfL/V3Azm5G8xLk7v81B3d6xWLQk+7e1CCafeRJZCnWT6Syw9hGx7Osyv+0WJIxksm8MQ7cFa1goUBDhNV7SoR+/NBO1kFXvqZebTtWCldffofY= X-MS-TrafficTypeDiagnostic: SN1PR12MB2480: X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB2480; 20:XfByEYHzHPL3KqP3sQT1wzFIZQHM5Hqlqi0C8/XXk5OOLPt0RfzZkEilVu0YCBZRFkIBuX0i3Ofe6/bPfe7c7yX3kYPae1WVw0UfjzvjATAK0IjxOmjsaNUYv6YJE4dbsynMrVtgrwUR9zIb9VgFNp9Ho+mepOi2poGG1cElDwRoJmXabKnCb1Eycs0B2hAxIWCc+ueuzKQD136o2HWNU+BYxa+9AHpJxV4RW14UBoocSY3DLfHf42WTvpdksWNrYVvZY04LoZz0nXgSdVuzCOnisNgAtfBLCrOoGbMVYhVy82tUvejaULrq+a2SQ0o5caFuPwCO5KHilZM9agZfkwZx+p/SLL5VuaGnKcx+WHsjKgV3/KC8JVBTT1qVhBXORevlRBDv2g3hmn0kK2XmtEny19myw1Q4VhiW7UL/EEaAclxSD3qFMvRBbyPDuPtm6hwUsVMNY8BVdv0RHBr5pNycV1uV+DCqWLYOg8Z9hLmDmmOAXyyZa86zg930qT+Z; 4:jru8b4zzh83RCXXoabypm7T+4bxN1rRgMbCwT+abZw4cFxvCKWrjhWYAZi1glJ4FURt1C6akm+I43HhUnOHp90CvIrgRVWGy23WPnpmYnjhj6jbowdEudDDxGdhtvqHj9d2JHj5lBST52yu0Kq6eh1BMK2r1ihe0nwBEIoijRHw9LFgVWGGJhUtjvEN64cuhdgoahdlLgYnXOctn+3CfsyYZLTotjEiRFVTmUoU4NCRemKuiMn5ALJAFWzWS+k/0lfPaqmqmFuOHlnCPdcKe4Fg4OPXnW3E59kmOCMdJQFQ+bCJKmSlebRDmi0rBYNlh X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3231254)(944501410)(52105095)(3002001)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:SN1PR12MB2480; BCL:0; PCL:0; RULEID:; SRVR:SN1PR12MB2480; X-Forefront-PRVS: 0703B549E4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(396003)(39860400002)(366004)(376002)(39380400002)(189003)(199004)(68736007)(2906002)(25786009)(52116002)(7696005)(72206003)(51416003)(4720700003)(956004)(6666003)(2616005)(11346002)(44832011)(486006)(53936002)(7416002)(476003)(446003)(76176011)(6486002)(39060400002)(36756003)(478600001)(4326008)(6116002)(5660300001)(7736002)(305945005)(86362001)(8676002)(186003)(97736004)(16586007)(66066001)(3846002)(53416004)(8936002)(16526019)(316002)(386003)(48376002)(26005)(81156014)(81166006)(59450400001)(50466002)(106356001)(50226002)(47776003)(105586002)(217873001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR12MB2480; H:linux-h3ml.amd.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN1PR12MB2480; 23:w/eARVa8UF+2qPl5fSbsFQGUIKI1+3y3QTBqMaJBd?= HXYUY5Gn9wMlkw2LE9ZwBSnGRZRBIdeCx9xdd93EU5QpHBBKhRez60Rtwe/WoozrpIE8PfIns3Ek6aDkA0yX4ObR/2WpeciARnNfI/OvyHW4HAh0BsTlVS0OhNDDwjlthqI4jPU52twIAnePxVB9SZ6iAkhOMQA50i1LkNdoof3QdJdc79wvBw+bdyVzwQAF1/+uX/EC9WaA0+zU0vXo75WyZGloA84OY0MAWnPXsRsz3kX6AIHb2g5VSBGiNyC4Xc4GO2z4S399Tw3qaiXBPvJLbe+F0z6iuugM8B1Hfz20xEdsgWKmvZxp2CqMv7FxnOo9osfCRncnHEoqUpouAAvu/eYy7SkYuSo6xuaeVCLPAmbt4PG9C8SEf/VApHMmkgA7yqiYKE/MLqOWXLnVI+g3Y0Nvp8dqWlBDIye6RZI4iaOszOwB4v5I8aySN9m4cRYlS9RMJfGmbvGF8FfS6eOFBTMmizsKOCS7l/E9jKNgictA/4no9bWxeY6PIQXpt2mq+QrbjM+SJi88VScljg0p6Wyv3V+sqIUSPOJ+A1zaFfJZUHvfvzY2BpsI4yC813zwQeiSmajUQzvpZ/UxXdJmLsHN6ZMTU9Ow7hxwg/0lXQQYGfIm6v2CSDQTElqo7Zesz1aozLHzvjeXqHs8C3ePYFKSIT22Slhbb7Jqpx3SRUCmWa3t+AZXksWWNtaCpF8EtANedrxWYrKyk84u1osGDscg+zmIRfOtkXQOOVmMcX8xoI6bvoL+LKU6yM+zsCj0rRghDwDGAIYjtJzqXGZqFRHa6NCALa+DyGryT+lu5M03LjVgS5sRZnmjdm6MMSjg0dLOJbXXuRtzkwK0YHTvV7AUKN+pe+urh/hoxnqK643UVKpldSOra8k+b2xALfrfi+4jTBIlO3ZkAvkW97TEEvmUu53jgFzhhmHN+PG9oOWmvoQgfS5tS+gw0vYMlHUxksEK6rXL4TBVN74o7abDQskVtXiTxawAaNtnli9wqMi6l+/13OhH6TN9jrtf0oilEGua7qIahJBx4cWFQVvh1zcQz9MkbW4p7D4s7Z+/LEVqTgCxzPtqv14LPbU0ZSEcLgfFLSNljOsH+oge5qzEegn+YUNLodZFNAqLYpu0Fo4dgJ+1zNBPXDWuXiVF3ZXF1rwDbXKStDe4+Bxpnx4JC9n4mcqBCYdwJmyJObhup7j88QnlvKYnGiJh7rkF/BhFdSwg97lpX8zv/qDXFbbZemaWTBfwRGhTOHCoKXh+zhigKmH/y5QBjxF2utR2dXuw2jFEyVbU0wpVmjDZRrC X-Microsoft-Antispam-Message-Info: fhdqEW62nXbGm3a9molrA0aLSQWDeJNR/VXsrRmRMpPNljRouGE0QsLiG+Cvo2RGJ7FsHLcTLK7Pfvl0pfgtri0L2x3y4s4SHv+/RE7W3bkHTdKiQ7s7iZJkXLKi7sw7uHfPlT8WJUYgCM9jsp0rHLaCnrhQDPToMP6rqlQu0p7OzYT9v144XpHt4+cn/rwl X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB2480; 6:Iqvt0sltHldNo8oyEYKqstyCtvptYmPvv6UkuLCnIKFAY4ENNP/GgfUNa2gOFxseGNGbB2VYxv7W5bHLS0vHMXGTF2PI/Xng/B95O04JD3rgSTNLE/mwgDIIkwtZNw3MkFNWw2cu1OQKMfejCt2rCRsXp/qq1EBM6sgzMYFvFVTDpt13FNekqcRZRUOKuz7SFQDBKSNo4Fy60f5qFA97HqdsfDlrM352Oezw3dpQGlWNWzG9nwsjetzxcKl5Tg0EgqMi5JmZEB+4/kS2BeXMtsJIIfTPthNXGU7Vu36pkxv/OMLpe3lgbCA576OKF5L1L8vcTlF61raMPTjp18T6KBkGzS7mRT4kqjTstb22AZ75sM6gllG0dIQbUjT4I+0ILhv/VqG3BVkXl9Wy1CykeXVlqqgvsfvH9MRuGVaSM2dbFYJRzmNhRVCNr2KVQ7xN6zD376e6Ext3Ze+usuo1sQ==; 5:ryrxkkkIhXFuhLaqfHJYP1ody2bbHqTLcmjNQVHmKQdaHc9oCqppjr/yc0MFke64DrflsCA9kj8NdQm8DUbfL9B3vS4fjU0KI7ESMSKzrGUm2J9iJzYdTn7a39aNoqH7urn9toK14/53hDjVilKDGoevsfPWDo6Fq8MRnfdGV9A=; 24:ohgcw4hKoNQ31nxoQpKuRDB4mdc84vVlwp/37N5XnOSDtwY4wKrojxcpSDRwuxBMwsYgL4wUQHxdHNzkxH9iQ4m5RWGjRaLZeCsavbvHTyw= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB2480; 7:Fcxql/vpxATH1QRKZPkC7BammAGGbyh2nf7lhHzEMN2e/j7cGRMGhslCc+r07dYnyr0OIUr9R7r2ZBzqQBEKqpFvh3PmkBQItH9KhIidMTXFiJjsO147ocm0y7G/7+rsy2ndFIdF3TEakRltRrf+6WxkFbK5mo4pKyuC7w5dq3ejS1ktcKxVMK+l/JOAU78Q8v9hUGKsiXeQoK3QdLaUh8MUA+IhNHXJ3ejIPz7pYHiP7Z0faCxfHTGtQA50mMNe; 20:tHp36U5bHYc4ubf/IFhU9PK+s7KiJJGOD89TBylV+FsJPigCv9ZWLs2UNvGq3czh3BsYMaOuEjGni24XiSqT7JqqPstgnoBVgX1bWpCzoWAvBqhdh/ibdsOGqXxl4575jhCHYfY6NSgsmnmZWG4+d744wR7/5uBZiTr8IiC+BrvdTn8VN/5NU2bYKh8bitWjbibThh5hALml9pdhHZVX4MzTRlokv11o8EYsXsGbdhirEvsXJuSPryPACXPoigDZ X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2018 01:18:40.9327 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 31a42387-e6de-4fd9-1ef1-08d5d194c3c6 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB2480 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 40.107.70.76 Subject: [Qemu-devel] [PATCH v14 2/6] i386: Enable TOPOEXT feature on AMD EPYC CPU X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: geoff@hostfission.com, babu.moger@amd.com, kash@tripleback.net, qemu-devel@nongnu.org, kvm@vger.kernel.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Enable TOPOEXT feature on EPYC CPU. This is required to support hyperthreading on VM guests. Also extend xlevel to 0x8000001E. Signed-off-by: Babu Moger --- target/i386/cpu.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 86fb1a4..2eb26da 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -2554,7 +2554,8 @@ static X86CPUDefinition builtin_x86_defs[] = { .features[FEAT_8000_0001_ECX] = CPUID_EXT3_OSVW | CPUID_EXT3_3DNOWPREFETCH | CPUID_EXT3_MISALIGNSSE | CPUID_EXT3_SSE4A | CPUID_EXT3_ABM | - CPUID_EXT3_CR8LEG | CPUID_EXT3_SVM | CPUID_EXT3_LAHF_LM, + CPUID_EXT3_CR8LEG | CPUID_EXT3_SVM | CPUID_EXT3_LAHF_LM | + CPUID_EXT3_TOPOEXT, .features[FEAT_7_0_EBX] = CPUID_7_0_EBX_FSGSBASE | CPUID_7_0_EBX_BMI1 | CPUID_7_0_EBX_AVX2 | CPUID_7_0_EBX_SMEP | CPUID_7_0_EBX_BMI2 | CPUID_7_0_EBX_RDSEED | @@ -2599,7 +2600,8 @@ static X86CPUDefinition builtin_x86_defs[] = { .features[FEAT_8000_0001_ECX] = CPUID_EXT3_OSVW | CPUID_EXT3_3DNOWPREFETCH | CPUID_EXT3_MISALIGNSSE | CPUID_EXT3_SSE4A | CPUID_EXT3_ABM | - CPUID_EXT3_CR8LEG | CPUID_EXT3_SVM | CPUID_EXT3_LAHF_LM, + CPUID_EXT3_CR8LEG | CPUID_EXT3_SVM | CPUID_EXT3_LAHF_LM | + CPUID_EXT3_TOPOEXT, .features[FEAT_8000_0008_EBX] = CPUID_8000_0008_EBX_IBPB, .features[FEAT_7_0_EBX] = @@ -4667,6 +4669,11 @@ static void x86_cpu_expand_features(X86CPU *cpu, Error **errp) x86_cpu_adjust_level(cpu, &env->cpuid_min_xlevel, 0x8000000A); } + /* TOPOEXT feature requires 0x8000001E */ + if (env->features[FEAT_8000_0001_ECX] & CPUID_EXT3_TOPOEXT) { + x86_cpu_adjust_level(cpu, &env->cpuid_min_xlevel, 0x8000001E); + } + /* SEV requires CPUID[0x8000001F] */ if (sev_enabled()) { x86_cpu_adjust_level(cpu, &env->cpuid_min_xlevel, 0x8000001F); From patchwork Thu Jun 14 01:18:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Moger, Babu" X-Patchwork-Id: 929175 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=amd.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="2JrqEaNe"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 415m4N2HZzz9s01 for ; Thu, 14 Jun 2018 11:19:32 +1000 (AEST) Received: from localhost ([::1]:37616 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTGvC-0001L6-18 for incoming@patchwork.ozlabs.org; Wed, 13 Jun 2018 21:19:30 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48662) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTGuW-0001Hy-0G for qemu-devel@nongnu.org; Wed, 13 Jun 2018 21:18:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fTGuR-0007hx-PZ for qemu-devel@nongnu.org; Wed, 13 Jun 2018 21:18:47 -0400 Received: from mail-eopbgr700076.outbound.protection.outlook.com ([40.107.70.76]:10976 helo=NAM04-SN1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fTGuR-0007gd-Jq for qemu-devel@nongnu.org; Wed, 13 Jun 2018 21:18:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SpehMR4hLm9HTDC8nwZO4BHoUVw4bFQbJ3lmd1YTdM4=; b=2JrqEaNe8/RTqbo/yeCzLP6Vn+gBKf9ptdOCBf2erDz8kdxcQoLiMkxq5dassZnPMbz4g+f+CcuG2g+BmfeVdzUxbJ2rvj4iAb8kr6TJoHFdXZIHPgvEl4yrToJ6M3Lypeybi2Qpt2CDE1/oDoj8mUNCHCKsp0+g1hZQPStDmMY= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Babu.Moger@amd.com; Received: from linux-h3ml.amd.com (165.204.77.1) by SN1PR12MB2480.namprd12.prod.outlook.com (2603:10b6:802:29::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.841.14; Thu, 14 Jun 2018 01:18:41 +0000 From: Babu Moger To: mst@redhat.com, marcel.apfelbaum@gmail.com, pbonzini@redhat.com, rth@twiddle.net, ehabkost@redhat.com, mtosatti@redhat.com Date: Wed, 13 Jun 2018 21:18:24 -0400 Message-Id: <1528939107-17193-4-git-send-email-babu.moger@amd.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1528939107-17193-1-git-send-email-babu.moger@amd.com> References: <1528939107-17193-1-git-send-email-babu.moger@amd.com> MIME-Version: 1.0 X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SN4PR0201CA0064.namprd02.prod.outlook.com (2603:10b6:803:20::26) To SN1PR12MB2480.namprd12.prod.outlook.com (2603:10b6:802:29::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 218601c1-aea4-4eaf-fb2b-08d5d194c429 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(711020)(48565401081)(2017052603328)(7153060)(7193020); SRVR:SN1PR12MB2480; X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB2480; 3:XOmR7gELvM8PvVpbsSv1tT4NM497a4uYDCO6v0nc+BCQlnexfv+wG9IdE8H2SNYIgoJLZz9ETQXi4ODKvLnSpVpO3pxZfCLVuaCj1DCX/ezBW/3tTpYhfFnp0Tb5XSDAVa/aiM0RqyzOsfKYqEvnET6ESsNJ5DohEai1x3v68umJ1Sj4K53262MsMr+PCXnXmfNsc0gUphH74T8S+DtqNcHF3/RVUlDOJGgwfMcqOv7UxMgkE3V+buZLz0/Ttji4; 25:WSjfy04Qz/1AIY8lfG6l2oKc3kTEwz7geynA7rjJLw/kRZscn5s21WtvxX3zlfLV3/XsoDWEZ0aceo6OFYUBb3xvej6YXfGp27qb8WYoSD1wdqY2sQFKwhXYYCdOsDKnvNHqP0A+gZsyhykhiB8uY0jeYBxZBydWOGGFW5ZgG4eilXLhqGfUoCWFJcZE2mrbZ/yN9s+bXIeMERcgLPEKXhbRO1ZbRg4AcaF9gfQ/NeAuXXeCwWq6MiUfMu3x7/9DQft59i2unDFy8D57NOI2Hi5TT1MuJLuPZrIrs6j1nOXrKs1MAN1x4Em8Bo9jIf1t1wtjhh+GukzL+So9/OghTQ==; 31:aMaH/AlgjcV8CCbyg+DkKaGs01wwqVqGXjxazxHKjWEe2YwrzthIeO9yX5rzhIlCgtpVxyqjZDUiBxU0bzW1lM5b13bQSY57vI9WmjjR9bvEjkRM1NjVqtu1tPV1YHUc/ASKyqqhzYR2oYleUtWA+9IeTbxfhsLRwJsIzZqmK7b2jfaj0R6XjT1FCQkQtYoQn3nMFjbO1lCk9An5bYcglf+xAk9JiEzjtBjc0mfudBo= X-MS-TrafficTypeDiagnostic: SN1PR12MB2480: X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB2480; 20:tL0jrYx/9/MOE7WFFgtQDt622tpOM51mtYZ/VZhIQcxRwJODzHx5qCDGBQFAXMXRxyLM5RhMO7LQehFeZ5Q+/azwT/50zzB5VsqixVzAcD0kJr45A1ceEL+9KuYJvZozC+ckNLBUgCcGd86h2+zJcvq6NufnEbxComk9X8I9ZrnmM+lm3s/WABE4rdYwuzR7uI3U8lpegFUJNAHmf36j/a+aPciKkza7VfBRtYFWAJZ18+kCdwtuFovgmSmthPhnn/AEFlI1Iz8/ontuHtweWknVnWIIaT0T7P4AsRbnsIxshWktolDzCwaOofArN+bLfZi9tnp6asf9whf8GQPgo7NTWxl7T9OjtBV1kw0vvhVVf3+xhiMVr0vY5ZFWu62ewB02c3aytxBJRezCyxox2rQAzo87Zki1AcmaDJLPNaEPrplLBzJO657xkjpLsY0WUmAuJXVqbAeg1w0E6PEw4nHnu9pdPhyIQ3buqMJC6caioDqS6La24qJRWWo1MCl4; 4:6OQ9MnI5++x4kq0hH7NChaqHiu0wN8W7BEOTcHoLFtumXLWIqSoQ7IlgGOxh7De7pyNrz7HFyabrPEhyg97A4kpVLys3Ulenzmh1W1D/aNNA3xBpj9mN+2mkLqtQweCkNl2bp3RrByf92CFZ93vIok1wqGLYTnwofZt7NAwYHK23T3mZ/q6G8jPJ3e3jisuJ63mEE7s9rwGP8GmYw21jlnS7SBwGQeUCADzRQm0V8cywBN9uuIxtFhdsr4/ieFYhUG4dL9p7PEVmjFVLK2qVZndxQ6rspsOIb9XfE9d0+ZzQFZylSHoo6fDo5sTbWjEZ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3231254)(944501410)(52105095)(3002001)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:SN1PR12MB2480; BCL:0; PCL:0; RULEID:; SRVR:SN1PR12MB2480; X-Forefront-PRVS: 0703B549E4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(396003)(39860400002)(366004)(376002)(39380400002)(189003)(199004)(68736007)(2906002)(25786009)(52116002)(7696005)(72206003)(51416003)(4720700003)(956004)(6666003)(2616005)(11346002)(44832011)(486006)(53936002)(7416002)(476003)(446003)(76176011)(6486002)(39060400002)(36756003)(478600001)(4326008)(6116002)(5660300001)(7736002)(305945005)(86362001)(8676002)(186003)(97736004)(16586007)(66066001)(3846002)(53416004)(8936002)(16526019)(316002)(386003)(48376002)(26005)(81156014)(81166006)(50466002)(106356001)(50226002)(47776003)(105586002); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR12MB2480; H:linux-h3ml.amd.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN1PR12MB2480; 23:+o/9+KXXtipC5qkf3QIfl0iJJR3YBvkg95/IJhnGN?= KEGe3qHeWzN6qYMJHa1RsX0V/Vt3DzEKRsAwzd1ySuO1WHRn8N9kia/7tpY65V42r0tD8BxttXyFGRqPIQrShYB2ZTrrH6JIbKgvBGTbsMhCUb2zPQWFXrGfJBhWxi6xVEAPo444/PrHfU6MK4sKHsFrxUQdTIh19kjzfCBRNxBGZZnPnxCNIrfIbsGXyTGpYv7M8tjJfXkcYE3K31iUY6A9fHb9ZikT6oyKY5vqL04AyPttSraYuWc+nIJO1i7PNNvld9T5rC6iU5qS6GiHJzVPbUCzMVNM6mFfa9+SxKmwoNs/bjUsKDaDphIGoHkiQXdgWY7Cj/PKNoMq9EtUBhTl8M3g/YosUTJGvpTEzaZjQu/B/CWomrElZZiEm9VFjQtnmkvau3ikzpdBxuqxMsz11CVp9chsInd6FMYroCI3iwkDbWaHmbWd2DBzluvMUgVjvXu0NCfCBr2CWx25w3zP1//1tTJYiaX4FbHjwCPxwbwZPcZvq/ls3rVPFILQlkE5y1oY0WsEsl4UiHmhIW9l8sHQi1Qiw6fWRQYVV34KMg43HwE0uTySpaH9WF4PXh5CDxp0C5IGGejY38KPNWRVIp8uryYM23hZtVAoV0UOTC5aTo+ei6Y6EaIIq5MzqgY8DMEkiNDfEGDg8YUmK+cwPeDpTOKj2uJfT9g/V/XR5ch+1H2O7pI+SaM8NKwLlX38eaMgpKkROZBH0eet1wAuIjikDDF1tr/OtiHZa/HvT6c2N8BahqnFLIBKvaLtNBR7EBpiXCT6zOIyJKhkNzEBOTjw5drjYEq0uT+uMGqCK6+jjvvwueAr/e4erxuqHqszpos9zTGpR6ODyeaqEJGCg1M85WtqhU9gK920QxGYfzSK7F+ZmalEuI+bGJgrhnm+gujUD2Ve9//QVcpCFqxaBpDSrHwTF0Zx13C8yklkeVVJI78r79IH9oz8oiEcKbq+bSkxgQZGdcxVTcEm4G4A4gqzm9dieHBbIc00rIOQcvnu+rT7g1aF0MtMPgBtPXiJIddOYPsKRuGmQUlZiXyo/uOgQrt2wO1zM+S2VNJeuYQpfdxdSL7b+S8lih2RUOc05rvVLXoXebuPheEBX4ZDKfdVEKhDn98K6qwJ9ZXcZWjKCgAFM+WpVEqaV1M+W7m63mOWxLSTw2GxoT2RemY67K9GM66USWv8J59ywcncqZ5ZGwOb5o2j2OYASrH7rY0f779ZsL9xJlUjdreJxqW X-Microsoft-Antispam-Message-Info: EpCBpyCqd8FDbF4HDIs6a/yKRHlCDZUKVPNygpkvLZHvm2sPWcS8l8UpfTU4zbsUpRzPGPvT3fZ8sikPp510llLWqFvbavtehfuEbhDYdyiK4CJWYrV+tGnA6PKuVLf/wUv3cIemIZNKhjF/Za2DTb5NjhvQ6aSA/k3Lfy1r5LBPOGGsNViskjBfxfVOpCnV X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB2480; 6:CVOwEieVxDbXj3IoWeNPFuTQdziKie118vh4oqmanERPmRyHx6BbhfXMwOMibXrfGv3ApRspxKjjtg0LOXUodjokOHD3w8DzLwck0w3tQ4IjPXD+8ytb/zC1bQlTrb/wsKYhc078+hoMepN87BZq//ywJY29U1PsITfTWf/lhA34fu3MObCYcyP7lnKaEQbhm4OFLDH/F68krwE+26TVcoH1lmuAm/szrhePqO18Tpdc0iipClh8cYpOOQiHSHtafehODj8NEEP4L1FV6M+iaAhM039h6mR5DZySEcWVeCYMZQ14S8v3B1lfR4wRnyymUoGuEHfr5LKXMhGY/7yt2I9TkV48oC6Pv5ijc0f6SZj/avX2A47a/1sCYbnRaLFpWRBMYE5tb+INAdNLCpUTCqpwAfkrZBU2sOqhJ7F/k3o7JzI/v/EXCpI7KWIZzscWvODBAyGX1abHPvURAwwFoQ==; 5:/3GEZd+t3UvFecR740cZDzaM8EROqpwSTpJU4regjAs97xK2NRO4O3hK1azHsLnZkfYWmYCVj1ixnRotoQf2gcy6ZQd5n3ZBHU2N5GmFbyCr+d5ch594lgrAOSu7PwICsTqi6brVvNT/NXaA4bUa2sDwcOESBxc1R96oUBXNjqw=; 24:HY/weDl6SuSf5Ch7NzNvlLmn6npID4q9A9EU7Z3wKif5vPDOHoKCBbKy8+d4MffU+MHmwC3bACc0FSRKsrjtrw5zzPbYme6Lu1d9fVhkDqA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB2480; 7:Dsunz8wzULe6yi4p05c9rp3nzmSQ0pDfwVVuO66UqoXrRBcGe/gZsPZ5Et0u/oLHkeo+PJx0a37VasxfyYdANbjRelFh7qRq9KqTuY24aeko8vdAB6Px762HcJ2EnEjnejU9wDGL72f3AF1vshv6jidGjPLFdjHN42Bq76M+a1q3Z2tE+otGxEqhzXQJNbuhxhLhPHLnhjirrg4P1AsKmpgykgEDqcmOZc1cWxph3nnFH04f87RBsLDMBWtwl2ec; 20:0bz2YIW7p6eGHcPLE0HaQy15fhT8gSyE7zxkP6CZLfYdDBKLRY+XJXKV9cRpcqeJkNrPYyT7dzl5J284mzKrB+A5k1TQoQrag4emJpo9wlb7SrG7MzpOdrpjMJQMmgwsIFwa+yLHwJHoDxv9QJ45tvQOvxyQxUHwBjSHB0ToaxItMY43f6789hmkncOBdWY7l5ZYV14u5YQwS2kzOxDgqjf27gu49jQIkRtxhUDnYBBBtwWCiZ0HMd9FCrNiKsQz X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2018 01:18:41.5881 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 218601c1-aea4-4eaf-fb2b-08d5d194c429 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB2480 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 40.107.70.76 Subject: [Qemu-devel] [PATCH v14 3/6] i386: Disable TOPOEXT feature on pc-2.12 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: geoff@hostfission.com, babu.moger@amd.com, kash@tripleback.net, qemu-devel@nongnu.org, kvm@vger.kernel.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Disable TOPOEXT feature for older machines. Signed-off-by: Babu Moger --- include/hw/i386/pc.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index 04d1f8c..ecccf6b 100644 --- a/include/hw/i386/pc.h +++ b/include/hw/i386/pc.h @@ -303,6 +303,10 @@ bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *); .driver = TYPE_X86_CPU,\ .property = "legacy-cache",\ .value = "on",\ + },{\ + .driver = TYPE_X86_CPU,\ + .property = "topoext",\ + .value = "off",\ }, #define PC_COMPAT_2_11 \ From patchwork Thu Jun 14 01:18:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Moger, Babu" X-Patchwork-Id: 929181 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=amd.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="fSn44RIj"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 415m9h2CPqz9s1B for ; Thu, 14 Jun 2018 11:24:08 +1000 (AEST) Received: from localhost ([::1]:37641 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTGze-00056x-0m for incoming@patchwork.ozlabs.org; Wed, 13 Jun 2018 21:24:06 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48685) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTGuX-0001Ij-72 for qemu-devel@nongnu.org; Wed, 13 Jun 2018 21:18:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fTGuS-0007jB-RE for qemu-devel@nongnu.org; Wed, 13 Jun 2018 21:18:49 -0400 Received: from mail-eopbgr700047.outbound.protection.outlook.com ([40.107.70.47]:33423 helo=NAM04-SN1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fTGuS-0007i9-K2 for qemu-devel@nongnu.org; Wed, 13 Jun 2018 21:18:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y/5JOaCMYSWv1HmhXTlTHfgPS/XC9dLqzT4mNsbqOm0=; b=fSn44RIjobhOg8jw0sjLMx8JLic4Jnhvkc2NXpAQT+J6DEWmtelik/zyyCSuWqdKYcCFIhQ+bZIRSdkcvGiG2QmsbjlORa685UQG5pd9z3KXrJcpMy7wajcLTYfNEZYJIzH/q7i6ZeyBwwxeBDRLKKcImut2qGT4AFWhPPlAG9Q= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Babu.Moger@amd.com; Received: from linux-h3ml.amd.com (165.204.77.1) by SN1PR12MB2480.namprd12.prod.outlook.com (2603:10b6:802:29::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.841.14; Thu, 14 Jun 2018 01:18:42 +0000 From: Babu Moger To: mst@redhat.com, marcel.apfelbaum@gmail.com, pbonzini@redhat.com, rth@twiddle.net, ehabkost@redhat.com, mtosatti@redhat.com Date: Wed, 13 Jun 2018 21:18:25 -0400 Message-Id: <1528939107-17193-5-git-send-email-babu.moger@amd.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1528939107-17193-1-git-send-email-babu.moger@amd.com> References: <1528939107-17193-1-git-send-email-babu.moger@amd.com> MIME-Version: 1.0 X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SN4PR0201CA0064.namprd02.prod.outlook.com (2603:10b6:803:20::26) To SN1PR12MB2480.namprd12.prod.outlook.com (2603:10b6:802:29::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 001475be-111a-4810-c99d-08d5d194c48a X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(711020)(48565401081)(2017052603328)(7153060)(7193020); SRVR:SN1PR12MB2480; X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB2480; 3:+lN7DGKXfrWXKf0S9Nwm/1UDzj8GsBAKRgno+4aT/QC2jP77MQ0ardSGxjorhSl0J8nH/EuDbqO8huhxJIV3Udiy9mMi5l1d/rqnj3VOWbpv4QDagP+Qb3VY2Lbg7RQH++xZQ91BvGSEiGz8GS4xrNlRLDSdOow9hCgqKMux0KFyvSXSv2ORREu8CWucXERQ8Nsr7TWcdHEunk7vilQScQ+EUpYFyjTHj3CrFvMr43TS5wZOzzqTSt1e5dsGBJVM; 25:8lGMXhGc7UwGTIxObHgaAGvyiACNnxcqZrnRwoOkZ0KPIPe+cP3s/chSGIElPuqCzeGWBOfdpI6JOodTHUHDQZjLY5cgsnD0+6+e09xpMcdHnzI40qjzhHzfSdHeLnwgP1hsfinpHTiSb35y3378x0PW9zikdJFrRinzOdVUJgLarEzI0mF1lWG14TkR8lAmzJ57kxhxDgXgp+QcjplWvWkS6mcicpbzT8TZMZuRuhjCJg+mVFw9GQ9SWvIp2jOpJawQPfBl1NkFaBvB2uN0pkqtFJbF/QciLRnFGplGtdH6vOdHIF0U/DNY4lQ6z5mTTj5uuX2XLTbwDTU05QeSEA==; 31:UX1MuvGhflZpQSaUC+o0GwjwXAFqXobJLObwxoTTYvxxp4ivqizbsRuOz0ty9PZvmcP3SfKdfgCCx2rC4evEZR9bjdhgDSOv8cnB1p7Wniqv+PiQQjaa2Nw8Hb+X5FhhsfAQrtKCQ9GU3Siyq9hWO4K3BoiBOTDwbcx/fO3bRuv51TpzvtQ5itAUjIeHJXL5HAearXsuFlSF7Zc+bSqvgZCGDMVZrLt7ezHQa5af+xI= X-MS-TrafficTypeDiagnostic: SN1PR12MB2480: X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB2480; 20:xRF6XwUrQAvom7fku4ZscTDtvN/AkgsHR27XW0Ddb5dU8mT6QTw1PMvmFqqH/zYrJ91WGXwibJgC33NPflpgIubjVg3xCBAnn2JesbHawy9rH0KyTu722j2/hcvvkwyxcgdwiJ1MKIMHcLSCZ3vMbGJ51KZpZIu/al6ZcN/x69RHjbJHU3jeP6xavVqR6gP7eoglPIPCtoLxMnnfA4+Le1xulbqk7o5NlYevN+1ezBnq5Bqwdvxg+gKLfDrDVbgZmnpcPcSN/LdeMkSjtVkC9XaeRfp4Hz64cHQRXLVjVyaW0rk6E2a0ymOgPUbR4eciosSkM3x9a7i8RAg1PyrYjse7JZSkZiyLyNvWCF7WNDLozxQG8+UMBe0vdKcxrcHrLpkZAAMmzW/pV8fq+paRgAFho0ELu//hr77Ge5HoMj2BiBEFeHz3Ib1sEDwRndeJkbfHGdlLz1Vj767xhTgmmP00jyeeLL+X/9vwlxE2W4TGfSl6ybVOGpqhFzydT+KQ; 4:DED5Y5qgZRp0qmFsmjiZvZhLEHnDocAyFhvTB7+et02I6z2aoKHOKzr4OSn+PmCcYGqlJA5h6I7Lu5qjAfHH9WRkrl0PAVfZbppm7UBiMLEIMgMxpe0YuuYxDcImTOjDPvUUGsgOoji3wTpSJJ+xLP+bfY8ZR7D14+uBOCjbwRB+MdJETnVGCJvFpV51z+vFv6CeZ6fzvBJSTu9Uej5hN1taKPj8BFLW1Cf2SZGRtMCwcmjFh6sWowJSaCqOYWH/9lYC9kejY33ejCE9XIUhwjOnVtgPSZS8NpRwd7SsiZW3JJu5Q5VyFyIR2RQ/HVQS X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3231254)(944501410)(52105095)(3002001)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:SN1PR12MB2480; BCL:0; PCL:0; RULEID:; SRVR:SN1PR12MB2480; X-Forefront-PRVS: 0703B549E4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(396003)(39860400002)(366004)(376002)(39380400002)(189003)(199004)(68736007)(2906002)(25786009)(52116002)(7696005)(72206003)(51416003)(4720700003)(956004)(6666003)(2616005)(11346002)(44832011)(486006)(53936002)(7416002)(476003)(446003)(76176011)(6486002)(39060400002)(36756003)(478600001)(4326008)(6116002)(5660300001)(7736002)(305945005)(86362001)(8676002)(186003)(97736004)(16586007)(66066001)(3846002)(53416004)(8936002)(16526019)(316002)(386003)(48376002)(26005)(81156014)(81166006)(59450400001)(50466002)(106356001)(50226002)(47776003)(105586002); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR12MB2480; H:linux-h3ml.amd.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN1PR12MB2480; 23:A8TmdIETO+8ywlif1GmYWV2WwEtQqWAG8SkE+jjAy?= 2XvRZ4G5oC3amT9AOo+JIivVsT2Pv1KZk4KZLbmJSZrruezxAuSLvKR2tlhQxKWyK1WjWyxYAmcbvdcnDdcYGqle9NOzadzRbR6vOxSJp2GvohsFIyVYLKsStaJDTC6/xRHSC8hTIIeH2RanDNfSK3YNFAqjCXthIBQgIHaevGZFgii8BtmDuRKgsMUqDt3inNAh7FEgTMTuhwlWvizLRJiOjK4oFBrKzM9LEqeAQFQZHym9S9GDMFztOSWUyiP0vQt7c8wax1iPlwM3qwKud6kr0XNmeNjU2kgYteNSWxhl1kSVbY/JpIVg77NDns6xcK1sCgvzB8+2e4UIJ6Wjg/ElQ8gLCC9kzgNB4xNBhhcKmlg4bSN4hxeSZMsJScaoANTAQQQlvzQPlMo00CPZ7HQGqEQ+G5MiZ7+MKQumx8blOs6IPORpChJa/3e1WbdcNbbbWFNGGbSFh3OfyJCBjdthWLVLw+hdXGZobqH0YGHgxEuzSt8+ThNPA9Jv9kyf4zSjwwDeXDBv5ld1+ZebdJDd2vzyTIOu/F1SqwygxthXGa8nr5JyrucEIh0N0Xl6likI7TQWUVVzfEXM+EVxLFNw4BmlmaeCe/zx1V8nXDRAlYRo/afMFOUlT0sh8mHctJjNud5W5ypMlOtAC9ZtczHSLJRjFdDUt+6iyGhRBpTuTbcyXd7bAuaqoO62hVAtKctdbQ66WFBDf6z3FV6jotQ/y11B55WMMZ0qR4OvLwUBOgX2GvmRShCgtB3vcPf70xWnC7ZfDaYTFNN7qU3cxGLV+vd/CgTjRktf5BStu5lKvOMlLMo8oKaVtTD/Q17Z4CRbL10JA3TxCmBaFChSAiHxzsTQzm/zQLgv2o82XOiDn4+VukGBxXLeQd8rHPNt3UNnSXiaOsUTCN8PzDMl6aVfrQX9fj9VLjaQ2Aa7R3x1MysJyN/qD0vywfMu3xkjIDfxvirbzV9456uuYuprPcLaorqi3m2WTKYE/CA6oldrL8wx3HLZ20yqBFhl8Rh9uXNKHs9SEIdx6/cmGscuoxWghOyyLPNi2Ji9TOYjVYjLIuoJeI9Buceup2NYgyjSncM0ITl2CWfGVrSyPo78FAgyNi1w+7qz7Ugl2N2aljKHfAkl0QgHlRZ7i/YLFCd6ljsY8G2fh3dyJsAMTNa3nFZ9K2q8jW2XQNCeJP70C27BYPCR/8UtO2umM4njqb9gDoa/1Glzfq4pO/KFxNrGbJ79NCMigG4Pfp3h4bPtBmBp2NxAwm+iUGNH9HU/GX80Wc= X-Microsoft-Antispam-Message-Info: iooKsFDGaZp1SGR2LGKb5AGKBDdL8NLl/u7AwOfDl6FBEF8MIZuI+0jciD0fOhEVrUsULmSvlrBBMSdjUmqQTQCroQw+rpwQXlc1WXDz3htVB4WI5TvASmkR3Losyp215Qk7oPrySsYfV7VljEFfUFCsT1bSrISyoTwe8K/rnODjyZtGEeU5RaleiW+eHeHC X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB2480; 6:LumyG4pveI5N9Ota2mfg3K8JNfoRRFvAdjSM0P+6DrHtx0d4fP+26D4XiRInLLDhlf/3s6sw5Ikw2Aov6z7IMgojcyvBHNgZUPD9USZNaxpkY4UbC88V7vW7ZWNgIrxDzwslp7l8FB/jvuCBCwbHkk2YSQk0hPDoLyQZ/eYw56o9AXlUCPFpM7TR3BLuw7klBg5Zt8PhHLZmg8f/xCxE519PNBilXV0rx9/f8V9w7dZBM6Lk5hEW816bBtu/Sr+q3v4Xu5FEHnREpPob7xeC1jd6LyPe/+xEor4LV2YSplv0itvuX9WisoKRt0syHr0gTeag79YgGq7o89hJxBhpSJCiDs3a6heTJM0kWkObFtrNvzULs2lRoR0bdPu+O3krkTZKRMqqcCfAgUYeTMztdtu434OOifdEgyPhsp0KS16m314HbTVBHPEUwdpLPsUW2tRieHfBx815/4twzCzvWQ==; 5:wv68EDvemxgoZLxEK7MPdWht+VgVthIZU0Et4ydSmgNq2up18jEFa0Uyt7OeMugTYkhuCHdCOBeffQ5RhvlNCyW55HslCw5fdMszAEYf0IXeCHObwRoc6IFfosgnu8XQaEIOGSK8SvmBE/rD/ZKVgD+cBjLUsClg1eNS9CeScNA=; 24:hldBzl9xggSvau+7v5tb9G60kJJBG/uGzhYWNZvoyZSrI4DrmfSp4youaM9r6MwmSr7YGbdy+yMlgGhWDcqDplcy/W9Q1fbLkX3A62gU+NY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB2480; 7:UDZbmmKcT+ckKL6u51Io/7nCNuJu1Gsqg65ENdbiKSo8+uWNzxVHI9BT85dqrnFH+vDG8mZBDHJTF2rM4X7W2wHy80bAhbYZ0E9NpKUjTyEsonJJmfpD2W3F/kVvCXjYAeAaiV9zZuBHQ+d+sWe5A+kvrr1ZNfnaiyw/YbZ1KH9eTJjRqCw4dkPc2BRCC3aiYzHz/+pgc41/LPBBHJ8Zpd6YYM4ifAInp24P+0qtsrfihPxJXyJh3kU2o30uIb1i; 20:DjrEBkOkKydIIBOFOMxwu5ybIIVWKAaORhMugCYdtZvZF9R1ssP5t/di/POtwH087PONVWEBy4IXegCk+T26omW6CCDJ7W7s6sFAhO0MDgMzVXGitiwExUO6Pdy52ymU7w2DSP64w3BVCR/Pt/d8vrZwjYFOgoKtuy1RClGbNdWV+x/O1bilY+hnt+adOIMVyWZC+KXfXs+xy2hUcCVZHS3uDbC2cPFr9d/1ebh/UtwGdxoFotY17pEThJf5SmX1 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2018 01:18:42.2225 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 001475be-111a-4810-c99d-08d5d194c48a X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB2480 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 40.107.70.47 Subject: [Qemu-devel] [PATCH v14 4/6] cpus: Add new function topology_supports_topoext X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: geoff@hostfission.com, babu.moger@amd.com, kash@tripleback.net, qemu-devel@nongnu.org, kvm@vger.kernel.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Add new function topology_supports_topoext to verify if we can support topoext feature. Will be used to enable/disable topoext feature. Signed-off-by: Babu Moger --- accel/tcg/user-exec-stub.c | 5 +++++ cpus.c | 13 +++++++++++++ include/qom/cpu.h | 9 +++++++++ 3 files changed, 27 insertions(+) diff --git a/accel/tcg/user-exec-stub.c b/accel/tcg/user-exec-stub.c index dbcf1ad..715818a 100644 --- a/accel/tcg/user-exec-stub.c +++ b/accel/tcg/user-exec-stub.c @@ -11,6 +11,11 @@ void qemu_init_vcpu(CPUState *cpu) { } +int topology_supports_topoext(int max_cores, int max_threads) +{ + return true; +} + /* User mode emulation does not support record/replay yet. */ bool replay_exception(void) diff --git a/cpus.c b/cpus.c index d1f1629..17f6f4c 100644 --- a/cpus.c +++ b/cpus.c @@ -1979,6 +1979,19 @@ static void qemu_dummy_start_vcpu(CPUState *cpu) QEMU_THREAD_JOINABLE); } +/* + * Check if we can support topoext feature with this topology + * Fail if number of cores are beyond the supported cores + * or number of threads are more than supported threads + */ +int topology_supports_topoext(int max_cores, int max_threads) +{ + if ((smp_cores > max_cores) || (smp_threads > max_threads)) { + return false; + } + return true; +} + void qemu_init_vcpu(CPUState *cpu) { cpu->nr_cores = smp_cores; diff --git a/include/qom/cpu.h b/include/qom/cpu.h index 9d3afc6..4ac4d49 100644 --- a/include/qom/cpu.h +++ b/include/qom/cpu.h @@ -1004,6 +1004,15 @@ void end_exclusive(void); */ void qemu_init_vcpu(CPUState *cpu); +/** + * topology_supports_topoext: + * @max_cores: Max cores topoext feature can support + * @max_threads: Max threads topoext feature can support + * + * Return true if topology can be supported else return false + */ +int topology_supports_topoext(int max_cores, int max_threads); + #define SSTEP_ENABLE 0x1 /* Enable simulated HW single stepping */ #define SSTEP_NOIRQ 0x2 /* Do not use IRQ while single stepping */ #define SSTEP_NOTIMER 0x4 /* Do not Timers while single stepping */ From patchwork Thu Jun 14 01:18:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Moger, Babu" X-Patchwork-Id: 929179 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=amd.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="2V64H/NW"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 415m7w0tlHz9s01 for ; Thu, 14 Jun 2018 11:22:36 +1000 (AEST) Received: from localhost ([::1]:37634 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTGy9-0003pA-OW for incoming@patchwork.ozlabs.org; Wed, 13 Jun 2018 21:22:33 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48687) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTGuX-0001J1-Li for qemu-devel@nongnu.org; Wed, 13 Jun 2018 21:18:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fTGuT-0007jN-2I for qemu-devel@nongnu.org; Wed, 13 Jun 2018 21:18:49 -0400 Received: from mail-eopbgr700047.outbound.protection.outlook.com ([40.107.70.47]:33423 helo=NAM04-SN1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fTGuS-0007i9-SX for qemu-devel@nongnu.org; Wed, 13 Jun 2018 21:18:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9E8/YRt/9YGlin+m/uolgAivQ0cfwIQjJEUKLxVi0dU=; b=2V64H/NWEgsPd+2m2uGNsrbbvFy92TXDcQ0T7fVqzHlZJJoVX2ugP8AY8B6pQ4by+NU3tk4yD3HG8fEFO6OF6is0lLbKoE5dkBsN2xaFTAuYMU2IvuwxhCiqRRYw1EXo4CFXCmnsJx4FV9G50WGCNCL4aL2PhVAl294Kv3YBppg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Babu.Moger@amd.com; Received: from linux-h3ml.amd.com (165.204.77.1) by SN1PR12MB2480.namprd12.prod.outlook.com (2603:10b6:802:29::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.841.14; Thu, 14 Jun 2018 01:18:42 +0000 From: Babu Moger To: mst@redhat.com, marcel.apfelbaum@gmail.com, pbonzini@redhat.com, rth@twiddle.net, ehabkost@redhat.com, mtosatti@redhat.com Date: Wed, 13 Jun 2018 21:18:26 -0400 Message-Id: <1528939107-17193-6-git-send-email-babu.moger@amd.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1528939107-17193-1-git-send-email-babu.moger@amd.com> References: <1528939107-17193-1-git-send-email-babu.moger@amd.com> MIME-Version: 1.0 X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SN4PR0201CA0064.namprd02.prod.outlook.com (2603:10b6:803:20::26) To SN1PR12MB2480.namprd12.prod.outlook.com (2603:10b6:802:29::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1265e11a-35f2-4dfd-73e0-08d5d194c508 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(711020)(48565401081)(2017052603328)(7153060)(7193020); SRVR:SN1PR12MB2480; X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB2480; 3:9SZnm5CrggySOtIyYIk0sdwcC8To9oCBLWvcEoscKeJkbmcI9N8ZWC8ulMj5joK5FhDNW7GkcGevffsg5i31PdImSz49z3SbH7n0iBkXkklY2ngbPrf9++Yl5HYV0AmYRSoUC3mpe7Di5xGxe9Uc/4yELqtAYdM+P+xGtD+H4V4gV0aJEpGg/i4kmqLY7U6D6ckv2GLX+TofP3LfqmqSXz94h9YcRXMVLMEMmTFKQ7BP4cKYghu6sqNc3jVzwWUr; 25:gCHE1r8WiDdEmruFkNKXA2esHSzYx/gK5CvthgOKdOrnWGZjMEfRkbN1Wk7LwrCcJxBID4Q1tMljEVBazp+PzQE2umggjElkJQfCoyOa8jtJZEtqsvL+1ggdnA5+og+Xl6MxsstXWHBQ41gk2cBl+lWMc7KpM5Tvr3mjTWOzlYVtV0WghDo9ZPgW3k85zg20JZbDkzIhbV1BgkwxClFvWcMnHUu4RT5EpBMVe+slJ5VELILyrNizVM0fJ0gUqJ+7wtctAyq8SAP9cb9PwZ6tsCmJ1OFcSJhQtS4sGT1Ef7indipr4VSOyRG2txbOQU7W+S1yYS5HYLJgeZH1kpQMEg==; 31:Orh3w/YJjiJ76liF0dWe+tog1nDSkBF8XGjNS07GpvDoJ6TX8OXSZsrEdE9itfRNVpvuqfUVH68t+GIQrMJ813cOpIqnFm98oJGLNjT5wf5OQ1giuamsDTdNoX7A7Jtc1WfAhawlqvFPbC6RjFtDw3BQK4F/vMV5+xbrQCPWwIWTjVgva3+IyzSbCz4AsANhSgJ5nsaZjbvTimWr8yXKnxgZCRm7LOmbwNvSR2a/3As= X-MS-TrafficTypeDiagnostic: SN1PR12MB2480: X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB2480; 20:fQzOhSEALDmiwHBfwwzBi3SjMSAqlWV5drIZsTS21NuhhajkCRrS7wnc/CUT+ljT85PF7gBlJIQZcRhG4NLmzoxsEj4XwyIZKaz2ji0VQpXgARum0ucVvjhjbVNynXPzCkQNSvUB5BgBaveIpcHT2P40e+RRqP3Ob7LPEBoAAwHQRMwzIeM094V/VNlEsbYMoBkYVOgpSNBSvuIMI53BgVteMS/TIv87Sk1iT4JORx+8timOC+yIN0QfEzbHD7e+hxUI9QjYFbw1Xa8vbgnZagGZSgAcha6tBdCKiGLpdyiSli6p0WSTJAvGtr4Aj0JxCKuP+ahkA157+OauG5U5Z94cf3plzjYu4CT/nm14TkIjQNst+6OeHY5gebhO7f2g+EeuJY/0XOPYbZtlf/c1pMr5ozdy73KP11+0Yi0qxgqQSS3iTrcB6kEws2Aznma4BmV5rMrVivB0zycavDavEojbfyESqJiK8yciLgq2rYgmmUggCuerbed/CzZTiEMl; 4:yiM5mFzH9ideF/WFHAwz1O2UCoKzQUOe3fQ6dvACedbJvmYa29HrmcRExP1k0eYQ+/2D45ftLzFFHo5v3wsWhUORKgNRSe+Q6Mh4EZyfBBl3T5rVSfznVqK/Fp9pepXbefp5UeaFA6wkXUPOLZLCXFSkrs2rzzFCWx2VMvWHlQpoeIT+VtDsKZ0RkRSvaaXv2e1gD3Mlt86/1zppxeHTIaneADtwQjNeYnhWz0Fr11NbSc2FlhhmT2ja7p1xlM9GXg3Cghg07bQk6dfQpmsOxKZW96wdJ3XUNv/pqjvcnfE+8sS/W8WpKONDOqRY/b5H X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3231254)(944501410)(52105095)(3002001)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:SN1PR12MB2480; BCL:0; PCL:0; RULEID:; SRVR:SN1PR12MB2480; X-Forefront-PRVS: 0703B549E4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(396003)(39860400002)(366004)(376002)(39380400002)(189003)(199004)(68736007)(2906002)(25786009)(52116002)(7696005)(72206003)(51416003)(4720700003)(956004)(6666003)(2616005)(11346002)(44832011)(486006)(53936002)(7416002)(476003)(446003)(76176011)(6486002)(39060400002)(36756003)(478600001)(4326008)(6116002)(5660300001)(7736002)(305945005)(86362001)(8676002)(186003)(97736004)(16586007)(66066001)(3846002)(53416004)(8936002)(16526019)(316002)(386003)(48376002)(26005)(81156014)(81166006)(59450400001)(50466002)(106356001)(50226002)(47776003)(105586002); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR12MB2480; H:linux-h3ml.amd.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN1PR12MB2480; 23:1Nx9AgS8Mnbk5yEjOefDt7043/PHi/n6Dp3L8yVu7?= JlFKyqt49tW6xeKlwhFojDQFlRpcGUShX0rQ3HWssIPu5T2XPSiuCbEoAzH2WxPFQBkEkCfHKi8Ptp++1QefTOPFqU+MFhct9TyLhWXI0n8LUUNIj6swCI3+TAwqZqcLD+auJlioJ2OUOAi0qDQEEgNlu8CYh0F/ss8QVNocbWWmanXjPq+OYYPQ7AvqPFOXcyQ39X1ZPPfZX7COAELTIUUlotv7ll/JK58VwLG469gfvLl/5zDB/ufbaz4ES9/cM1rOgjXL6jIb7JcXqqyIjaGi0UJKNn1fqW88VUwSD4pVpwk2vkg6Fq/Tmq7RVXw0nnp9De6MpFOmOYHoa9ZLuBm+bcTrihQAL5kLAoNBHob4/Bcj1af+wY3GwONkB+YyDjluROJ8A+lIbWkb/saPTM4TN2qgGMMPEQkKdYtalSuVqUnNyYSzLaqmAO0Q6aAnWVvUEixTXdak+Piuru4QFgX01LdCDzqjOv7y4bxiKNXafV2A+OZMhEgXABMwaZ+VzeVueJCj6DYFOetAd0eDHySu6GUHsQDfNxMnfRZIHkzCaUsMTCyNbZkmaiDGXG1QPuwq1k5OpuU7hPHrV2qZLFkQ6YTKWasOSHu3JybrBs22HZrBsGUlFVMtd5m6YFTv+iHuNj1GiJE2eMwpe4yRZymAsi62Qs1GouL0YYkaOWGiHxteqm87vq/+8ZK7C2C+d/nlctPh9qjga/xrd1Ntx1Gs/p0/7I/fOZqPv8tUhZDp5un2itS7eBiNEoVA6vhBouEtNBu4RQfLzMmWWGFzOXLrUZv342HVe8wcoqDdAdAb3uQNhGP7Jvwrhy/G+eg8iZUOyu00Ii5PmfZuAb7Eui3om10pwvYu1N4GcS+1oXFfSjXW0sjFGg6p9R3KVdMzkm/LeGPXid53wRXJYClyHZUAxefwKJOB2EbJ/Xtd1PimxCQSzu3bAj0u0td1EzIW5uflPghSyr5kndTNIb4HBHjlLTB30DVzwDpC+XLe6ibkZZ42kPungcWw3/cDhli0Nuqy3bT9zgNv8BLLaLT6h5C22w4f1u1j803pJVSks3Z/HMfbcoyMP2vEoJEhkfKF6RbyCJ5zv0pC8ZWDBgrdjkRYED6xl7WCL+AmZS/wQM7Xb0UFw42lTkHjgPpL6FoaXW93QXKFKR2nWPNLlIdZaQvWk/6VjWN2TtMB6udREuX4+ikFUbYbdmMtpAW5/FuN+se5sTWB7ygKHwrWwPpoL3raLDdk++C4twRHei2dbfL9nxKf2RmsMi/wEdZSlcbw10= X-Microsoft-Antispam-Message-Info: pqzUu5wJStfY/Rq40iBRgF9bAnDuQUtpLOBUcBvR/RuQZK3pvU6Sr/TbnwcXQcv6idrPBCDKQnuD1wJ7mTmyavDebyyXAK2dfNrftYXu/2+zWLlGIm0XME2rqjcjTnekI0J2Shg30NbZi3F7a5n9KHMx73gTXjB2rNkJvW+UTLIYy95aIUK60r31tTlyzlyh X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB2480; 6:5TRuLSggi8a8SVSU5ov8db38N2FtSwqsQxr/E64+sdCrN8CuOUI6PxKdjhtOZWV4KlsErccOPEemO4gRL7AWkr/VAj5cjKYme+ZnXktDvUOZE8l2n72kjRmdcPlquRx2HimKZL32gX++R2qN9A9b6kd0OuLodcXf5cdE9ZF61MDBjiGCZh2qNNJI19T49VO86EouFy3HwN0ZkNULoEOtyG0uP+QIz3j8ZtQt+tZnBjhyIXEEMbhj58mWHzy6lxijinO6NgD7Dk74loM+7X2bqwJ1UR5sPnUZ6PyOuWw/ssHXzw3L0LCu/wHuk6bSg5VjKbL+Tq+WTuxpxoBvRWD3N73bTO1PYQxZEu+cpavC6oy0c9ZcJ4qa719usmkuqvDzW956+TwP6FNXxfub+OgyBBweZ6csB730AcH6FW2C27zAaPcR70YSri9mGZW1MxNLtMGH3NSQJOudfAgtMXSBAA==; 5:kstr/iSyVAuII10hdzMdMVdznz7uqIT6XZWSdwyY7T4bNKe+dxCqjfDwFhZhIc/E4umKqgkeeRPt3L0ZjS0QrHJ0BZ7C5MQ0c2NXtKqYzh6p+I/rSorkuTgp4f566tg1+CRArxdlqv87PAcIpYJt5PfgM3WdZ9kO/CAaIhLgQqk=; 24:utaz3NXXiFEO6H0PwzzimYcUK27zB5xsHgKWMID1JyIApt8jP/Tb27TIa7In5Y25/AyA/8NDPkt2+5xHLSVxhKZ/fhYiPmRJJl9XTp1ih9k= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB2480; 7:+rgxhGZ8WG5eab3jaHVinT4Z0VWff6GECm0L/EKGXBtASTEkxvbZsj6QDwKQ3LJxzZC2fX1q6qYcVTVxUTu2DoU7Kn70qXffRYp+9JSuKe3PJ92sSPkfJeIthjlhybejf94bs02ih/Ty6xE8DxtRmgU0bucCFFdhFoFd1oYJN7BUKXDVxoqRadLuxkiGn/DNAfm5mmE0Wdx+y5lskSkd5lKHqPOBYta9EsSAdamXRB9Qk1LTFJB8ts0kAFm1psw+; 20:kMR2wj2jmL6xz9sS/B8zGkvidiG+TDUhObyMXvo9WRVl8ejDJ+5zyB1VrEgEFF5qavNwNl0rcl3rBTQRB8HKLeP8dhfpcTr29Y2EKhM7HDTNSX6NPgdx+sBhUzqvn1Wb+hXlUMhDpNIVNlIUnyDzEciFXvg6r6QIKPyjJYlwE/yK+c1TMBSRZCJFPJHsP5gK3laSLyi13GAVptqdkiV8foj3/OUwf+iCQBDqmhlTXbWEPrQC9bnrkFRMhODbW9Av X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2018 01:18:42.8340 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1265e11a-35f2-4dfd-73e0-08d5d194c508 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB2480 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 40.107.70.47 Subject: [Qemu-devel] [PATCH v14 5/6] i386: Disable TOPOEXT feature if it cannot be supported X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: geoff@hostfission.com, babu.moger@amd.com, kash@tripleback.net, qemu-devel@nongnu.org, kvm@vger.kernel.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Disable the TOPOEXT feature if it cannot be supported. We cannot support this feature with more than 2 nr_threads or more than 32 cores in a socket. Signed-off-by: Babu Moger --- target/i386/cpu.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 2eb26da..637d8eb 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -4765,7 +4765,7 @@ static void x86_cpu_realizefn(DeviceState *dev, Error **errp) X86CPUClass *xcc = X86_CPU_GET_CLASS(dev); CPUX86State *env = &cpu->env; Error *local_err = NULL; - static bool ht_warned; + static bool ht_warned, topo_warned; if (xcc->host_cpuid_required && !accel_uses_host_cpuid()) { char *name = x86_cpu_class_get_model_name(xcc); @@ -4779,6 +4779,21 @@ static void x86_cpu_realizefn(DeviceState *dev, Error **errp) return; } + /* Disable TOPOEXT if topology cannot be supported */ + if (env->features[FEAT_8000_0001_ECX] & CPUID_EXT3_TOPOEXT) { + if (!topology_supports_topoext(MAX_CORES_IN_NODE * MAX_NODES_PER_SOCKET, + 2)) { + env->features[FEAT_8000_0001_ECX] &= !CPUID_EXT3_TOPOEXT; + if (!topo_warned) { + error_report("TOPOEXT feature cannot be supported with more" + " than %d cores or more than 2 threads per socket." + " Disabling the feature.", + (MAX_CORES_IN_NODE * MAX_NODES_PER_SOCKET)); + topo_warned = true; + } + } + } + x86_cpu_expand_features(cpu, &local_err); if (local_err) { goto out; From patchwork Thu Jun 14 01:18:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Moger, Babu" X-Patchwork-Id: 929182 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=amd.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="WxlQ04Tr"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 415mBK4G8Fz9s1B for ; Thu, 14 Jun 2018 11:24:41 +1000 (AEST) Received: from localhost ([::1]:37644 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTH0B-0005WN-9P for incoming@patchwork.ozlabs.org; Wed, 13 Jun 2018 21:24:39 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48699) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTGuY-0001Ju-Q4 for qemu-devel@nongnu.org; Wed, 13 Jun 2018 21:18:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fTGuU-0007l2-JK for qemu-devel@nongnu.org; Wed, 13 Jun 2018 21:18:50 -0400 Received: from mail-eopbgr700061.outbound.protection.outlook.com ([40.107.70.61]:40992 helo=NAM04-SN1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fTGuU-0007kH-B3 for qemu-devel@nongnu.org; Wed, 13 Jun 2018 21:18:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xREWvCqYLa7qefFJlezsIHRXGET6NenmC7oMO9tiGSs=; b=WxlQ04TrKjrTZ/DvezZnq5Yak4pVCp/AreSG0Fdk6AFADof07HU2gt8fMM0N6BpdO9PTigDxiJXZIfxMm28Koa6wW+3KVLMqMRfmqqyraju797TpqTIiu1taP9lkH+u9zcxa1JnR5/mBNCO0Bu0PC5Fa+2ECdxSAKUa6HjPK3xc= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Babu.Moger@amd.com; Received: from linux-h3ml.amd.com (165.204.77.1) by SN1PR12MB2480.namprd12.prod.outlook.com (2603:10b6:802:29::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.841.14; Thu, 14 Jun 2018 01:18:43 +0000 From: Babu Moger To: mst@redhat.com, marcel.apfelbaum@gmail.com, pbonzini@redhat.com, rth@twiddle.net, ehabkost@redhat.com, mtosatti@redhat.com Date: Wed, 13 Jun 2018 21:18:27 -0400 Message-Id: <1528939107-17193-7-git-send-email-babu.moger@amd.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1528939107-17193-1-git-send-email-babu.moger@amd.com> References: <1528939107-17193-1-git-send-email-babu.moger@amd.com> MIME-Version: 1.0 X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SN4PR0201CA0064.namprd02.prod.outlook.com (2603:10b6:803:20::26) To SN1PR12MB2480.namprd12.prod.outlook.com (2603:10b6:802:29::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4edbba48-0b42-4389-fe17-08d5d194c56d X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(711020)(48565401081)(2017052603328)(7153060)(7193020); SRVR:SN1PR12MB2480; X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB2480; 3:Ogl5Fi4hrReDFzWAGYBvUeVWXWlPWluWm9Jt1OIzoigGKVwbwGNKX3P+EemWsu3Dk7KqVPwYwBR2H9Ub8ACfSBi/mMKvGgJose+65SgpxJN0wEEaedbtN+VDcInnlv9t9giOoR531+2jrdpsSh+xamjUlZ3Oy06TdG7MEwb3ClRxWTQxvVwDOr81AItz4W+w9A4MwJ6+jAoefeew3ZDrDIhyxnt4ulthSajh/ouETg6yoaX5d0PsCtlGopNwaG+E; 25:d1Eg/AduVBZoGWlyJ+8sqkHJqE8ftW+aNyyffen+E5GeyHCAmtiJ+rtIz2w0JTW/J/L3hP3WkZV5nY4YV/4vrXF3QGquJ4Zsaw3eb5O95XpF0/8Ri69hFF5bWlCOJpLyPoh6s54ng/0KmRMDuOCPNSB7bnO2I0eceJu8AAdEi0ARW/OBkR/jd5Ht++LsW4lJdG2i/jdyY1IY6kssVawe9lfvtaPp9i73DxTu5UiXH7a9l8RQM5XyfW+B4nf1eQt2lgNh9cfS6+Uwr6mf30GoiNFeLVANrVf+KcvHyNRf7DVL6ansEmKSRGfHFcBrBDbZtec5kS6iulSpnr0RUuMnWg==; 31:qyqgZzzDmSSIlxedfuF28Dk8xD2SI2bwFmlZGS4Fekqg5vOTke9p41TNXnCpCzq7LsuaQXKS+DNcLufdrSUl6olUIrkraRxGnaPeO+PTtEmzSo+15cCDBCEdhaPdKsuH50k/n57j64tkgJbjNxX6neblIFLEAXrgAI4z4Jie3ymkgY4gsvOLxNV872TJSxvMxWtzfnN1GjnNaE1VBaT9KyNlB3/Zeo1MwH9s7tTi/xs= X-MS-TrafficTypeDiagnostic: SN1PR12MB2480: X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB2480; 20:IVVZLswykKTmoj9CxNn88+4h/zH1ZFIvgwFbynp17RZ9NW5EtGYZrYB0ddUsCGg0/K0YI/sPgy8FqXHfjoglyUoroJRb5L93/u9Gh+zdZoxb/EAK1L5FJEmmYDrUbNrZ27IZytMXrkiWBPaLPhUJOW8cBdEmRYawP32BxAHNrQDMxu74HahqRGQx+w5wq1IGmZLNh6IqFidK8FAu5bsyLsJYPj6H1bQEa+et5bGo9fXk7O2ouqpZw0iNJaUSOzFQYncQ9p0zajIKs5PEwDf9KqSYgiwj1pDQMdzAOnJMe7eJetdNyEbhUuRp0RebJFgjDR2GCk3pZXbmk5CqnuWLos9y2Z2+xrMA+3AT35wJ18uPdWndBUQOCZ+T9RCzZfGYy6Mp5KtjC0XoDmOhUtpS6zYPc5p0MhZ/4+HtFlx2/Voh3cw7wY53Nc7XVtl4R+y2bJtBvUutPyplSplUfUqRCe85eR3HdXm6tcDMSBBb7AoPDVlvXZ8TdPrP8+TePtDp; 4:oBo+ZLbOEJ3sWQGT3T0dtNdP9te5U9lD/GyrakDrnOXFqFV9OZbimHoFSWJGWu39mDvMAWimjIwzLBUL9Ewr1NxxMdp89UvC0X4sbz7VdwpcqjhwG3h6hgJbuBY1E1L3v2VlUWna6nCYGsFFGvrFoXO0vyAmrk94BIQ1+h4FYHjkA9GCwnc6uhSQ1cMFJwkA1rDjEwH/OYl8wZwsnkHiN4O49GaBc1+l5a82ILlhhImpHZwlO2fpq+9uKsl9oRT327Yjb2k4/cnTQ3939TGw+duwOSL9kzx/KYkiK6ai3zhMU75afKs/lpiNXMz0kvNf X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3231254)(944501410)(52105095)(3002001)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:SN1PR12MB2480; BCL:0; PCL:0; RULEID:; SRVR:SN1PR12MB2480; X-Forefront-PRVS: 0703B549E4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(396003)(39860400002)(366004)(376002)(39380400002)(189003)(199004)(68736007)(2906002)(25786009)(52116002)(7696005)(72206003)(51416003)(4720700003)(956004)(6666003)(2616005)(11346002)(44832011)(486006)(53936002)(7416002)(476003)(446003)(76176011)(6486002)(39060400002)(36756003)(478600001)(4326008)(6116002)(5660300001)(7736002)(305945005)(86362001)(8676002)(186003)(97736004)(16586007)(66066001)(3846002)(53416004)(8936002)(16526019)(316002)(386003)(48376002)(26005)(81156014)(81166006)(59450400001)(50466002)(106356001)(50226002)(47776003)(105586002)(41533002); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR12MB2480; H:linux-h3ml.amd.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN1PR12MB2480; 23:V8oowyv5HdwI1Sje4nKMk8WJN/R5mhJ6qcGbCzbCc?= iqCo9609zh/wkqa73PoA1oCEusuXK4FeTSR2RXhHZVnx7DWi9nSHS7l7GIhCGDkn44/O8GTU3uH4gWRHRLfOTlvJ9u5XplKY2Bg1ffbbc4r4cHCtF7VxBGOyj5mG2v8sCM2DFs3032vKhgPEJC0zBZ/ZwyxrWbPW44OQ79iRRSI1Dp4JX2qweq7MUFtqeA7uDke2X43sncPRAoyh2AJf6Mv9nYRIj1dNSje3V9wTSyk45UrayEjD5cfcY/Qw4YR5BBepMYruAzmJPAUzO0FckIrCZWVR6YIVYZHrZ8gAxEQtNNJAtvIGWBb3FJpaumEvVrBwSk2nDAV5BSE0NyIjrwPp0wvndC78WBrO0BoXsZQ3AvI5eZyJs2mv7epU3uQJjrElZOKeE7P3eAno0bApLtcdwyBTfl4Y578CyCj9EqBpPby0vvC/f4s+556ZT5qecAElU+A2E2W0s4TUHN7I0/Nu5qo8RpTZ/eGTiUY+RpHEt+FdCp35al7ufaRg9lrkh2ShizTfQwAGa8B7tcMXu1WZ/0fSeNyKmBdR37AwVBOT8ulJUDdAoG1neZITcCX0LxXEIaV3JUBoP5Gg26fEd7MFJWz7PSBVoARfpz7SfjpMohAagJD+zs5H/xRiC35AqRkw1hgOj3x8quwAtudBGfONFxbHmOf6i1cvwQhijXgVgScgkegil6pgltNPqy6quT53WfVTzERW94TVcsthNKBxKK6jyQ5mHXWiy14fz0ryx/FQIu1ERtGKE3GcpoORZc1TMw+GjFkC0K0gsAlrw+ycbNz60mXCmj0yB4yDMA9tpwB+mltL9RcrvqBxJxkyJK7yzulBp6vvWMeMK4nGQw/5bh0OgI+UHOw4UyTDGWdMAIuxw57Jylzm0YBLP5OM7OKveQIU3aQC0gHH8ntnXc1ytv87OvZ3qma4Jl5lHUt51kpEFKzHJVKAOy076FphH44PbTVTI4V4q0T8rmKg5Fpw2mMOZAEB2+OJpVLkOkeGe3fFzoGc7Q4hZjqoZz2f4/nkA8K43RWywWvIcmqAUbSfS7a+UesHSHLYOmimL1Lz8tldBMZemToLhb//z02jRM5i/12mQ1ITX5eOIf6zIhmRcuy1hL0eN4Vmy91AZfKcoPkk+GgHxfKnoWzt0eJGRmgN7iQ1FoAgnTv2t460pObcvM53NfD98PT/zgznad6/96H9JnZLTVsZRDm0Xetpf6tsV0MNhSACXqx07xpUkesj8joy2a1B2NegyZP9k30QH0OHPOUu0jnyFfENsCRhoZ5CaGXbob0k04tH7cgBWQ2 X-Microsoft-Antispam-Message-Info: kblggfW8bMir+Gnfh3wg32vINH+KAF0ZxQiIhUOy4ApkNYaJ482xvO8TpJRvL7nE/NQAFQ4Zyfop+1GL7fUPR1L2NBN/6QAJ0dc4XMzjy3+3oVSH2AKR9BsjmNAY3eL7tcAR3GiyR24xe7kz/KHublteSHT6lbkGFU9ygTcQZCi0hpttoM7xJkUu54/f+Q07 X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB2480; 6:1ukGUaqwnwtYUNmp6sPKi/5ejzYlhns7kiiDAW28hrIjSzZLzxc8uV+pGKl/4Bu1hKNUPEzxshevqNmVoFyE//Hh24hSRWn7LVarbpTQ1s0HK015neqVCY3AgQ/Vr3G/Z94hJTcvmO4GMI/0cgv4TbT+pKFtFH6Q7JrJ+Prfu85O6feAUvvS1l9uCCJ5CVB35v/NqhOMUcbQ9PGE1NHEgg2+W1qKH2b5tdO3uUJ6xesAp640hGy2fFEUFzmAF+3y+qlD8omF6vGERqdJT4E+CuI7gZWaGmYDGB2MhnmpJL2Fjdcge64Txvcq6q2tZnGR5Gn2M4Z5Gv1Inksnm7eWgupJfmDvLB63F4lWh1ZITCxnEbRkdot8uGkH4zXz5yq6dr0nqCE9/bRKF205DpknHFCXNM54iAtFaN44qut1frUERLl0h2+PsjDNAqXyfv8WERzS5/GpEU4NC68iCtkMaQ==; 5:AXQmWou6/WUAnWFe4/biRfex/RXox0LlADuY62IpJn7/xCoRV0GiLj6WVvshRh18daN+sn4FGebDUxpsZELUNtjl2Jufp+7GmYuCMvP4ns8JujrSU8Ni1TuI9uNL4QSxGDU3ow1NP5d8fQ4XVhqbZScxqHXz7N69r72M6IXWkr4=; 24:AIMSwBxGszlMvBsbrCy1VLijM/30ws0LJ3okPbe2Lf+weVYOGUhhhkzvhtmB951L979BNcHXCt3cC0ERBcm1qcFSDLVCwrlW4SEM85Ut6bY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB2480; 7:J4ovE/Jp26zl5xeNwCW5jhEFgjDrH4VT1lbndZX2MY4mLKagJw/ai9Ij864YKl6fkoKBl2iwfb6F+Nf9uyW2MbdN0A5wJRIYK35tIZBp8ra8GOj2SqdDJyqSkyJG0wAasj6SHwtzVo2T9LuF05QiEBuKFPBwt2Bc5bzQGz8jrrCJ8Oi9cESzPYvyCf794twK1hvQTD6adZOpkNcBIhtBjDWfm90GrHeTC5DE8Z7e1blOSuJM+dbJo0wR5dyLLZag; 20:OIvo4ymD/wOVaiAXzpd7q2umobWLsHpxdeg/Bm+hI0bbr9pQtUS/VpJdotSU5ycmkBPwmMY0D0KN9QDmCSIQkuAg9bLtx4jyMDdCIVd2D9EpmACqRxriqWuBPUhU7f7pDRQJnONJUvjwdfp+9MmI8+IX4RwHsYhYDXSY7LmHiIRECzRNEDgyTMNyAwb+lVifHX8OWh1kXZNp9sVdxN1kblq2Qiv3iRaavc/dm+WXdXkj+rbIfXyx858NTO68bKs3 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2018 01:18:43.7125 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4edbba48-0b42-4389-fe17-08d5d194c56d X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB2480 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 40.107.70.61 Subject: [Qemu-devel] [PATCH v14 6/6] i386: Remove generic SMT thread check X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: geoff@hostfission.com, babu.moger@amd.com, kash@tripleback.net, qemu-devel@nongnu.org, kvm@vger.kernel.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Remove generic non-intel check while validating hyperthreading support. Certain AMD CPUs can support hyperthreading now. CPU family with TOPOEXT feature can support hyperthreading now. Signed-off-by: Babu Moger Tested-by: Geoffrey McRae Reviewed-by: Eduardo Habkost --- target/i386/cpu.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 637d8eb..6783305 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -4963,17 +4963,22 @@ static void x86_cpu_realizefn(DeviceState *dev, Error **errp) qemu_init_vcpu(cs); - /* Only Intel CPUs support hyperthreading. Even though QEMU fixes this - * issue by adjusting CPUID_0000_0001_EBX and CPUID_8000_0008_ECX - * based on inputs (sockets,cores,threads), it is still better to gives + /* + * Most Intel and certain AMD CPUs support hyperthreading. Even though QEMU + * fixes this issue by adjusting CPUID_0000_0001_EBX and CPUID_8000_0008_ECX + * based on inputs (sockets,cores,threads), it is still better to give * users a warning. * * NOTE: the following code has to follow qemu_init_vcpu(). Otherwise * cs->nr_threads hasn't be populated yet and the checking is incorrect. */ - if (!IS_INTEL_CPU(env) && cs->nr_threads > 1 && !ht_warned) { - error_report("AMD CPU doesn't support hyperthreading. Please configure" - " -smp options properly."); + if (IS_AMD_CPU(env) && + !(env->features[FEAT_8000_0001_ECX] & CPUID_EXT3_TOPOEXT) && + cs->nr_threads > 1 && !ht_warned) { + error_report("This family of AMD CPU doesn't support " + "hyperthreading(%d). Please configure -smp " + "options properly or try enabling topoext feature.", + cs->nr_threads); ht_warned = true; }