From patchwork Wed Jun 6 17:44:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rafael David Tinoco X-Patchwork-Id: 925989 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="ADV0BQpk"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 411GJb13Ygz9s0W for ; Thu, 7 Jun 2018 03:44:31 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753842AbeFFRoa (ORCPT ); Wed, 6 Jun 2018 13:44:30 -0400 Received: from mail-qt0-f193.google.com ([209.85.216.193]:37452 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752026AbeFFRo3 (ORCPT ); Wed, 6 Jun 2018 13:44:29 -0400 Received: by mail-qt0-f193.google.com with SMTP id q13-v6so7262353qtp.4 for ; Wed, 06 Jun 2018 10:44:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=o04SUTGAO/i8KRV5fbYYbE9ZQXszNrVB9tM/Ct/KSdU=; b=ADV0BQpkfzo26GVfTeD9tlEknSzTezkcSFRPAEXicLlRQjyzyLunC07aUTTZMA/Htt tq1ORQOWxaqKPpoa1JAZceisFTpetomwFIagU74DM78m2byyvQSTrujuX88RZkmP6mTE HEN6RTNWelvUPzet5BN+fjgcaNrY6y9HJoJdM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=o04SUTGAO/i8KRV5fbYYbE9ZQXszNrVB9tM/Ct/KSdU=; b=R2xqcdB9RzR0FY25nkRmKH8iHhCKTP2DAHW4lfaiN1vgCtInb3ohNIFIJS39vMLAWn Eq712uTDkbqZkhfap+8EsXvx4DhQ9BRYYFvXuXVhDvvIB3dHUBBfdBiLBnAaV7v/MnJj aNylfb5fzv2YfOg4Hic5l0Q2nRXSRypNiMbeKj3RK8uqEsoAbm+uewOvT3/wrDCi6P29 O6N0+9tM/arb1k/iiOrcNiB8abR1Y7cobd4NPXGXTh5UiPL9ObKFks4ulPTpQgpX7oka 3M7MBBAB9qnG9QFw0NIGs5dr//r4wLwYUMgFImUCFZydSI8QNwJvYa5zXutOC0DfoCsC Dnew== X-Gm-Message-State: APt69E3siM7laEgOV7RtiPo1Cc4DbwBsGXKf0TE6Uu/5o/1xvChjveF3 U4ikU17p8TzNyH0CeFrFUvl2lQ== X-Google-Smtp-Source: ADUXVKIxQi7Slbz/4uZxEColbO22KHfygo3U2F/3F9eOwBpWMWNaTmThOG+QTN4DMAKYNOywyuQA0Q== X-Received: by 2002:ac8:25f2:: with SMTP id f47-v6mr3885398qtf.12.1528307068672; Wed, 06 Jun 2018 10:44:28 -0700 (PDT) Received: from workstation.celeiro.br ([138.204.25.57]) by smtp.gmail.com with ESMTPSA id 47-v6sm42941210qtw.4.2018.06.06.10.44.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Jun 2018 10:44:28 -0700 (PDT) From: Rafael David Tinoco To: bamv2005@gmail.com Cc: brgl@bgdev.pl, shuah@kernel.org, linux-gpio@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, rafael.tinoco@linaro.org Subject: [PATCH] selftests: gpio: gpio-mockup-chardev GPIOHANDLE_REQUEST_OUTPUT fix Date: Wed, 6 Jun 2018 14:44:24 -0300 Message-Id: <20180606174424.9630-1-rafael.tinoco@linaro.org> X-Mailer: git-send-email 2.17.1 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Following logic from commit: 22f6592b23, GPIOHANDLE_REQUEST_OUTPUT should handle errors same way as GPIOHANDLE_REQUEST_INPUT does, or else the following error occurs: gpio-mockup-chardev: gpio line<0> test flag<0x2> value<0>: No such file or directory despite the real result of gpio_pin_test(), gpio_debugfs_get() and gpiotools_request_linehandle() functions. Signed-off-by: Rafael David Tinoco --- tools/testing/selftests/gpio/gpio-mockup-chardev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/gpio/gpio-mockup-chardev.c b/tools/testing/selftests/gpio/gpio-mockup-chardev.c index 667e916fa7cc..f8d468f54e98 100644 --- a/tools/testing/selftests/gpio/gpio-mockup-chardev.c +++ b/tools/testing/selftests/gpio/gpio-mockup-chardev.c @@ -225,10 +225,10 @@ int gpio_pin_test(struct gpiochip_info *cinfo, int line, int flag, int value) if (flag & GPIOHANDLE_REQUEST_ACTIVE_LOW) debugfs_value = !debugfs_value; - if (!(debugfs_dir == OUT && value == debugfs_value)) + if (!(debugfs_dir == OUT && value == debugfs_value)) { errno = -EINVAL; - ret = -errno; - + ret = -errno; + } } gpiotools_release_linehandle(fd);