From patchwork Thu May 31 04:10:14 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiaoli Feng X-Patchwork-Id: 923146 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-cifs-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40xDWw6vzwz9s1R for ; Thu, 31 May 2018 14:10:20 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751165AbeEaEKT (ORCPT ); Thu, 31 May 2018 00:10:19 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:59580 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750949AbeEaEKT (ORCPT ); Thu, 31 May 2018 00:10:19 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C738680825A5; Thu, 31 May 2018 04:10:18 +0000 (UTC) Received: from dhcp-12-126.nay.redhat.com (dhcp-12-126.nay.redhat.com [10.66.12.126]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4B3D720A8472; Thu, 31 May 2018 04:10:16 +0000 (UTC) From: XiaoLi Feng To: fstests@vger.kernel.org Cc: linux-cifs@vger.kernel.org, xiaoli feng Subject: [PATCH v3] common/rc: skip atime related tests on CIFS Date: Thu, 31 May 2018 12:10:14 +0800 Message-Id: <1527739814-30451-1-git-send-email-xifeng@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Thu, 31 May 2018 04:10:18 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Thu, 31 May 2018 04:10:18 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'xifeng@redhat.com' RCPT:'' Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org From: xiaoli feng From the feedback of cifs developer, the behaviour of atime/noatime for cifs is basically noatime always. So the atime related mount options have no effect on cifs mounts. And Skip these tests on CIFS. Signed-off-by: xiaoli feng --- common/rc | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/common/rc b/common/rc index ffe5323..0295b30 100644 --- a/common/rc +++ b/common/rc @@ -3242,9 +3242,16 @@ _exclude_scratch_mount_option() _require_atime() { _exclude_scratch_mount_option "noatime" - if [ "$FSTYP" == "nfs" ]; then - _notrun "atime related mount options have no effect on NFS" - fi + case $FSTYP + in + nfs) + _notrun "atime related mount options have no effect on NFS" + ;; + cifs) + _notrun "atime related mount options have no effect on CIFS" + ;; + esac + } _require_relatime()