From patchwork Mon May 28 10:50:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Siva Rebbagondla X-Patchwork-Id: 921891 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="kniIsjn4"; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40w6xJ3Cdyz9s1w; Tue, 29 May 2018 18:55:00 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1fNaP5-0007Oh-BT; Tue, 29 May 2018 08:54:51 +0000 Received: from mail-pg0-f68.google.com ([74.125.83.68]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1fNFg7-00007Y-Nx for kernel-team@lists.ubuntu.com; Mon, 28 May 2018 10:47:03 +0000 Received: by mail-pg0-f68.google.com with SMTP id 15-v6so4815558pge.2 for ; Mon, 28 May 2018 03:47:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=tF5Y4CT0tkb2I+rqF80cYMwgclej6QRXaHrO2ol2GBU=; b=kniIsjn4z74z/Hhg/X6mX7f4PLtHpafjFafx/US3PryIzXpDSoGSAUi4ljAaJ/X6M/ s16PTw68e+Stb8N8HB7tQ/ICyoH/82mhk+02XaoalEgourJDi/T+eWIOfZirscmj9swY yVWSrvgSyXddq/7pcoioqwqrvRp9erd03g96Ut1yCM7uNl3mt+umsopM3eZcd4Fn7jj+ Ke4zyJ6DNVUdpLmJXTWZNH+OQGcevkcu2ysOPffUa+DN/jJAZE+1ZraU6J/VSW0iM7/t 3WmagMQyEP/lKQJ/naBDNgxtW/Fbcffx3SF5d9JMdVLzvNbZbozvf397GUzz9NrElD5A xd9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=tF5Y4CT0tkb2I+rqF80cYMwgclej6QRXaHrO2ol2GBU=; b=PwajzWuTExh+unhHnGy84fpFgeJGR09hK6LFwyXBl8e4yKXp+jY0IzRaHnT5imzBTZ +YyN1cb7sNFai2WPRWRqQsllce/0mZgZuT0lpUv0S2Jxi06E6GT7NzQWQOy/RUS/yvtn pOueAlqGs3idQI8dOCBmo3mbJucPozUo5YwDczGucdFDrh+pU/cFUCyP6dNXbyPue8M1 /MjxhFZIMyBf3C88OZInvxXhmsy9Wm40VlN9Av4xmTeO/xPR6Es4FkDImway+wGObseN uByQuXgS06QQPpHJTam6/Dq7QezdDDk2hzdR6oxvdwwUWsuw/TDBAcGBIEymlwzkG8PO 3M2w== X-Gm-Message-State: ALKqPwfXNN73HYH8bGT8ckydYP6NUGvm3Lyew9FSIPBQLheOEZegbSOD Nx6IiM9LBlXxojeU/RheU92i3Grs X-Google-Smtp-Source: AB8JxZp/jWV97DR2wH/iWPYWTU5S8Df3hGyYc7UDncQhX/wZAc+lClPjdP0bCmfvCP3bcE6I8e1bDQ== X-Received: by 2002:a65:5308:: with SMTP id m8-v6mr10445403pgq.42.1527504421905; Mon, 28 May 2018 03:47:01 -0700 (PDT) Received: from cpu459.localdomain ([203.196.161.90]) by smtp.gmail.com with ESMTPSA id w12-v6sm79058176pfi.158.2018.05.28.03.46.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 May 2018 03:47:00 -0700 (PDT) From: Siva Rebbagondla To: kernel-team@lists.ubuntu.com Subject: [SRU Xenial][v2][PATCH 2/2] UBUNTU: SAUCE: Redpine: improve cancel_hw_scan handling to fix kernel panic Date: Mon, 28 May 2018 16:20:00 +0530 Message-Id: <1527504600-26655-2-git-send-email-siva8118@gmail.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1527504600-26655-1-git-send-email-siva8118@gmail.com> References: <1527504600-26655-1-git-send-email-siva8118@gmail.com> X-Mailman-Approved-At: Tue, 29 May 2018 08:54:49 +0000 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sushant Mishra , Siva Rebbagondla , Sanjay Kumar Konduri MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Siva Rebbagondla https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773410 Kernel panic is observed when network manager is stopped while system is entering into hibernation. The root cause of the issue is scan work function keeps running even after cancel_hw_scan() call. Issue is resolved by calling cancel_work_sync(). [ 1171.913244] BUG: unable to handle page request at 00000000001067e38 [ 1171.913248] IP: cfg80211_scan_done+0xb0/0xc0 [cfg80211] [ 1171.913554] Hardware name: Dell Inc. Edge Gateway 3003/ , BIOS 01.00.06 01/22/2018 [ 1171.913668] Workqueue: phy1 ieee80211_scan_work [mac80211] [ 1171.913773] RIP: 0010:cfg80211_scan_done+0xb0/0xc0 [cfg80211] [ 1171.913780] RSP: 0018:ffffc1fe41b47dc8 EFLAGS: 00010286 [ 1171.913789] RAX: 0000000000000001 RBX: ffffffffc0e60120 RCX: 0000000100080006 [ 1171.913794] RDX: ffff9eeab7e3bc58 RSI: ffff9eeab0c69080 RDI: ffff9eeab7e3bc00 [ 1171.913799] RBP: ffff9eeab7e3bc00 R08: 00000000b7e3b201 R09: 0000000100080006 [ 1171.913805] R10: ffffc1fe41b47d20 R11: 0000000000000000 R12: ffff9eeab0c69080 [ 1171.913810] R13: 0000000000000022 R14: ffff9eeab0c68760 R15: ffff9eeab7af3c00 [ 1171.913817] FS: 0000000000000000(0000) GS:ffff9eeab0000000(0000) knlGS:0000000000000000 [ 1171.913823] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 1171.913828] CR2: 00007f76c73ac190 CR3: 000000006e20a000 CR4: 00000000001006f0 [ 1171.913833] Call Trace: [ 1171.913864] ? rsi_mac80211_sta_remove+0x260/0x260 [rsi_91x] [ 1171.913971] __ieee80211_scan_completed+0xb1/0x390 [mac80211] [ 1171.914078] ieee80211_scan_work+0x7e/0x480 [mac80211] [ 1171.914098] process_one_work+0x142/0x3d0 [ 1171.914111] worker_thread+0x229/0x440 [ 1171.914122] kthread+0xf5/0x130 [ 1171.914132] ? process_one_work+0x3d0/0x3d0 [ 1171.914140] ? kthread_associate_blkcg+0x90/0x90 [ 1171.914152] ret_from_fork+0x35/0x40 Signed-off-by: Siva Rebbagondla --- v2: Changed the subject as per stable patch format [Shrirang]. --- ubuntu/rsi/rsi_91x_mac80211.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ubuntu/rsi/rsi_91x_mac80211.c b/ubuntu/rsi/rsi_91x_mac80211.c index 244ef27..5a85bcd 100644 --- a/ubuntu/rsi/rsi_91x_mac80211.c +++ b/ubuntu/rsi/rsi_91x_mac80211.c @@ -429,6 +429,7 @@ void rsi_mac80211_hw_scan_cancel(struct ieee80211_hw *hw, rsi_wait_event(&common->cancel_hw_scan_event, EVENT_WAIT_FOREVER); rsi_reset_event(&common->cancel_hw_scan_event); + cancel_work_sync(&common->scan_work); common->scan_request = NULL; }