From patchwork Mon May 21 19:31:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Shaikh, Shahed" X-Patchwork-Id: 917801 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=cavium.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=CAVIUMNETWORKS.onmicrosoft.com header.i=@CAVIUMNETWORKS.onmicrosoft.com header.b="XyQiJUql"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40qTSG2RM2z9s1w for ; Tue, 22 May 2018 05:32:14 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751160AbeEUTcK (ORCPT ); Mon, 21 May 2018 15:32:10 -0400 Received: from mail-bn3nam01on0088.outbound.protection.outlook.com ([104.47.33.88]:59254 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750942AbeEUTcI (ORCPT ); Mon, 21 May 2018 15:32:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/otYP375onbWDFIxvZyGiRivolZe/EMJZqnjlLnTzrA=; b=XyQiJUqlMK23J+W5zObOIHXUvz6hdpCVsVQXUwzd4SQeXaqx3Vm+BNDX9lmHqF5HwinB7/zdWhsikzct8H/eG3zH5/HKoNljQJTWTgzVrtDMyngyeKUlh9SwWEYj5QlQwEeQpzCQNh+as6YQkO0LXhcc7XuQw61BpQMNEmz/sNY= Received: from CY1PR07CA0036.namprd07.prod.outlook.com (2a01:111:e400:c60a::46) by CY1PR07MB1510.namprd07.prod.outlook.com (2a01:111:e400:50ed::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.776.11; Mon, 21 May 2018 19:32:05 +0000 Received: from CO1NAM05FT021.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e50::206) by CY1PR07CA0036.outlook.office365.com (2a01:111:e400:c60a::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.776.11 via Frontend Transport; Mon, 21 May 2018 19:32:05 +0000 Authentication-Results: spf=pass (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; davemloft.net; dkim=none (message not signed) header.d=none;davemloft.net; dmarc=bestguesspass action=none header.from=cavium.com; Received-SPF: Pass (protection.outlook.com: domain of cavium.com designates 50.232.66.26 as permitted sender) receiver=protection.outlook.com; client-ip=50.232.66.26; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by CO1NAM05FT021.mail.protection.outlook.com (10.152.96.129) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P256) id 15.20.797.3 via Frontend Transport; Mon, 21 May 2018 19:32:05 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Mon, 21 May 2018 12:32:03 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id w4LJW3r2018673; Mon, 21 May 2018 12:32:03 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id w4LJW2IA018672; Mon, 21 May 2018 12:32:02 -0700 From: Shahed Shaikh To: CC: , , Subject: [PATCH net 1/1] qed: Fix mask for physical address in ILT entry Date: Mon, 21 May 2018 12:31:47 -0700 Message-ID: <20180521193147.18628-1-shahed.shaikh@cavium.com> X-Mailer: git-send-email 2.12.0 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(39380400002)(346002)(396003)(376002)(39860400002)(2980300002)(438002)(189003)(199004)(478600001)(72206003)(4326008)(2906002)(51416003)(305945005)(1076002)(186003)(107886003)(87636003)(36756003)(2351001)(47776003)(356003)(126002)(2616005)(44832011)(476003)(486006)(26005)(5660300001)(69596002)(106002)(80596001)(81156014)(48376002)(8936002)(106466001)(50466002)(6916009)(6666003)(42186006)(50226002)(8676002)(81166006)(86362001)(54906003)(16586007)(336012)(316002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR07MB1510; H:CAEXCH02.caveonetworks.com; FPR:; SPF:Pass; LANG:en; PTR:50-232-66-26-static.hfc.comcastbusiness.net; MX:1; A:1; X-Microsoft-Exchange-Diagnostics: 1; CO1NAM05FT021; 1:Zzh6egfTTD4Gx+PBGaCxse9vBHFF+m4PVDDpr702ijPtuWOv6B0/wlmf1izfp9z8vGEfLR5RTCywLRW0dED5fZ810m2w6gOL08oMzhxUBTcTUbBbOxpBQxt0JDEY7IF/ X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4608076)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060); SRVR:CY1PR07MB1510; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB1510; 3:ZW1WXV9Ax78iSVxERa32WlAfAomzYYcclGtDPmyrTNqvnl4/91O03dQJOpytskQpOqS+/jRZtGqZOl1G28vnq7KapovdHpIVbDf/jPkp1bkl8XDSW8Y7XeHWyZUlPwno9cJts49nQ3qVvvxaa2lhZ0GZYBDZORC+oJMD3A61z8pxu9KgiSXyikJzRnRzAPqu3soL0Qncii/Pi18BCV+BZLOjYjrBxr+ijFlB+KhxxP/jsYnl0HN9l4y+xaregbK3sBUFAvp5go2nHmnE0xPepOfry/pNXWKvZQ2LUoPG0teaIDc1Kf8i9SDR0XOmV0SLD3kK8sBtR67EuR9Kee5mkm/JAGdxKfuCwSXOGTkfdJw=; 25:el0y2nE0roH1EKlRMdIopRHfX2VHEeYjGBiSrK+DHj5psVx2dMXxsUngoubIQHVSAvK1Hhoopyk/vj6U3JPo6gxApJOzLpRFTo52f+85ApwgKI2FecJG9aCFmjkPCbQRgzzMO5FXUMJhLlwARK+yqCs57dNHjEK/VqbrNL/qQpfxWnwa2KfOKNSfSXQItezSBSVuh3BDgqrOg5jqohiSZ2MqjkWH2ybTPdAGB696xVNCNr9wxbWXPps63DIXZLJ4HIKTk6GPeqj1y8d7Ll2AgGiH4B3C1F7GPyPhqu7TQQr0cc30pFx0vZDMdXvtY+DZOQtsAUHdoPDNnVDe3NKOKg== X-MS-TrafficTypeDiagnostic: CY1PR07MB1510: X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB1510; 31:FtGYLDfoFf2mWmnNSk8x7KsZA4DQJ0u+5RkvOixQSD6spGiXHfzNiXTz9vW9LjJPtbijoS557Saa0bfHDMnLnqHzpbRzGDqEo5VKZ0JVYWC3c2WGg+iRkVi7veQiQP+w9CAuQKz8MA5s8WTJy3NmcuoG9LwPxUQArWXhXUti/7LTH0YS/ktagjiTyYDhL4HGVGWuUePuVoGuoPr+sL4aiM08JyqNEpVSzwjk3JFce/k=; 20:dvtwofhEOvOZ6wTZnhyukInmZxZmOvEisNvrVNaVONUSipI3uKSDqNwxeUaGVS6xqdbpK0BV1yrBh6+apqaGQX1dLeslk9ws6ZtMIc2IKVbn3MWY9G7voHD8oLrDhVEvZrkHVBy0QK5XkbocUma1yz9QzcR2EgPl8neCJuT2/pggTqQLrKxiRzqWy4IupLWN1KERN3iT7YhpOncjfHBDaRhdwQeshrM80B6F58k4ywO4W5j45dOkfIuIgiq67b6kIaE9NeeIvTcQcn0cTHx8oGjNb5Sn9TJxWh1acfxWET9iSYadxMhHxh7KcyewT/bxFFm+VVYVaHW6DyozHnMhHY/Xw5ZxNnh870Jrh0vrreUU/WUgSFI7qJVQ9KdA2ioAYX5CqlkAlSqsRrP/jxIlfPwH3SLwE1dTdNvB9Q//8m9YIv7XF6RP9kEsE9Ru/nbO+5MOlNlOj8UXl1IT1eeUZl8ffYg3BybqTi0OcvEr3iAdmFbdh3VAlSnnzCGh7fbH X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(3231254)(944501410)(52105095)(93006095)(93004095)(10201501046)(149027)(150027)(6041310)(20161123564045)(20161123560045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:CY1PR07MB1510; BCL:0; PCL:0; RULEID:; SRVR:CY1PR07MB1510; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB1510; 4:tBrtpAMrm65NCIP/UAsWX8rNfHqJZmdKyJOntfIqTUHNtF9OB2kkq7Pw3bS1lZqG5Eb6usZ9q1bwKhXWkMJY0IwV30S8c8T4W7ClFtVjBhDd3aguZ7X9rpeYMFHL8oZwcwG5ZdSS+W6Ss+N2nQX6rGezEa8zlV1hSHs/K6WfswlWorbxXJTnf7tv1OmuTVMnO0L2+OVYK6YQShk0yARskM4Q4rKPNvJLiHGPMPcT8KGFPs0rezdfsNdaim30t4XZI0jzK/xkohIFrn4ul7Thqg== X-Forefront-PRVS: 06793E740F X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB1510; 23:NF68v4s3+G39PcImF96gxy2PTL6TmjmKJ3IrQVBANP8OUs+YfI0eBoWGIUwyYEDCrmhcNkZSIxIii9c8IgGKrfPcjqMCvhsNeac7ZUK100zBpifE5p87uLrUGY2vXGJ/K1IBSkUxC//a/E4zjdPr6YS3rqLUYRmAIepdIiPnjGBP5FkjqJl4Bq/xHSNSlnqQpixQ8qKKx/IQUmQrhq2lP9lqxXGBW7YXN6dP6nAnTwpJ2r9rgJRPkCsFFXbwyJcNxNuDw5BK0aNx4EL4KiOamYbi9reFtPqrW9PRWpIpCPh0HYdqRPyOXZ/HlRPr2pf2SilDTx52B+vuqAcpYq8npW0CAcxxwJs17X7RUvsPv0MTXkvrRcJm0WmHGXfHig52DPApcJeCeR9RDBMVjbNBfM0qgiX1EFbGvWT/wRWGHZV5wwvqr4FMsAbbPq2AUOpqMwl16nT5NMFlVm9ylyAEhgHWlfFwxxce9w81K3IgNXJOJraWywIh6thbnnBMHXefiWd7L5kXq23zZCtQQbMT9klRfk0zwSEnb2MyykXrzN038KysPg2yec/V7I5IuPThrov3XOt+UIzQ8WNTruGkdkpJnvZE0qN5x2vrFgBmm6W9IE8Ks6p6de9nUDmpdZH+gPjDj404rzazkKdWVN4gsOuJdDEE9ypMdHCbLJB+fYn5VYDypI5vIT8lmXafbpl1Z7ilm+Lugfh05Gsf+jmewDp4MVy+AWpB0TIJj+SnmoJoKUrQZXEq4auA8du/jQ1JrkEB6kUeJ/gBlcVNu60g9m6zIIFip52MNiSpQyI+koqiq9pi9SUKzZ4eK9V150/6p3ElkwnF2phWR1DTZGUXgb8jPEGf2jhI8EEWQ2bQTQ6qnKSYXtmxluCI8/a+MhrxC+A2wTcraolzH5UKOuR54sn2zfg4MaEHDG19tcHSHLRoox3xb2NXcUzlLo24TZ49UdNCPc95lDXEKPHmv9QiJHJWfImYy8mq8pC5vv8COHUB7SLVKBeXxpYuL5+aAgeTcfFBD3dgRn1V4QM40Onpt6smYUnCAfT+KfWrWmk2hOwVyNr++PDF5UBgx4Eqej2fcFU82yD5gC+O1JfYmx75hw== X-Microsoft-Antispam-Message-Info: RL+WkLtpI1UIGKOgvboJLCPT9OsjSVmdZBDMmNkDFPrZGHPiV3zh4lxazGOcMHsSIeIGM7WFhCECZT+wK1CurHE3GeGnApst5Ippuc+OxwB+lMF8rIl6eXisdyafYJJHqD0zvLjCgeOw2xa1dU+hWZ2WS7nteV2HzYJ9V+0AnBm5BSX3XhTSXgw+WsO4V4Ns X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB1510; 6:EvzONY5sW966rwPNet3jp5hOAZcpvuD6KoNgtSvpDJDAQSvJrA6BL53PhbQlQCmi0SbDHsbc5egydrJvUmay56obs2uRYliZJ+g+TLRvCMH0TfZyWjYio8vaj2+KxMl+NC27Yk6h3h7ngcYXDv7OQmRjk+ns2e3yvcYuOaob/Zd/qDiQgeQ/eIQA0RvuQno1zRZqsGB9DKNg4KTwObGFSDbPy6DBs23dSU9A14ju2/mRMylQlRDLBGf0PpHAU7f2wHsuT0Dq6MM+Aq7HvLwOLilxciBgKNidWZc4IMeqmXcaUkxrPTwxn/CCxQ3BzF2akyzPwJLJQ9q5BRyUGplZMofpVUl8903ju4/ELvEOB/K9Ua+oWLL8FJ7PLcd2T915Ku3eD8zMilxd/+JjOVFqH4BK4kSEsDwXawAguyg58xLP0kRDUsLOXvYMz1tIneMsZ8aR3lx6Mxu0jLHpTyUrog==; 5:mAQZPXXk4J7C6m9uSIEFWzXabWcNaPcHAZIwzNYyf+MPjzVfI5K1CAOZ2NZ7Ei4HjM8flO3JX4qdSdZf/Xtc/9KzjM6X/l2uDxBwvqjCc+MmdKBDV/J698Fkblt8nbPQ+NE3L29s6XqvZAADneItroXD4bU9SHPn/O0wZy+HRBU=; 24:/qR28faN+R3AOqH2Yb+TQULss4dzi7p9yEnXQ7EE+s4qw5eDOoNd/FULaVEpIWQrKE0R4g6H/QT6EDNnadyH0fhE1Rw59Hsn+5s7XjtIMZI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB1510; 7:bmC5tdjxKmFcQRPXgs7Wsayd4h+7nh/7iVJ9kEMwrydjtHQKM1JVv4Fyjk1eHaVzYHfao8NJu2njhiH071IHNyj2wWw27N1JdTDUX/k5EtZ/EINX8BIgRIot+4GDIA5lB6YLTLkWlVzNOAutroOKFMt2hOm/I91funl4gsnNRBdj35pakbNP0Tg6dTQ60YxsGtiRC1i+/r+f+bXWfLm0aGoEyLDJL9TGDp4C4EjZCZOtR7gYbig0wUNWWkxJw0ba X-MS-Office365-Filtering-Correlation-Id: aaa9781a-ed98-427e-c327-08d5bf5188e9 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2018 19:32:05.0570 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: aaa9781a-ed98-427e-c327-08d5bf5188e9 X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB1510 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org ILT entry requires 12 bit right shifted physical address. Existing mask for ILT entry of physical address i.e. ILT_ENTRY_PHY_ADDR_MASK is not sufficient to handle 64bit address because upper 8 bits of 64 bit address were getting masked which resulted in completer abort error on PCIe bus due to invalid address. Fix that mask to handle 64bit physical address. Fixes: fe56b9e6a8d9 ("qed: Add module with basic common support") Signed-off-by: Shahed Shaikh Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed_cxt.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_cxt.c b/drivers/net/ethernet/qlogic/qed/qed_cxt.c index 00f41c1..820b226 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_cxt.c +++ b/drivers/net/ethernet/qlogic/qed/qed_cxt.c @@ -77,7 +77,7 @@ #define ILT_CFG_REG(cli, reg) PSWRQ2_REG_ ## cli ## _ ## reg ## _RT_OFFSET /* ILT entry structure */ -#define ILT_ENTRY_PHY_ADDR_MASK 0x000FFFFFFFFFFFULL +#define ILT_ENTRY_PHY_ADDR_MASK (~0ULL >> 12) #define ILT_ENTRY_PHY_ADDR_SHIFT 0 #define ILT_ENTRY_VALID_MASK 0x1ULL #define ILT_ENTRY_VALID_SHIFT 52