From patchwork Mon May 21 13:28:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TWljaGFsIFZva8OhxI0=?= X-Patchwork-Id: 917618 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="OI09VYLL"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40qKQM6szDz9s32 for ; Mon, 21 May 2018 23:30:03 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752661AbeEUN3R (ORCPT ); Mon, 21 May 2018 09:29:17 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:38260 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751103AbeEUN3K (ORCPT ); Mon, 21 May 2018 09:29:10 -0400 Received: by mail-wm0-f67.google.com with SMTP id m129-v6so26529151wmb.3; Mon, 21 May 2018 06:29:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lJ0oyMlXPt6A2GeMGNwPe/PjTOtqWsKb9bjlT5Pe7Nk=; b=OI09VYLLFXLcU4sUn2cbWgv0iaN4gbJhntxv6LhM/CFVrxZxTEJEtiEzRyEr+OCvKt ha1Q6ZzQtL2Hl6JB/O1eGOvpD3XQoC0mavavjoltCEP3ceo5plTfxpoXMAeHa4I3twnq MU7iSpffBQ+c7rU0NVByfbiiHSOthYPHhUAPEt7F2C45nZwKR5kfqKHX8DpVjnt5czWZ b9Ay0pbq+HFtMoWG6pxqfwX8cs4iyfpCsQlWZF+mUjBNBeORh8CCTxWxitfZYdFYJOwv fQdrlIzg0BpVpVj4kkHT3EEMq7H+H56R/k9TGeXBzFKocTZ5s0a6X6VW3R8xRYZUQCEz y0xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lJ0oyMlXPt6A2GeMGNwPe/PjTOtqWsKb9bjlT5Pe7Nk=; b=ejC2iLWsqxpyofrI3Yxyq/RHoUWLlqT3IHcPHmuO9w3liPcRGd95tTn3+dTN18RxLN uAmvCQVacTvgda3Urezze+VhFLzGj8jdCFbPH+CDC8xrZl272McylQ5Wt77WNwqTPqcD 0CSaTYuzRDEqWqSHg3YoULfisJho3x++IIW1L/JUtxsCFz3GEnD2vLk/H3W37HEZz7qy Lan2X0AOru3Q0B6vN9GzwzF975WSNJxw2J6jes7O7GpNnHV92JxO1/83PMmC5AjPNhWO wRy3Q/+I2hGpcrYCoWbGhaO2ezQRDjdy43ZgSB6pOFjdiN36HsmOM/wy2AZTIOeWgWVE lKXw== X-Gm-Message-State: ALKqPwfdon1hJKIBQUDbaJODlc3a2fZm2NIcoVIpWpeN4jISzCN9pgZg Fj8rfoSipZHlp7hY+7Qpkc8TlUq3 X-Google-Smtp-Source: AB8JxZp7RoyhYYAwTPh9ozdvmW0ktXYCZN30RCAIX8VlN4/Z4EOI9vG7qm1GLEqB/5xowxsvrAZ18Q== X-Received: by 2002:a1c:101:: with SMTP id 1-v6mr10862857wmb.28.1526909348422; Mon, 21 May 2018 06:29:08 -0700 (PDT) Received: from iota-build.ysoft.local ([89.24.100.190]) by smtp.gmail.com with ESMTPSA id 32-v6sm2402899wrf.33.2018.05.21.06.29.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 21 May 2018 06:29:07 -0700 (PDT) From: "=?UTF-8?q?Michal=20Vok=C3=A1=C4=8D?=" X-Google-Original-From: =?utf-8?b?TWljaGFsIFZva8OhxI0=?= To: netdev@vger.kernel.org, michal.vokac@ysoft.com Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, f.fainelli@gmail.com, vivien.didelot@savoirfairelinux.com, andrew@lunn.ch, mark.rutland@arm.com, robh+dt@kernel.org, davem@davemloft.net Subject: [PATCH net-next 1/7] net: dsa: qca8k: Add QCA8334 binding documentation Date: Mon, 21 May 2018 15:28:07 +0200 Message-Id: <1526909293-56377-2-git-send-email-michal.vokac@ysoft.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1526909293-56377-1-git-send-email-michal.vokac@ysoft.com> References: <1526909293-56377-1-git-send-email-michal.vokac@ysoft.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Signed-off-by: Michal Vokáč --- Documentation/devicetree/bindings/net/dsa/qca8k.txt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.txt b/Documentation/devicetree/bindings/net/dsa/qca8k.txt index 9c67ee4..3d73cd0 100644 --- a/Documentation/devicetree/bindings/net/dsa/qca8k.txt +++ b/Documentation/devicetree/bindings/net/dsa/qca8k.txt @@ -2,7 +2,10 @@ Required properties: -- compatible: should be "qca,qca8337" +- compatible: should be one of: + "qca,qca8334" + "qca,qca8337" + - #size-cells: must be 0 - #address-cells: must be 1 From patchwork Mon May 21 13:28:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TWljaGFsIFZva8OhxI0=?= X-Patchwork-Id: 917617 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="q47USE+a"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40qKQ708Fkz9s16 for ; Mon, 21 May 2018 23:29:50 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752092AbeEUN3W (ORCPT ); Mon, 21 May 2018 09:29:22 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:43006 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751280AbeEUN3L (ORCPT ); Mon, 21 May 2018 09:29:11 -0400 Received: by mail-wr0-f193.google.com with SMTP id t16-v6so12845284wrm.9; Mon, 21 May 2018 06:29:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=c6fiNVAWxxeK2QcbCjLzi6p8Ygq1fzO+Fw2sCBLSKHs=; b=q47USE+aay1F8bknABbiMa6eb5YomRDwyvv+5X7PAJ9kjujnRgBqa/bRwiRQeApWaN mDgv4xrHs6GyH49maUM7tQCdrP+C8HN3KtDPuwzzYhgh3MdyNt17xdxXrPKzJZtiH9AP Cx/mRldcuYN/z6WHziTvQSTxhnSW72/mIuv6cITvm36yewpuAeNscWzOYv2ImeMJXzr3 zvNQ3tSIDjPOp7Cf5Eb8TzzsIzsqE7hR+WEDza6brMGxGnqZ4jqLhWac3cICpaipLyH9 qwN0nb9NkGwgB/ILhyLnuX4ybdGjdN7zpC8W52rQy3+fbAeU2nZKTW5oambbPHgHcQPz oXag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=c6fiNVAWxxeK2QcbCjLzi6p8Ygq1fzO+Fw2sCBLSKHs=; b=jlNH6UZ4nUJOcrsAoH8MjrMhMN2Q0D5pWemxoR9AKm9To369mloavhmj/+XpSV0+zY 84kpLsBkRHjpipucf51SwHJt9ljv0tukGiU9qgL3jOemsMBRaHitF+5R+iCQsvgOFcDO rzdhgQjVTF5tIp38CkJ3Yfvwid2aeXe+t+pZOHD6yx35e1EMQlysf1Cn8doYl6DNBzuX ps9Kaj5h9cOrkxAsvMqiyu6rbR7MRVumULhuKNO+y44IRYjtq6moUndZTqSgODJ66xm4 iCEKEBLPKsyKaVJlHsvrO1h062BFv7lF7vBf9Qqdyjhpzp5LVq4WDkeBIBa0yCr47BnI l21g== X-Gm-Message-State: ALKqPwdrMvNqWl83Y6bMeBQeDQKsnF1ucWOMKmuf2e+4qrwzqt/uo5Vl 3MvppmYQguy5msSHZ3RYsG6HDYTa X-Google-Smtp-Source: AB8JxZrAQ6MyW3gy3Yl0SMXspmxN3hZyAYiriQRdbY8vQKKJNwKynoV37tlVGfjq1zHnekbN2/7riA== X-Received: by 2002:adf:84e2:: with SMTP id 89-v6mr4184025wrg.167.1526909349619; Mon, 21 May 2018 06:29:09 -0700 (PDT) Received: from iota-build.ysoft.local ([89.24.100.190]) by smtp.gmail.com with ESMTPSA id 32-v6sm2402899wrf.33.2018.05.21.06.29.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 21 May 2018 06:29:09 -0700 (PDT) From: "=?UTF-8?q?Michal=20Vok=C3=A1=C4=8D?=" X-Google-Original-From: =?utf-8?b?TWljaGFsIFZva8OhxI0=?= To: netdev@vger.kernel.org, michal.vokac@ysoft.com Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, f.fainelli@gmail.com, vivien.didelot@savoirfairelinux.com, andrew@lunn.ch, mark.rutland@arm.com, robh+dt@kernel.org, davem@davemloft.net Subject: [PATCH net-next 2/7] net: dsa: qca8k: Add support for QCA8334 switch Date: Mon, 21 May 2018 15:28:08 +0200 Message-Id: <1526909293-56377-3-git-send-email-michal.vokac@ysoft.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1526909293-56377-1-git-send-email-michal.vokac@ysoft.com> References: <1526909293-56377-1-git-send-email-michal.vokac@ysoft.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Signed-off-by: Michal Vokáč --- drivers/net/dsa/qca8k.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c index 3684e56..6a3ffb2 100644 --- a/drivers/net/dsa/qca8k.c +++ b/drivers/net/dsa/qca8k.c @@ -1010,6 +1010,7 @@ static SIMPLE_DEV_PM_OPS(qca8k_pm_ops, qca8k_suspend, qca8k_resume); static const struct of_device_id qca8k_of_match[] = { + { .compatible = "qca,qca8334" }, { .compatible = "qca,qca8337" }, { /* sentinel */ }, }; From patchwork Mon May 21 13:28:09 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TWljaGFsIFZva8OhxI0=?= X-Patchwork-Id: 917623 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="gjLA+DAq"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40qKRx444Gz9s32 for ; Mon, 21 May 2018 23:31:25 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752829AbeEUNbN (ORCPT ); Mon, 21 May 2018 09:31:13 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:34795 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751656AbeEUN3M (ORCPT ); Mon, 21 May 2018 09:29:12 -0400 Received: by mail-wr0-f194.google.com with SMTP id j1-v6so5071242wrm.1; Mon, 21 May 2018 06:29:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CUQDZtbrwC+PTscvq7TgW6+Nua94RkVniw6mMpUWsXI=; b=gjLA+DAq8va6hbHwn8qDgdOphfflysCgp2ZA1BqePIs0u/jZi+rUF6OKoyrfQS7ySR zKxt1Jww3cBk6B4BQMPezyBUEvreI0+27CF949kQf9AN2GfncdFPtMFFSIwQomkG7P1L Fon4XrrPrwP/50Fj8/7F1RPfo32G4gAgCs8s8I+zZHzrkff5+5i7oHAIn8+b8VcqeZGs J6AMLKUzjeyVMGrOW/s338fwHf4AtFgdGlRt03HD3KpkYqqxNSeTt3U4DUJUpxuapNzR IK7WLYq/9mpVTZ7iPSUHc8V/+I33+TO1LbJhixSpB8ulABmGLdNlvLXGpBf/8Cwv+A0B 9TSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CUQDZtbrwC+PTscvq7TgW6+Nua94RkVniw6mMpUWsXI=; b=PHqcwIJEbTAsd0QyrUMRWPO2yVXhfepKe7vVaHYl/fudzvfFIbAmzPxZURhYMK0dEP sxNR5hfDg4g56jCklHoeqsj6Iju73yFFLJ6O/0glCt5vzRf8Epk+nxd9psYXhLm2mn3R DwE3cUvfEVRqRRDIkAXkh8HOm7wN4+lcz2YcYmYTBn7TFOGYLK6LCuNhV+Ztk8IhZkLt bjL4OIKrUXqKL0a4dM0RrYdkeh9mQrGndliLDpzhpwQFd+dD38XgC5hCXuq7Hx/jXz+h JR55kgaMFkuq7VrqPDj0lGj8ok8KhfbC+9duaRgfE26gYEwBLgfRXiqdKel1TXnx29Cp zs0w== X-Gm-Message-State: ALKqPwdUyTKA1d8h5XTSTvbbX0UWZUbg5IVH03V2Kt6X+v+xv5N6ZP+X j5oy9b4NDuwJYATwoaLSmbfLyZo9 X-Google-Smtp-Source: AB8JxZo9Ifob/sK6Zu8j3lqeERKbT+XTLm5uhDA+sKnwNv0XhF0TSZoVQJEg3N2QWiPlHcVCdW/zuA== X-Received: by 2002:adf:8ec7:: with SMTP id q65-v6mr15786814wrb.261.1526909350785; Mon, 21 May 2018 06:29:10 -0700 (PDT) Received: from iota-build.ysoft.local ([89.24.100.190]) by smtp.gmail.com with ESMTPSA id 32-v6sm2402899wrf.33.2018.05.21.06.29.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 21 May 2018 06:29:10 -0700 (PDT) From: "=?UTF-8?q?Michal=20Vok=C3=A1=C4=8D?=" X-Google-Original-From: =?utf-8?b?TWljaGFsIFZva8OhxI0=?= To: netdev@vger.kernel.org, michal.vokac@ysoft.com Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, f.fainelli@gmail.com, vivien.didelot@savoirfairelinux.com, andrew@lunn.ch, mark.rutland@arm.com, robh+dt@kernel.org, davem@davemloft.net Subject: [PATCH net-next 3/7] net: dsa: qca8k: Enable RXMAC when bringing up a port Date: Mon, 21 May 2018 15:28:09 +0200 Message-Id: <1526909293-56377-4-git-send-email-michal.vokac@ysoft.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1526909293-56377-1-git-send-email-michal.vokac@ysoft.com> References: <1526909293-56377-1-git-send-email-michal.vokac@ysoft.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org When a port is brought up/down do not enable/disable only the TXMAC but the RXMAC as well. This is essential for the CPU port to work. Signed-off-by: Michal Vokáč Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli --- drivers/net/dsa/qca8k.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c index 6a3ffb2..0d224f3 100644 --- a/drivers/net/dsa/qca8k.c +++ b/drivers/net/dsa/qca8k.c @@ -516,7 +516,7 @@ qca8k_set_pad_ctrl(struct qca8k_priv *priv, int port, int mode) static void qca8k_port_set_status(struct qca8k_priv *priv, int port, int enable) { - u32 mask = QCA8K_PORT_STATUS_TXMAC; + u32 mask = QCA8K_PORT_STATUS_TXMAC | QCA8K_PORT_STATUS_RXMAC; pr_debug("qca: port %i set status %i\n", port, enable); From patchwork Mon May 21 13:28:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TWljaGFsIFZva8OhxI0=?= X-Patchwork-Id: 917621 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="u1KXv4Gu"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40qKRN0hnQz9s32 for ; Mon, 21 May 2018 23:30:56 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752822AbeEUNax (ORCPT ); Mon, 21 May 2018 09:30:53 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:36598 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751712AbeEUN3N (ORCPT ); Mon, 21 May 2018 09:29:13 -0400 Received: by mail-wr0-f195.google.com with SMTP id k5-v6so3931158wrn.3; Mon, 21 May 2018 06:29:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2PcRi1kOS2b0fFkDOrP2YFeaiGjU5ZE54ZcQ+VPSy0s=; b=u1KXv4Gu5lz8CFbUxecsuQ3N+PGVUhUg++1Lm3l5oXamAnHhpzUbghVhVAN2d3WiL9 Ir0va+SMNnzRoRJ/Tk4Lyi2TVmbTIoKp4Q6Uk1jrj1QNLi8M6FyRK/lsUKm1dyhWgU5D cggExVQXPSbX9BC1QkSmk/cOnNkpaMIHD7Wla9Vre1yOhdrZC13loJSW12PuDIZOZNgh OhDHoejsy9mdxhRiJRD4VGPOLBYlO6tRLLyZN8m/Bm/roxAXkrrwUNDRB1TeW8+W3tbl 3Wf+fkbr7MpR84YRA4/CL+SjM0V6c/+vWZmnyS8rd7nafCYtC1kiatAaQQP6I1NJF3Jw 8/5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2PcRi1kOS2b0fFkDOrP2YFeaiGjU5ZE54ZcQ+VPSy0s=; b=ECrP8RWWM5TPP78qrqtbjAOR3dDzRaU8O7qDzmdhdvpNX3fnXaxWzBTkYv2HFYMqn9 /aT1WoLvSdjp89VTM2glU4OqKGvKM71vkHDg3KWutDmGoo77LqsC0h4T2ol4BwmkU/km z72eijKBEZYfhu932rm+0Q2SHShSu9duKfTlhnC9RSfDUJsjE8KTh2lrKjY+eAW7IITp bDRQ7s9PGU58X9+0sHf/H9muMaSE4QYZwUUKHDyGPMOILXsPFl0wgKqKhrkeEpiH1ajI U5zooMMIKdZU1/FeBW5HoEkAwvZUgssy4HHSa/XC9+Jb39zSuo1zUQrYl5LM6EUMVsO/ nCkQ== X-Gm-Message-State: ALKqPwcvulKvHhCYDUMPhBLPP+Zapjn+vpMFkvE+8hYMaHkg+8mLBy11 vSG33D4AOLFYByWbeWW3ZEYhAv2E X-Google-Smtp-Source: AB8JxZo9VzKH2Uf4gY2rk9QomL2Qm+HSZIOEEAQWbFQaNdVDlBUS0yoPLizlN+U3BHFN0XZIbw3rbw== X-Received: by 2002:adf:82d6:: with SMTP id 80-v6mr5631868wrc.77.1526909351855; Mon, 21 May 2018 06:29:11 -0700 (PDT) Received: from iota-build.ysoft.local ([89.24.100.190]) by smtp.gmail.com with ESMTPSA id 32-v6sm2402899wrf.33.2018.05.21.06.29.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 21 May 2018 06:29:11 -0700 (PDT) From: "=?UTF-8?q?Michal=20Vok=C3=A1=C4=8D?=" X-Google-Original-From: =?utf-8?b?TWljaGFsIFZva8OhxI0=?= To: netdev@vger.kernel.org, michal.vokac@ysoft.com Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, f.fainelli@gmail.com, vivien.didelot@savoirfairelinux.com, andrew@lunn.ch, mark.rutland@arm.com, robh+dt@kernel.org, davem@davemloft.net Subject: [PATCH net-next 4/7] net: dsa: qca8k: Force CPU port to its highest bandwidth Date: Mon, 21 May 2018 15:28:10 +0200 Message-Id: <1526909293-56377-5-git-send-email-michal.vokac@ysoft.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1526909293-56377-1-git-send-email-michal.vokac@ysoft.com> References: <1526909293-56377-1-git-send-email-michal.vokac@ysoft.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org By default autonegotiation is enabled to configure MAC on all ports. For the CPU port autonegotiation can not be used so we need to set some sensible defaults manually. This patch forces the default setting of the CPU port to 1000Mbps/full duplex which is the chip maximum capability. Also correct size of the bit field used to configure link speed. Signed-off-by: Michal Vokáč Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli --- drivers/net/dsa/qca8k.c | 6 +++++- drivers/net/dsa/qca8k.h | 6 ++++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c index 0d224f3..14a108b38 100644 --- a/drivers/net/dsa/qca8k.c +++ b/drivers/net/dsa/qca8k.c @@ -537,6 +537,7 @@ qca8k_setup(struct dsa_switch *ds) { struct qca8k_priv *priv = (struct qca8k_priv *)ds->priv; int ret, i, phy_mode = -1; + u32 mask; pr_debug("qca: setup\n"); @@ -564,7 +565,10 @@ qca8k_setup(struct dsa_switch *ds) if (ret < 0) return ret; - /* Enable CPU Port */ + /* Enable CPU Port, force it to maximum bandwidth and full-duplex */ + mask = QCA8K_PORT_STATUS_SPEED_1000 | QCA8K_PORT_STATUS_TXFLOW | + QCA8K_PORT_STATUS_RXFLOW | QCA8K_PORT_STATUS_DUPLEX; + qca8k_write(priv, QCA8K_REG_PORT_STATUS(QCA8K_CPU_PORT), mask); qca8k_reg_set(priv, QCA8K_REG_GLOBAL_FW_CTRL0, QCA8K_GLOBAL_FW_CTRL0_CPU_PORT_EN); qca8k_port_set_status(priv, QCA8K_CPU_PORT, 1); diff --git a/drivers/net/dsa/qca8k.h b/drivers/net/dsa/qca8k.h index 1cf8a92..5bda165 100644 --- a/drivers/net/dsa/qca8k.h +++ b/drivers/net/dsa/qca8k.h @@ -51,8 +51,10 @@ #define QCA8K_GOL_MAC_ADDR0 0x60 #define QCA8K_GOL_MAC_ADDR1 0x64 #define QCA8K_REG_PORT_STATUS(_i) (0x07c + (_i) * 4) -#define QCA8K_PORT_STATUS_SPEED GENMASK(2, 0) -#define QCA8K_PORT_STATUS_SPEED_S 0 +#define QCA8K_PORT_STATUS_SPEED GENMASK(1, 0) +#define QCA8K_PORT_STATUS_SPEED_10 0 +#define QCA8K_PORT_STATUS_SPEED_100 0x1 +#define QCA8K_PORT_STATUS_SPEED_1000 0x2 #define QCA8K_PORT_STATUS_TXMAC BIT(2) #define QCA8K_PORT_STATUS_RXMAC BIT(3) #define QCA8K_PORT_STATUS_TXFLOW BIT(4) From patchwork Mon May 21 13:28:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TWljaGFsIFZva8OhxI0=?= X-Patchwork-Id: 917616 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="BeN6+RPM"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40qKPf5NBKz9s37 for ; Mon, 21 May 2018 23:29:26 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752702AbeEUN3Y (ORCPT ); Mon, 21 May 2018 09:29:24 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:38447 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752318AbeEUN3P (ORCPT ); Mon, 21 May 2018 09:29:15 -0400 Received: by mail-wr0-f195.google.com with SMTP id 94-v6so16018034wrf.5; Mon, 21 May 2018 06:29:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OyQtEqIRe8N/9OZDWH7vDpJKzhHc1I1WJNKSGlcc2OQ=; b=BeN6+RPMxdKhF8hLQy7d85bbLexWm2lumthDnVRewye+Kr+5evBwOrlyNtGLg+UgA1 ON+RUaY3SGxIz5Bl04m9C2oltllz+7h9Q3Ej4GWKl7uLQC+deRr6e2ZhBBExJL7gYEeu 6OdXjGbKiBlvsDW8AvzEoICrBYzxIUMmJDDIyg0n1EiWH6+gas3qxGnHdsImMpC43QXl dk3vcnMQu6B27xfQWT01R+M5wR/1VcbXxRT//6M+kRkxfOOKe2YLh4lfoQZa6Y/GiSlo 40Sk0zdTlhwhXkjJFnUssxFYIUgio2M0hMQvq0hnoQq50hoPlXTrONueKVwdSDqA98KZ 6iSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OyQtEqIRe8N/9OZDWH7vDpJKzhHc1I1WJNKSGlcc2OQ=; b=dUpZOXtaCVRs22w0bGmfx8IlwxoMSrs1/Qmzw3IYqbH7BcxwehvQXtsffAvLhjg0uV yyFgH33MhXXM1j5VOmWKCSG1uFeqEQoTcKhCQ5+/Id0pvHIbpKpb8bARHAqTu3i44JZR Uks7Aox3u3NQZafy97GzfJVDyTx0M38YNkcIT2NSgAI+OfSoNKPvYThwwLNhG02ZfR5i OTRe78f8aKlYBXhLzAmWHWon5zRCgTaTSzcHHaGHbkbgtI7TC7+sw8/r4Eu8shyTGq8D 1avi1SnngycadxTwQMtZQ/2w30qOUPGXn/VuJSSs0DipPlx/T03DlnUrc4kb9CXbxJky V5PQ== X-Gm-Message-State: ALKqPwcJvCBgGZVWgMLIZAU7bVxLf5oYhwugHkIYGj2jQjpdKGCBhfZM +Uy4ufmrbnBmf4hKjeQ8O/+B4AYv X-Google-Smtp-Source: AB8JxZoEF8R09X/tvfVltSORD1CgI4Ker+KQmr8zlXoU80WDY/Z/9GgakV9oihkwAFAKwfJDwDHfSw== X-Received: by 2002:adf:9ae5:: with SMTP id a92-v6mr14776348wrc.180.1526909353082; Mon, 21 May 2018 06:29:13 -0700 (PDT) Received: from iota-build.ysoft.local ([89.24.100.190]) by smtp.gmail.com with ESMTPSA id 32-v6sm2402899wrf.33.2018.05.21.06.29.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 21 May 2018 06:29:12 -0700 (PDT) From: "=?UTF-8?q?Michal=20Vok=C3=A1=C4=8D?=" X-Google-Original-From: =?utf-8?b?TWljaGFsIFZva8OhxI0=?= To: netdev@vger.kernel.org, michal.vokac@ysoft.com Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, f.fainelli@gmail.com, vivien.didelot@savoirfairelinux.com, andrew@lunn.ch, mark.rutland@arm.com, robh+dt@kernel.org, davem@davemloft.net Subject: [PATCH net-next 5/7] net: dsa: qca8k: Allow overwriting CPU port setting Date: Mon, 21 May 2018 15:28:11 +0200 Message-Id: <1526909293-56377-6-git-send-email-michal.vokac@ysoft.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1526909293-56377-1-git-send-email-michal.vokac@ysoft.com> References: <1526909293-56377-1-git-send-email-michal.vokac@ysoft.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Implement adjust_link function that allows to overwrite default CPU port setting using fixed-link device tree subnode. Signed-off-by: Michal Vokáč Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli --- drivers/net/dsa/qca8k.c | 43 +++++++++++++++++++++++++++++++++++++++++++ drivers/net/dsa/qca8k.h | 1 + 2 files changed, 44 insertions(+) diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c index 14a108b38..7eba987 100644 --- a/drivers/net/dsa/qca8k.c +++ b/drivers/net/dsa/qca8k.c @@ -636,6 +636,47 @@ qca8k_setup(struct dsa_switch *ds) return 0; } +static void +qca8k_adjust_link(struct dsa_switch *ds, int port, struct phy_device *phy) +{ + struct qca8k_priv *priv = ds->priv; + u32 reg; + + /* Force fixed-link setting for CPU port, skip others. */ + if (!phy_is_pseudo_fixed_link(phy)) + return; + + /* Set port speed */ + switch (phy->speed) { + case 10: + reg = QCA8K_PORT_STATUS_SPEED_10; + break; + case 100: + reg = QCA8K_PORT_STATUS_SPEED_100; + break; + case 1000: + reg = QCA8K_PORT_STATUS_SPEED_1000; + break; + default: + dev_dbg(priv->dev, "port%d link speed %dMbps not supported.\n", + port, phy->speed); + return; + } + + /* Set duplex mode */ + if (phy->duplex == DUPLEX_FULL) + reg |= QCA8K_PORT_STATUS_DUPLEX; + + /* Force flow control */ + if (dsa_is_cpu_port(ds, port)) + reg |= QCA8K_PORT_STATUS_RXFLOW | QCA8K_PORT_STATUS_TXFLOW; + + /* Force link down before changing MAC options */ + qca8k_port_set_status(priv, port, 0); + qca8k_write(priv, QCA8K_REG_PORT_STATUS(port), reg); + qca8k_port_set_status(priv, port, 1); +} + static int qca8k_phy_read(struct dsa_switch *ds, int phy, int regnum) { @@ -909,6 +950,7 @@ qca8k_get_tag_protocol(struct dsa_switch *ds, int port) static const struct dsa_switch_ops qca8k_switch_ops = { .get_tag_protocol = qca8k_get_tag_protocol, .setup = qca8k_setup, + .adjust_link = qca8k_adjust_link, .get_strings = qca8k_get_strings, .phy_read = qca8k_phy_read, .phy_write = qca8k_phy_write, @@ -942,6 +984,7 @@ qca8k_sw_probe(struct mdio_device *mdiodev) return -ENOMEM; priv->bus = mdiodev->bus; + priv->dev = &mdiodev->dev; /* read the switches ID register */ id = qca8k_read(priv, QCA8K_REG_MASK_CTRL); diff --git a/drivers/net/dsa/qca8k.h b/drivers/net/dsa/qca8k.h index 5bda165..613fe5c5 100644 --- a/drivers/net/dsa/qca8k.h +++ b/drivers/net/dsa/qca8k.h @@ -167,6 +167,7 @@ struct qca8k_priv { struct ar8xxx_port_status port_sts[QCA8K_NUM_PORTS]; struct dsa_switch *ds; struct mutex reg_mutex; + struct device *dev; }; struct qca8k_mib_desc { From patchwork Mon May 21 13:28:12 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TWljaGFsIFZva8OhxI0=?= X-Patchwork-Id: 917620 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="HjTknUXb"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40qKRB3f49z9s32 for ; Mon, 21 May 2018 23:30:46 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752765AbeEUNaa (ORCPT ); Mon, 21 May 2018 09:30:30 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:38449 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751021AbeEUN3P (ORCPT ); Mon, 21 May 2018 09:29:15 -0400 Received: by mail-wr0-f196.google.com with SMTP id 94-v6so16018073wrf.5; Mon, 21 May 2018 06:29:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5Inb4vZFKwsQ25pt9PHkcalNJ0Qd39ZeyYKAo9Uq6C4=; b=HjTknUXbJjWuRlEW96C+njWWRRe5Jcucz40PsJxmD5OSzqrWVXf14ncPEPbu3AGsen 3AJzbKq3Zb007TKps1PrvYjHwKO1D1Fd5bjckFKXyKgaaP4VlyCVxJGqmVBylxzyXoh8 doUUT1KujIBN1G/fKtZdiRCDKXcMjpe747fVDoCTk9rkoFQGPKr+OZUJf2vEugyu+lYd 2AOZzUceHTa/R2zVPOpQFVlQiR+r0JlQY0o3f6HPwl2s4uoVto0TPaGyaG8oeZK7nJfx xMbwgyvZufklyYmf1/51nlTYfcHR/t+vkvJ4o7iC+uiUDJ67a68hPxCCFEUUnryFTUIn W+MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5Inb4vZFKwsQ25pt9PHkcalNJ0Qd39ZeyYKAo9Uq6C4=; b=nRqLufwOkynPYQcHsrvTv38CiCEpFy8qi5VqBA4iPCWLu3kwGtpMgodFy3260eb4WD Z0iBoSnpiWM4TV9vsBFDhPdWYRjMxAKiHz1d+HNEfJNp0UzZZ4mAyTb/sg3qdVshi9cd qb8J6kNW83xQbw2MWTMKH29k4w3MAi4PjEliB9RfYGjg254+wZmuGtPAWSrWqO9p+mBl HK7UuS5UJ4pfh+h57ceik8N5iz+7msvgPAKGOPuu26ZRURrdeFPseu/hcCNq5ZxFi5g3 qzvo5pKJDb+59h2AFnEc5T3XbALkcC+6aud6SaoE92BatxOLE10GllzZjDjoLFYIFNT9 P13A== X-Gm-Message-State: ALKqPwfAK6TbxjNdN9xnZWxYWm8PRdOyR1F5f29XHy4rztwY2X4HK+QO Yo7TEhAqgwpyUkl+CTEjYBaHo7Zi X-Google-Smtp-Source: AB8JxZpF8gnLxafN2LpXHJXKX3/J1pyou/wFu8BvHz7h1qP7MB3DmHDStr3IXZVUlbnqNQ/l0+ptLw== X-Received: by 2002:adf:8756:: with SMTP id 22-v6mr14262259wrz.117.1526909354151; Mon, 21 May 2018 06:29:14 -0700 (PDT) Received: from iota-build.ysoft.local ([89.24.100.190]) by smtp.gmail.com with ESMTPSA id 32-v6sm2402899wrf.33.2018.05.21.06.29.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 21 May 2018 06:29:13 -0700 (PDT) From: "=?UTF-8?q?Michal=20Vok=C3=A1=C4=8D?=" X-Google-Original-From: =?utf-8?b?TWljaGFsIFZva8OhxI0=?= To: netdev@vger.kernel.org, michal.vokac@ysoft.com Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, f.fainelli@gmail.com, vivien.didelot@savoirfairelinux.com, andrew@lunn.ch, mark.rutland@arm.com, robh+dt@kernel.org, davem@davemloft.net Subject: [PATCH net-next 6/7] net: dsa: qca8k: Replace GPL boilerplate by SPDX Date: Mon, 21 May 2018 15:28:12 +0200 Message-Id: <1526909293-56377-7-git-send-email-michal.vokac@ysoft.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1526909293-56377-1-git-send-email-michal.vokac@ysoft.com> References: <1526909293-56377-1-git-send-email-michal.vokac@ysoft.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Signed-off-by: Michal Vokáč Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli --- drivers/net/dsa/qca8k.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c index 7eba987..c834893 100644 --- a/drivers/net/dsa/qca8k.c +++ b/drivers/net/dsa/qca8k.c @@ -1,17 +1,9 @@ +// SPDX-License-Identifier: GPL-2.0 /* * Copyright (C) 2009 Felix Fietkau * Copyright (C) 2011-2012 Gabor Juhos * Copyright (c) 2015, The Linux Foundation. All rights reserved. * Copyright (c) 2016 John Crispin - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License version 2 and - * only version 2 as published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. */ #define DEBUG From patchwork Mon May 21 13:28:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TWljaGFsIFZva8OhxI0=?= X-Patchwork-Id: 917619 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="IJC3Zsss"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40qKQm0DnTz9s33 for ; Mon, 21 May 2018 23:30:24 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752734AbeEUNaJ (ORCPT ); Mon, 21 May 2018 09:30:09 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:39209 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752604AbeEUN3Q (ORCPT ); Mon, 21 May 2018 09:29:16 -0400 Received: by mail-wr0-f196.google.com with SMTP id w18-v6so12269888wrn.6; Mon, 21 May 2018 06:29:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YyggNc9h+1urH2LTiuIVq+W5kCxmnIQWJYF+jeH5dSs=; b=IJC3ZsssBkXtyArozJH89/yKyYIL6gSVfxZBYRViTtN1YFFCsP47n6yqgqq7PVyEbY Mwz3AcTD1Tc14z4gfve+1uJYFTs4S4dbRhUD30jusA8JMs2+seGX8PdocZN7eeHmCxXC uqTc0dw2/pcViXGGKxJ0VTleQr87dzn4VjTUeOGQhj6gdwxV1zTRaT8F9JNwLXTU/o7L H2xv28UIUnd5Oh4PgVtO0ebiqhnSLMXztyvxtuC1LY821YUBoelAxVEZF2M4HJ24fbNa KFQeQPN4mtxK/N13wfy/Gn+DWx3Gas0fLNn77St9RxtJcbvxafq+uqBzu7x2m0NpHrFt nw1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YyggNc9h+1urH2LTiuIVq+W5kCxmnIQWJYF+jeH5dSs=; b=e9DxE9mYL9OJugFVl1jdAR+AQ2K1Fn2qdaTHRdJduCYGC8BAoH/oKts0RpPekrMr8c 7JOPS7q0i9fNZGEMaNX6H5AaKPfhrUBQOZQhVY1tn6ZqvWVyio/8pGoIFwtF6iF/4oRQ SU9S7P5a5vmuXY7JpABJn41gFeUxm9TCHZkITbdIfUFbzEG9welPnVXy7U9G+Ue2BfXm ZoQP7EV347+B1U1Tr9lc/+oDDCcEXl6hnIGffCgwSoX0hGPNuXvX8u/JztfMiq0woQJr WYWEfpeLu+2N6zqiuk5v6rBr49NQUiIo7gvRGUNev75VVseVz4DXfmWFsBTKVFNzsbOo M1jQ== X-Gm-Message-State: ALKqPwev1vCqpVqoybhYD+tW6yXKLXjFZk4NXbTSXeptgHiPb4V8jF/c e1rEywOerhzMEeB0iPsm8ajj45F/ X-Google-Smtp-Source: AB8JxZrzWARvNCUf2r0lnpvlapkBAPjpQF25FdQ0mHXx/reIK9JUbfZjxSVgFBGO3m0RftgZ8rhNgw== X-Received: by 2002:adf:8b02:: with SMTP id n2-v6mr10382569wra.282.1526909355203; Mon, 21 May 2018 06:29:15 -0700 (PDT) Received: from iota-build.ysoft.local ([89.24.100.190]) by smtp.gmail.com with ESMTPSA id 32-v6sm2402899wrf.33.2018.05.21.06.29.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 21 May 2018 06:29:14 -0700 (PDT) From: "=?UTF-8?q?Michal=20Vok=C3=A1=C4=8D?=" X-Google-Original-From: =?utf-8?b?TWljaGFsIFZva8OhxI0=?= To: netdev@vger.kernel.org, michal.vokac@ysoft.com Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, f.fainelli@gmail.com, vivien.didelot@savoirfairelinux.com, andrew@lunn.ch, mark.rutland@arm.com, robh+dt@kernel.org, davem@davemloft.net Subject: [PATCH net-next 7/7] net: dsa: qca8k: Remove rudundant parentheses Date: Mon, 21 May 2018 15:28:13 +0200 Message-Id: <1526909293-56377-8-git-send-email-michal.vokac@ysoft.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1526909293-56377-1-git-send-email-michal.vokac@ysoft.com> References: <1526909293-56377-1-git-send-email-michal.vokac@ysoft.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fix warning reported by checkpatch. Signed-off-by: Michal Vokáč Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli --- drivers/net/dsa/qca8k.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c index c834893..c0da402 100644 --- a/drivers/net/dsa/qca8k.c +++ b/drivers/net/dsa/qca8k.c @@ -513,7 +513,7 @@ qca8k_port_set_status(struct qca8k_priv *priv, int port, int enable) pr_debug("qca: port %i set status %i\n", port, enable); /* Port 0 and 6 have no internal PHY */ - if ((port > 0) && (port < 6)) + if (port > 0 && port < 6) mask |= QCA8K_PORT_STATUS_LINK_AUTO; if (enable)