From patchwork Mon Apr 28 01:34:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Longbin Li X-Patchwork-Id: 2077966 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=OvB1QUBE; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=147.75.80.249; helo=am.mirrors.kernel.org; envelope-from=linux-pwm+bounces-5731-incoming=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from am.mirrors.kernel.org (am.mirrors.kernel.org [147.75.80.249]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Zm5cp0jYYz1yMg for ; Mon, 28 Apr 2025 11:35:54 +1000 (AEST) Received: from smtp.subspace.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id CCD5D1899452 for ; Mon, 28 Apr 2025 01:36:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F0655156228; Mon, 28 Apr 2025 01:35:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OvB1QUBE" X-Original-To: linux-pwm@vger.kernel.org Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F599A945; Mon, 28 Apr 2025 01:35:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745804158; cv=none; b=AF+R23uZ+9G7EbdqdZlmecCBFf7eTaGXFv2t+CUrT72BS4MKfBwaqbH37dhe+PRij/dBbQ58cYWrpYguWBCSatfHxS8QWVPsI3naLpKDMqvs42IiX8PcDa40y+QxgvI9eyvQYT8R8zsIVx8BD8o2jCOwiET6u2M6GoZ2oLYQHVE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745804158; c=relaxed/simple; bh=t1QahdLTkbggHPkd85bqDjxlEjBR+yVNZ2AkbAlaWf4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CrFuViPr+4STQyAYuBuOarRIpRmSbwK10fOI6eN66hodHt6jPxpWvJuNP2qxCz6lsORo6B8sgDgHkJj4zENF+nDTeUxYIeQ9OHQclpjAfxhJqIq7UsfDzUAU7Glyjl5qUtw+nHv324dxIMdG3hZDRSsNFZW8UOohsQbrS2i5hrE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OvB1QUBE; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-30820167b47so4076037a91.0; Sun, 27 Apr 2025 18:35:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745804157; x=1746408957; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pHBvgY1YVP5MIQkksIw+XJJlNkG/WcVVicP7k946nis=; b=OvB1QUBEkH2zDrm9xI+qfFFiS9Yq5R6/ic6zeJHacUwFen37wSRu0MQMLu0C/TNHU/ yKg8yOX23Kkoq1BO4wf8KAlgafvRnJA5M79IBGbC54kt06PYotlS41Bvm9VCY8HmNU5g RhQbQEwWXYc6U8l9Zs6xi+9NsgCoHdA4zw/Qa8coL1sKiKJ3Hsb8FmECL6qRbDJVXQIJ MD/w4BXb+Im9SQm9rIVfEvMZo5H6qrG/t9jTeBxMVD/rWnQ/p+mdZ44GpWQcYoI7rrWM cdNJ6BsIjNF6PFfiwu+Uh+V/B2OKLvlHIzMWJ+CZUk5mJ67Mo1lBG08FBT2BNOoRzhgd yZaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745804157; x=1746408957; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pHBvgY1YVP5MIQkksIw+XJJlNkG/WcVVicP7k946nis=; b=GPsFcldPQQqFC2xR4Pg3SH5wumpg291DhAT1Z2dvRSGKCX/Jea20ouQPXa01e+x0ua e1qW7xpwMBzwzfslSNiEf6uMzHrydgESmHUKwU3kuWMXwERiEgQ/xb4iyFFXeHTelUO7 Le52PxXGNLr2FbdadwfItfWmMUEavrqfck1qEF6zrQ76uKRR9Ey0p+w6qUhMqto5RDyj jRkUwP1pjgUNtnPLUKdFb7xKdgymWB6GA46kO/CMFwfra2PZxrezLDRxJnndYKIUFpVj LkeTVvvZ6dnysyZN3nzM/D+2TtJGNov40QJY4bosoLkZ65fPTCurkZAFeQKIV0ArfAfU iJUw== X-Forwarded-Encrypted: i=1; AJvYcCUN6JHU9yVNqfmQWLmk3pfTocgJb1wrbD2ep5R0sIhHiiF8/OwtkrZYMRe6iwS9gSwij4MHNnlwAotu@vger.kernel.org, AJvYcCUeSQg/zz5aBTq4Q/iNs+ci3OMJWzFrf7Qz/EmS/sopyad3K5gDGfqnW75v3TjDPDg0h8ss8LOlLh03@vger.kernel.org, AJvYcCXYR/+f1K/OVjgJUD0SkGmvU+WujWa1EALHVxenYq60gjrZiB6pe7lYc1HirT05PlOLQ/SVYHCJRa2Q++/y@vger.kernel.org X-Gm-Message-State: AOJu0Yxso8cxcYJmIweU6Qu8MaL+i/ExlVMUQvM4/5e8Y3to1zz0NQ5P xh03HzONNlx1y2rihqYLE/y0V6JJyktNZOehC02ul3B6B0mEvJzg X-Gm-Gg: ASbGncv+gbztBk7vc3+jBOTW+DXRlpcAf8Hcjfe+t9pqhn48LoqLOsf7HUfUMZvkNTD H7kcOHh+QmwZU8K7hk1JImnNgoNHcCxGbeAIk71D95hSsnVfNtdAI8QBXvn3EdZ55sxZgicWeaN PKPcNdK28F6mTjWHn/SIK9059VL8ojkpbjiOG0/Q1XUywsTM1lH1soPYrIWzCLsyRUQ7Ae5wlGx HhsB1WwpOT+BLxMRvKrvMXBxit0+8gtMkDf4lXSguGGL6FkaZbMBu+Q2c1ieIK6wCu48SPNUqA2 pQPbQ5JLBVDw X-Google-Smtp-Source: AGHT+IFqoBqa1cKvvhGBCQiK2llHcQRAb6wNABgaxcrqM57k4VTCHHFQ9C6HjSqiASDd5djKAcaSlA== X-Received: by 2002:a17:90b:5870:b0:2ee:c30f:33c9 with SMTP id 98e67ed59e1d1-309f8a076f5mr14749294a91.14.1745804156600; Sun, 27 Apr 2025 18:35:56 -0700 (PDT) Received: from cu.. ([2001:da8:7001:11::460]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-309ef03bb26sm8508671a91.6.2025.04.27.18.35.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Apr 2025 18:35:56 -0700 (PDT) From: Longbin Li To: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen Wang , Inochi Amaoto , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti Cc: Longbin Li , linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, sophgo@lists.linux.dev, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Krzysztof Kozlowski Subject: [PATCH v4 1/3] dt-bindings: pwm: sophgo: add pwm controller for SG2044 Date: Mon, 28 Apr 2025 09:34:48 +0800 Message-ID: <20250428013501.6354-2-looong.bin@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250428013501.6354-1-looong.bin@gmail.com> References: <20250428013501.6354-1-looong.bin@gmail.com> Precedence: bulk X-Mailing-List: linux-pwm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Add compatible string for PWM controller on SG2044. Signed-off-by: Longbin Li Tested-by: Chen Wang Reviewed-by: Chen Wang Acked-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/pwm/sophgo,sg2042-pwm.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 2.49.0 diff --git a/Documentation/devicetree/bindings/pwm/sophgo,sg2042-pwm.yaml b/Documentation/devicetree/bindings/pwm/sophgo,sg2042-pwm.yaml index bbb6326d47d7..e0e91aa237ec 100644 --- a/Documentation/devicetree/bindings/pwm/sophgo,sg2042-pwm.yaml +++ b/Documentation/devicetree/bindings/pwm/sophgo,sg2042-pwm.yaml @@ -17,7 +17,9 @@ allOf: properties: compatible: - const: sophgo,sg2042-pwm + enum: + - sophgo,sg2042-pwm + - sophgo,sg2044-pwm reg: maxItems: 1 From patchwork Mon Apr 28 01:34:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Longbin Li X-Patchwork-Id: 2077968 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=inGTE+gz; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=147.75.48.161; helo=sy.mirrors.kernel.org; envelope-from=linux-pwm+bounces-5732-incoming=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org [147.75.48.161]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Zm5d03XvMz1yMg for ; Mon, 28 Apr 2025 11:36:04 +1000 (AEST) Received: from smtp.subspace.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 0805C7AC68A for ; Mon, 28 Apr 2025 01:35:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F00691632DF; Mon, 28 Apr 2025 01:36:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="inGTE+gz" X-Original-To: linux-pwm@vger.kernel.org Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52E1C14BF89; Mon, 28 Apr 2025 01:36:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745804163; cv=none; b=hkQfrDzL78195P6hYJKZ5QGxQDF1XuEa+NblZO6xilFgYY2RLDHoxmRCdCERfdqMbx8qmAFa20KUVJvLWoOCueJwBbfRhWAYKCsCvNt5+16kpr50YYYst8QI7w5TEZ4m2TqoVV7bXfENMbjDvWLkQM5hx5esz0YiM52LBx+u26M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745804163; c=relaxed/simple; bh=KVPIWLMbsRzdhWS/MzSM6OjFjPRyaTi+mNpqH0dKv1Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sMP/nSO1qLr4HicrZQ+PlctQNAgTPpbsDLMTr88HEPvRAZHr6r55TPnTZtcPy6sHOKYIjXFddQvk+i3yKcGEe5YdK0JTBcme3x21OahexNhjjNcKr3qjmvqucbphFhs1YUyFRZNiRIouNkERDOuidctUlzkKS9omB4wVBwYhmkU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=inGTE+gz; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-3031354f134so3477189a91.3; Sun, 27 Apr 2025 18:36:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745804161; x=1746408961; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gHhp31roZ+6LDh1o6IeC+4GGTrHD68JTiVVSEKfH8PU=; b=inGTE+gzjFJghBN9J97osRjZYHMC/N/TU4/LOVsiK9sq5kREQGhspnkb7tFTsQER7y jWar8cUUrbXI9hQAdqSrgzuvEjqTyt4Y+aBNvviu1j7EMKik5AXtPtgny7HsFF1S6RQ8 EMJojTMGXQP4KN7PyAefYhio9CVUEK9nwQS5Erg5V1cl7rGeF212s9MmaIm5P9Fv13Jz RZSyZb4qvEU7WVKcLHnmG4kDFMkA/0puqS5tTjx/JOxOilldPSUJpktJpBG+B0Oak0Yv KRlq5WWDZh3f8Ga4yfX5J0jofoyzZ3Z0WmqCE7059UlzFMtiNjcygmIGhLuXt6dHRqJD vBdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745804161; x=1746408961; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gHhp31roZ+6LDh1o6IeC+4GGTrHD68JTiVVSEKfH8PU=; b=soo1dsEu9/jNi4tnIXVd2HGyRAziIMNB2y26J/T/+cyeB41RqUOttoDGV7B0nFRdCW rulIHBWABR7QRNspFIVxXYvk2CfpxN5lmMZxSXpcojBV/yLywcvjj+zBciHp19p2kbKA Exm0WQpibzzVRBaLG9REtewf30CtE09c/3+DZfmhGTliAkmjhOW1EWLBrmxmFTS0uanT 47DZvQni4WkcOfPZ19+4wibOISBiTSI6+UZAKb5ev1oaJD59BpnE76l+AIShrQn8aQpM FPnpnwRtsuyZZZb1Im+OmmUI42XNX8l+/tPtCq3HL21Z1e1aLfN3EIuRusP2uIbPbkyN FCTg== X-Forwarded-Encrypted: i=1; AJvYcCUjQpJQB0xGMIF2R4iW345TZL2LzqLxkAmummVls3WuX7eveAAtpbX2BKhEF2Xy/1GSGNALs8G32R1+wLsY@vger.kernel.org, AJvYcCV0nYkb/TyQOErYruu8YBJ5GjW9SFvMBWk4Jm9WIUBEgzAArZgVDwC9OTQSEeahNgPShx1bhJwMWIzf@vger.kernel.org, AJvYcCWDulecnZK6r/NSCElkj2aMGMG7psM4mY2Bag4V/dS1JVfWgd9zyeOJcSRjnab2N1EnyT6W6T9y9Afp@vger.kernel.org X-Gm-Message-State: AOJu0Yz5u3haw0ZDY12JQeFObOmZj9LmCSCi9YoHYqr4ooWiOTDQHjDb yV87dqsu9kaHteQdHvdzwQTo3Zi5Ye+h4JVCO3ioawDzwJuRVERE X-Gm-Gg: ASbGncvrCEZGKTPaygyuVNEj3szsCn83v8wqfrRzrTwM7UeEWfnoSKvR4h0YxXxhul4 jFe+P+biGJQz4AnBTJ8ZAmoFct08f7dbi3NahhelFZb4Rd60cC823qj1ijuF6afWvirW2J3mIO6 mZBZBHrquwGFHmcm8gwLFbyQKIk/eCllCG/2FFLLEko7DAc3P3m85w2311UpUWODZzr9iO+nTcT 1RFwswG0Fz08Z81zOZTxNzND4IVXS2l6b49SO4UVFYI3tCa0BvMDneRa2ou/Pl+FiZSk0BM2bky bFN96m1j9Bhn X-Google-Smtp-Source: AGHT+IEBUsVDhTbQCZ3hLDGrgjru+S6KyHLsCa0Or036h9tHeTodcy1s7CEeSmJmugTf+EVD8kpJyw== X-Received: by 2002:a17:90a:d64b:b0:2ea:5dea:eb0a with SMTP id 98e67ed59e1d1-309f7d87c12mr14363027a91.4.1745804161420; Sun, 27 Apr 2025 18:36:01 -0700 (PDT) Received: from cu.. ([2001:da8:7001:11::460]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-309ef03bb26sm8508671a91.6.2025.04.27.18.35.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Apr 2025 18:36:00 -0700 (PDT) From: Longbin Li To: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen Wang , Inochi Amaoto , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti Cc: Longbin Li , linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, sophgo@lists.linux.dev, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: [PATCH v4 2/3] pwm: sophgo: reorganize the code structure Date: Mon, 28 Apr 2025 09:34:49 +0800 Message-ID: <20250428013501.6354-3-looong.bin@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250428013501.6354-1-looong.bin@gmail.com> References: <20250428013501.6354-1-looong.bin@gmail.com> Precedence: bulk X-Mailing-List: linux-pwm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 As the driver logic can be used in both SG2042 and SG2044, it will be better to reorganize the code structure. Signed-off-by: Longbin Li Reviewed-by: Chen Wang --- drivers/pwm/pwm-sophgo-sg2042.c | 62 +++++++++++++++++++-------------- 1 file changed, 35 insertions(+), 27 deletions(-) -- 2.49.0 diff --git a/drivers/pwm/pwm-sophgo-sg2042.c b/drivers/pwm/pwm-sophgo-sg2042.c index ff4639d849ce..23a83843ba53 100644 --- a/drivers/pwm/pwm-sophgo-sg2042.c +++ b/drivers/pwm/pwm-sophgo-sg2042.c @@ -26,18 +26,6 @@ #include #include -/* - * Offset RegisterName - * 0x0000 HLPERIOD0 - * 0x0004 PERIOD0 - * 0x0008 HLPERIOD1 - * 0x000C PERIOD1 - * 0x0010 HLPERIOD2 - * 0x0014 PERIOD2 - * 0x0018 HLPERIOD3 - * 0x001C PERIOD3 - * Four groups and every group is composed of HLPERIOD & PERIOD - */ #define SG2042_PWM_HLPERIOD(chan) ((chan) * 8 + 0) #define SG2042_PWM_PERIOD(chan) ((chan) * 8 + 4) @@ -53,6 +41,10 @@ struct sg2042_pwm_ddata { unsigned long clk_rate_hz; }; +struct sg2042_chip_data { + const struct pwm_ops ops; +}; + /* * period_ticks: PERIOD * hlperiod_ticks: HLPERIOD @@ -66,21 +58,13 @@ static void pwm_sg2042_config(struct sg2042_pwm_ddata *ddata, unsigned int chan, writel(hlperiod_ticks, base + SG2042_PWM_HLPERIOD(chan)); } -static int pwm_sg2042_apply(struct pwm_chip *chip, struct pwm_device *pwm, - const struct pwm_state *state) +static void pwm_set_dutycycle(struct pwm_chip *chip, struct pwm_device *pwm, + const struct pwm_state *state) { struct sg2042_pwm_ddata *ddata = pwmchip_get_drvdata(chip); u32 hlperiod_ticks; u32 period_ticks; - if (state->polarity == PWM_POLARITY_INVERSED) - return -EINVAL; - - if (!state->enabled) { - pwm_sg2042_config(ddata, pwm->hwpwm, 0, 0); - return 0; - } - /* * Duration of High level (duty_cycle) = HLPERIOD x Period_of_input_clk * Duration of One Cycle (period) = PERIOD x Period_of_input_clk @@ -92,6 +76,22 @@ static int pwm_sg2042_apply(struct pwm_chip *chip, struct pwm_device *pwm, pwm->hwpwm, period_ticks, hlperiod_ticks); pwm_sg2042_config(ddata, pwm->hwpwm, period_ticks, hlperiod_ticks); +} + +static int pwm_sg2042_apply(struct pwm_chip *chip, struct pwm_device *pwm, + const struct pwm_state *state) +{ + struct sg2042_pwm_ddata *ddata = pwmchip_get_drvdata(chip); + + if (state->polarity == PWM_POLARITY_INVERSED) + return -EINVAL; + + if (!state->enabled) { + pwm_sg2042_config(ddata, pwm->hwpwm, 0, 0); + return 0; + } + + pwm_set_dutycycle(chip, pwm, state); return 0; } @@ -123,13 +123,16 @@ static int pwm_sg2042_get_state(struct pwm_chip *chip, struct pwm_device *pwm, return 0; } -static const struct pwm_ops pwm_sg2042_ops = { - .apply = pwm_sg2042_apply, - .get_state = pwm_sg2042_get_state, +static const struct sg2042_chip_data sg2042_chip_data = { + .ops = { + .apply = pwm_sg2042_apply, + .get_state = pwm_sg2042_get_state, + } }; static const struct of_device_id sg2042_pwm_ids[] = { - { .compatible = "sophgo,sg2042-pwm" }, + { .compatible = "sophgo,sg2042-pwm", + .data = &sg2042_chip_data }, { } }; MODULE_DEVICE_TABLE(of, sg2042_pwm_ids); @@ -137,12 +140,17 @@ MODULE_DEVICE_TABLE(of, sg2042_pwm_ids); static int pwm_sg2042_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; + const struct sg2042_chip_data *chip_data; struct sg2042_pwm_ddata *ddata; struct reset_control *rst; struct pwm_chip *chip; struct clk *clk; int ret; + chip_data = device_get_match_data(dev); + if (!chip_data) + return -ENODEV; + chip = devm_pwmchip_alloc(dev, SG2042_PWM_CHANNELNUM, sizeof(*ddata)); if (IS_ERR(chip)) return PTR_ERR(chip); @@ -170,7 +178,7 @@ static int pwm_sg2042_probe(struct platform_device *pdev) if (IS_ERR(rst)) return dev_err_probe(dev, PTR_ERR(rst), "Failed to get reset\n"); - chip->ops = &pwm_sg2042_ops; + chip->ops = &chip_data->ops; chip->atomic = true; ret = devm_pwmchip_add(dev, chip); From patchwork Mon Apr 28 01:34:50 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Longbin Li X-Patchwork-Id: 2077969 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=dHrwScZC; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=147.75.80.249; helo=am.mirrors.kernel.org; envelope-from=linux-pwm+bounces-5733-incoming=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from am.mirrors.kernel.org (am.mirrors.kernel.org [147.75.80.249]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Zm5dJ6m34z1yMg for ; Mon, 28 Apr 2025 11:36:20 +1000 (AEST) Received: from smtp.subspace.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 46D4C18821D5 for ; Mon, 28 Apr 2025 01:36:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A1002155398; Mon, 28 Apr 2025 01:36:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dHrwScZC" X-Original-To: linux-pwm@vger.kernel.org Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0071516DC28; Mon, 28 Apr 2025 01:36:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745804168; cv=none; b=aAXojMLZeLU9o4eusjjP0ZKGprA4lKHwWSH6a3oM+Qa+w0bDv6To0qt1kmdkm1IaaNfWvJWmp5lsrNeoGoEBCKmt2YAPozt+3qxIQEnjuKWv5/VmrnxL/bRyW30tpOUKFlQkb9Fj2pbUYfELOcdE9PLW/HWyQsrtUL1XReYHwH8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745804168; c=relaxed/simple; bh=RAwT+b9QULu37wssvt5BOzimq4M/z0TasiXxablI9RI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Y++GeZKaCQeQFAt03OyLULZNWXAbIlz+P1rSeOUsrGxYWMYqoLzIAUymAQeGIaOKSQziddj839761QYcbDgtQaoNKuftaI7f/bTPG+KWJZ6FhkHiTK8J6ZFimsJV67x1vHsY6uDPixjpvyW9XZA8wtAfiCNdYE9BDV5wygVE9Ro= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dHrwScZC; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-30549dacd53so3316781a91.1; Sun, 27 Apr 2025 18:36:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745804166; x=1746408966; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=O1XOo3Vbbk6OtPs69iC9nG392lpAw1JpBjWZCyN3iG8=; b=dHrwScZCib+i4igc8u5SaNDSOFwviJtK8T7bfUEhBeEBlRD2ms1Yej+r9gbBNX0FKW EgDZc0nzF9bQGYMTx8sNkU266lR48P3HTvHxKsTSG6PKlZ49ZIpdqAZLR+4dOM0Yfec0 z7FjPnXy4o3tXFE44GOuoDqW0Z0yAtxNt6TVuukjmCJtl1h5uzpqSW3pDlhJNpJ+acn8 C6ALHggzRaQo429+BfzmWdrMlh9WYwBYyInb+T9TyYnufgrWmbtmXD76lEQe1CSL04l0 UIvGW3a7jC3KG+PpuHjhwDZ3xbYDt0kf9hu/ykO1h6ibcDeepOaoni91rYoiHcwYmE84 0MAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745804166; x=1746408966; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=O1XOo3Vbbk6OtPs69iC9nG392lpAw1JpBjWZCyN3iG8=; b=a0sB3F43fh1vs1QfjVSPhVSb/OxMPNIV5SQgGYvGGGyklIIMqVq7pgBLlu9jAFq80K 62oxeoPlrKStCMpRxbtaxEsWpZPbyqtrP463GFLGR2StlBCl4Sp6Xf09UXkEPCGvNL+A PwDAfmSLyLMlTJfAPCgrwdIMne3nkOuY8RslrEBDx+7B4pMG0WHxdKpjqnKUkK3td86t kdbtf5vdwpx3Rn9DEanIuUHNG/voAclzVYTEGdi4qTP7Sr0GQ/sMzAhF/An6FqxP3IfZ u9MoGI24PEy7CU36FzHtRoX9dlYyr/AVC/PJIGJvu/ygfb2EsqDYpYD6A4ooNBcmaPDW cZpw== X-Forwarded-Encrypted: i=1; AJvYcCUWTW8cffJ1sEoK9H+ukEMCbboETX627VBo0ARB4G9Tqfbyx5BGreJZGCbM8INbEFFHw93O4cJaeKcQ@vger.kernel.org, AJvYcCWHwRRaUic7wM7Z+ul7ryxmEqwBoL7pFZ3rB6EVL/HJgR+E4IGsVJEQL7oxoNGnLjG4HfPVoLZZPUBT@vger.kernel.org, AJvYcCXnO2pHSlz7u4ECbj+Nm21va/op1VeOmbFBw3eDuxluCZKD5y0GapsQu0t504t1zXleUXGEWBwsZxm8P+Ac@vger.kernel.org X-Gm-Message-State: AOJu0YyEFi1uclN9rPCbgsX/vCq0OPIaSKu1SJa3AFZbI9Jhh4ACFCo9 6XkWQ3I8NgzREuWw2WFSBipUekCI2hd9oAsbukWc+FG2GqeUjfMh X-Gm-Gg: ASbGncsxjyijZ21GXOZ1VJuXfP6K9qYLgfZ36sJxl02d+ZRMxaS77Oi/BEUvIhlnwJv AXchE63r1hYIjIRrWRwEs9fN4dBZ4pR9vYaOloFdBQOtCLf/p6NKyD0f4faYcBMO4a3E5PtDjdb iQP5/9k++GtCGntZbb94gAuQu8qz0cQoTVbsJhrzNCIuee+mTmUk9z64Csj4Pr9qTtiWEaIS75w psWEZX0VMhjU5TSmKREDaMNNeq3Ts48sPOCx6e1WKqmD7aBPMgRiFlM0n1kuIuPzsT1dDnvx3F1 sHBDCOJ0q+rR X-Google-Smtp-Source: AGHT+IHnQ1vU6MU1r9JMw0k7Ecc6KjPOryGisSgNWZ3r5gCwX8c7GY+Ct6trsj1ZnBJ9DZNBVx8LLQ== X-Received: by 2002:a17:90b:268c:b0:309:f46e:a67c with SMTP id 98e67ed59e1d1-309f8a0769dmr14912717a91.11.1745804166022; Sun, 27 Apr 2025 18:36:06 -0700 (PDT) Received: from cu.. ([2001:da8:7001:11::460]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-309ef03bb26sm8508671a91.6.2025.04.27.18.36.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Apr 2025 18:36:05 -0700 (PDT) From: Longbin Li To: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen Wang , Inochi Amaoto , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti Cc: Longbin Li , linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, sophgo@lists.linux.dev, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: [PATCH v4 3/3] pwm: sophgo: add driver for SG2044 Date: Mon, 28 Apr 2025 09:34:50 +0800 Message-ID: <20250428013501.6354-4-looong.bin@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250428013501.6354-1-looong.bin@gmail.com> References: <20250428013501.6354-1-looong.bin@gmail.com> Precedence: bulk X-Mailing-List: linux-pwm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Add PWM controller for SG2044 on base of SG2042. Signed-off-by: Longbin Li Reviewed-by: Chen Wang --- drivers/pwm/pwm-sophgo-sg2042.c | 89 ++++++++++++++++++++++++++++++++- 1 file changed, 87 insertions(+), 2 deletions(-) -- 2.49.0 diff --git a/drivers/pwm/pwm-sophgo-sg2042.c b/drivers/pwm/pwm-sophgo-sg2042.c index 23a83843ba53..5bb92c910540 100644 --- a/drivers/pwm/pwm-sophgo-sg2042.c +++ b/drivers/pwm/pwm-sophgo-sg2042.c @@ -13,6 +13,9 @@ * the running period. * - When PERIOD and HLPERIOD is set to 0, the PWM wave output will * be stopped and the output is pulled to high. + * - SG2044 support polarity while SG2042 does not. When PWMSTART is + * false, POLARITY being NORMAL will make output being low, + * POLARITY being INVERSED will make output being high. * See the datasheet [1] for more details. * [1]:https://github.com/sophgo/sophgo-doc/tree/main/SG2042/TRM */ @@ -26,6 +29,10 @@ #include #include +#define SG2044_PWM_POLARITY 0x40 +#define SG2044_PWM_PWMSTART 0x44 +#define SG2044_PWM_OE 0xd0 + #define SG2042_PWM_HLPERIOD(chan) ((chan) * 8 + 0) #define SG2042_PWM_PERIOD(chan) ((chan) * 8 + 4) @@ -72,8 +79,8 @@ static void pwm_set_dutycycle(struct pwm_chip *chip, struct pwm_device *pwm, period_ticks = min(mul_u64_u64_div_u64(ddata->clk_rate_hz, state->period, NSEC_PER_SEC), U32_MAX); hlperiod_ticks = min(mul_u64_u64_div_u64(ddata->clk_rate_hz, state->duty_cycle, NSEC_PER_SEC), U32_MAX); - dev_dbg(pwmchip_parent(chip), "chan[%u]: PERIOD=%u, HLPERIOD=%u\n", - pwm->hwpwm, period_ticks, hlperiod_ticks); + dev_dbg(pwmchip_parent(chip), "chan[%u]: ENABLE=%u, PERIOD=%u, HLPERIOD=%u, POLARITY=%u\n", + pwm->hwpwm, state->enabled, period_ticks, hlperiod_ticks, state->polarity); pwm_sg2042_config(ddata, pwm->hwpwm, period_ticks, hlperiod_ticks); } @@ -123,6 +130,74 @@ static int pwm_sg2042_get_state(struct pwm_chip *chip, struct pwm_device *pwm, return 0; } +static void pwm_sg2044_set_start(struct sg2042_pwm_ddata *ddata, struct pwm_device *pwm, + bool enabled) +{ + u32 pwm_value; + + pwm_value = readl(ddata->base + SG2044_PWM_PWMSTART); + + if (enabled) + pwm_value |= BIT(pwm->hwpwm); + else + pwm_value &= ~BIT(pwm->hwpwm); + + writel(pwm_value, ddata->base + SG2044_PWM_PWMSTART); +} + +static void pwm_sg2044_set_outputdir(struct sg2042_pwm_ddata *ddata, struct pwm_device *pwm, + bool enabled) +{ + u32 pwm_value; + + pwm_value = readl(ddata->base + SG2044_PWM_OE); + + if (enabled) + pwm_value |= BIT(pwm->hwpwm); + else + pwm_value &= ~BIT(pwm->hwpwm); + + writel(pwm_value, ddata->base + SG2044_PWM_OE); +} + +static void pwm_sg2044_set_polarity(struct sg2042_pwm_ddata *ddata, struct pwm_device *pwm, + const struct pwm_state *state) +{ + u32 pwm_value; + + pwm_value = readl(ddata->base + SG2044_PWM_POLARITY); + + if (state->polarity == PWM_POLARITY_NORMAL) + pwm_value &= ~BIT(pwm->hwpwm); + else + pwm_value |= BIT(pwm->hwpwm); + + writel(pwm_value, ddata->base + SG2044_PWM_POLARITY); +} + +static int pwm_sg2044_apply(struct pwm_chip *chip, struct pwm_device *pwm, + const struct pwm_state *state) +{ + struct sg2042_pwm_ddata *ddata = pwmchip_get_drvdata(chip); + + pwm_sg2044_set_polarity(ddata, pwm, state); + + pwm_set_dutycycle(chip, pwm, state); + + /* + * re-enable PWMSTART to refresh the register period + */ + pwm_sg2044_set_start(ddata, pwm, false); + + if (!state->enabled) + return 0; + + pwm_sg2044_set_outputdir(ddata, pwm, true); + pwm_sg2044_set_start(ddata, pwm, true); + + return 0; +} + static const struct sg2042_chip_data sg2042_chip_data = { .ops = { .apply = pwm_sg2042_apply, @@ -130,9 +205,18 @@ static const struct sg2042_chip_data sg2042_chip_data = { } }; +static const struct sg2042_chip_data sg2044_chip_data = { + .ops = { + .apply = pwm_sg2044_apply, + .get_state = pwm_sg2042_get_state, + } +}; + static const struct of_device_id sg2042_pwm_ids[] = { { .compatible = "sophgo,sg2042-pwm", .data = &sg2042_chip_data }, + { .compatible = "sophgo,sg2044-pwm", + .data = &sg2044_chip_data }, { } }; MODULE_DEVICE_TABLE(of, sg2042_pwm_ids); @@ -198,5 +282,6 @@ static struct platform_driver pwm_sg2042_driver = { module_platform_driver(pwm_sg2042_driver); MODULE_AUTHOR("Chen Wang"); +MODULE_AUTHOR("Longbin Li "); MODULE_DESCRIPTION("Sophgo SG2042 PWM driver"); MODULE_LICENSE("GPL");