From patchwork Sat May 19 21:02:36 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergei Shtylyov X-Patchwork-Id: 916929 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=cogentembedded.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="zR9pu0Qp"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40pHYd3sbjz9s4b for ; Sun, 20 May 2018 07:02:45 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752534AbeESVCl (ORCPT ); Sat, 19 May 2018 17:02:41 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:36855 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752515AbeESVCj (ORCPT ); Sat, 19 May 2018 17:02:39 -0400 Received: by mail-lf0-f68.google.com with SMTP id e9-v6so1826449lfb.3 for ; Sat, 19 May 2018 14:02:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:from:to:cc:references:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=s2piPLJDIGoZcnkJA7Cv7bT4HJc47J0WpcWmpCgJ1os=; b=zR9pu0Qp4cOsqzn1YJ6ptIOqYX3ObhvtYW2BIt3Z3GMuXZpMvYc7UlTycEF0uB/tI9 by3opAVpoExrMVsnLg+Dew5Q7oHYTu+TXObuyD2BvoPC3W9eeeddXlx2uTSAJgzo2RO0 4UhK0WsxFDUmx+c/V7v67frN+NB0I1Yc9ljIb5aXbz/zGSfqrLijWsVHpDioozALXJbt 8HoId7MmEbkuKJCEDne/jlEa8AsvwsaT42CoPj8KIZDtL/K31NwkvjnGrEF2veOd+zI5 nPMSSIBIaWU8KJf3EClpA37Au9ShuyTnKw08VlGblOagTTcE0gReHv6uFstrgGHwFi7+ aYnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=s2piPLJDIGoZcnkJA7Cv7bT4HJc47J0WpcWmpCgJ1os=; b=pyx7R1qeyw9Rp56umAgwZ2pgmQAf4CRUM7fqN/2Hr30pqV+Poh7uvZmiMZvoOBJKgB RH3h/L9mxKuAjIOeflqYOPSeBV7VqLAjjgGB4ro1iLahQjz+etHEHvarmBjkjukok2ch aG+ghrsJZBufD73OPYPgktZuQEUSpD4zhuaSlYfRAWxFHHRpvyNzXWJY6UON4u5SPt3x VCsC9LUwAXRUMl/TCejwK1ZfI4KR6gBHJI9fW46y7cQMvwKO3IXVeCGm5LtHjWvuNWw9 XS/JFCoxm+TMMZe50RApw+pAuBHPoOnlVxc6U59ocNx1kaOQDDpzUZ5mBZLurILt36nN cmEA== X-Gm-Message-State: ALKqPweP9gN28Jl59MyPaL+WcZbH3wQE2zV8Xhz9J5isgpTNc9li1ah6 axl0Q/wr1zHVlyPigK3KuJwvOg== X-Google-Smtp-Source: AB8JxZohZjADSk2PUYmyV5dfOEZRkEo93z26yLuBAZ7bwGF2I5ODlXuTvo4hbS32lu7WOHoikVqQnA== X-Received: by 2002:a19:b587:: with SMTP id g7-v6mr24745893lfk.90.1526763758111; Sat, 19 May 2018 14:02:38 -0700 (PDT) Received: from wasted.cogentembedded.com ([31.173.82.0]) by smtp.gmail.com with ESMTPSA id j188-v6sm2552539lfg.52.2018.05.19.14.02.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 19 May 2018 14:02:37 -0700 (PDT) Subject: [PATCH 1/3] sh_eth: fix typo in EESR.TRO bit name From: Sergei Shtylyov To: netdev@vger.kernel.org, "David S. Miller" Cc: linux-renesas-soc@vger.kernel.org References: Organization: Cogent Embedded Message-ID: <0de7581f-dea5-7773-32f6-5bd6256358d5@cogentembedded.com> Date: Sun, 20 May 2018 00:02:36 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-MW Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The correct name of the EESR bit 8 is TRO (transmit retry over), not RTO. Note that EESIPR bit 8, TROIP remained correct... Signed-off-by: Sergei Shtylyov --- drivers/net/ethernet/renesas/sh_eth.c | 10 +++++----- drivers/net/ethernet/renesas/sh_eth.h | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) Index: net-next/drivers/net/ethernet/renesas/sh_eth.c =================================================================== --- net-next.orig/drivers/net/ethernet/renesas/sh_eth.c +++ net-next/drivers/net/ethernet/renesas/sh_eth.c @@ -706,7 +706,7 @@ static struct sh_eth_cpu_data rcar_gen1_ EESIPR_RTLFIP | EESIPR_RTSFIP | EESIPR_PREIP | EESIPR_CERFIP, - .tx_check = EESR_FTC | EESR_CND | EESR_DLC | EESR_CD | EESR_RTO, + .tx_check = EESR_FTC | EESR_CND | EESR_DLC | EESR_CD | EESR_TRO, .eesr_err_check = EESR_TWB | EESR_TABT | EESR_RABT | EESR_RFE | EESR_RDE | EESR_RFRMER | EESR_TFE | EESR_TDE, .fdr_value = 0x00000f0f, @@ -738,7 +738,7 @@ static struct sh_eth_cpu_data rcar_gen2_ EESIPR_RTLFIP | EESIPR_RTSFIP | EESIPR_PREIP | EESIPR_CERFIP, - .tx_check = EESR_FTC | EESR_CND | EESR_DLC | EESR_CD | EESR_RTO, + .tx_check = EESR_FTC | EESR_CND | EESR_DLC | EESR_CD | EESR_TRO, .eesr_err_check = EESR_TWB | EESR_TABT | EESR_RABT | EESR_RFE | EESR_RDE | EESR_RFRMER | EESR_TFE | EESR_TDE, .fdr_value = 0x00000f0f, @@ -774,7 +774,7 @@ static struct sh_eth_cpu_data r8a77980_d EESIPR_RTLFIP | EESIPR_RTSFIP | EESIPR_PREIP | EESIPR_CERFIP, - .tx_check = EESR_FTC | EESR_CD | EESR_RTO, + .tx_check = EESR_FTC | EESR_CD | EESR_TRO, .eesr_err_check = EESR_TWB1 | EESR_TWB | EESR_TABT | EESR_RABT | EESR_RFE | EESR_RDE | EESR_RFRMER | EESR_TFE | EESR_TDE | EESR_ECI, @@ -831,7 +831,7 @@ static struct sh_eth_cpu_data sh7724_dat EESIPR_RTLFIP | EESIPR_RTSFIP | EESIPR_PREIP | EESIPR_CERFIP, - .tx_check = EESR_FTC | EESR_CND | EESR_DLC | EESR_CD | EESR_RTO, + .tx_check = EESR_FTC | EESR_CND | EESR_DLC | EESR_CD | EESR_TRO, .eesr_err_check = EESR_TWB | EESR_TABT | EESR_RABT | EESR_RFE | EESR_RDE | EESR_RFRMER | EESR_TFE | EESR_TDE, @@ -876,7 +876,7 @@ static struct sh_eth_cpu_data sh7757_dat EESIPR_RRFIP | EESIPR_RTLFIP | EESIPR_RTSFIP | EESIPR_PREIP | EESIPR_CERFIP, - .tx_check = EESR_FTC | EESR_CND | EESR_DLC | EESR_CD | EESR_RTO, + .tx_check = EESR_FTC | EESR_CND | EESR_DLC | EESR_CD | EESR_TRO, .eesr_err_check = EESR_TWB | EESR_TABT | EESR_RABT | EESR_RFE | EESR_RDE | EESR_RFRMER | EESR_TFE | EESR_TDE, Index: net-next/drivers/net/ethernet/renesas/sh_eth.h =================================================================== --- net-next.orig/drivers/net/ethernet/renesas/sh_eth.h +++ net-next/drivers/net/ethernet/renesas/sh_eth.h @@ -243,7 +243,7 @@ enum EESR_BIT { EESR_CND = 0x00000800, EESR_DLC = 0x00000400, EESR_CD = 0x00000200, - EESR_RTO = 0x00000100, + EESR_TRO = 0x00000100, EESR_RMAF = 0x00000080, EESR_CEEF = 0x00000040, EESR_CELF = 0x00000020, @@ -263,7 +263,7 @@ enum EESR_BIT { EESR_CERF) /* Recv frame CRC error */ #define DEFAULT_TX_CHECK (EESR_FTC | EESR_CND | EESR_DLC | EESR_CD | \ - EESR_RTO) + EESR_TRO) #define DEFAULT_EESR_ERR_CHECK (EESR_TWB | EESR_TABT | EESR_RABT | EESR_RFE | \ EESR_RDE | EESR_RFRMER | EESR_ADE | \ EESR_TFE | EESR_TDE) From patchwork Sat May 19 21:03:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergei Shtylyov X-Patchwork-Id: 916930 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=cogentembedded.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="j1rISJkr"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40pHZt5Jhxz9s4V for ; Sun, 20 May 2018 07:03:50 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752544AbeESVDr (ORCPT ); Sat, 19 May 2018 17:03:47 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:35903 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752515AbeESVDp (ORCPT ); Sat, 19 May 2018 17:03:45 -0400 Received: by mail-lf0-f67.google.com with SMTP id e9-v6so1828110lfb.3 for ; Sat, 19 May 2018 14:03:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:from:to:cc:references:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=I+eOxtkTihTZlPcshCxXjDLib/3YsAQE744BdU9TyXw=; b=j1rISJkrRrOA3zK29x8g32uM7KcBaVqoZjPeprev2qPewIAHnGgzzqIy3vSawBziBW rh6OWe1HcjKFTHYuwDsSXJ1BD09izy177tfurROcgERnZ+WV0K7qIQHEI20Wa5LZG1UT PehGjuFVu5PpK8sLvMITm7oftQI4qdskmtPGrruTLWc5YUXNYrcl0sP24psdWlGNQurL A89vqwg+AzBCW5QjvoF6wqHxRkMbmOSv/cw0IUwGbOEslwR/4WqZH7ezbmukrIoN5JYe z8k8Vdv775QUYDh0ZWAL5LMV0r/uaO0WRHBgpVlOiG52UCdASOUPRmzx0DNvy0r4rj2I gjfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=I+eOxtkTihTZlPcshCxXjDLib/3YsAQE744BdU9TyXw=; b=HsTmW1VJAyqZJvfh67Kdh5oMlqGHl+1WqAMDQqbTBJcTqNQvYLcnhe3nFuR7WDV+ri RpB0ZyMtTid9QQfxsHD42OJVxomEfTLRZKFsbVZHs4VhQgGNrodHIO5koJpaoAheGXXA E3guK629GTFPnIV4HG8lMXJOVsMh2BPVfLDzshc1J+LWrYpT/Wf9MMDrSOj+1BtM5TKH /4a06GCtwq6mxgGG0V7KHZdLhxcUJKfR3hNKkzPpr2J6MNqFPyj5AECSiyf0IE/3saXb 7PTnVz3ERu0Z3K0U/DXAsUQUMqj2iuYVBK2AKiiXFDEHu+IE0DNhC1f6wt2Ne94iXyE8 yC8A== X-Gm-Message-State: ALKqPwfJgBF7YuaC5FP7zO42oLrh6vPRQb1IYQ1U1Ye3kiHPZUkIYzd9 aRmz5FDMbyQcQ7VfPNX28pg5Ng== X-Google-Smtp-Source: AB8JxZoh28N/euVpNDd5+jkaiX36kkIRRbaHzVPqVnp1JiNnJLIhL00oTAGlvreXJoeB59k5uc6yxA== X-Received: by 2002:a2e:8150:: with SMTP id t16-v6mr8563192ljg.32.1526763823714; Sat, 19 May 2018 14:03:43 -0700 (PDT) Received: from wasted.cogentembedded.com ([31.173.82.0]) by smtp.gmail.com with ESMTPSA id r137-v6sm2580411lfr.17.2018.05.19.14.03.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 19 May 2018 14:03:42 -0700 (PDT) Subject: [PATCH 2/3] sh_eth: fix comment grammar in 'struct sh_eth_cpu_data' From: Sergei Shtylyov To: netdev@vger.kernel.org, "David S. Miller" Cc: linux-renesas-soc@vger.kernel.org References: Organization: Cogent Embedded Message-ID: Date: Sun, 20 May 2018 00:03:42 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-MW Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org All the verbs in the comments to the 'struct sh_eth_cpu_data' declaration should be in a 3rd person singular, to match the nouns. Signed-off-by: Sergei Shtylyov --- drivers/net/ethernet/renesas/sh_eth.h | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) Index: net-next/drivers/net/ethernet/renesas/sh_eth.h =================================================================== --- net-next.orig/drivers/net/ethernet/renesas/sh_eth.h +++ net-next/drivers/net/ethernet/renesas/sh_eth.h @@ -499,21 +499,21 @@ struct sh_eth_cpu_data { /* hardware features */ unsigned long irq_flags; /* IRQ configuration flags */ - unsigned no_psr:1; /* EtherC DO NOT have PSR */ - unsigned apr:1; /* EtherC have APR */ - unsigned mpr:1; /* EtherC have MPR */ - unsigned tpauser:1; /* EtherC have TPAUSER */ - unsigned bculr:1; /* EtherC have BCULR */ - unsigned tsu:1; /* EtherC have TSU */ - unsigned hw_swap:1; /* E-DMAC have DE bit in EDMR */ + unsigned no_psr:1; /* EtherC DOES NOT have PSR */ + unsigned apr:1; /* EtherC has APR */ + unsigned mpr:1; /* EtherC has MPR */ + unsigned tpauser:1; /* EtherC has TPAUSER */ + unsigned bculr:1; /* EtherC has BCULR */ + unsigned tsu:1; /* EtherC has TSU */ + unsigned hw_swap:1; /* E-DMAC has DE bit in EDMR */ unsigned nbst:1; /* E-DMAC has NBST bit in EDMR */ - unsigned rpadir:1; /* E-DMAC have RPADIR */ - unsigned no_trimd:1; /* E-DMAC DO NOT have TRIMD */ - unsigned no_ade:1; /* E-DMAC DO NOT have ADE bit in EESR */ + unsigned rpadir:1; /* E-DMAC has RPADIR */ + unsigned no_trimd:1; /* E-DMAC DOES NOT have TRIMD */ + unsigned no_ade:1; /* E-DMAC DOES NOT have ADE bit in EESR */ unsigned no_xdfar:1; /* E-DMAC DOES NOT have RDFAR/TDFAR */ unsigned xdfar_rw:1; /* E-DMAC has writeable RDFAR/TDFAR */ unsigned hw_checksum:1; /* E-DMAC has CSMR */ - unsigned select_mii:1; /* EtherC have RMII_MII (MII select register) */ + unsigned select_mii:1; /* EtherC has RMII_MII (MII select register) */ unsigned rmiimode:1; /* EtherC has RMIIMODE register */ unsigned rtrate:1; /* EtherC has RTRATE register */ unsigned magic:1; /* EtherC has ECMR.MPDE and ECSR.MPD */ From patchwork Sat May 19 21:05:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergei Shtylyov X-Patchwork-Id: 916931 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=cogentembedded.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="P8e6qw+H"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40pHcP34Gbz9s4b for ; Sun, 20 May 2018 07:05:09 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752618AbeESVFH (ORCPT ); Sat, 19 May 2018 17:05:07 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:34099 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752515AbeESVFF (ORCPT ); Sat, 19 May 2018 17:05:05 -0400 Received: by mail-lf0-f68.google.com with SMTP id x145-v6so6736105lff.1 for ; Sat, 19 May 2018 14:05:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:from:to:cc:references:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=phL8DU/5ML1LWvkH6h9CVOa9DJdkos17f3tVqS4dx0U=; b=P8e6qw+HVREYPnxamwC9S7dCym6z0fr6lZNJ7gS9Y+kLkD09dTQNHhZFyO0s56jPFE FyoyG2erdMLPSfBDRGlOSJlGgcs+FP8vDUR0fKWInEZF2eV2TIuAs3i1ACug4UMqUHPZ JQGW9Yc5Y8B+JVC5JqayImXqA4FJUL6vRz1lymEvZkd3gqEK1DPZ0k5ZLn4CR7G0tOhm +ufolE06OeYlSVIBZG7b4l6GfsM4DS3Q2bTKkkYaE7qv+pLRuaKX385c/t7f+rCMuoTZ 39fVcE++EC3n42q0g2xv/ihllEyKMYM6RnSRWPLs5vU+ULlWto8vHnad5H33urzOmOC3 QVHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=phL8DU/5ML1LWvkH6h9CVOa9DJdkos17f3tVqS4dx0U=; b=LeXFd0Pu1Q4mmNHPTpssBQQi4ybV7cMpyC8lEaMwuRU+1P6YIdzidqeD0iHDyg6TG1 vcn05MNaQqix9ozpw0ar0Th2tJIRyhpKn5PZ7a27VicuCp0S/CA5Kfyq0jqhvXccgscq tNvW9fOeyTO8i3g972pps4cIy0jH8GY0xSD8Ua0hKqgSQifGckINvNIoU7pu9JDlkyU9 mQHz0LmZB+VlAOX1KUUdAstJTet1VwvuPQE3kSKUeIdiYPXUxRYMEpCbYs7G9vx7mADf 16YNSSxDk8vKu7TiaKNn3KNG5pqrhBNjMaW/OhZj9pK2OKUcRNdEO2Fp+E70IxqzZYy0 Hzhg== X-Gm-Message-State: ALKqPwcdLUvFBlUIxsL9EZmEhjgeL4xolxiz2ezZ8n16y/GxqQGsOWxe Y9X3sAK8BV1iu+Nc8DdP0LUmlYfwY5Y= X-Google-Smtp-Source: AB8JxZpHL5Un6EZ215M9obd9AnEOOpr8fokQG+oBi1/D5W2CszhHl5OlXDyGHntiBSupXKahDPaAQQ== X-Received: by 2002:a2e:638f:: with SMTP id s15-v6mr8547483lje.78.1526763904216; Sat, 19 May 2018 14:05:04 -0700 (PDT) Received: from wasted.cogentembedded.com ([31.173.82.0]) by smtp.gmail.com with ESMTPSA id c12-v6sm1802957lji.59.2018.05.19.14.05.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 19 May 2018 14:05:03 -0700 (PDT) Subject: [PATCH 3/3] sh_eth: fix typo in comment to BCULR write From: Sergei Shtylyov To: netdev@vger.kernel.org, "David S. Miller" Cc: linux-renesas-soc@vger.kernel.org References: Organization: Cogent Embedded Message-ID: Date: Sun, 20 May 2018 00:05:02 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-MW Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Simon has noticed a typo in the comment accompaining the BCULR write -- fix it and move the comment before the write (following the style of the other comments), while at it... Reported-by: Simon Horman Signed-off-by: Sergei Shtylyov --- drivers/net/ethernet/renesas/sh_eth.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: net-next/drivers/net/ethernet/renesas/sh_eth.c =================================================================== --- net-next.orig/drivers/net/ethernet/renesas/sh_eth.c +++ net-next/drivers/net/ethernet/renesas/sh_eth.c @@ -1481,8 +1481,9 @@ static int sh_eth_dev_init(struct net_de if (mdp->cd->nbst) sh_eth_modify(ndev, EDMR, EDMR_NBST, EDMR_NBST); + /* Burst cycle count upper-limit */ if (mdp->cd->bculr) - sh_eth_write(ndev, 0x800, BCULR); /* Burst sycle set */ + sh_eth_write(ndev, 0x800, BCULR); sh_eth_write(ndev, mdp->cd->fcftr_value, FCFTR);