From patchwork Thu May 17 15:12:56 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Satou Kazuyoshi X-Patchwork-Id: 915488 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=googlegroups.com (client-ip=2607:f8b0:400c:c08::23e; helo=mail-ua0-x23e.google.com; envelope-from=swupdate+bncbcopxhxyzqerb6nx63lqkgqehghtwxi@googlegroups.com; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.b="fMkiq271"; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="nko+dtP8"; dkim-atps=neutral Received: from mail-ua0-x23e.google.com (mail-ua0-x23e.google.com [IPv6:2607:f8b0:400c:c08::23e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40mvv06F9Mz9s4V for ; Fri, 18 May 2018 01:12:59 +1000 (AEST) Received: by mail-ua0-x23e.google.com with SMTP id a25-v6sf4119412uak.7 for ; Thu, 17 May 2018 08:12:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20161025; h=sender:date:from:to:message-id:subject:mime-version :x-original-sender:precedence:mailing-list:list-id:list-post :list-help:list-archive:list-subscribe:list-unsubscribe; bh=ALRdg+9l97D/kDVKiAaLx6CjqUHixMTrk/a4E48QJDY=; b=fMkiq2718hRofdC58YP5qCGlNi1Di8TSHTBWITwDF8RiGMvAPXyPN2UVtiyF64J4rc cTBzOnko4tvYvuCDsc9oi3b8/zZUZszplKC4O17hkw+pk2/J1OJ3Wtc/V4KUCHqPvTA+ gcgjoHnl2aT40DEamam/c372tpA6T9eSd+ZcfflvcAP1uTPQWsfn4tWYpI581wTgaEVe mSzMfFHxjlVQh5axGjmynenVXrg89EZHt28ScGmm0rtl2Tpk+nn98npnUbFdxUZ2Up7k X93EEGq2VFH9PJV5pbCoDpFhvhcOulR5EKbaC8IW5YOwDnWFL2WHNZZeCXu06hjx6wA/ ai0Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:message-id:subject:mime-version:x-original-sender :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=ALRdg+9l97D/kDVKiAaLx6CjqUHixMTrk/a4E48QJDY=; b=nko+dtP89zJw9JW4BpvIQ5Exs2Osnv+VoT8pu7MWo8fT2lLhJhAAgaQ4w80H7zjiWz uAlzxMfieqBnB4m14GH5kg9MUWHEXO98rpKezuI0g/+Xwc7M3J4r0JWrk7IhOiVyasJE Bbpm0hgw0sEQr6t+RcM79al2hpNoSXz1HDNaqIw/e1C/T+VK8w7ydS0igRnUg5t4JaZj ZZ1YhX8zj9xSUCUIP+sf9VywS4sQiUflmdjt1hFaZ4LQfnFN4n61bWbgE8w3YNJPGfVl kRSH1NzjTd+465BzHlfKFBaq6z1U5qn7TxstTJO8qhqu8V9VMLzc1ec/I1+HnJ3C1slC 5kxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=sender:x-gm-message-state:date:from:to:message-id:subject :mime-version:x-original-sender:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=ALRdg+9l97D/kDVKiAaLx6CjqUHixMTrk/a4E48QJDY=; b=FqgrIt2nDTLyG13FpzSwv3yHeQ2L/AUV2E3xivmvWjhEwv5Ia+PQ8Mvqt37mIY5OyB c78pa0LAN7U8Q7ECF9XT4TFovKrcwtXWLbl2Dcf1u0sXxUXjiLZM9JcUBufNZ7mfh7NT P1xTS1a3ONWWdSS9pkdffQFIZVzXEXt1BSNmNmkNCfONXovGcy2MTPTdqVOD/yw7JJAd gXfv2+tEFQc4HAuFsl8wmMvekK/yMM6few97L/NnkhtiXwBWrUAZ2z6iLXb9VTESl7GQ LtfxBnxsl3tYAzvucgFARbUo0DmgujyWjt1JCeQW6FMENgwjdRnxCu1dGwWKAUo98Cv2 Vmtg== Sender: swupdate@googlegroups.com X-Gm-Message-State: ALKqPwe8icilHaduKf8BgbKXZqiRNsujx2d7q3FueJkw2CGMEnQrLkvp E6O55HbasYZlmJorORU9PKQ= X-Google-Smtp-Source: AB8JxZpZ1EbPYg7iWw6tr1LjzugV2uSKKA9AJ+Vn0kZ9kRA2XyjL15AKRMllO56FYSR1PHLI7Ew6Eg== X-Received: by 2002:a1f:c102:: with SMTP id r2-v6mr735495vkf.11.1526569977667; Thu, 17 May 2018 08:12:57 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com Received: by 2002:a1f:7306:: with SMTP id o6-v6ls3176372vkc.15.gmail; Thu, 17 May 2018 08:12:57 -0700 (PDT) X-Received: by 2002:a1f:9717:: with SMTP id z23-v6mr737174vkd.6.1526569976978; Thu, 17 May 2018 08:12:56 -0700 (PDT) Date: Thu, 17 May 2018 08:12:56 -0700 (PDT) From: Satou Kazuyoshi To: swupdate Message-Id: <99bdde36-491a-4901-87a6-5a52b55808a0@googlegroups.com> Subject: [swupdate] After swupdate updated application completely, it don't inform to Hawkbit about successful status MIME-Version: 1.0 X-Original-Sender: satou.kazuyoshi.2212@gmail.com Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , I couldn't send the patch file by 'git send-email', so that I create new topic for this. I caught the problem as below: When Hawkbit server request to swupdate about the application need swupdate download the swu file and install the application. The update was successful on the swupdate side, however swupdate did not announce the ACK to Hawkbit. So that, Hawkbit still waits for the ACK to return from the swupdate. With my little knowledge about swupdate, I created a patch file and attached in this topic. Please take a look to confirm it. Thanks and best regards Nguyen Duc Hoa From 122dd5adc4fbf1a0bfdb866394920f0ded57f41e Mon Sep 17 00:00:00 2001 From: hoand Date: Thu, 17 May 2018 11:05:09 +0900 Subject: [PATCH 2/2] fix handle acknowledge to hawkbit server Change from: refs/tags/2018.03 Signed-off-by: hoand --- suricatta/server_hawkbit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/suricatta/server_hawkbit.c b/suricatta/server_hawkbit.c index ef70e4a..948d9ea 100644 --- a/suricatta/server_hawkbit.c +++ b/suricatta/server_hawkbit.c @@ -1299,8 +1299,8 @@ server_op_res_t server_install_update(void) if (server_send_deployment_reply( action_id, json_data_chunk_max, json_data_chunk_count, - reply_status_result_finished.none, - reply_status_execution.proceeding, 1, + reply_status_result_finished.success, + reply_status_execution.closed, 1, &details[3]) != SERVER_OK) { ERROR("Error while reporting installation success to " "server.\n"); -- 2.16.2.windows.1