From patchwork Wed May 16 11:14:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joanna Yurdal X-Patchwork-Id: 914701 X-Patchwork-Delegate: jeffrey.t.kirsher@intel.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=osuosl.org (client-ip=140.211.166.133; helo=hemlock.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=trackman.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=TrackMan.onmicrosoft.com header.i=@TrackMan.onmicrosoft.com header.b="cqDDyKGZ"; dkim-atps=neutral Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40mJJ65MHkz9s3X for ; Thu, 17 May 2018 01:29:10 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 405228731A; Wed, 16 May 2018 15:29:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JEXD6frBk2di; Wed, 16 May 2018 15:29:07 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 0EA8D873CB; Wed, 16 May 2018 15:29:07 +0000 (UTC) X-Original-To: intel-wired-lan@lists.osuosl.org Delivered-To: intel-wired-lan@lists.osuosl.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id DB7811C14DD for ; Wed, 16 May 2018 13:47:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id D710A85AB5 for ; Wed, 16 May 2018 13:47:30 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tP92lsCLEnGc for ; Wed, 16 May 2018 13:47:29 +0000 (UTC) X-Greylist: delayed 02:00:29 by SQLgrey-1.7.6 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30103.outbound.protection.outlook.com [40.107.3.103]) by fraxinus.osuosl.org (Postfix) with ESMTPS id CE4FC8232E for ; Wed, 16 May 2018 13:47:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=TrackMan.onmicrosoft.com; s=selector1-trackman-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aQlc5jtcIOAr1gt4j968vY9saRn+Sag/b/C9yxkJNKQ=; b=cqDDyKGZWUHNKKQcn8T8vj+AzaPMfQ14ZpYVwfJWulMAdxAM/9+ksfse+1WnTWHG8IkSX4K5Cbp3/n4ya6mlRT62n3XiQki8tozpy1FkpP+TrfSd94/fj3HaTXGNZvuy5R2v5Or05L3kcZDD2IsZCylM0xaHmd8NcJUn6zu4nGo= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=jyu@trackman.com; Received: from [192.168.220.153] (87.116.45.194) by DB4PR07MB332.eurprd07.prod.outlook.com (2a01:111:e400:982f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.776.4; Wed, 16 May 2018 11:14:13 +0000 To: intel-wired-lan@lists.osuosl.org From: Joanna Yurdal Message-ID: Date: Wed, 16 May 2018 13:14:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 Content-Language: en-US X-Originating-IP: [87.116.45.194] X-ClientProxiedBy: AM6PR0202CA0014.eurprd02.prod.outlook.com (2603:10a6:209:15::27) To DB4PR07MB332.eurprd07.prod.outlook.com (2a01:111:e400:982f::22) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(7021125)(5600026)(4534165)(7022125)(4603075)(4627221)(201702281549075)(7048125)(7024125)(7027125)(7028125)(7023125)(2017052603328)(7153060)(49563074)(7193020); SRVR:DB4PR07MB332; X-Microsoft-Exchange-Diagnostics: 1; DB4PR07MB332; 3:V87Qi6XpJ1zqPbCJ3ml07qYV/yAuVzqWFYaCy2Z1xlPLq5/WjlF6IMRGCSCQAHKpvE8QMrpzCGzNw/xt0sATwa+bemBZxgEUjA9LgpTSeOyvHkdovPjwP2mOyTjdT2QERYsGYSh5cSplToAe3/Q2V0iqvY/QL9HDk7q2mH5L1ayBoF8TrfoVLooS0n19Xwew/65eAb4rpCsprt2orNAqB7j1BW4Owy8VHxpqbr9jWXL3x8Rw0cCWB7q2pJXXpxX3; 25:gQ30ok+09olO3M/ED5yqAIAFs/wQB+UNAA9lQQrfVVdStCXIBEctOWs05H3ak8mOv7a7MZoVbPf3JZWtkLT80gZAdJBzzLeX+KapbLkzJVlVlLoRb7cvmw/HbFkInhzIfZYNxeNVkD+xpN8Q73C8BWnyZhf8ZIDvv4IJfXX78Zg603z01CLFPd+TnictPsVgzKaWXQoGB0kWyj8d+KKyiv4zo4krczohXmuuBukdIpUGFSv1LLbInRWfKr1aWLiBkP/moUAFAtZzb5Ug62yBCC42cwZm3vd7blPAUMifWzGpbMkKCSveAQO+p1jiAZp/b7VRn0EIQ4E/exsyTmPSJA==; 31:zeaI93F2XemojjOVsv3mN7Dhz5W1u058AZzD65xJnO3P8qPyvIVZRnqCG3k9z8p3VgFKSl1HzG7yl4oOpBXpkS35KPPexOjfmJHD+D38nTMFAGIsWWM0t5SBsEolZEds4ptmNPsGPec6TOIH7FhXItmEZewaCpbAUPiwpBCL1MUbTw2jtZ9ghh0WcqjNoSyZNIO3ihUxZrsmNL2S5kXXWpLtxNuKJgwWdr6wIL+Ssgw= X-MS-TrafficTypeDiagnostic: DB4PR07MB332: X-Microsoft-Exchange-Diagnostics: 1; DB4PR07MB332; 20:n1Plcvdnm1ZtmwpdvlQX5pGdAm7hQz5ervB2C3BYaTRZoJWriXMo/XgF+hF6akCTHqqUIC0bbxuB8A1ruPr4RtX2qrIe+lsWv+LgJ60zCpPRQg3IZDoqGAxZ7mtv8iMn6N0yMpMU9MMQQWQdOIy2ML4/Nn6jHtttFm1SNne7SyknkCklxC+G7hwVeFTEWjcxJzhrSQTyYma3ymnJRwAscFM0R8sHQLAKed+5P5odXsYzs97G4aD/zI3sSm2xLjeZGOtFZMBLVlXhAuNm3VvJp3qEeAmummwoLd7bRI91uoNV9xAACvCIA9NBsvJs62JK6EOIuNSsO2NnoLyVkj/RZ7opn4hHI706TcsIFjE32HWCvFmNAcYL8xzbFOxvNt0nvBJncQtqqrnn5dBCgbYXC3Zad9JesDnNdKa+qTp/QMwdEl6r9aSPJyNBQRgbIkUXFHZBAQcL54xj5lsp0LXt4BFPSRvYc56jHfB9IItgE0gXv2SlN7cqkJLIQIxvmzLW; 4:pUfDwgDWtJ/v6EU++Z+sn+3yF6EIe2TUhkpJE8sBadGO2WDaJPwuttAWIFhtNc71pADoiB2BepsLsgsxfe3IBrxdyKiuYnveShjbur0uUMyQowtwuVmv4wgEWcaMe99Jk1upqGf/c9o8CUO7dgHmztPqtOxixJjqqq4YjtYUgQqAfSaPHWqBtPGSR6g4q0Asz8bvJAgp6CUbDyaEPhTzLIE91tf3BJd1bqRcD4kvnGD5cGQ2LPQKLqUUNK5C/M4Rer/5o1Ut/5DEJ9igIFQ/JA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(102415395)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(3231254)(944501410)(52105095)(149027)(150027)(6041310)(20161123560045)(20161123558120)(20161123564045)(2016111802025)(20161123562045)(6072148)(6043046)(201708071742011); SRVR:DB4PR07MB332; BCL:0; PCL:0; RULEID:; SRVR:DB4PR07MB332; X-Forefront-PRVS: 0674DC6DD3 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(6049001)(39380400002)(39850400004)(366004)(346002)(376002)(396003)(189003)(199004)(6486002)(2616005)(52116002)(2351001)(386003)(8676002)(86362001)(476003)(31696002)(1857600001)(478600001)(36756003)(53936002)(186003)(16586007)(58126008)(316002)(37036004)(16576012)(81156014)(2361001)(81166006)(16526019)(568964002)(956004)(8936002)(270700001)(486006)(2476003)(65806001)(68736007)(5660300001)(65956001)(66066001)(5890100001)(65826007)(105586002)(5000100001)(33964004)(4610100001)(84326002)(77096007)(117156002)(64126003)(6116002)(31686004)(97736004)(106356001)(3846002)(26005)(7736002)(6916009)(2906002)(305945005)(25786009)(42262002); DIR:OUT; SFP:1102; SCL:1; SRVR:DB4PR07MB332; H:[192.168.220.153]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: trackman.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB4PR07MB332; 23:oFM0zL10GoLDCIpWtvMqNrM7b6y6OYQsshUOQbh/YR?= nttby/p/I80c6e/OpTdWd3YRQddmX2YG7mjf713KjxulU1taU+GmUdOPhc+mNWPjZ/pdbiSpN3vQglzlSRA3taIlRQitq+pcGDHv7ZJkBFt76Itj996UAm/xBTD2EuwUo313gv47sKrIRz5pWGviqi6T5a2qqGJPl06trBtllgYZJjGKmiTTcYthf2cVL5SUso9bPFRdJ+htlNCF1FOoGtq0V5/3ipv3aHcIZzDR7UaXuSd2s7sZcNbPm4st5SVT5ylfqlMMg6jyu+EAlgOBzEOgpB+OB38pHqWAbXSwWiQx7w4vGTILIXuLdXsBWeG108F7bOOrc2G170tbjmRDrNtii8TNLyze4Jb6RTzuGwA3kyiCbSazmLfd6RAQdkgHz2Td8CGFveJodoZSnuCTF81CJ5pHfwZLvZ0v1ZjQBPNUqOgc6wbOvuVIKYVdbvU1maAsjOnlKsHhg2euQYv1mRoBOrbACTP2LLF1EP9+CqxeyeNw39CbkAuqAjLbzWGF75hpscAwGMqtD/69oYU0fqH1TPYCQ3HSrIpmmn5RHrzikPzUPQwUpwjZimkJBJzj+40Fby2zXQClDhXioxM4tt8BqEFFCCmUAMshFDnxvrxnC0AZm+7IlLkd2bKWI9Dr6VSs3A/Sg/ksxapTAP+EKBy4D4QW9y70oaY44sWIYhYBoy5FtVHUPpva9IP0aYODnt5xiMOi10D0U4sEPIHz5suVSpsEJymRRnwOP/wgju/ZNn6oZ/84mcBD9iMdAxmXCQEwT1YEBGIqxHPn5cSDt4fHBTf0Trik37AhrFwUog3Zx/LMXHuec1VI65+l4zgOVci+jNRwaiPQ/FY3iDAitQ5802WW2Zy7uhiSlwHirKichc9TOn4juiwwb0No+oqXdByolf0CQjJZl9aBfn37TuKY4Q7Q0L7qG06Zpf1ZDoYjeWNeH5Rkjb7NZivxKDd8nJDNhQZNsT81AtMKGS5Ir9hydjw1NCmkpCzQBZeQ7Eam3nbvf8jAfBZeO+YFEJlVKG/xmTQvT/n7JRUC5fxGzkl6THoQvQ8TgGZs0BVvNM0s9A/K47SVacWxeNMft/Q1D09ihntbYF4YwSReBBnVayA1CjwC2Q59+f60rMongZ2F54gZqMnkO/L6kwTWMw1peO6COuHuLhAQMvcXUzQ6jZGQqHhX+62+tNAfcfh7ktInUyDLutw9eKLtGAfzp6uPiiqoIa4xVxm9WadSwTlVb8aXJxbTokiAsDlHZAil/vSkI9NklpmK0Si94rAxlgmQ9Da8eEUsowEHfiFzD+5fPVOajaV9rykLiKAEXtCz+oOKPSi5oWE7eAMYvB5W2cpFhJ479hY6hOPt/Q93BWwXOjxHQ46e3kZyxPZApfHPt7syY0B/s31CqEwzNwDMp1SI6ixOok36yQBbldj/nP+778 X-Microsoft-Antispam-Message-Info: XP8CqcxVrh3A9lMww7psTkgH3Z77RCDkIoUNoDxheFPyWXnMivLbsJe8uROHRzj0cBIqa6+O3HVNI8D7aIq6eC3svfLaChQBUlV0yRNJRvjHyQFuJKO3w2RNIXk8i7G7Y2pFBv0tb5J6GKtPvXwbqs3LKRsW8SJo9vMJdHW/woWZ2SohxtHOm+OfrRZPmqXe X-Microsoft-Exchange-Diagnostics: 1; DB4PR07MB332; 6:I0P2y0UmSIYZRKYQyhdt/za93BBQW4IyTKS2/ZENNlCSUG9meY9pURWQ+DKdtUsxMXXHXQeUgHWNKkm4FedidirKui2+fFhP45g7qEs6FQphEz9UTgHqCSa1eBXHGZAhIi3B+i+Xldb82XLh+VlTx9eK46+JPd30z8tvDZQiPjSKvJ45riIra/hZJR4EyuJnKkB14kC+E5pd4CxAXNhJhsYj7o0vwKeGQXajqA7jSR75tJ4LoqgFjX7ltUnQ8dZGZD4zhpGCPov6Bd6uVqXrTDlVsHg0gQ3NcBCcsXq5dqqFNg+IVH1rohTtFAwXMnfQSFPhamSp6gQHRJodNsdKDlS1czUCLsgyIhChBpet0bYWTxxUn77ZNZjC9INmW01IPwTCGwzM3fuGhO++T2Yo+GmV/m8JLh4lG5x43Apner5ZTiGxTaZ/rxdMfhezSntrDtPwWY1QYnjTpMAWrrWuIw==; 5:+zeeFWloIwjrFbyxWNVVzdm3be/nXsAetXDMm5PgLupXCcDPHCU32C4ZPV1mcfqWX8HqvDw0KE54MxLl0OM+Tu4fQIuuVVhms3dxLzcP0aNjmOsgX3MLrB6tg4ELNk/Y1D0/WW0r4hos39cStTjOKW+uTX8EgYhWgbo61MyBydc=; 24:d6JqqyR2gugMS1jAXciWbKqaDAaZ2i8iLfojA2m+EiGC6lhCKhXh0zJpkhT9R5Bv3IOGP+cw/rA+ohuQkQ7t0qfk8AklNa9Lww/5N2dkvwU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DB4PR07MB332; 7:vPtpgeTjL8S56jD8yo95bB2twkKOC0PZiUn7QiTBVEiH1yVc6E7VD+I2TIwlPzbRjM5m2kR38lBW/Vy5dNAWRrSIgq0V6qm0ZnbP6RIHjcthvthblpVgwQC0l9VLTC/6xPcy7lXTB5eLta9KEjiR9XXktbFpHUf0fZpFtTIOmIniu+ETYfriH6nWZchKQGQGB0qE27Wna/OIwIHnYfMAqeGD6SowgMfHFZ18tDgBy74IAWJP+8ZqT7KMAAKzwJxT X-MS-Office365-Filtering-Correlation-Id: 5d0a0297-6675-45f1-5f0e-08d5bb1e27f0 X-OriginatorOrg: trackman.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2018 11:14:13.4708 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5d0a0297-6675-45f1-5f0e-08d5bb1e27f0 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: eb272a1e-e767-4041-9363-f8736579f898 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR07MB332 X-Mailman-Approved-At: Wed, 16 May 2018 15:29:05 +0000 Subject: [Intel-wired-lan] [PATCH] igb: Clear TSICR interrupts together with ICR X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" I have been working with the PTP using IGB i210 and the linux driver can end up in a state where it stops receiving E1000_ICR_TS interrupt. The ethernet driver works fine but PPS stops and no tx ptp timestamp can be retrieved. This is caused by not clearing the TS interrupt before enabling igb interrupts in the igb_up function. Tested-by: Aaron Brown From 8e3eeef09b9960c67917a7f7fafe47751c0932fe Mon Sep 17 00:00:00 2001 From: Joanna Yurdal Date: Tue, 15 May 2018 12:55:10 +0200 Subject: [PATCH] igb: Clear TSICR interrupts together with ICR Issuing "ip link set up/down" can block TSICR interrupts, what results in missing PTP tx timestamp and no PPS pulse generation. Problem happens when the link is set up with the TSICR interrupts pending. ICR is cleared before enabling interrupts, while TSICR is not. When all TSICR interrupts are pending at this moment, time_sync interrupt will never be generated. TSICR should be cleared as well. In order to reproduce the issue: 1. Setup linux with IEEE 1588 grandmaster and PPS output enabled 2. Continue setting link up/down with random intervals between commands 3. Wait until PPS is not generated ( only one pulse is generated and PPS dies), and ptp4l complains constantly about tx timeout. Signed-off-by: Joanna Yurdal --- drivers/net/ethernet/intel/igb/igb_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index c1c0bc3..5350644 100644 --- a/drivers/net/ethernet/intel/igb/igb_main.c +++ b/drivers/net/ethernet/intel/igb/igb_main.c @@ -2063,6 +2063,7 @@ int igb_up(struct igb_adapter *adapter) igb_assign_vector(adapter->q_vector[0], 0); /* Clear any pending interrupts. */ + rd32(E1000_TSICR); rd32(E1000_ICR); igb_irq_enable(adapter); @@ -3621,6 +3622,7 @@ static int __igb_open(struct net_device *netdev, bool resuming) napi_enable(&(adapter->q_vector[i]->napi)); /* Clear any pending interrupts. */ + rd32(E1000_TSICR); rd32(E1000_ICR); igb_irq_enable(adapter); -- 2.7.4