From patchwork Mon May 14 20:49:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vasily Khoruzhick X-Patchwork-Id: 913227 X-Patchwork-Delegate: agust@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="J74yIQzz"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 40lCXV2DkRz9s0q for ; Tue, 15 May 2018 06:51:05 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id A58E9C22066; Mon, 14 May 2018 20:50:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 22AF5C220A8; Mon, 14 May 2018 20:50:17 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 65249C2200F; Mon, 14 May 2018 20:50:03 +0000 (UTC) Received: from mail-pl0-f68.google.com (mail-pl0-f68.google.com [209.85.160.68]) by lists.denx.de (Postfix) with ESMTPS id B046FC2203B for ; Mon, 14 May 2018 20:49:59 +0000 (UTC) Received: by mail-pl0-f68.google.com with SMTP id e6-v6so8034447plt.11 for ; Mon, 14 May 2018 13:49:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Ya6vq/2f+qxL/uz458rNU6E4fcp39g1b338me/zA/Ys=; b=J74yIQzz3MDS048lfhHhxO9uzefGSoJBTFNvKMnBpwBsYhMAq0eA5ckmCdk0znhQQ2 PY7ZZTpdihspf7h0h0Vm5nuKK1QQsFfyqPcn1eYb70MjwrzBbY+FlkKDT1pQAVx3FK9I 1i+y4l8LV+ZrP3F3C6bS5oVVG8fNYdJzq9oEC5ZBMb1/BMCWy0u3IwCg/sOz6Hf4X6mG rhgbj/S02KdHKgPoaOYfu1omMT1h/tgXOa/zI41H2U2XTCrfFbZs7rIth6mooMqfeW9U Tf7t5abyzaI3IcK1mWHemWo6l2n/ePoZ9ERy/yxwiZwm2CqUNpcVD/OEYVlnLHKpMhZN XH2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Ya6vq/2f+qxL/uz458rNU6E4fcp39g1b338me/zA/Ys=; b=hw7zR0nkbfX44qY+PS9Bo6r72I833cQ5/LoIkg2tyP+5oIHwKfHx2r4LF4QA8aTyks DrDRQUd5cJedZR4KWxXUhv4kusEp0beXYzbXR+jMXr5/IiPTtrA9F3rbTIo8G6+d6pwM ++cexQ1vhMlIVXaHgS9FXV904Lx0gxWt6pxPPhX2oZCz+aomn88c+En8co3CSXR7S8Ok iUl1gqW3WsO29xSu+aRytKpUzgZyZwVyqyMi4rIMsLezbVM1Fv+CrsQfj2qQcIQJs13q kulgjokuNTDhagCkXHviMo3+M/PfHXECi8sSbmU7elRoRIs/GFNvMHTgMNKbx1C4965i TFZg== X-Gm-Message-State: ALKqPwd/V3dmEE1heNkWDR9wRRqJ3nsz4rj719uh6h11fedVjm1j0F/V 5L7ndusRkhIixnIC2GPzG/k= X-Google-Smtp-Source: AB8JxZodqwqDMxEa3ub8T224xjN+6cZB4x71oWSbCXYoFwWGLv/cZOA/yzk7wx129BHt2CW3oAjIhg== X-Received: by 2002:a17:902:24a5:: with SMTP id w34-v6mr184758pla.52.1526330998437; Mon, 14 May 2018 13:49:58 -0700 (PDT) Received: from anarsoul-thinkpad.lan (216-71-193-140.dyn.novuscom.net. [216.71.193.140]) by smtp.gmail.com with ESMTPSA id q207-v6sm16671933pgq.9.2018.05.14.13.49.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 May 2018 13:49:57 -0700 (PDT) From: Vasily Khoruzhick To: Anatolij Gustschin , Maxime Ripard , Jagan Teki , Jernej Skrabec , u-boot@lists.denx.de Date: Mon, 14 May 2018 13:49:52 -0700 Message-Id: <20180514204953.11606-2-anarsoul@gmail.com> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180514204953.11606-1-anarsoul@gmail.com> References: <20180514204953.11606-1-anarsoul@gmail.com> Subject: [U-Boot] [PATCH v2 1/2] sunxi: video: HDMI: use correct bits for HSYNC and VSYNC polarity. X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" HSYNC is bit 8, and VSYNC is bit 9. Signed-off-by: Vasily Khoruzhick Reviewed-by: Jernej Skrabec --- drivers/video/sunxi/sunxi_dw_hdmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/sunxi/sunxi_dw_hdmi.c b/drivers/video/sunxi/sunxi_dw_hdmi.c index c78e33b947..9dbea649a0 100644 --- a/drivers/video/sunxi/sunxi_dw_hdmi.c +++ b/drivers/video/sunxi/sunxi_dw_hdmi.c @@ -303,10 +303,10 @@ static int sunxi_dw_hdmi_enable(struct udevice *dev, int panel_bpp, sunxi_dw_hdmi_lcdc_init(priv->mux, edid, panel_bpp); - if (edid->flags & DISPLAY_FLAGS_HSYNC_LOW) + if (edid->flags & DISPLAY_FLAGS_VSYNC_LOW) setbits_le32(&phy->pol, 0x200); - if (edid->flags & DISPLAY_FLAGS_VSYNC_LOW) + if (edid->flags & DISPLAY_FLAGS_HSYNC_LOW) setbits_le32(&phy->pol, 0x100); setbits_le32(&phy->ctrl, 0xf << 12); From patchwork Mon May 14 20:49:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vasily Khoruzhick X-Patchwork-Id: 913228 X-Patchwork-Delegate: agust@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="S6HsDN6W"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 40lCZG5CKKz9s0q for ; Tue, 15 May 2018 06:52:38 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 63503C220B0; Mon, 14 May 2018 20:50:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id EE016C2208E; Mon, 14 May 2018 20:50:21 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id DF1CBC22082; Mon, 14 May 2018 20:50:04 +0000 (UTC) Received: from mail-pl0-f65.google.com (mail-pl0-f65.google.com [209.85.160.65]) by lists.denx.de (Postfix) with ESMTPS id C17F7C220B0 for ; Mon, 14 May 2018 20:50:00 +0000 (UTC) Received: by mail-pl0-f65.google.com with SMTP id t12-v6so8050072plo.7 for ; Mon, 14 May 2018 13:50:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=9brHxsoFBxYH/XRZULpU5I5kZhpP+WZwCy6PM1EKRCw=; b=S6HsDN6W/ha4ZzSM26mcCGJhscYyVeIUoa93sE94B5/nc/8hOv9rdIn+Neqg0i9cw/ SrRFChbzp8RZTTNN/sTlrXP2HYP60fy/yxG8Fm/lI3m1cONUJ/oRfx6g/fPwzuKGXNFP E528jcF9lhEcG4g4YnbO9HJrs1E646an1Hm67UWlX+hqUXfJF2ndhLVhZN2zghyU4YRl Ys7fW8c9tDPGhyStSCw0XAgo1h47TqzOoStbN5IBJqQgHEDAh7/umwybwSGfPA+VGVfq WvH1Gv/D2IiCaAEMMCUs6FRI4lJAEi6KYa0gTAZQIzi4qxgNKblFTt2cMQM24pncmZqx aLAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=9brHxsoFBxYH/XRZULpU5I5kZhpP+WZwCy6PM1EKRCw=; b=Wj2pY/cDna50Oot/HeetcWuJvG2Z/LCes9qgDArzXWec9AMyvmUmIvGZtupQ3FuEwb 3gEk7PmcqaIYrFAEaKx7QA2xxAU4y0a21o5PgWZx/IlgvFHmhwpzJk9ixsTgppF1vma3 rKnjTRaeISaZqBhqPsUftQhV/9bndMjWB7qr8hVf55DsUVfHVa3KVXOXM6tVLKPS5k0r 0MJvJ7fW/XSr3RHrEws8WIbwMp9fkdrht1h1rD2jM9NDO6S9ezG6ci7YAsbLxHOhmiL6 gpa5SmrDXrdV2fk/60fJnWf5ie7UJ98qdzBbQErNw/tyi/iyFlHlJ1FPGfbCzwQ3u/Ao udzA== X-Gm-Message-State: ALKqPweZcp2kH+1eAE/mZ9+vSoheKkZEuRG+3O+6IegIxSNvH+5N4KBA 2lAbzKuSFi1SFQDJnANwjog= X-Google-Smtp-Source: AB8JxZoZYKVDA7Q812KXDyVGKvyi8a7F3BkmfQsLtf+c/bhgXR/i1db+TtT+oboIbnzNrm5Uot8HNw== X-Received: by 2002:a17:902:8217:: with SMTP id x23-v6mr11189836pln.380.1526330999495; Mon, 14 May 2018 13:49:59 -0700 (PDT) Received: from anarsoul-thinkpad.lan (216-71-193-140.dyn.novuscom.net. [216.71.193.140]) by smtp.gmail.com with ESMTPSA id q207-v6sm16671933pgq.9.2018.05.14.13.49.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 May 2018 13:49:58 -0700 (PDT) From: Vasily Khoruzhick To: Anatolij Gustschin , Maxime Ripard , Jagan Teki , Jernej Skrabec , u-boot@lists.denx.de Date: Mon, 14 May 2018 13:49:53 -0700 Message-Id: <20180514204953.11606-3-anarsoul@gmail.com> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180514204953.11606-1-anarsoul@gmail.com> References: <20180514204953.11606-1-anarsoul@gmail.com> Subject: [U-Boot] [PATCH v2 2/2] video: dw_hdmi: fix HSYNC and VSYNC polarity settings X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Currently dw_hdmi configures HSYNC polarity using VSYNC setting from EDID and vice versa. Fix it, since it breaks displays where HSYNC and VSYNC polarity differs Signed-off-by: Vasily Khoruzhick Reviewed-by: Jernej Skrabec --- drivers/video/dw_hdmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/dw_hdmi.c b/drivers/video/dw_hdmi.c index dbad0e2b24..229bd63c97 100644 --- a/drivers/video/dw_hdmi.c +++ b/drivers/video/dw_hdmi.c @@ -401,11 +401,11 @@ static void hdmi_av_composer(struct dw_hdmi *hdmi, /* set up hdmi_fc_invidconf */ inv_val = HDMI_FC_INVIDCONF_HDCP_KEEPOUT_INACTIVE; - inv_val |= (edid->flags & DISPLAY_FLAGS_HSYNC_HIGH ? + inv_val |= (edid->flags & DISPLAY_FLAGS_VSYNC_HIGH ? HDMI_FC_INVIDCONF_VSYNC_IN_POLARITY_ACTIVE_HIGH : HDMI_FC_INVIDCONF_VSYNC_IN_POLARITY_ACTIVE_LOW); - inv_val |= (edid->flags & DISPLAY_FLAGS_VSYNC_HIGH ? + inv_val |= (edid->flags & DISPLAY_FLAGS_HSYNC_HIGH ? HDMI_FC_INVIDCONF_HSYNC_IN_POLARITY_ACTIVE_HIGH : HDMI_FC_INVIDCONF_HSYNC_IN_POLARITY_ACTIVE_LOW);