From patchwork Fri May 11 08:57:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ido Schimmel X-Patchwork-Id: 911857 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=mellanox.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=Mellanox.com header.i=@Mellanox.com header.b="BelRWPaM"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40j3sy1x7xz9s15 for ; Fri, 11 May 2018 18:58:46 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752677AbeEKI6n (ORCPT ); Fri, 11 May 2018 04:58:43 -0400 Received: from mail-he1eur01on0068.outbound.protection.outlook.com ([104.47.0.68]:44676 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752165AbeEKI6k (ORCPT ); Fri, 11 May 2018 04:58:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=k+KH0a5v3OtPMwP9Zo8O0J0GcK7zq8zv1NWpwz6od3c=; b=BelRWPaM3nAPRF4CZzrjsynfttdHEu0DOsphAnskz1+FFKSeq7TrdwZJ2FtZWjIPvoYX68VJE/1TVaIsYNNLwMzELVFqQkmEFpVVHF1/tr/eCUly54vvFaV6OE08Mq4KmI3uPOFHwFxwYIw7Q5w4rE1ZgHfP8kWCEjYEFx2B+Hs= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=idosch@mellanox.com; Received: from localhost.localdomain (79.177.0.42) by HE1PR0501MB2330.eurprd05.prod.outlook.com (2603:10a6:3:27::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.735.17; Fri, 11 May 2018 08:58:34 +0000 From: Ido Schimmel To: netdev@vger.kernel.org Cc: davem@davemloft.net, jiri@mellanox.com, petrm@mellanox.com, mlxsw@mellanox.com, Ido Schimmel Subject: [PATCH net-next 1/2] mlxsw: spectrum_span: Rename misnamed variable l3edev Date: Fri, 11 May 2018 11:57:30 +0300 Message-Id: <20180511085731.9256-2-idosch@mellanox.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180511085731.9256-1-idosch@mellanox.com> References: <20180511085731.9256-1-idosch@mellanox.com> MIME-Version: 1.0 X-Originating-IP: [79.177.0.42] X-ClientProxiedBy: CWLP265CA0058.GBRP265.PROD.OUTLOOK.COM (2603:10a6:401:12::22) To HE1PR0501MB2330.eurprd05.prod.outlook.com (2603:10a6:3:27::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(48565401081)(2017052603328)(7153060)(7193020); SRVR:HE1PR0501MB2330; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2330; 3:2U/yn+B8RF5UrB+TQczVPeP4mpQtWnTBxMe06X0ldMQqS0BvlAVCRiYFuRRUwpZNkfIzx/HKoWgB08d1SRlrnWUUoklWxjwePUIZ7MFeeETFDth7VHTBMcA6bb2dFdrxKfvcCrjaosdW15qW6bD30qTa1rGgKwTrwI4ad5Vrt2VjpE5OSdIFp96anIhQkcXl5KpGQQ+G4tIH5uHWkdwhakNESrdeXAMxHRYt3LHbfinxMP9cKIdBt3Y56BPJ17k7; 25:Rsysshz0PoZQ20L6QHRD/k4RMGiAe58HsvkdId718OPcsI1Nf2mYVmZWYJ+iKFBZOn+/FBfsKCcXxQyn2nEx5np/EME+SWNzgU2/TTqErtLSHcAwhKIglqwL21P1s3raTCoZXdBuKK4Pd/z8Ia4kzhzst6ceRWQnHv4nxg9K4/nx4Kna1E82wdEDVlVFwWSMkHnQmZ9+1lwlFdGyYP+aDRTn2RZPVnGKWXxjy01B6aJuFZZbTN9KRjD6vISEN5IWUPTk60wcCk9GGAX+FOYO4MpoATn8kxZ4Yn43oMPQh+uqImR15P/2LDOpEWsmEIZchL1NNtIm87al+GIbqu11TQ==; 31:EL6U1GzZ12TGcNAjvAtVduptwBVC6zGCK5foMSkRJy0IKcmiOHMmOCc9TwoFSreQq9lwMVognyIhqRTLFPTNjGeaP5uGgHc9ePCi4Q/GaDF37Tf6y8/Is7Qp6Mj5ggA9mON7uD0qcSXQ5m+XdBoQWJaCf4WK46j0ao3LmTUoCURZ5ya7AXr7JyiX9tmKdvzwaRwcWFBkWRT08Q0WhZdV1HjBfdjc6QCSF5CnqpgfM9A= X-MS-TrafficTypeDiagnostic: HE1PR0501MB2330: X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2330; 20:1RWLHW1sCO/Gvy6w+vnVFIA32ijlQGngd2Te0GalKjd+aMY1kJeorBMUPvpeKCiP2jqdqsxqRF733AS6rKXa31xMHH6XgTBHlR0DBrgBZwzRNzGO/t3m+Vu4IYX+OWYNCvh4Lq+QsVRljng3eIiuaesCvCMPtk2wUXj11dhmYnJb4jGdu4S7t9QXxNkO1Um8FsFlmUQ7kNxSjLGaClntx0FSAlotTbZb0WbUivcjVmrnWCNE6b7yREXgiuVJAq7HQ7yHTgACgGRRIsnPFcnsTUMmUKZEtPAyGAnt4GvdMKhShha5oNCGl/ZSLadUwpyCoFi2igXZAb1BhSvdoNW6ddi6s788L5KAJCcY35NmVmf/w8DJWt24kSu156OkwMwtDgf7qqlGj8B0Y4SzE6haIZO1FUD1lTXQbYT1AJu0i2GFZ8IebKRb0GAYNWM46G5nAzx8DwlEXoqv6VdyGoaQw0+sLimhQWLqbf2q2AvAcMhFeqphCeUKlOOnzyjRvBux; 4:kA2Ka9+85c+f8ZRqUcK5x1f6+6wDUKQxJ+FYNgk2LpgTw3eh5dEvbCWdn/mqHS8llFQcrJVFRVRHi0081t7Q9QZkDrh+26C/jkDi2Rj6sTdu0oqaR4vP1T+ztQsn9ZQ2hd3z5uXJ4/alLx0Kx+pllKkrQ+xLZu9nVQXW4+gwD2tSlI3Myey4p1IwmWu3HkkTMXbDdY7HKvlLwPQixCHCdW2+cnoqCR+wFfJo0mkl5erlU5ewZxjR+k6rTNElJmQQR0OAtGtFUwxqZygz4d7vdw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(6072148)(201708071742011); SRVR:HE1PR0501MB2330; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0501MB2330; X-Forefront-PRVS: 06691A4183 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6069001)(376002)(346002)(366004)(396003)(39380400002)(39860400002)(189003)(199004)(86362001)(6512007)(53936002)(486006)(11346002)(3846002)(6116002)(446003)(476003)(2616005)(956004)(106356001)(36756003)(47776003)(107886003)(316002)(16586007)(97736004)(66066001)(7736002)(105586002)(305945005)(2906002)(6486002)(5660300001)(25786009)(4326008)(2361001)(186003)(16526019)(68736007)(478600001)(1076002)(6506007)(386003)(6666003)(51416003)(26005)(6916009)(76176011)(8676002)(50466002)(81166006)(81156014)(48376002)(8936002)(50226002)(52116002)(2351001)(32563001); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0501MB2330; H:localhost.localdomain; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2330; 23:iW3MXusQkigMe7q7YDPutNG8UFhCdwqrvi4VLyshpuKBs5UyWq0lN03hEM4i1cfBGF4l0lEcHwTu9eBiHfgAM+a/ewFnGxKRRpaToQwp7SVKEDOhAvtN+tcF/l1ILZojTz4TxJ11NZp/iBRklq55N7uOfYVHFFtX31j3VMn58A2PCx7AlkvJAu4b7Xr2bblvNy/TllYaAJEjoNieknShbbn/2NzlrpnLa8Tkqzp7/o3dGNlQP82KP2gBv2nU23yww4GQC/08L/mJDQJtL4v/ZbmYckYUJzlWnEwUTDQlHl9Yqct4JoUQApNE+HySApS78VX54M7xht1QyMSm1D9ZC34Ruhxsg6Kx/2pzbcWE2tXEyS4raH5OW9PVhz1gIq+xURinntU46ABxrKHiRcVF+R0rOa8eblJtb75FlQE6ixEPkjalfzcTp9nAYFZZVwGDAXzPiAHJTo8Ontl56vsOMN/c97+0n4U3lZohOoRn55L24Sd3tfM4rI8XMKd7B6P1Vo96P4Cv/YDtm6OANzhYy9iHP+rdwOlfTVqS2zK8nG8cTmf30dOy0D6L8Onie/1RctAGGxTOikEXOuYZEBkjY0pRDleGTLH5B183Ly4VNotbv317ZSzwHrnkVXhkO7Xgq4u3cFKTbvuM9Wj6YeYaVVTbSgstxfXK+9gDjQxflrjJETZ3xkRFkqQG0J9+xYpF0vAbBrNSBWCKCN1WiEByfPbT/2ui4tzSyCb+uhBN7EQt/Qc3I9o0Ymq9myFmpwaRDt4yTDe2+OlHo9QEB3dvTDcSVXhdEhM9a/nXtWj9nzeI/MP8d20KDzqcFwsnzkXaBPZXo7LcTGksEyj75oKyQMYoksZ1l83rxN6xYb1LAgzUS2fxVYT47Jd94iRY05vjSll2hrqbwN3ELawbZL98D3gojW6ObMJ5lFfGhiPLfNCQjIuhb8aDStgLAFImfO0W7zCYU4brvuBPyea8JhjhHGbb4tVx33wLOqllg60SX56Vs4sXhLmhtCP9dVkoIpgOw4RAjzsRlhzF8XgGsHi4pgZ/oDffEINunOhXB7ETkNl78rZw07KHjNmMX1O+yZ49Ttld4iikteo0C58ejgZj4Ayx3qY3KASEMYanhNVL9b7693BseB1hnBe3JJ+AgzL09o6oHWXCzqjDyEz8j9dGED5vBexh8kCD3j9qdJnd7i99Xevu7eEu/wikmId500wvXeaGbERC/Y3Zz2+XdciD9iHy94FEjmIsHHgdcvVJOF2wk9XUqvbsA3pTBQLkNw57joZc8iXn78f1EtXrTB6l1g== X-Microsoft-Antispam-Message-Info: 4pM/j9ea0NGyoFw3R6QKGcORiLL44nNCv/WH4d4HvWBjLJxzxAJeYVFTq1TPaIe7BHBjWaZsAZjaeFBXwU7GMp+Q4WTCtdoL7cd1RArOUCgX/le9TF9U7HGmm/LRNEmy4eXcClismCF3SxGAF0HhwFq3xeE6nD3cJPhUf336Cpt+Pb60CBQK2ikVTtGsOtmn X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2330; 6:ihgC6yqFmBKPotFFBREQ9GWyTdVtHd5giDPMOmLvMbqot0aQDW1YFydinF/aj3QkbeV2Dj6vSpvGp/0bzKoOxUkvZ5rxw3vsiOXhsM2sbKwfRCJE1wx0hZbNXLwM4okBHIhKIdyAOnSK9miPJIX18/M64E+UxqX9UYMK2VMzS2ADnNDtpwVaIwspJOswlMQHNRRWzFu7AnWRYI2LDkcE9AxUKppkx3tmoodh6PHKfcRLBnZQ7h7vOEQ1UT6SXyh9G9CvFx2GGtLYcyOdfs1vrEo2W58nisN8DaJc40vuNaUbWo9yHHWEV+ljYD2XLiOVEEq7MfmLuYNXs0k/pBu2AGdICTrAiznkV72gyFlGZCzTjJ+hP8A0jXzphoZrthSXuTUMOyKKw3+3VxsnbwgJMG4WtURjI7SKDVw+MhHA+eQGboB+FkzPYMl724BZNPBdN99qRlAplmFcnKe8pCur3A==; 5:6Ptf55RRnfy29h0Cg4aeunRNaPxcuMMi6RGFIYpBRtd8XqJnRH8S0u2kV5MsqpNLSvTv0rT1btXL+eWXzJz1iV0J4Frck/i8eGVez4wRTlr+1Uycl+1I4QGVryTD0b/d7X2kV2JLm4cUXWyLDvXt9vik08/4jS+PXaB6EdqgXcA=; 24:NUsDssgpKpdhS0UoxBRjW4OGyy4SNKlbUK/ogZ6Y6OEuWH4jHYXDADhJNQER864z5C7ditswtPb6pNEbdAfnvwwBhNHZWGb4tdhvGIv+msk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2330; 7:uw+IL6wdAIqs68bgK8jFpIwSf37bXswB3mx97o560TIVAxwz5qBmm4RnnaWasIlljc8ZUCCtwVdkbaClR55n4n6GOCRK7lNZbqc3ShqpOX+A0Cxo9C4Yt+UQ80gkORRm0NZ/CcNWkCtGyoru6dzfO+1zHlmML0ViG7RpfuR1Hknpoa1cVx20A5virZCRG9GYHk2gmhNLW+KrL5uctB/Z01BaSu1E17TO2+iE4hQ959yGH0QbougPmntXGnw6EO+p X-MS-Office365-Filtering-Correlation-Id: 992401d9-ba99-401b-710c-08d5b71d61cc X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2018 08:58:34.9578 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 992401d9-ba99-401b-710c-08d5b71d61cc X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB2330 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Petr Machata Calling the variable l3edev was relevant when neighbor lookup was the last stage in the simulated pipeline. Now that mlxsw handles bridges and vlan devices as well, calling it "L3" is a misnomer. Thus in mlxsw_sp_span_dmac(), rename to "dev", because that function is just a service routine where the distinction between tunnel and egress device isn't necessary. In mlxsw_sp_span_entry_tunnel_parms_common(), rename to "edev" to emphasize that the routine traces packet egress. Signed-off-by: Petr Machata Signed-off-by: Ido Schimmel --- .../net/ethernet/mellanox/mlxsw/spectrum_span.c | 32 +++++++++++----------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_span.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_span.c index 3b77990df599..adf1f789b166 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_span.c +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_span.c @@ -137,14 +137,14 @@ struct mlxsw_sp_span_entry_ops mlxsw_sp_span_entry_ops_phys = { static int mlxsw_sp_span_dmac(struct neigh_table *tbl, const void *pkey, - struct net_device *l3edev, + struct net_device *dev, unsigned char dmac[ETH_ALEN]) { - struct neighbour *neigh = neigh_lookup(tbl, pkey, l3edev); + struct neighbour *neigh = neigh_lookup(tbl, pkey, dev); int err = 0; if (!neigh) { - neigh = neigh_create(tbl, pkey, l3edev); + neigh = neigh_create(tbl, pkey, dev); if (IS_ERR(neigh)) return PTR_ERR(neigh); } @@ -246,7 +246,7 @@ mlxsw_sp_span_entry_vlan(const struct net_device *vlan_dev, } static __maybe_unused int -mlxsw_sp_span_entry_tunnel_parms_common(struct net_device *l3edev, +mlxsw_sp_span_entry_tunnel_parms_common(struct net_device *edev, union mlxsw_sp_l3addr saddr, union mlxsw_sp_l3addr daddr, union mlxsw_sp_l3addr gw, @@ -260,31 +260,31 @@ mlxsw_sp_span_entry_tunnel_parms_common(struct net_device *l3edev, if (mlxsw_sp_l3addr_is_zero(gw)) gw = daddr; - if (!l3edev || mlxsw_sp_span_dmac(tbl, &gw, l3edev, dmac)) + if (!edev || mlxsw_sp_span_dmac(tbl, &gw, edev, dmac)) goto unoffloadable; - if (is_vlan_dev(l3edev)) - l3edev = mlxsw_sp_span_entry_vlan(l3edev, &vid); + if (is_vlan_dev(edev)) + edev = mlxsw_sp_span_entry_vlan(edev, &vid); - if (netif_is_bridge_master(l3edev)) { - l3edev = mlxsw_sp_span_entry_bridge(l3edev, dmac, &vid); - if (!l3edev) + if (netif_is_bridge_master(edev)) { + edev = mlxsw_sp_span_entry_bridge(edev, dmac, &vid); + if (!edev) goto unoffloadable; } - if (is_vlan_dev(l3edev)) { - if (vid || !(l3edev->flags & IFF_UP)) + if (is_vlan_dev(edev)) { + if (vid || !(edev->flags & IFF_UP)) goto unoffloadable; - l3edev = mlxsw_sp_span_entry_vlan(l3edev, &vid); + edev = mlxsw_sp_span_entry_vlan(edev, &vid); } - if (!mlxsw_sp_port_dev_check(l3edev)) + if (!mlxsw_sp_port_dev_check(edev)) goto unoffloadable; - sparmsp->dest_port = netdev_priv(l3edev); + sparmsp->dest_port = netdev_priv(edev); sparmsp->ttl = ttl; memcpy(sparmsp->dmac, dmac, ETH_ALEN); - memcpy(sparmsp->smac, l3edev->dev_addr, ETH_ALEN); + memcpy(sparmsp->smac, edev->dev_addr, ETH_ALEN); sparmsp->saddr = saddr; sparmsp->daddr = daddr; sparmsp->vid = vid; From patchwork Fri May 11 08:57:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ido Schimmel X-Patchwork-Id: 911858 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=mellanox.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=Mellanox.com header.i=@Mellanox.com header.b="c+SVP4Sv"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40j3t33FJdz9s15 for ; Fri, 11 May 2018 18:58:51 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752711AbeEKI6u (ORCPT ); Fri, 11 May 2018 04:58:50 -0400 Received: from mail-he1eur01on0068.outbound.protection.outlook.com ([104.47.0.68]:44676 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751406AbeEKI6l (ORCPT ); Fri, 11 May 2018 04:58:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=p9mpPUobG9amvEXGPQWfbEN5LJIMn7r74NvlbAlQ9mA=; b=c+SVP4SvO9yoR35MAlGMmaxtL2Sku2YrS/8EHEU3ZfpHWpjtDxfT1ggZ28NTQWeieMa3mENEs3AX4LgqwcoZBR/3cI9JA6zce/138CLKzk2tlQ46jBNSpApPiUxlf/Ftago3rD6BwisxEPtT2y04hnCqyhAhahV1MZEs84xc5YY= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=idosch@mellanox.com; Received: from localhost.localdomain (79.177.0.42) by HE1PR0501MB2330.eurprd05.prod.outlook.com (2603:10a6:3:27::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.735.17; Fri, 11 May 2018 08:58:37 +0000 From: Ido Schimmel To: netdev@vger.kernel.org Cc: davem@davemloft.net, jiri@mellanox.com, petrm@mellanox.com, mlxsw@mellanox.com, Ido Schimmel Subject: [PATCH net-next 2/2] mlxsw: spectrum_span: Use a more fitting error code Date: Fri, 11 May 2018 11:57:31 +0300 Message-Id: <20180511085731.9256-3-idosch@mellanox.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180511085731.9256-1-idosch@mellanox.com> References: <20180511085731.9256-1-idosch@mellanox.com> MIME-Version: 1.0 X-Originating-IP: [79.177.0.42] X-ClientProxiedBy: CWLP265CA0058.GBRP265.PROD.OUTLOOK.COM (2603:10a6:401:12::22) To HE1PR0501MB2330.eurprd05.prod.outlook.com (2603:10a6:3:27::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(48565401081)(2017052603328)(7153060)(7193020); SRVR:HE1PR0501MB2330; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2330; 3:P4g+8x9nSgOutl5XRF9yxx45cwBBu73KjUQTrodx7wnZCoI9qvUlRvMwt5C2RUgVcJZ2miZrTGK6E9YJxq42nj1f1wWO2YiD+ykyVEtimZ3+knW5TxqDnfD2ObLupB3uEekx9O1Lfs17pgrcXaogmp6DIFbesyW/bmXMgZDxyXSoz5j6sIpvgoEvB6G0QJlQQKIuH3wfyQRGBJwsmo7qMfvFlvN+7M1lUsqTtyBoWZI6qdw8go84Hp/2MPchSURw; 25:Eve56AEoMSvRMGPMvpMmDUPFjNSogyOeOt/VOGQd/sIDjZVSzqpC3BSbQN3njj0oVvAvetCA0OkIGqJRnQCCJCvoUKiQYUWbsDUraD4NqgxGzWa0UWGK2CBTnajThZQoftSRN8tdZ+xNRlmmMqajmAAPXQo84QxDokAKcLN+E6wrJe0hYuEAt5UlOGUBshQVPHroql4klHjBnGetsAltnGDjZVVjA1Nzgx6tjTsZvPzJpboXhdUDHOF/uieD/zPWNk8JmfX3iIDh+hgxEU4Qgnc67EU9TdATo7qKzXM/JnsXfJ1o7FISbzAWD1Ae7/nWiuBKJyd3TZALq8ZirHxYZg==; 31:lSvkejzI/OpEsuOq2o+PvzpTgC04vqZHxPSqVGyDCIe5cJGKZtoMdSulnQIg/EcyyaK8C71/azm0M/ZdpLs6ny3RJSC6f1mDO3Qi315JmPmcsOszy8uF0tmMKeloUJ4i1GBBLfD1gjoJdp8Lb9w7vyTO87WezCPR73YgLLxsHLhxK3B2PFQJbHH7hBSzuKJtDR6+KOyh7xiQjRt7jvDaTlRKU2P/lTpXjlEfjWfLQvo= X-MS-TrafficTypeDiagnostic: HE1PR0501MB2330: X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2330; 20:utTrVXDBkHzJkPjclj6G8QVLRMo2NP7hHC8A/TIYwgZ1LiuUja9vath2ieVsiBNUUxzYBg4PnlPT6i/sH2Ur0BIj1XAl/iRLj2JB9EjhPoiSzoKnVldzrH1ZA2zFbCDxKWb+YBdRzMFN4DhaEnwOV2+gmtSojzhgxyY5OYs1a4wY4xis5ubym/zFmJ2F1GVcfGdUCYH8jAUgeq+ccvPq3n3T130tXy0KmzADl3s8ycKjlz5R3uRD0P1R2lXMG7sYnXN+QQLr03pNXXml8BdPlnHfbqvd3QD9ZqdYA/oRMzrdAFWBDHJwOdW+XrYISkGGPezzuGurYkM8kit5xHl2ZlG/8uqoNgLC2KQtQLquztg5wkPiuADeLM+L3GVYuz+Jj92jPH71rtMbF8BderXml7mC54inmy7fhWqhlLEBqn25+Kge2ZGfPCxT++IbDXrlrKFWGlXrEMm1aO5IUsHZ3QRS001D1EUp9LZshOn1yb30WCv43Hdnz2+3VojwgQim; 4:AZRKiCtAU1gxMgmCrEmeyK/XhF28IOEr9r6AHCkbyvuewygj7aKECx6uRNVeD+fRihSyJh5cDsE06zclh/DARMvne1AObx9+tKA5x9YaJnsiT2nWuSJ909e4dWjFyHhFtSgcQ4r3p55UMqnlYq5308XSw1fDHSeLqP85hvml+krHLOU/A9X9Ithb0JZUIa82magCZthpkEVBcrGQ2u5D3TIclk4kRTLDkCqhHUscNu8pxlFlH+Y2I4wyKn+duWx4qV+1LHNnyXEEEEtSk/goDQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(6072148)(201708071742011); SRVR:HE1PR0501MB2330; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0501MB2330; X-Forefront-PRVS: 06691A4183 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(979002)(6069001)(376002)(346002)(366004)(396003)(39380400002)(39860400002)(189003)(199004)(86362001)(6512007)(53936002)(486006)(11346002)(3846002)(6116002)(446003)(476003)(2616005)(956004)(106356001)(36756003)(47776003)(107886003)(316002)(16586007)(97736004)(66066001)(7736002)(105586002)(305945005)(2906002)(6486002)(5660300001)(25786009)(4326008)(2361001)(186003)(16526019)(68736007)(478600001)(1076002)(6506007)(386003)(6666003)(51416003)(26005)(59450400001)(6916009)(76176011)(8676002)(50466002)(81166006)(81156014)(48376002)(8936002)(50226002)(52116002)(2351001)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0501MB2330; H:localhost.localdomain; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2330; 23:eQfn3JTqAoSJNfCp2HT2h+n8PL3h8oC1Z60ZK7v+bd2AUkhHLYo9a0jACnjvSLLo4emqDxhfda4LYrtKN+DKky0JLzaddgGfpx8dwIa2pLolVM2c5voI+UNDVd45JyF16vGeauNTgoIlR57UJt/X00hnGKKPmu+IE0ptgFuZXV807AwhZF+TvFsMoqzjC20zSaou2NT2QC4PKeLQ1Q45kRtHeD6T9cGtDUmmfKTaf3wMqETw88d/samNOjkb+v4KjbaFZ7WZPURcj3yXgIUeLxh0f9UdnhXWZS7UqREnf/IHbcZyzCchAFRMFVl4UrEI5VIzENxYbPHUKcap/nuac8YkX4+dW17nmnn89YFXMw6dV1yI4Gf2knOEGnVTUZx9/ZxYLjxownscQZ46TmVe8vof+WxMO+6LlHxKiyb4TpZuWKTIHTQ7N5D1dJrVV6jQktNJuk97+/xxiArUpHFMsePhi14Lwcp8Ii/lSc0GDl55O5wBmozzwhX2/AoyKcoWyGBpI5/pd9JrN9UNDccMoriT07TqJw+xX39wJxDqjxyS0EKn70VbU2I5eDDgm2Kdw8MnVD9f+Xc99/D/pzHaJ95JN8g8GQujlcM4W3Y+Fibb15F3vP8pw9bDY2mqJQVroooR70ywWovz8N1hK7AJp/zttUxXiC1/Rpv/IG9HLtF6gEsflre0QUAV61EPNIaMmtPJPpjg7cqMmHdlRcNq6ulOUQ9104Jk1gntpXFEGW2/DOvButyXBT7T3DVzJeVsZS5d6irIlzXmGYI6VfsdnQz6vRhr+hRL/Ayu7VUbAQkVmB+XkuTZUuIchss8WIGliST4povVRdB1U7MR/jdgc5zL93NYUo3dhn2FOZ1wvqYFK5dppaZdURwA3yWDyM3nEPZ8JpTjW5q8z3Gamy2H97SBTKedjhDi5gx4S8yEuBGHiZXpO9mLCxJsLVInhgP+/f7FaWG6qaEid/FuTJQ04QZi8sF+3gcsYI2dwAsjJ/rSgXseA+9VylrlwW4iRji46prf+WbuVt4U1sjp1SYyFbj5AgRzkWnxgBluwLGbX/1jg7eLWiGLzwn7VsQTmdySof+vW8eOECusWEqez5WKCZDAYwB85B8FhHrFrqmEj6KZKqtdtouhLvlhSWwr5aDlpA3Ufm3VQbLxEIeTQDfKxPNDVLryo02ZyRY5WBwpa9WttXVzef8mBuqvBmhqy8fen0VJekT1X6bNAe+2dKzlbb6lHXyBziK00XS0FzxNVNxaL3a4LhdDXnIU9idm3XppQI1Du694lQI7bWVGu/iV7vwCNjAiaA+rtxYB0cOVeyQXzPI5u2TVFPG5157zhrdfbq37Pg22B5WW0hG8mAnx3nx84Lba6x4tT4iBBpBIQgW7XJt4xylBNnDwqd9W3Px9 X-Microsoft-Antispam-Message-Info: BSORf19HaqoVnTa6CeQ2426TvKpyBUNdC1ihYpFC+EAK4q4qrUlQmuGG/dJGfti5IhH1Iv0Bb9JHAg9+cxjfdzi1bqGPvpNiDEapCnVmo6spjMdFjcXVxUZROKv/gVTnQcUZ/jvDW3ewnwnsB+wYoWP4NMrOpEHCQTjRywo8V3Wt17ysWvwyb8vWCM0PVF7I X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2330; 6:EIZHSmCQRj7BVykN8U6qrTc1ptOXfWt+mLXgfu9FZMZhFEHMq091HDzaL4TizJOIe/AeNYFzNW0cW1ccGvOhI7A8zWJj7O4TizIEgvCdJRmPFJJdX0qXe0WEo9vrelJl658YvV6MxDqI6iq3iU2BZEhOhMJaqcrsLcJFWraEa6MtGaYHpNlyqDT/I+np/Ft643Lip5VTGrudfv+GIKolHEh+J6pGmgOZMdHpSbXEyqX2ytTGMfPkHkANg37SPxV366H83++o7rSXTg8SH9TbYnisxgXRQBl+Erf+scpW/nS+ILrEYehMXpkTMeUjOL1j+jf6eRRCZwSmtv+b88b/tP+yReQIjmsviwNuwUJ9qNNO4E9HxbFBnLtstT7Z4E1NFJqsdTt4E1wfM6IPqhfFtleZR/iqI28XJC/8TspJ2ZcGzAO9JqTk5js1vsJg9HTES/lTuUMpAs2Axz5D6qG9nw==; 5:2KcUlmoUXOvxuenhcAYiHYikFGWR5qYhFVc/OEeqNg0tGzcFA2vqLbX1P0pzp/hpacl4u5LEfRzNXGe1boE0DV1pcS0P+grTbzKnTVcx+ZUgnrk8ebYy5nYsqKfoUITEwoX0wOFCkSAdYblml1fh8TEax3mDNUquOJ7O8IHvbW8=; 24:/ngSolFyaQ5u0iEh7322tdcr4/5FDc69NGSN9pyOLEjiKTFhBPaR/Af7r6UxseCN4dXxdK6pXABydEUhXvhpqyOI5mR0lthtNI3g3wgU6uw= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2330; 7:/Z3q0by1ECxI9p2S/H985UroiTWEGO1Ia6wgG2e0znpWDuEY57VKsVYjxC9Jr+8Qnw7jYySdPJEZ2uF0qes2hrSGPUENy2Kpa5G/iprTLlwMUpS+FVXEmtuVg6CvesaFYlWJGouMGeAPtJ0tya6kwZ0lVfhmykF5BJasFYg0nsnNOpBRwjR6UON3XYwluO5KHvmcweqMN08zTb7PoZTqUt9LatdDo7FRu4/HEoy5UXs55ZyAxSsJ+jmBRhLWEbOn X-MS-Office365-Filtering-Correlation-Id: 78481f34-7852-4f87-c51e-08d5b71d6304 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2018 08:58:37.0359 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 78481f34-7852-4f87-c51e-08d5b71d6304 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB2330 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Petr Machata ENOENT is suitable when an item is looked for in a collection and can't be found. The failure here is actually a depletion of a resource, where ENOBUFS is the more fitting error code. Signed-off-by: Petr Machata Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/spectrum_span.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_span.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_span.c index adf1f789b166..e5f4f7620ab7 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_span.c +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_span.c @@ -924,7 +924,7 @@ int mlxsw_sp_span_mirror_add(struct mlxsw_sp_port *from, span_entry = mlxsw_sp_span_entry_get(mlxsw_sp, to_dev, ops, sparms); if (!span_entry) - return -ENOENT; + return -ENOBUFS; netdev_dbg(from->dev, "Adding inspected port to SPAN entry %d\n", span_entry->id);