From patchwork Fri May 11 02:26:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wang Shilong X-Patchwork-Id: 911671 X-Patchwork-Delegate: richard@nod.at Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="b4o5zVcJ"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="dtYPi6np"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40hv9T2tNMz9s19 for ; Fri, 11 May 2018 12:26:33 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=LEaCRIeR69VIeDtP6iUtlFzd5iGR4+lSvIXgGHsBiBM=; b=b4o 5zVcJ8RYE2lmX6nm43aNOVqZoHrUdhlGRBNN3qNO+MZDAaj5WEL72rFVxsq+QD8Y8NcROF9UMOvJs a/XkrAg8uKatkT3gsdxlOdD7YTgcnXbThV33UlrCYMs+70ZLtDIxodNhbV3oL0/AJ4OfQiaXzCg88 Mv+RuoP4lxot9Kx9pXAJzNZw0/gQ9levAg+Uv9WEzgIvpvOR5v5m9LNsIartQK2c42AbowC3ARVXQ dYN/CBjVXTB9c79iitKq1OnP33nupwKLdH4DBxzkmQ/yPSfBlB07yi7gQ0JRbDpouJVat4a/lk2rQ aqmUJPPl6oomso+W8L5HHDxjwSk0NIQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fGxlJ-0000ub-U1; Fri, 11 May 2018 02:26:25 +0000 Received: from mail-pg0-x242.google.com ([2607:f8b0:400e:c05::242]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fGxlG-0000tQ-Ci for linux-mtd@lists.infradead.org; Fri, 11 May 2018 02:26:23 +0000 Received: by mail-pg0-x242.google.com with SMTP id i194-v6so1779097pgd.0 for ; Thu, 10 May 2018 19:26:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=ad00gPPft+NCZc2iQUuakihaV5rkEbkF8t3ANl1Sphc=; b=dtYPi6np7l1NG4YdioU7sAb1Um6H5Iowv9Cc4kYvuWBpUwBQ311+TSjsQK3Imjk7aA Qy5uECu2Zi7Aa9AFp6roiD6Admf5DvCXqkmS0a74K5F1s95CWCNDCEJtKX6nb+IBZse1 nYdIpvWkJHd+4bEFQRT03vxcdPtXpK/Kste0qqAv7SbP93ZU8pM92RHw7cAM2X1qca76 3eA+xvzA6rKAYomCFUEsLAliGqY/UHGt7oXGZIpnVhg5r7eZ9/HpzCFsWISZoxr8MZJd kglmg/1IWql6rX/Z/isvWvqc5X93TTfbeF+zLLVgRf5Yjw01R0tA5CCUjnrWY6pnO+6D sPZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ad00gPPft+NCZc2iQUuakihaV5rkEbkF8t3ANl1Sphc=; b=qKho49wzVM1AGzh0OPnVvJrFerzOsiAZEW+VtUuH+bLGNYwpgleo81jX/cgGuJME3h YBnKBHtKPxAB+bb+IomtOXoj7NPsWurq5pEZ/c38A/LG6oSGcWw7zbqEiNXHytBhJB+P dkgR5rskjrajUxvSH+xQrWPmBNycXaBq44IQ2GYAutsc1Vj6cHliaLt7CXV3cicnjO7G BfDul26LM3o2JnCO/3cHZgYZaZqzQ64oQqSjdjxf0KsRvTYzMrhzSp1RmJud+Xfgajlu lKNLFFD79ha2zrqRPtXVcxO6kOqwoy8gMUpH2pCQrKgTIZk8h//pPdLy5Opq1fV4f3AG 1UQA== X-Gm-Message-State: ALKqPwfmcZyGk8SIzS65PuXovbMiWBt1Wess1pY7KJaLg3FTbh7+Rx5Z u5Rlvy8F2MBqWIPt4HgCPeSBsA== X-Google-Smtp-Source: AB8JxZq/DaLfYMN84Bt9TI2bG2SCL3/oC/zokRDyI90y26kG/Qifpr7YdMa0HvBzHauxwlwJ7LPqOw== X-Received: by 2002:a63:725b:: with SMTP id c27-v6mr2828599pgn.296.1526005570927; Thu, 10 May 2018 19:26:10 -0700 (PDT) Received: from localhost.localdomain (fs276ec80e.tkyc203.ap.nuro.jp. [39.110.200.14]) by smtp.gmail.com with ESMTPSA id z13-v6sm3482254pfe.77.2018.05.10.19.26.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 May 2018 19:26:10 -0700 (PDT) From: Wang Shilong X-Google-Original-From: Wang Shilong To: linux-mtd@lists.infradead.org Subject: [PATCH] ubifs, xattr: remove misguided quota flags Date: Fri, 11 May 2018 11:26:03 +0900 Message-Id: <1526005563-25667-1-git-send-email-wshilong1991@gmail.com> X-Mailer: git-send-email 1.7.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180510_192622_434032_B3C2067F X-CRM114-Status: GOOD ( 11.89 ) X-Spam-Score: 0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:400e:c05:0:0:0:242 listed in] [list.dnswl.org] 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (wangshilong1991[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (wangshilong1991[at]gmail.com) -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jack@suse.cz, rockdotlee@gmail.com, Wang Shilong MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Wang Shilong Originally, Yang Dongsheng added quota support for ubifs, but it turned out upstream won't accept it. Since ubifs don't touch any quota code, S_NOQUOTA flag is misguided here, and currently it is mainly used to avoid recursion for system quota files. Let's make things clearly and remove unnecessary and misguied quota flags here. Reported-by: Rock Lee Signed-off-by: Wang Shilong --- fs/ubifs/xattr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ubifs/xattr.c b/fs/ubifs/xattr.c index 759f1a2..6f720fd 100644 --- a/fs/ubifs/xattr.c +++ b/fs/ubifs/xattr.c @@ -139,7 +139,7 @@ static int create_xattr(struct ubifs_info *c, struct inode *host, inode->i_op = &empty_iops; inode->i_fop = &empty_fops; - inode->i_flags |= S_SYNC | S_NOATIME | S_NOCMTIME | S_NOQUOTA; + inode->i_flags |= S_SYNC | S_NOATIME | S_NOCMTIME; ui = ubifs_inode(inode); ui->xattr = 1; ui->flags |= UBIFS_XATTR_FL;