From patchwork Mon Apr 30 17:01:56 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 906791 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=208.118.235.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40ZW863HGMz9s0q for ; Tue, 1 May 2018 03:03:13 +1000 (AEST) Received: from localhost ([::1]:60675 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDCCj-0002Jo-2c for incoming@patchwork.ozlabs.org; Mon, 30 Apr 2018 13:03:09 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59094) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDCC2-0002IX-86 for qemu-devel@nongnu.org; Mon, 30 Apr 2018 13:02:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fDCBx-0007J6-Ez for qemu-devel@nongnu.org; Mon, 30 Apr 2018 13:02:26 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:35245) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fDCBx-0007IY-45 for qemu-devel@nongnu.org; Mon, 30 Apr 2018 13:02:21 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue101 [212.227.15.183]) with ESMTPSA (Nemesis) id 0MSJ5v-1eo8Ia18kl-00TTkc; Mon, 30 Apr 2018 19:02:19 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Mon, 30 Apr 2018 19:01:56 +0200 Message-Id: <20180430170156.1860-2-laurent@vivier.eu> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180430170156.1860-1-laurent@vivier.eu> References: <20180430170156.1860-1-laurent@vivier.eu> X-Provags-ID: V03:K1:+GwsLHp+V+H4G4EpheIWYC0e9M8MJfzSAIImK2HWgNJEyhqo+gx PNtmJceo1M9UBXhcoUy1D8/zPpxlKNDuOd1w8QDS8IqGLSbDrEYQis/psAP0RzzkBZq8jT3 RDibrczOy45W2oZ4DBctHzbEHnZbtBcDfIM5U15dwru5AluTchclzoSp3moDnWkv7Bjq2TA pdkhEl25NzWiUiUwLulqw== X-UI-Out-Filterresults: notjunk:1; V01:K0:zRKByp7LQQI=:zZ9AGtvzd2PiDMmz7kKKhP PAtn/HxSEhCncwdO+RTU554nnc4mCt8WHWORTdzTC/O9zxUpSRJvj+hziKbyFUvTkpmQ0MKbQ jWrHiu+QjFgJBKnBpEUPkmG/BFTD8J+GnpigMmd/gcEcVHKV9z0sOhRp/816RsTWkmqE4nsPS ZdQqUcqlfrVF+j1xoLF2iUsqYCw34PiH7UL+mHBXQ1sYavxv3TpeAWCnkDET+ZRmOgmZ5Mos+ wuD6dAmZrHCtie/JZZxkYMu7iL9cp75d7lzee9mSsMGar56QB83TThHfOABrd9ssj6DqTKaZ0 UQLJDfbE6OGb2nsH5mLyDX/pbVPN/EO/IGlNv1AMG9yxqIltGZ7rlCbKeRxDo/7UGrjNYqC6R Y42bkQ3eqNAPmcc2317MX+rK8d62ssRdPDugUATT4o/1jRUb5XJM1OkFF1rrZ1QGtT2hziCjA BNfu021+vN5U9SsEWmPS30RQchYsgYy76h+tN3RPvkZg6dxHv1ieZRssmEBcSQXG/o8WbH2yH 6bqXQwcKBV8Py9x3uHTA+orBqVd/HMrgOe1iWB4asGgJeh9U1tsMB6khEYybrnSKpVHt87jwI KRL7PETqclSKt28XILBNqby8V+j6IugE4BIohiLuGlpgs0PE4oS779qaGj0fWCYlffvYKbXTG KKXqr7TMgybmqoJjeWluE9kHH4sBWqMxWdTY02K0zWD4WSpVcR3CVOrQRLD5WwGZqD60= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 217.72.192.73 Subject: [Qemu-devel] [PATCH 2/2] m68k: remove dead code (Coverity CID1390617) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" floatx80_sin() and floatx80_cos() are derived from one sincos() function. They have both unused code coming from their common origin. Remove it. Signed-off-by: Laurent Vivier Reviewed-by: Peter Maydell --- target/m68k/softfloat.c | 43 ++++++++++++++----------------------------- 1 file changed, 14 insertions(+), 29 deletions(-) diff --git a/target/m68k/softfloat.c b/target/m68k/softfloat.c index 2c069a5efb..e41b07d042 100644 --- a/target/m68k/softfloat.c +++ b/target/m68k/softfloat.c @@ -1497,7 +1497,7 @@ floatx80 floatx80_sin(floatx80 a, float_status *status) int32_t compact, l, n, j; floatx80 fp0, fp1, fp2, fp3, fp4, fp5, x, invtwopi, twopi1, twopi2; float32 posneg1, twoto63; - flag adjn, endflag; + flag endflag; aSig = extractFloatx80Frac(a); aExp = extractFloatx80Exp(a); @@ -1515,8 +1515,6 @@ floatx80 floatx80_sin(floatx80 a, float_status *status) return packFloatx80(aSign, 0, 0); } - adjn = 0; - user_rnd_mode = status->float_rounding_mode; user_rnd_prec = status->floatx80_rounding_precision; status->float_rounding_mode = float_round_nearest_even; @@ -1591,14 +1589,8 @@ floatx80 floatx80_sin(floatx80 a, float_status *status) status->float_rounding_mode = user_rnd_mode; status->floatx80_rounding_precision = user_rnd_prec; - if (adjn) { - /* COSTINY */ - a = floatx80_sub(fp0, float32_to_floatx80( - make_float32(0x00800000), status), status); - } else { - /* SINTINY */ - a = floatx80_move(a, status); - } + /* SINTINY */ + a = floatx80_move(a, status); float_raise(float_flag_inexact, status); return a; @@ -1616,7 +1608,7 @@ floatx80 floatx80_sin(floatx80 a, float_status *status) status); /* FP0 IS R = (X-Y1)-Y2 */ sincont: - if ((n + adjn) & 1) { + if (n & 1) { /* COSPOLY */ fp0 = floatx80_mul(fp0, fp0, status); /* FP0 IS S */ fp1 = floatx80_mul(fp0, fp0, status); /* FP1 IS T */ @@ -1629,7 +1621,7 @@ floatx80 floatx80_sin(floatx80 a, float_status *status) xExp = extractFloatx80Exp(fp0); xSig = extractFloatx80Frac(fp0); - if (((n + adjn) >> 1) & 1) { + if ((n >> 1) & 1) { xSign ^= 1; posneg1 = make_float32(0xBF800000); /* -1 */ } else { @@ -1681,7 +1673,7 @@ floatx80 floatx80_sin(floatx80 a, float_status *status) xExp = extractFloatx80Exp(fp0); xSig = extractFloatx80Frac(fp0); - xSign ^= ((n + adjn) >> 1) & 1; /* X IS NOW R'= SGN*R */ + xSign ^= (n >> 1) & 1; /* X IS NOW R'= SGN*R */ fp0 = floatx80_mul(fp0, fp0, status); /* FP0 IS S */ fp1 = floatx80_mul(fp0, fp0, status); /* FP1 IS T */ @@ -1744,7 +1736,7 @@ floatx80 floatx80_cos(floatx80 a, float_status *status) int32_t compact, l, n, j; floatx80 fp0, fp1, fp2, fp3, fp4, fp5, x, invtwopi, twopi1, twopi2; float32 posneg1, twoto63; - flag adjn, endflag; + flag endflag; aSig = extractFloatx80Frac(a); aExp = extractFloatx80Exp(a); @@ -1762,8 +1754,6 @@ floatx80 floatx80_cos(floatx80 a, float_status *status) return packFloatx80(0, one_exp, one_sig); } - adjn = 1; - user_rnd_mode = status->float_rounding_mode; user_rnd_prec = status->floatx80_rounding_precision; status->float_rounding_mode = float_round_nearest_even; @@ -1837,15 +1827,10 @@ floatx80 floatx80_cos(floatx80 a, float_status *status) status->float_rounding_mode = user_rnd_mode; status->floatx80_rounding_precision = user_rnd_prec; - if (adjn) { - /* COSTINY */ - a = floatx80_sub(fp0, float32_to_floatx80( - make_float32(0x00800000), status), - status); - } else { - /* SINTINY */ - a = floatx80_move(a, status); - } + /* COSTINY */ + a = floatx80_sub(fp0, float32_to_floatx80( + make_float32(0x00800000), status), + status); float_raise(float_flag_inexact, status); return a; @@ -1863,7 +1848,7 @@ floatx80 floatx80_cos(floatx80 a, float_status *status) status); /* FP0 IS R = (X-Y1)-Y2 */ sincont: - if ((n + adjn) & 1) { + if ((n + 1) & 1) { /* COSPOLY */ fp0 = floatx80_mul(fp0, fp0, status); /* FP0 IS S */ fp1 = floatx80_mul(fp0, fp0, status); /* FP1 IS T */ @@ -1876,7 +1861,7 @@ floatx80 floatx80_cos(floatx80 a, float_status *status) xExp = extractFloatx80Exp(fp0); xSig = extractFloatx80Frac(fp0); - if (((n + adjn) >> 1) & 1) { + if (((n + 1) >> 1) & 1) { xSign ^= 1; posneg1 = make_float32(0xBF800000); /* -1 */ } else { @@ -1927,7 +1912,7 @@ floatx80 floatx80_cos(floatx80 a, float_status *status) xExp = extractFloatx80Exp(fp0); xSig = extractFloatx80Frac(fp0); - xSign ^= ((n + adjn) >> 1) & 1; /* X IS NOW R'= SGN*R */ + xSign ^= ((n + 1) >> 1) & 1; /* X IS NOW R'= SGN*R */ fp0 = floatx80_mul(fp0, fp0, status); /* FP0 IS S */ fp1 = floatx80_mul(fp0, fp0, status); /* FP1 IS T */