From patchwork Sat Apr 28 02:24:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Linhaifeng X-Patchwork-Id: 906022 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=huawei.com Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40XvlG1TNSz9s08 for ; Sat, 28 Apr 2018 12:24:41 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 88CC025A; Sat, 28 Apr 2018 02:24:39 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 6081211 for ; Sat, 28 Apr 2018 02:24:37 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from huawei.com (szxga02-in.huawei.com [45.249.212.188]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id AABFB67B for ; Sat, 28 Apr 2018 02:24:36 +0000 (UTC) Received: from DGGEML401-HUB.china.huawei.com (unknown [172.30.72.56]) by Forcepoint Email with ESMTP id F2B33680534D7 for ; Sat, 28 Apr 2018 10:24:32 +0800 (CST) Received: from DGGEML422-HUB.china.huawei.com (10.1.199.39) by DGGEML401-HUB.china.huawei.com (10.3.17.32) with Microsoft SMTP Server (TLS) id 14.3.361.1; Sat, 28 Apr 2018 10:24:34 +0800 Received: from DGGEML502-MBS.china.huawei.com ([169.254.3.252]) by dggeml422-hub.china.huawei.com ([10.1.199.39]) with mapi id 14.03.0361.001; Sat, 28 Apr 2018 10:24:33 +0800 From: Linhaifeng To: "dev@openvswitch.org" Thread-Topic: [PATCH] dpif-netdev:Delete port check in do_add_port Thread-Index: AQHT3S4VOPn7SbLQ+E6mQgCjx7V0xKQVdYSQ Date: Sat, 28 Apr 2018 02:24:33 +0000 Message-ID: <4099DE2E54AFAD489356C6C9161D533394CB77EC@DGGEML502-MBS.china.huawei.com> References: <1524726771-17384-1-git-send-email-haifeng.lin@huawei.com> In-Reply-To: <1524726771-17384-1-git-send-email-haifeng.lin@huawei.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.177.20.223] MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] =?gb2312?b?tPC4tDogW1BBVENIXSBkcGlmLW5ldGRldjpEZWxldGUg?= =?gb2312?b?cG9ydCBjaGVjayBpbiBkb19hZGRfcG9ydA==?= X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org Ping... -----邮件原件----- 发件人: Linhaifeng 发送时间: 2018年4月26日 15:13 收件人: dev@openvswitch.org 抄送: Linhaifeng 主题: [PATCH] dpif-netdev:Delete port check in do_add_port It is not need check port exist in do_add_port because it had check in port_add. Change-Id: Ie66206b40e305cef5f5b20af765c3128ccec6782 Signed-off-by: Haifeng Lin --- lib/dpif-netdev.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index be31fd0..f7976b1 100644 --- a/lib/dpif-netdev.c +++ b/lib/dpif-netdev.c @@ -1568,11 +1568,6 @@ do_add_port(struct dp_netdev *dp, const char *devname, const char *type, struct dp_netdev_port *port; int error; - /* Reject devices already in 'dp'. */ - if (!get_port_by_name(dp, devname, &port)) { - return EEXIST; - } - error = port_create(devname, type, port_no, &port); if (error) { return error;