From patchwork Thu Apr 26 19:08:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnout Vandecappelle X-Patchwork-Id: 905326 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=mind.be Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=mind-be.20150623.gappssmtp.com header.i=@mind-be.20150623.gappssmtp.com header.b="w//8Te+9"; dkim-atps=neutral Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40X66z37PLz9s08 for ; Fri, 27 Apr 2018 05:08:58 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id B649188931; Thu, 26 Apr 2018 19:08:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MFNTRSrkidaS; Thu, 26 Apr 2018 19:08:53 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 1D321886E4; Thu, 26 Apr 2018 19:08:53 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id EE8B41C3EC6 for ; Thu, 26 Apr 2018 19:08:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id EB5B08A7E7 for ; Thu, 26 Apr 2018 19:08:51 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id j1eCLhrPh9Ds for ; Thu, 26 Apr 2018 19:08:50 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by hemlock.osuosl.org (Postfix) with ESMTPS id D8B1E8A7E3 for ; Thu, 26 Apr 2018 19:08:49 +0000 (UTC) Received: by mail-wm0-f66.google.com with SMTP id t11so7900609wmt.0 for ; Thu, 26 Apr 2018 12:08:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mind-be.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=RIKGlq4RtLwb70IMgstWUNoWDUZHlDL98glrSgzLDlw=; b=w//8Te+9Qj2yAVz3M5DhgeQloic+jinlrFFhG9EolwIVDgO0WCxvsBgpv0gfZONzR0 3Cz5JYjKOQxFSIYEHaKksVG9AdO79wYbEvI4Em6fjztQVae84u5IBnB4aikG4kCzcoL4 WYvDhdnWLa4gWb0pF8tmGaeLylNSejOSdG7Gl/7gNVpz7CxYCgI6CQD5nsro7xKu48/T Za7REcjuDoUzuFMuTJ8qk2A5zvFWrrRCQg98cGndoA5QfIlvAM9yV8q24t+gY91KaAwg PPp9dp289KJe5r9TlFuQtmowJ9UQC3DL/v9mg0cXQhkTP+kRzItOCHFiNXQTFqW/y3UW AxqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=RIKGlq4RtLwb70IMgstWUNoWDUZHlDL98glrSgzLDlw=; b=fuounUwBWeIwskFvs0QBIgrPvhbtpeB54mGv798/OMYz58HzfzW9oCFC/fLc+dj2iF 0MMduAF0l1Nb+ILVICzUigxcYVdGc6RfH/XOzIYwb3IpQr1SSrmy26kAmtEXtatusTq2 LSnkpoGfZQ/nFaqbNmYw1SB6DMpMKKTqC34OGWC8IzBLdJxG+1WL6VZ8qFyeln5GAMY6 Pp87XW0JnDvrdcULAtr0kQoCAJ5SV3koS/5GAjUACekyyfbR9p5fssSEDrs/l0YCDT8v 1BxRCTTre9G4dWKgXTrlt7MDg8/gTHVjbsjXNhLMQVHN5ySPTANplG+YT55Cgb8fjNAY TsRw== X-Gm-Message-State: ALQs6tAmAxFka8Nf4a2dGV6bliBeqL3XxQe2GfuTc4W34D4vLx+QtP7O zkB4mVbY9YrpIsQb2dX5ZxzEs1LKpEQ= X-Google-Smtp-Source: AIpwx4/+1S+mPFU7EEMjeTQUXAw1BGYx60hJ9x9FevZ1pjpe8XWJM66KMNT1xap4Ig84JteaJFDv7Q== X-Received: by 10.80.191.10 with SMTP id f10mr44564752edk.205.1524769727730; Thu, 26 Apr 2018 12:08:47 -0700 (PDT) Received: from localhost.localdomain (d51A4E7A0.access.telenet.be. [81.164.231.160]) by smtp.gmail.com with ESMTPSA id s14sm1227686eds.10.2018.04.26.12.08.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Apr 2018 12:08:47 -0700 (PDT) From: "Arnout Vandecappelle (Essensium/Mind)" To: buildroot@buildroot.org Date: Thu, 26 Apr 2018 21:08:45 +0200 Message-Id: <20180426190845.21415-1-arnout@mind.be> X-Mailer: git-send-email 2.17.0 In-Reply-To: References: Subject: [Buildroot] [PATCH] package/ncurses: enable widechar for host build X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.24 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David De Grave MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Kconfig uses pkg-config to find the ncurses or ncursesw library. If the ncursesw package is found with pkg-config, it will #include . Since Buildroot's host-ncurses doesn't install a .pc file, and linux.mk anyway doesn't pass the pkg-config options to find the host pkg-config files, Kconfig will always find the system's ncursesw.h. However, since commit dde090c299 (linux: fix passing of host CFLAGS and LDFLAGS) HOST_LDFLAGS is passed to the linux build system. Thus, if host-ncurses was already built before 'make linux-menuconfig' is called, the build will pick up libncurses from the host directory, which is NOT widechar. Thus, two different ncurses configurations are mixed into the final mconf program. This will result in serious breakage in the rendering of the menus (lots of @ and question mark characters). As a workaround, just build host-ncurses with widechar support. That makes it compatible with ncursesw.h picked up from the host. Clearly, this is not a robust solution. But it's simple, it works, and it shouldn't hurt to build host-ncurses with widechar support (we can safely assume that the system doesn't have a non-widechare uClibc library...). Signed-off-by: Arnout Vandecappelle (Essensium/Mind) Cc: David De Grave Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
--- package/ncurses/ncurses.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/package/ncurses/ncurses.mk b/package/ncurses/ncurses.mk index 90cf4a4dc5..9942d3f0bd 100644 --- a/package/ncurses/ncurses.mk +++ b/package/ncurses/ncurses.mk @@ -153,6 +153,7 @@ HOST_NCURSES_CONF_OPTS = \ --without-cxx \ --without-cxx-binding \ --without-ada \ + --enable-widec \ --without-normal $(eval $(autotools-package))