From patchwork Sun May 12 19:58:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harald Anlauf X-Patchwork-Id: 1934327 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=gmx.de header.i=anlauf@gmx.de header.a=rsa-sha256 header.s=s31663417 header.b=ZgXVg/Xv; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VctjV592gz1yfq for ; Mon, 13 May 2024 05:58:52 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7BBE2385841D for ; Sun, 12 May 2024 19:58:48 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by sourceware.org (Postfix) with ESMTPS id DE6C23858D3C; Sun, 12 May 2024 19:58:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DE6C23858D3C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DE6C23858D3C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=212.227.17.22 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715543904; cv=none; b=vU4KUcEgNgSuNXavY+DXKaFkQqF7fyQq8/tLu+JLxdQH3xJMQkPBu9FYYyLMBPVAuVSvBO2kW/bJZQBlJpb9SfUXr4RwZImxhKa4dmkyxB2JimMewe7PnolfvHSRRPLSc4j0V3jjHhwZsQH4DxGA3ddp7ESH7pd/86vl3x+kgss= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715543904; c=relaxed/simple; bh=Ys6XWQ6bFM0yN7EX76V/1aUotsKtgXyIUwdOnrXeX4E=; h=DKIM-Signature:MIME-Version:Message-ID:From:To:Subject:Date; b=VXciJHbl7spQP3+hXvxcxyEQrfjm7ab7CNvRnhQjNhCcAxaMZbbBqblnH29yJ+NLH16BqaHO2m5jUSILa687IslN8X+OQN5C2M+4BhCJ2YJfVfI5ks/wqWmIq+3xYiodlX3fXQpL0RaTbn7Sow4vD4AuWXeYAVTX4yiTXeq7skA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1715543901; x=1716148701; i=anlauf@gmx.de; bh=GFqBAU0QtE256rPKQ0KUB6C1Oy0bIXquD5moqFW1NNc=; h=X-UI-Sender-Class:MIME-Version:Message-ID:From:To:Subject: Content-Type:Date:cc:content-transfer-encoding:content-type:date: from:message-id:mime-version:reply-to:subject:to; b=ZgXVg/XvT1kHMnn8M1hNlgLPH9WIiAioUZSBsyC2muc/D7syCDCMuGh/0Y6OyVFm FHmQEnzHgaDJ1rYAYH5fZTZ8Zhz6EGW5JlEMgiY/R3Qs4ooMZTpZVTfkj0kk4oG6K pWd1YVbtVtImwFxNYkmSeKPwYMjYDSQbkPsWm0dtGUfMXKhh5xpRSyEl6oDpASvJy Qfua5eaqiVmXzd5QeneF1KjAkHpJQkB0nw0wtjE0Qq8iXaLW84SZiDQeTSjsDmmJF hVK3NNEiucKQxMzuAyX82o83fJdzT+/RV/HYeJQ65nfNlfb7cA1QRKLDFLohzrB4E KdDtWSwUBJO0doEkoQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [93.207.82.27] ([93.207.82.27]) by web-mail.gmx.net (3c-app-gmx-bap07.server.lan [172.19.172.77]) (via HTTP); Sun, 12 May 2024 21:58:21 +0200 MIME-Version: 1.0 Message-ID: From: Harald Anlauf To: fortran , gcc-patches Subject: [PATCH, committed] Fortran: fix frontend memleak Date: Sun, 12 May 2024 21:58:21 +0200 Importance: normal Sensitivity: Normal X-Priority: 3 X-Provags-ID: V03:K1:YNhCrP2nuzXLueNDNc5ULP5oUdakYpIiv5ts+Kp9Fr8i3L2WgEQ8TmUx3Md+fQnvuucN3 2qzAlKtGavWlWHD635tLy+39ocRy1kporpKNh2wtjr6uIbN9F4SOqxGgrjKNgC/ckk5qNOUbK2SU 4jhJv2y5OQ+IQRtZyJ+QRVsWu8tClEfGa6QHsHPAFh5Nalw8pgr6u3Qswm9GUUZqwrPRsF/RvbEY O2inDSk/tnfCa/niDY5xLISTqnTfoTqy0nEeEaX7RfyELFyW3RfqTetpKt3XIr2fV6qQia/7SsrL 0k= UI-OutboundReport: notjunk:1;M01:P0:fzf0dm5DdDA=;54mV3FBFq33lQoGMcTfbkBj7eMa 9SzgsvfRUNjgr5SMkEfJxqZslWHPJUItqtYABinV/4QhwDLi/PY+58QVMrbhqtjt7w81/pBdh baG8goPxiuRgKMQdHCa2QY7aMl93eGfiEXCMG3K91/a6SvY//GfrE6I3rAhI/QiAS6u5IP600 dw0rpOUbZhZIRH0vzM0fUI+VjZ+I50L3ivSEvvEw5hKMaC06FKG6+uxF0D4y6UFYwaRholTyc mONAu15AmfmXwh8ajPHbEnpjZOlsHA1ELi0Mf6eKS32/vcLVfJHBhxLWjgwlky8ph6t8/F6ta QJv2V3tuCPYW0uncqNulhIvWVyLg2h4HzM8f8OUvov17solwr0Aw3eKlGp/xSvYWPZnHHPJym lvTkg9gGtMjcC799kIdmoQpvrbES0J0raFfY3Hfzc9BDdbMmFw7JETpFQzHiFn5yhqv1ppMTD 0E6+MZ7AuIgnMSiybXZH4Nf0Od8OWntYLNR8Ac1pdAzKyqStzynyhGxf7sWDZUymQkpSUqUZk KpW8wZ0ETs7YMOC9wSxx6h8uaxx1gZszJGBKG359rsWj9RhTDr0UlPokQQBqBnoqe1KE+CBDM IUYjcJf38XIq62X1z4l2w/ktrEZGuU/eWo0rxYLmnrbEKw+nHUP0OY/W83S+eH52DtnhJ00Ay 9dtL8f/F9IeXDKp1CMNLw3ebi2i1aSUe7PurAWTuMdjh+wv+H/vScyxLtD8j370= X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Dear all, the attached obvious patch fixes a frontend memleak that was introduced recently, and which shows up when checking for inquiry references. I came across it when working on pr115039. Committed after regtesting as r15-391-g13b6ac4ebd04f0. Thanks, Harald From 13b6ac4ebd04f0703d92828c9268b0b216890b0d Mon Sep 17 00:00:00 2001 From: Harald Anlauf Date: Sun, 12 May 2024 21:48:03 +0200 Subject: [PATCH] Fortran: fix frontend memleak gcc/fortran/ChangeLog: * primary.cc (gfc_match_varspec): Replace 'ref' argument to is_inquiry_ref() by NULL when the result is not needed to avoid a memleak. --- gcc/fortran/primary.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/fortran/primary.cc b/gcc/fortran/primary.cc index 606e84432be..8e7833769a8 100644 --- a/gcc/fortran/primary.cc +++ b/gcc/fortran/primary.cc @@ -2250,7 +2250,7 @@ gfc_match_varspec (gfc_expr *primary, int equiv_flag, bool sub_flag, can be found. If this was an inquiry reference with the same name as a derived component and the associate-name type is not derived or class, this is fixed up in 'gfc_fixup_inferred_type_refs'. */ - if (mm == MATCH_YES && is_inquiry_ref (name, &tmp) + if (mm == MATCH_YES && is_inquiry_ref (name, NULL) && !(sym->ts.type == BT_UNKNOWN && gfc_find_derived_types (sym, gfc_current_ns, name))) inquiry = true; -- 2.35.3