From patchwork Sat May 11 09:24:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aldy Hernandez X-Patchwork-Id: 1934090 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=IScJCy+4; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Vc0q16TSyz20fc for ; Sat, 11 May 2024 19:30:37 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0AFD13858C98 for ; Sat, 11 May 2024 09:30:36 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-44.mimecast.com (us-smtp-delivery-44.mimecast.com [205.139.111.44]) by sourceware.org (Postfix) with ESMTPS id 88F503858D38 for ; Sat, 11 May 2024 09:30:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 88F503858D38 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=localhost.redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 88F503858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=205.139.111.44 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715419816; cv=none; b=pD2HewVZB4EX7EdonrX7DzVIYq/AX4jT3TNKYe7s2Db28EOgc22IO1Hv6wh2FR0XgKcwt6yU7Lj7Jd2+vpjfnKMai9ddqA8OmrxVBXN8J+MtkFWiuZlEgbNYq65QRpk/gmJPsMYE+y/oirwdfORHWw4rYoH6M1TMrR734P6xuP0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715419816; c=relaxed/simple; bh=ruHryVM9bqstyITkht8jaO55RdhZnLjc7O0/Sq5Ke/A=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Nxq9StmmvD+dr6eRJ5rQItWB7AFV39qXR2h0xFLG/YDekh/q0PMGOLIdkSqm+4Do1OXdfHC5/gcpRzI+heNfcTLKTG4IEGrcEtK48Cthhw31jPF6mNYn6YCC5HlCwdVOSWhJokaiMfDTcqWNClKLcCyTCfhIJr38ooiW6lQTbno= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715419815; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2aFBl1aRxOSHgoB589ym+dUc+vmgb+NNv0eorx/9vY0=; b=IScJCy+4gQrtbmlnlr0VulqkGtZKbEJVdLN4I+yuORaRuijeaA7j8aXNR2t5Dl5ElIqEM8 nh2IBogXAT3WtvLCP8ZcZANCwh9vbjp/UCyldUElmRGYW880BPH+sL7WwyI3GWDLUONJHD E0NExY/g1iq8T09CZ2munt2iLV/7nwg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-558-StDi-DN-OR6M-eVKcKLCLA-1; Sat, 11 May 2024 05:25:08 -0400 X-MC-Unique: StDi-DN-OR6M-eVKcKLCLA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8158E812296 for ; Sat, 11 May 2024 09:25:08 +0000 (UTC) Received: from abulafia.quesejoda.com (unknown [10.39.192.9]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2C0C3219EEE; Sat, 11 May 2024 09:25:08 +0000 (UTC) Received: from abulafia.quesejoda.com (localhost [127.0.0.1]) by abulafia.quesejoda.com (8.18.1/8.17.1) with ESMTPS id 44B9P6BJ668123 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Sat, 11 May 2024 11:25:06 +0200 Received: (from aldyh@localhost) by abulafia.quesejoda.com (8.18.1/8.18.1/Submit) id 44B9P68c668122; Sat, 11 May 2024 11:25:06 +0200 From: Aldy Hernandez To: GCC patches Cc: Andrew MacLeod , Aldy Hernandez Subject: [COMMITTED] [prange] Default unimplemented prange operators to false. Date: Sat, 11 May 2024 11:24:58 +0200 Message-ID: <20240511092502.668080-2-aldyh@redhat.com> In-Reply-To: <20240511092502.668080-1-aldyh@redhat.com> References: <20240511092502.668080-1-aldyh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NO_DNS_FOR_FROM, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org The canonical way to indicate that a range operator is unsupported is to return false, which has the sematic meaning of VARYING. This patch cleans up a few default virtuals that were trying harder to set VARYING manually. gcc/ChangeLog: * range-op-ptr.cc (range_operator::fold_range): Return false. --- gcc/range-op-ptr.cc | 55 +++++++++++++-------------------------------- 1 file changed, 15 insertions(+), 40 deletions(-) diff --git a/gcc/range-op-ptr.cc b/gcc/range-op-ptr.cc index 466edc6bf74..65cca65103a 100644 --- a/gcc/range-op-ptr.cc +++ b/gcc/range-op-ptr.cc @@ -62,63 +62,38 @@ range_operator::pointers_handled_p (range_op_dispatch_type ATTRIBUTE_UNUSED, } bool -range_operator::fold_range (prange &r, tree type, - const prange &op1, - const prange &op2, - relation_trio trio) const +range_operator::fold_range (prange &, tree, const prange &, const prange &, + relation_trio) const { - relation_kind rel = trio.op1_op2 (); - r.set_varying (type); - op1_op2_relation_effect (r, type, op1, op2, rel); - return true; + return false; } bool -range_operator::fold_range (prange &r, tree type, - const prange &op1, - const irange &op2, - relation_trio trio) const +range_operator::fold_range (prange &, tree, const prange &, const irange &, + relation_trio) const { - relation_kind rel = trio.op1_op2 (); - r.set_varying (type); - op1_op2_relation_effect (r, type, op1, op2, rel); - return true; + return false; } bool -range_operator::fold_range (irange &r, tree type, - const prange &op1, - const prange &op2, - relation_trio trio) const +range_operator::fold_range (irange &, tree, const prange &, const prange &, + relation_trio) const { - relation_kind rel = trio.op1_op2 (); - r.set_varying (type); - op1_op2_relation_effect (r, type, op1, op2, rel); - return true; + return false; } bool -range_operator::fold_range (prange &r, tree type, - const irange &op1, - const prange &op2, - relation_trio trio) const +range_operator::fold_range (prange &, tree, const irange &, const prange &, + relation_trio) const { - relation_kind rel = trio.op1_op2 (); - r.set_varying (type); - op1_op2_relation_effect (r, type, op1, op2, rel); - return true; + return false; } bool -range_operator::fold_range (irange &r, tree type, - const prange &op1, - const irange &op2, - relation_trio trio) const +range_operator::fold_range (irange &, tree, const prange &, const irange &, + relation_trio) const { - relation_kind rel = trio.op1_op2 (); - r.set_varying (type); - op1_op2_relation_effect (r, type, op1, op2, rel); - return true; + return false; } bool