From patchwork Mon May 6 09:18:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Marc_Poulhi=C3=A8s?= X-Patchwork-Id: 1931866 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=g6AlbYia; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VXwwS2Ft2z1xnT for ; Mon, 6 May 2024 19:24:40 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 78C23384AB6E for ; Mon, 6 May 2024 09:24:38 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by sourceware.org (Postfix) with ESMTPS id A047C385E82D for ; Mon, 6 May 2024 09:18:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A047C385E82D Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A047C385E82D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::331 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714987114; cv=none; b=QBeXdlPkudmtbzdElHqdtiziZs2rteLJr5dHwtOMQlduoGTYczouK0UucKv++rXB6MKESmrQNt6WC6epUOZ6XqpFcdk0niNk0jzWwz3jTCuYMFfI0mw47C/wuVIoCfovour4YRP949E8YfW5dPmAI1eSELn2YhgDK/Iif0KY5KY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714987114; c=relaxed/simple; bh=nwTyEQoM2+F68iX2+DN92u7lpxY/ktOSYLht0kasmHg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Kq89NGjHQDmWU6bQhZ70E3ngwocaq+4s4sNa+KNlnda1fy6oxxsY3EJ8oRt15zcq+3nKF12MDWpmicOW28rdRxLWv9Lc/nXHr0bavANeSYfAgpL15IRTuLYUYP0lXSvzYRn92XIYuqU6ECsMCfSeDLwOBzUmxHnr0KhmsP2y1hM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-41bca450fa3so10090585e9.2 for ; Mon, 06 May 2024 02:18:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1714987107; x=1715591907; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=2mO2vCaaHtS52lj2EW5FWwp75JfA9BYgwqNNRy9zfJU=; b=g6AlbYiajTaFfl/lkVZ5q4sZcNW3X32X7CtNk75iyIi8xYJXHvbdfMLxA11Y4y3XPz uDrTqGOYmiCtEpcIcIkXfstlcFTmx8qLk7XViHT0CSvTA+vdBKnckfVlnliyCjRJiPIY 5PuPNbhJ8PHCjNnFozWfOD3MZm3Hh2bisPLUhDwOB9nDJEZkqBWxxjqAVhOGQ/ZzVREN seEm/3abal2OHX4javBQd31L778UgXkwdY24ZC/VqXrvpXiDvcRqz8u9BonZKg+r5S+l SIrocVlmvbvk/fzwAx3myD+2VX7oBd2QZmF06ej8jIOMbQz04GJhgANi6sp77XWuQIme Anwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714987107; x=1715591907; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2mO2vCaaHtS52lj2EW5FWwp75JfA9BYgwqNNRy9zfJU=; b=Zzv1IeJxWtOqfbkeoSJRMzpTtk+4lXVd3Sn/m84EyRvf7tciXaW578BLTQrAGYNpA/ nW1h9C4r1QyEyADSytD/dUgSnFhoW4pyN61jqMTTjC/7QKH0WBXDi2jKZIQuGoflxf7u 4WBqyY5++tDpeNgmRjq4yGQFdTEvaiU4WxkBa+UAHAf2kb1TDoJ6JaoUAbva/kQrG5fF XKCa2oSSiRxApNN0o78yPLnu0qUAMIZ+s4Zplfvsvcun+3Aazco9JZ/42hIvKt9cql6x E2Xje+Sf5u7+Fh55wHcGSo0ur1nd9bBYATVqOVPIhkR6OKfJKvENSkTCaEWZSpL/Ap36 Ee5A== X-Gm-Message-State: AOJu0YzY1obiF0WozAePu2CMmpk5sg+59N9OD/7kqW7DzUF+Nsw7H+3u nqW8oy59ulK12aNXLl+oR2HPVBtoUe1qoeV3NQusi8Kno4f/KQFIRNXNfj8MIr1DT8okug5sqWk = X-Google-Smtp-Source: AGHT+IEVph8ryZbZQjwMQ9qCg/8jaSlMR7mgP2rRq7C61tpxC1drD0qz7Q2tgX6sAkcTtr2RUpBP0g== X-Received: by 2002:a5d:544e:0:b0:34e:b69:1ae4 with SMTP id w14-20020a5d544e000000b0034e0b691ae4mr6155633wrv.12.1714987107436; Mon, 06 May 2024 02:18:27 -0700 (PDT) Received: from localhost.localdomain ([2001:861:3382:1a90:9ea2:39d7:df74:396d]) by smtp.gmail.com with ESMTPSA id f6-20020a5d4dc6000000b0034ea98a5660sm5896708wru.54.2024.05.06.02.18.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 May 2024 02:18:26 -0700 (PDT) From: =?utf-8?q?Marc_Poulhi=C3=A8s?= To: gcc-patches@gcc.gnu.org Cc: Justin Squirek Subject: [COMMITTED] ada: Spurious reference warning on qualified expression Date: Mon, 6 May 2024 11:18:25 +0200 Message-ID: <20240506091825.1585922-1-poulhies@adacore.com> X-Mailer: git-send-email 2.43.2 MIME-Version: 1.0 X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org From: Justin Squirek This patch fixes an error in the compiler whereby an assignment to an out formal (whose type requires a predicate check) can lead to spurious "value may be referenced before it has a value" warnings when the RHS is a qualified expression. gcc/ada/ * sem_warn.adb (Within_Postcondition): Add case to ignore references within generated predicate function calls. Tested on x86_64-pc-linux-gnu, committed on master. --- gcc/ada/sem_warn.adb | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/gcc/ada/sem_warn.adb b/gcc/ada/sem_warn.adb index eaf9a257ba0..0a54b3eda50 100644 --- a/gcc/ada/sem_warn.adb +++ b/gcc/ada/sem_warn.adb @@ -1982,6 +1982,16 @@ package body Sem_Warn is then return True; + -- Verify we are not within a generated predicate + -- function call. + + elsif Nkind (Nod) = N_Function_Call + and then Is_Entity_Name (Name (Nod)) + and then Is_Predicate_Function + (Entity (Name (Nod))) + then + return True; + elsif Present (Parent (Nod)) then P := Parent (Nod);