From patchwork Fri May 3 14:51:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Vinayak Kale X-Patchwork-Id: 1931065 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=S1EYUgso; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=patchwork.ozlabs.org) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VWDSl4wzXz1ybC for ; Sat, 4 May 2024 00:58:15 +1000 (AEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s2uME-0004Op-UY; Fri, 03 May 2024 10:57:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2uMD-0004OZ-9J for qemu-devel@nongnu.org; Fri, 03 May 2024 10:57:53 -0400 Received: from mail-bn8nam04on2074.outbound.protection.outlook.com ([40.107.100.74] helo=NAM04-BN8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2uM2-0003os-7e for qemu-devel@nongnu.org; Fri, 03 May 2024 10:57:53 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YLU9o8mJ2gAtdTKd7AL10B1Eq51rZmsVHc3Xrr4hf15AwdzJ6qcFXDSu/e9UwFPa99JG2lYaElm8a/9QBqIbDS8x2qhlRB8I8FjMJtVoCWts9PFcGNh1N9v28E+WOHcihXj2cFgX8DFCEr9yhqubdNBUxvd63HmCSP2/Ak4dnnq5Ez09PoNVFAFxEm532ZwSOdmWvHftHl3MoSVcJGp7+6dxH1uCeLvr4ltexHmxeCsfYwo2br8pjxV8j8ayb9Xe4mMdSVYMn2LrPOONKn7K0rJphGdknO5w0qN+wcOrOSP+JDC1NwXBFYpvVvk2+vtoHFUkG7unCyVlMvUeZ2TRow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aLJYcyAAeFEG64XhQP6rm7KTbxNIi98O91QY5f93ktI=; b=RFaTyzrtttbl3GmA0zCqCL3+piztgeL+AKUXk2+CBt/9nDO8FnrBpkad2U9MRXusjM+jLzLB+6x4VEjwtVxTxjw+chUTZ23tby5e0wk+uDaR9rHrkFYsNuatg1EAx7fpPSBJtKmos9sVSRMZEELtIEI2BrcZOd4b7Mch+j7KoQLBlMWiEFDVUYrHb08hUgbUt5GI29yQRnn0Ack/+sAL2S3IMONZWsSZ4lIttXt3BKGafl/GWWAC9zZwT1pa4MSiLtlPJ5BZIUzK1Wj41TXJSEgHRVzhnhb3dRMjk8rBbiAxuYoVIqQbSGZHfz0DPcn4rAG+vkd1vk29Yno8XCLJBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=nongnu.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aLJYcyAAeFEG64XhQP6rm7KTbxNIi98O91QY5f93ktI=; b=S1EYUgsoN+tAzmuGJkdvIEyBzYOGSTfMGMnrlT4qcDlo05VpltxTvRHZovK9D6OF2G5wU4AHLhXQ1JmsvphSd4xgywG6kaHbrAcuIgwcvZr9HwXlrjl1nyb1sgtVNh5jiuN6oCGJbRwLfMUzVNvURcnBKk9lJ5K4pyuUa/L8faU2sIXt7/Qg/ilXRacXXgHPiOM6PMc1Dw41LSb/Hp+t10Y8NfEUjLhIcWc2jazGxq99fkGHzqTAXuMI/ChDnZyCkueKsp70VQk+2Oux4PnkCB3P88jpj3Vl137Vbcpeajrn0i3PQd6fRKQdHq1ujM83PTQJfe4CKzKq4w2S179b/g== Received: from SA1P222CA0001.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:22c::34) by SJ0PR12MB7081.namprd12.prod.outlook.com (2603:10b6:a03:4ae::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.32; Fri, 3 May 2024 14:52:31 +0000 Received: from SA2PEPF0000150A.namprd04.prod.outlook.com (2603:10b6:806:22c:cafe::21) by SA1P222CA0001.outlook.office365.com (2603:10b6:806:22c::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.34 via Frontend Transport; Fri, 3 May 2024 14:52:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by SA2PEPF0000150A.mail.protection.outlook.com (10.167.242.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.18 via Frontend Transport; Fri, 3 May 2024 14:52:30 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 3 May 2024 07:52:13 -0700 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 3 May 2024 07:52:13 -0700 Received: from vkale-dev-linux.nvidia.com (10.127.8.10) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Fri, 3 May 2024 07:52:10 -0700 From: Vinayak Kale To: CC: , , , , , , , , , , Vinayak Kale Subject: [PATCH v4] vfio/pci: migration: Skip config space check for Vendor Specific Information in VSC during restore/load Date: Fri, 3 May 2024 20:21:42 +0530 Message-ID: <20240503145142.2806030-1-vkale@nvidia.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-NVConfidentiality: public X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF0000150A:EE_|SJ0PR12MB7081:EE_ X-MS-Office365-Filtering-Correlation-Id: f8fd8696-31e0-4133-9587-08dc6b80a8ae X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|376005|1800799015|36860700004; X-Microsoft-Antispam-Message-Info: =?utf-8?q?G6sjl9IwVYnUJnSlojeeZ5DWDvjtpNU?= =?utf-8?q?3ajmu+2wR9k5P3d8XOsjCp2zK4fRppOlgVthxwS+8sTI5HiVSoLJbe1hfiQNcBFhy?= =?utf-8?q?ZB3VUKAzgJzE/TMIT1JKlwXMm71UmcKm8a6P7EppJ+D0lcBv8rZ2O2Bo/KIcI5gLp?= =?utf-8?q?5dBbv1JfuTGDzFCAzpHu7ejCeVSOg5weSqBCUgNvZBlZ2iqF7nCr4jGXsvQ9y0aw2?= =?utf-8?q?oDTFNkbo5pCe5ozrauYqSSYFVBc0ih4Ak4bj+7BbK5CWvJZWwyo76WdGO85fScwtX?= =?utf-8?q?ZElFnB8eFg13Z/MYqDKQNfITTlP3KZOswyLZ/vkr2adQ0VTX5LNx2YaE+qUhked1B?= =?utf-8?q?6uq//vbYFGoIrzf7Zvq2+Rkqj6bZO/GcH/6wZSJ3WqRBQuEkpAqLloUwZ6IqRTLk3?= =?utf-8?q?fBdYyIsxohAk8YSPMXyhoLZpWfsj6U9EqQRdoj0MDROk1kknTZzBxqzNT3H05SGte?= =?utf-8?q?Lnw2xDY5YN3TGGpzdsJErRfr9SRsrSvqKVdIo65HvwY4YkSH6OAorDaRE6km6AmbZ?= =?utf-8?q?1gJBcjm4rxud9lmy0uO9pwz8W5qQWI6NTNkj0OZyAF0PSHuSvNqab9x05j1Rqh8kM?= =?utf-8?q?xVmAYrdZnz5Jv8afcItEI9gq6aRIPKz5NjXdVF0x4EUDx/zWZaD4TMnYe1gY6uRmq?= =?utf-8?q?vIwp/AxCFbsUWlIZ9P+b+I6I8kQ6L0bl4RyGh95NQNt9rQI2SWAmI7HqT+hrq84hV?= =?utf-8?q?+S+d61nczSSDyIg85i7Yyh+9d2iDlx2lm9pCWba/OSO3R+ZxyzSFLkt08Du0NrlmY?= =?utf-8?q?VlLlXtnlFTLWRBYMUk+NQ4U4fvfghbdhAUwX8d08gWgySRaGulXs/4H643+AXb7tR?= =?utf-8?q?Fio4A8BHLJyTfeeoVcN8cPPe7J8oniaOGyJD7WgFf4rFCtRKWR+wLbzOeLfFghCt/?= =?utf-8?q?byR64zYw/asd95XwKzjLFyXiV7fWcxkUxS+abBDwCo0WqhFMyUGQcXviSuv6ojRKO?= =?utf-8?q?OeCRjck3UEKXuFYdmIANS4CMDjM7wvRh2VB8dxn87IbgQrOXMXLyjVhgVvFr1JL8d?= =?utf-8?q?TQG3uFGYL0YTKuYD2ObfbFF4tCdP++rOF5W/nuhjaKZOeLm2g8T/t+d6W1St5H52l?= =?utf-8?q?tuARwsWWMw7g3q9BVt58Jtf/qRaPbZKcilcsVEuNYLiF3SKvU3kvyPT1D4CSvJ8Bl?= =?utf-8?q?ryLV9y/Gb2TqSdb6MQcHHAN/9pVKQM5BH3OvVUk7TTIQUwEYN9xXIwRqxaJb1TQIu?= =?utf-8?q?Sd6kWNAGuBKnmsUelIuprJiyBWVHgmrqKTy2EtMdibEL4KKpoJUZi6KXUe6vl8sYO?= =?utf-8?q?aisaONWQarW95UjShxAZxnO+5/wUCX4dEy7NuaGeNeBRPv44WDW8Hl1m+xbgpBEY9?= =?utf-8?q?D0X2offmyx3O?= X-Forefront-Antispam-Report: CIP:216.228.118.232; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge1.nvidia.com; CAT:NONE; SFS:(13230031)(376005)(1800799015)(36860700004); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2024 14:52:30.8361 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f8fd8696-31e0-4133-9587-08dc6b80a8ae X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.232]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF0000150A.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB7081 Received-SPF: softfail client-ip=40.107.100.74; envelope-from=vkale@nvidia.com; helo=NAM04-BN8-obe.outbound.protection.outlook.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.483, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org In case of migration, during restore operation, qemu checks config space of the pci device with the config space in the migration stream captured during save operation. In case of config space data mismatch, restore operation is failed. config space check is done in function get_pci_config_device(). By default VSC (vendor-specific-capability) in config space is checked. Due to qemu's config space check for VSC, live migration is broken across NVIDIA vGPU devices in situation where source and destination host driver is different. In this situation, Vendor Specific Information in VSC varies on the destination to ensure vGPU feature capabilities exposed to the guest driver are compatible with destination host. If a vfio-pci device is migration capable and vfio-pci vendor driver is OK with volatile Vendor Specific Info in VSC then qemu should exempt config space check for Vendor Specific Info. It is vendor driver's responsibility to ensure that VSC is consistent across migration. Here consistency could mean that VSC format should be same on source and destination, however actual Vendor Specific Info may not be byte-to-byte identical. This patch skips the check for Vendor Specific Information in VSC for VFIO-PCI device by clearing pdev->cmask[] offsets. Config space check is still enforced for 3 byte VSC header. If cmask[] is not set for an offset, then qemu skips config space check for that offset. VSC check is skipped for machine types >= 9.1. The check would be enforced on older machine types (<= 9.0). Signed-off-by: Vinayak Kale Cc: Alex Williamson Cc: Michael S. Tsirkin Cc: Cédric Le Goater Reviewed-by: Cédric Le Goater --- Version History v3->v4: - VSC check is skipped for machine types >= 9.1. The check would be enforced on older machine types (<= 9.0). v2->v3: - Config space check skipped only for Vendor Specific Info in VSC, check is still enforced for 3 byte VSC header. - Updated commit description with live migration failure scenario. v1->v2: - Limited scope of change to vfio-pci devices instead of all pci devices. hw/core/machine.c | 1 + hw/vfio/pci.c | 26 ++++++++++++++++++++++++++ hw/vfio/pci.h | 1 + 3 files changed, 28 insertions(+) diff --git a/hw/core/machine.c b/hw/core/machine.c index 4ff60911e7..fc3eb5115f 100644 --- a/hw/core/machine.c +++ b/hw/core/machine.c @@ -35,6 +35,7 @@ GlobalProperty hw_compat_9_0[] = { {"arm-cpu", "backcompat-cntfrq", "true" }, + {"vfio-pci", "skip-vsc-check", "false" }, }; const size_t hw_compat_9_0_len = G_N_ELEMENTS(hw_compat_9_0); diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index 64780d1b79..2ece9407cc 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -2134,6 +2134,28 @@ static void vfio_check_af_flr(VFIOPCIDevice *vdev, uint8_t pos) } } +static int vfio_add_vendor_specific_cap(VFIOPCIDevice *vdev, int pos, + uint8_t size, Error **errp) +{ + PCIDevice *pdev = &vdev->pdev; + + pos = pci_add_capability(pdev, PCI_CAP_ID_VNDR, pos, size, errp); + if (pos < 0) { + return pos; + } + + /* + * Exempt config space check for Vendor Specific Information during + * restore/load. + * Config space check is still enforced for 3 byte VSC header. + */ + if (vdev->skip_vsc_check && size > 3) { + memset(pdev->cmask + pos + 3, 0, size - 3); + } + + return pos; +} + static int vfio_add_std_cap(VFIOPCIDevice *vdev, uint8_t pos, Error **errp) { ERRP_GUARD(); @@ -2202,6 +2224,9 @@ static int vfio_add_std_cap(VFIOPCIDevice *vdev, uint8_t pos, Error **errp) vfio_check_af_flr(vdev, pos); ret = pci_add_capability(pdev, cap_id, pos, size, errp); break; + case PCI_CAP_ID_VNDR: + ret = vfio_add_vendor_specific_cap(vdev, pos, size, errp); + break; default: ret = pci_add_capability(pdev, cap_id, pos, size, errp); break; @@ -3390,6 +3415,7 @@ static Property vfio_pci_dev_properties[] = { DEFINE_PROP_LINK("iommufd", VFIOPCIDevice, vbasedev.iommufd, TYPE_IOMMUFD_BACKEND, IOMMUFDBackend *), #endif + DEFINE_PROP_BOOL("skip-vsc-check", VFIOPCIDevice, skip_vsc_check, true), DEFINE_PROP_END_OF_LIST(), }; diff --git a/hw/vfio/pci.h b/hw/vfio/pci.h index 6e64a2654e..92cd62d115 100644 --- a/hw/vfio/pci.h +++ b/hw/vfio/pci.h @@ -177,6 +177,7 @@ struct VFIOPCIDevice { OnOffAuto ramfb_migrate; bool defer_kvm_irq_routing; bool clear_parent_atomics_on_exit; + bool skip_vsc_check; VFIODisplay *dpy; Notifier irqchip_change_notifier; };