From patchwork Mon Apr 23 21:04:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cong Wang X-Patchwork-Id: 903167 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Ke3lK00v"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40VJrj379Cz9rxx for ; Tue, 24 Apr 2018 07:05:25 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932323AbeDWVFW (ORCPT ); Mon, 23 Apr 2018 17:05:22 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:33434 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932157AbeDWVFV (ORCPT ); Mon, 23 Apr 2018 17:05:21 -0400 Received: by mail-pg0-f67.google.com with SMTP id i194so9222569pgd.0; Mon, 23 Apr 2018 14:05:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=Tw1YFQj8mLL6HtY+dQI3kJu/f3dYbpY+NtGKAgAXxlI=; b=Ke3lK00vUEYOxALvfsgJh5TRjc/Fp3mJSityy3wS0WJIx4uCyudCLd8j/jVggBcOIz 8iDKhZkJGEtXV5ND7M0GGQg703j2Qf0ofUPSKWEjo62OkR08xcWfcCFWZdg5khA9++tu GuhYG+8UKS5VqklsJZDrwBNwJ6NKNXm/qs7mBcxiabDXdn1OSVxUcwaWRx5C8Vn8bKVM O5iDDE5b5qKbh/ZtigSEymi7aPW2e/n9nPESzf3xAY2tFr2ZFz/UJAPXxvGQ5H2N31r9 jvyToomsTb6Gf3eY9UlrBEo73/4ECnqvMGD0eN7gx/UrSgCdjoIXr/0gT9sbY/3bAYNn Xnlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Tw1YFQj8mLL6HtY+dQI3kJu/f3dYbpY+NtGKAgAXxlI=; b=aBLy72g1/HqlTrmOD+xtUnrbdXoVwnNDugeXoOLVqg5c8syBduXImsjHP7igZ3TOlr 91ZDv6U90dOlRVOn0enYUKGyz5Ooh+OkxMCeSOQhPgRCLiCpHMnoSpuqAxqZcBZ3SlVs 8sfwPbN5MtwEwTfUHxDzGhMgO4CGs7td0oNk202OPeX0G3PRsCeowves0/eWRkdBnGv1 wUsKt262wh/L5VWGagtrNW1VcGfrMT21VGLYj/zAAtrA/EBsZuyROXi9eW7I32hFQEca 6zMZhY+Exei4HMcpxeKGBgtvo79yJbne4eoElkJj6nZZE9AAa2geiizZoCJKQs+3xGbQ dQcg== X-Gm-Message-State: ALQs6tCsL9GSTVw/01WVO4tXRAA6wYMraLPmAv6iQ+/IjGNEZQwM0uZf JnolKGBvBXydUEjtw0psjwdcUsL7 X-Google-Smtp-Source: AIpwx4/qnIfEKkyv5ZA8jsqTnotS7EW7TSQhfOPzRVjVGz+10zjjNepssaBbR2GzH3lfXEH18ROvbg== X-Received: by 2002:a17:902:5992:: with SMTP id p18-v6mr22917194pli.49.1524517520393; Mon, 23 Apr 2018 14:05:20 -0700 (PDT) Received: from tw-172-25-29-37.office.twttr.net ([8.25.197.25]) by smtp.gmail.com with ESMTPSA id y129sm19497642pgb.64.2018.04.23.14.05.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Apr 2018 14:05:19 -0700 (PDT) From: Cong Wang To: netdev@vger.kernel.org Cc: lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org, Cong Wang , Simon Horman , Julian Anastasov , Pablo Neira Ayuso Subject: [Patch nf] ipvs: initialize tbl->entries in ip_vs_lblc_init_svc() Date: Mon, 23 Apr 2018 14:04:45 -0700 Message-Id: <20180423210445.18336-1-xiyou.wangcong@gmail.com> X-Mailer: git-send-email 2.9.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Similarly, tbl->entries is not initialized after kmalloc(), therefore causes an uninit-value warning in ip_vs_lblc_check_expire(), as reported by syzbot. Reported-by: Cc: Simon Horman Cc: Julian Anastasov Cc: Pablo Neira Ayuso Signed-off-by: Cong Wang Acked-by: Julian Anastasov Acked-by: Simon Horman --- net/netfilter/ipvs/ip_vs_lblc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/netfilter/ipvs/ip_vs_lblc.c b/net/netfilter/ipvs/ip_vs_lblc.c index 3057e453bf31..83918119ceb8 100644 --- a/net/netfilter/ipvs/ip_vs_lblc.c +++ b/net/netfilter/ipvs/ip_vs_lblc.c @@ -371,6 +371,7 @@ static int ip_vs_lblc_init_svc(struct ip_vs_service *svc) tbl->counter = 1; tbl->dead = false; tbl->svc = svc; + atomic_set(&tbl->entries, 0); /* * Hook periodic timer for garbage collection