From patchwork Mon Apr 29 14:28:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrick Palka X-Patchwork-Id: 1929038 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=c1fkqnx7; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VSm0c50zTz23ny for ; Tue, 30 Apr 2024 00:28:47 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CB1E93858427 for ; Mon, 29 Apr 2024 14:28:44 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 09F2F3858D35 for ; Mon, 29 Apr 2024 14:28:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 09F2F3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 09F2F3858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714400906; cv=none; b=n+WW8ZBW7OVJov5nYDmZk4nqI7gkYzLN16upJs1y7l0B1ryJBRcPjQLA8hB1IfW1LT26r+Y5JEcYUESe2J8EJ03SJN/qnRhiPQtHPPdng+uomSFzLMnEAtXG9otBaI8R3YMtwj1Op3IYMV51MNq6X4nfDceZ/6EOdvczJC9io88= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714400906; c=relaxed/simple; bh=IbahhLId/0O3ewnrf9IHS6vgLolHWFDMrULMDmCRYf4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=LvAL9XJr4MKFloFFNhr8PQV6ga9dUmz592v+UZBN4S25Jtfn28jqjVMx92j9Og7ysNjA4wqBn1WoL2uQ+hOCug7gcIYs5yfYvbzWXKcny2RK96E0zr2tRLC9L3zUXZGTmwqL1FdCOmqGubyayupxCzUy5aSQbNUH+5NZa2lr1ow= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714400904; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=F5AQ/iCgLPs7ssl6wfiah4gtjxxijmMJ9QEDC0Pzbbg=; b=c1fkqnx7mzyHG82ZdlKd9Pg78IKGoduq6oQKfmHjnLgqjjoyBpekGwOcXxU9/c0kt0xSCw zHfbyuqQLnMFUXe3kw1rHIDmwIGL4e2pb27YHVIA1ASJfC17Ayva0riYSkSxv4gCHQyAsO LkRdfboXe41fEjOSI1KgvL/kivGKOps= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-605-lisbtT1dOvGls8dcrXqaZA-1; Mon, 29 Apr 2024 10:28:23 -0400 X-MC-Unique: lisbtT1dOvGls8dcrXqaZA-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6a0d45ac0d4so10924406d6.1 for ; Mon, 29 Apr 2024 07:28:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714400902; x=1715005702; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=F5AQ/iCgLPs7ssl6wfiah4gtjxxijmMJ9QEDC0Pzbbg=; b=XsdPgzsHS1PiEKoSYwvoLTimaO0bH0ynxnOSOgPGmTI5ZQXNf1jZT2FominXfmjLd2 g/dQdK6U7RrTuumqyN5pvs+aKoGriYI0BM2o2G6LZd6yV1MOWxi1Smfpv3pLbSZr8L0t 2p/4SdXkDx/dxgz0gfbTlYyjFGxtPJRIJh9v430ocfV/pFtN67w8Ac3WDOgmMOO38+l2 G4aqmQXB61J0GG6i9sFmtUaseUH1E+aDVol0bmKvPN2MiILRkAEsh78MXQZM+TJsOnxr sV33mCtsr6+scNuJrnjB+tiZOfxJGU8ezzpk2Ak9VJdGfSLN5H7cj/Z/HjdPepmVxTDl aaBA== X-Gm-Message-State: AOJu0YxLOnZdshm2BvxREcf971Eu0NJVyWp19UzeT7z6ZtxwS6cMAo/1 Cmo/0fqSpTV1gIeDgnupErrP8yROfPueGwXFCfrt3SqR1mFhm32LfhJpnGkERha/6XIrBCGOXlW CeLQS3GS+9BGi49CJgPOdTaRMUEgdXEYEpHDpxzk9/XuRiE1LCUJ6cp2ecrASGJALr49oHfN6b6 H++fhowqkJZveSZLtVOdHY5B5OCwdsptxQKMJh X-Received: by 2002:a05:6214:3f8f:b0:6a0:8889:77ba with SMTP id ow15-20020a0562143f8f00b006a0888977bamr16388976qvb.6.1714400902740; Mon, 29 Apr 2024 07:28:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFEq/yiy6ZTyfb13qXfaclM0h0Ig4ablk0Vjskw73ab+d9wG/P97wkJtmOeJ/p4cenG7PWZKA== X-Received: by 2002:a05:6214:3f8f:b0:6a0:8889:77ba with SMTP id ow15-20020a0562143f8f00b006a0888977bamr16388948qvb.6.1714400902449; Mon, 29 Apr 2024 07:28:22 -0700 (PDT) Received: from localhost.localdomain (ool-457670bb.dyn.optonline.net. [69.118.112.187]) by smtp.gmail.com with ESMTPSA id ml1-20020a056214584100b0069b0c9a81b5sm2397747qvb.95.2024.04.29.07.28.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Apr 2024 07:28:21 -0700 (PDT) From: Patrick Palka To: gcc-patches@gcc.gnu.org Cc: jason@redhat.com, jakub@redhat.com, Patrick Palka Subject: [PATCH] c++: ICE with templated sizeof(E1) / sizeof(E2) [PR114888] Date: Mon, 29 Apr 2024 10:28:19 -0400 Message-ID: <20240429142819.3078305-1-ppalka@redhat.com> X-Mailer: git-send-email 2.45.0.rc1 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-13.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, RCVD_IN_SORBS_WEB, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Lightly tested on x86_64-pc-linux-gnu so far, does this look OK for trunk/14.1 after bootstrap+regtest finishes? -- >8 -- We're missing a dependence check for the second operand in the sizeof / sizeof handling. PR c++/114888 gcc/cp/ChangeLog: * typeck.cc (cp_build_binary_op) : Add missing dependence check for the second sizeof operand. gcc/testsuite/ChangeLog: * g++.dg/template/sizeof19.C: New test. --- gcc/cp/typeck.cc | 1 + gcc/testsuite/g++.dg/template/sizeof19.C | 8 ++++++++ 2 files changed, 9 insertions(+) create mode 100644 gcc/testsuite/g++.dg/template/sizeof19.C diff --git a/gcc/cp/typeck.cc b/gcc/cp/typeck.cc index e5a52dc2b39..a25f8622651 100644 --- a/gcc/cp/typeck.cc +++ b/gcc/cp/typeck.cc @@ -5501,6 +5501,7 @@ cp_build_binary_op (const op_location_t &location, if (!TYPE_P (type1)) type1 = TREE_TYPE (type1); if (type0 + && type1 && INDIRECT_TYPE_P (type0) && same_type_p (TREE_TYPE (type0), type1)) { diff --git a/gcc/testsuite/g++.dg/template/sizeof19.C b/gcc/testsuite/g++.dg/template/sizeof19.C new file mode 100644 index 00000000000..a1467995a9b --- /dev/null +++ b/gcc/testsuite/g++.dg/template/sizeof19.C @@ -0,0 +1,8 @@ +// PR c++/114888 + +template +struct A { + struct B {} *b; + static const int c = sizeof (b) / sizeof (b[0]); +}; +const int d = A::c;