From patchwork Wed Sep 20 07:13:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 816079 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="fo1JDVjA"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xxrbL6RbJz9s81 for ; Wed, 20 Sep 2017 17:14:38 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751730AbdITHOO (ORCPT ); Wed, 20 Sep 2017 03:14:14 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:36901 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751666AbdITHOL (ORCPT ); Wed, 20 Sep 2017 03:14:11 -0400 Received: by mail-pg0-f68.google.com with SMTP id v5so1181761pgn.4; Wed, 20 Sep 2017 00:14:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ehpOF8LqfzbIHCwrTCRjrL7cPywbkI1IrZmnMmYZi5Y=; b=fo1JDVjAqIZbT0p3Dkoz89of6I16F5RyH9h3SNq7g25JIY+9KQh1xJ3vf0lMFIlcuz +zgvfDEfVPWOzOGEHi/NP8QfvdXwyjS4l+vHeb85WwvZXwOMqAz0f33c+yiTgaCNEzA7 7MI89QyRDjKH6vc2TlqtYaMIpLm0YOT84aXXbK5evB7LtXjN5pRs7U9GLs1jjn667F7v 9fPonV8M+18smbYACSpXOr9DxsY3uB2XGkwOzcr0Fp1QM3pSbKhT/eAxO1obM1GipHiM N1ltgYUYKlFd52kCUytWITSegYQe47RKCZXcpMY/oGufYOVWJRaW6ZGK25GwG+eHh+Sx q9CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ehpOF8LqfzbIHCwrTCRjrL7cPywbkI1IrZmnMmYZi5Y=; b=ol8ji33xaqumYcbTD+etGgJ49hMkttmWPVVdFWm2Y5cOJoW57fIpxncH/zWGjOvTwx 7ZcKXrDfKaHSD6YXYylTwOF9GDtrGYFN/C+dNZnEFRUnSvCYxPk3A93JDHMNdUuN8Oxt cw0gpYmuEz4KTuUPEF7P5q1jn8NiR748SptySP/u6yRIed0/D7rsEgQKK6P2Q7Zscqxe O507OBDDIDKAVqCrEww3SnGxVTIjF7UE5R6tEivVlOvy5TE9ULoh9JyhYJ3+v4T+K6Iv ek9afdUXNUIqdxJIY7hkipf0a+niaDD2IZllPMMDd+x9KbsYt4vY5YC20dd+SHLrvVem CWAg== X-Gm-Message-State: AHPjjUgrfoP31+u7pLLzkec83mz9mvm0ONja8dPgg40hdgaVvXRcGQiF atnOpOPodIS88gbERr4PZe4= X-Google-Smtp-Source: AOwi7QBsdYMRXOOklwTP6JzE25tEIvxe0sct4divX/JiEy/msaoD6HF67Tzc41G0gmcDuOTNxyXlVw== X-Received: by 10.98.157.73 with SMTP id i70mr1208520pfd.268.1505891650883; Wed, 20 Sep 2017 00:14:10 -0700 (PDT) Received: from symbol-HP-Z420-Workstation.zebra.lan ([223.31.70.102]) by smtp.googlemail.com with ESMTPSA id 195sm5927913pgg.42.2017.09.20.00.14.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 20 Sep 2017 00:14:10 -0700 (PDT) From: Arvind Yadav To: gregory.0xf0@gmail.com, linus.walleij@linaro.org, computersforpeace@gmail.com, f.fainelli@gmail.com Cc: bcm-kernel-feedback-list@broadcom.com, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] gpio: brcmstb: Handle return value of devm_kasprintf Date: Wed, 20 Sep 2017 12:43:08 +0530 Message-Id: <1505891589-6632-2-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1505891589-6632-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1505891589-6632-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org devm_kasprintf() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/gpio/gpio-brcmstb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c index dd0308c..1227d6e 100644 --- a/drivers/gpio/gpio-brcmstb.c +++ b/drivers/gpio/gpio-brcmstb.c @@ -485,6 +485,9 @@ static int brcmstb_gpio_probe(struct platform_device *pdev) gc->of_node = np; gc->owner = THIS_MODULE; gc->label = devm_kasprintf(dev, GFP_KERNEL, "%pOF", dev->of_node); + if (!gc->label) + goto fail; + gc->base = gpio_base; gc->of_gpio_n_cells = 2; gc->of_xlate = brcmstb_gpio_of_xlate; From patchwork Wed Sep 20 07:13:09 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 816078 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="gJp49+st"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xxrb43G4tz9s81 for ; Wed, 20 Sep 2017 17:14:24 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751801AbdITHOQ (ORCPT ); Wed, 20 Sep 2017 03:14:16 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:35438 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751771AbdITHOO (ORCPT ); Wed, 20 Sep 2017 03:14:14 -0400 Received: by mail-pf0-f195.google.com with SMTP id i23so874236pfi.2; Wed, 20 Sep 2017 00:14:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=1wAxjax2nzD3DLIz/+gXxgwPnmKL4TYJUSg3RaNS1E0=; b=gJp49+stTqRXIrO82MS7oTc1e9ja8MCRAQvDG/1xHMDmJlJ5WYZK4FDQ3+3Yq+Ych9 0x6M4+/y0ZImUV6/PPDOyqvNPLyLgNKKaZXHwNAR19ox+e6wefZwK/oRHSoYBXycrJNI chihNmEA0uAs9VYWf7FJRk4xlP7z4S1rtADO5PuF+ep7bPfZU+P0vxSs7FKs56ti7bNJ moVMSmARg5rsJpwJkkpHWETzNSc3kbYPXOYxEir9ETj8kj5nEtrRNFIr1OJ2NyZIoAVH wBK7ya2z/v/ZkBtBW8OyxO2XLiSVfj+wO6Sju8vFlNWXc3EGjvpBDgMl3K16z2NgTl1U uMRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=1wAxjax2nzD3DLIz/+gXxgwPnmKL4TYJUSg3RaNS1E0=; b=Cpdg5wq0WoEfZ6i521j/VnFf9GKVucJz7OfZtLcHm/TQJYOqTVQZop6/t/dKOHR6HY F+E00Bm4wz4Gaj/F+FFzbfwsOppHPv2S9J2+0CnixdDHpa4ZOUtR10YEJlVzlV7Wnxjr KVOu4OrusFtf7YrXju0pBe15tDd7VDZojoPwsqMt4PhQdXaidTCWrGwjY5icwbAR2HDP DcWBDNhVGOlQfiXJ0G549ubCR8czK+EKGR8LsUlel3WBCbinn0BhgS92mYwtY+5f/c3g tdFidYejr7vUogF7/DVMWmrDKUicxMi6+B10ST8Qba2jjywNiFbvso1FZXVgagfjHpph bmAw== X-Gm-Message-State: AHPjjUhWUq2YU1jjJPAp4WOw7uiisautuwb2N8u4aS8Ni7zgXew6t4Bx l/ZmPDBl/HxcpwI0AUFgX8PiTw== X-Google-Smtp-Source: AOwi7QBGQUork/IHRZDkM62UFBdpIgsceJ9Ta+MSHIotRUyVrsaZQa17+RuQr+wQpBO3fmebv/jjPA== X-Received: by 10.84.129.226 with SMTP id b89mr1143522plb.438.1505891654123; Wed, 20 Sep 2017 00:14:14 -0700 (PDT) Received: from symbol-HP-Z420-Workstation.zebra.lan ([223.31.70.102]) by smtp.googlemail.com with ESMTPSA id 195sm5927913pgg.42.2017.09.20.00.14.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 20 Sep 2017 00:14:13 -0700 (PDT) From: Arvind Yadav To: gregory.0xf0@gmail.com, linus.walleij@linaro.org, computersforpeace@gmail.com, f.fainelli@gmail.com Cc: bcm-kernel-feedback-list@broadcom.com, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] gpio: tb10x: Handle return value of devm_kasprintf Date: Wed, 20 Sep 2017 12:43:09 +0530 Message-Id: <1505891589-6632-3-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1505891589-6632-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1505891589-6632-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org devm_kasprintf() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/gpio/gpio-tb10x.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpio/gpio-tb10x.c b/drivers/gpio/gpio-tb10x.c index 091ffaa..ac6f2a9 100644 --- a/drivers/gpio/gpio-tb10x.c +++ b/drivers/gpio/gpio-tb10x.c @@ -193,6 +193,9 @@ static int tb10x_gpio_probe(struct platform_device *pdev) tb10x_gpio->gc.label = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%pOF", pdev->dev.of_node); + if (!tb10x_gpio->gc.label) + return -ENOMEM; + tb10x_gpio->gc.parent = &pdev->dev; tb10x_gpio->gc.owner = THIS_MODULE; tb10x_gpio->gc.direction_input = tb10x_gpio_direction_in;