From patchwork Tue Apr 16 13:21:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roi Dayan X-Patchwork-Id: 1924102 X-Patchwork-Delegate: horms@verge.net.au Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=JIr+C6wA; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VJl8D2z3gz1yZC for ; Tue, 16 Apr 2024 23:22:36 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id ACE0F81E60; Tue, 16 Apr 2024 13:22:33 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id G0WNgR1bSbcY; Tue, 16 Apr 2024 13:22:30 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.9.56; helo=lists.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 4F7E681E4F Authentication-Results: smtp1.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=JIr+C6wA Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id 4F7E681E4F; Tue, 16 Apr 2024 13:22:30 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 10F53C0077; Tue, 16 Apr 2024 13:22:30 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 8BC5AC0037 for ; Tue, 16 Apr 2024 13:22:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 733246084C for ; Tue, 16 Apr 2024 13:22:28 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id u-6B15JvoJ_j for ; Tue, 16 Apr 2024 13:22:25 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a01:111:f403:2414::600; helo=nam11-bn8-obe.outbound.protection.outlook.com; envelope-from=roid@nvidia.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 7EFAA60819 Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 7EFAA60819 Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=JIr+C6wA Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on20600.outbound.protection.outlook.com [IPv6:2a01:111:f403:2414::600]) by smtp3.osuosl.org (Postfix) with ESMTPS id 7EFAA60819 for ; Tue, 16 Apr 2024 13:22:25 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ge8myo0JXyGInxP2Bbip2RSEeadZAsrsWUKqoaHOvDpYWs5yFsbnwRsatmSRX24s1+kyfxrE4covIOTlhV/QCM/NtErAk6ysSK//T8sDLKulmcVtGoLHJvsvleZaOe7LUlEdKd0nvBo5MQgCFscUltnQW+uqD1NAukSiyvrDFwuX8i25Dxacdi0mEWTEViUoxcVeVWyg4kUEvCZz8Ycpcmpn8gu3GFTeCllKFc84N+VM7+aPbnwAlZb5Qk3aLTam/OdJRg0f02qMiye5zr+UJZeTzfsaY6tVGAeNX0kX82s6eYRI54gBwPA45j8nNQNmF+/ZkzAZzuJ+lPjMlYePNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=guPQPciVX5ox5MC+YoRlAmI1v5DLFyWNvFSmTpJD9+E=; b=SxqJ4vAcev0nrlNGicZ+LUfJXxvLtvq+Y+fU17nd6hb2yQL1q2dUAeqp++fL6NUJmrvAD39lVFysF0LXb+ezFQ2tjMEIIPyOhUJzYoU2brZ3iLVZ+4nB6wGdNYKj+lpqtzpMjOFiXgY2tkC8M+T+NA+sI/76frOfMKgOrDXGvabX27r1TDc58CUHXI65YAxUG7fxjrAzDZyBS7ssQEduY0ohzdQ3MvbN2RLwICqBCLGMELsw/jdQqJeDJOjOBAcWL/bOlM8sgCk584CN9g4G3xUvbcTWtRApY9nR5M+7nRjSqxzEzE+mXtIaggHapYK2/wCwo6uXvRBQZGCQtsHPnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=openvswitch.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=guPQPciVX5ox5MC+YoRlAmI1v5DLFyWNvFSmTpJD9+E=; b=JIr+C6wAIig/Ncd66QJ8SxXaDNpTowCRubhFkfoLHT6YZ5aR7Ih18fcZbChjbgzk08ap9y/wYmb98UHgSOcwkRt4cjmzGNTTGk1NM0qqwfEwvHL48JpKAgCz/RZnobatVjyuE9DW0l4nIU2Ffn/H1lx3WwM7ObTd26hbGHW0sTve3i6KViiP1ZlaFTKp9hp+kK5wCknyPxO18gfJdbH4GkJzlNL0PqgRZbT2IGW8OrmOPZnq+SCjgLGthHE5r/yQjnGij+bMsMcoyPlzXWQU0jIyEA72QhxzYG8JI4PUtybzWe7yB8Ccls4yvqq3hdb1acXEr3fTaY8BjWIS28vGEw== Received: from BYAPR01CA0062.prod.exchangelabs.com (2603:10b6:a03:94::39) by MW6PR12MB8950.namprd12.prod.outlook.com (2603:10b6:303:24a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.50; Tue, 16 Apr 2024 13:22:17 +0000 Received: from CO1PEPF000042AC.namprd03.prod.outlook.com (2603:10b6:a03:94:cafe::19) by BYAPR01CA0062.outlook.office365.com (2603:10b6:a03:94::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7495.20 via Frontend Transport; Tue, 16 Apr 2024 13:22:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by CO1PEPF000042AC.mail.protection.outlook.com (10.167.243.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.22 via Frontend Transport; Tue, 16 Apr 2024 13:22:13 +0000 Received: from drhqmail203.nvidia.com (10.126.190.182) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 16 Apr 2024 06:22:03 -0700 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail203.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 16 Apr 2024 06:22:02 -0700 Received: from mtr-vdi-198.wap.labs.mlnx (10.127.8.13) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Tue, 16 Apr 2024 06:22:01 -0700 To: Date: Tue, 16 Apr 2024 16:21:48 +0300 Message-ID: <20240416132149.1698611-1-roid@nvidia.com> X-Mailer: git-send-email 2.44.0 MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000042AC:EE_|MW6PR12MB8950:EE_ X-MS-Office365-Filtering-Correlation-Id: 363278f5-52ac-48cf-cf9d-08dc5e183a61 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +hQzHcD9IDAugqNMFqTQzouf/KLSFx+sMor1AjAIPOA2G1xDgZNFHbJtJiQaiBiMHx3DUNG53bDrQ5nWuVuTCefkGmE1sDou3Mdh9YeVdpoAsWgPJAXnEyfOsliDP0uw7sxPcoMuVQw4t6+iyiAMQWsykRJRf43fdkESxNKw5vKB0pRn0f1omTo4olhFDMb65rr6rehy5jiLlZK+tp9argnTv5kxsIaOHQf2MSjIXeHI68Kqlw0jzzETq8DMOQyQKV3lw94yy+svyWWuTwB/f5F2jDrZfq5q0H89SySDJxJH6zsSET+icwlT73Gvq2W7RPrK6qI+maveDd+97q72uxS6cdjPSRPH4EUhzkyh1hc/oN4EXqKSpz6jBu8p+mDPEyo4eunlj3KfeZpcudL7F1fBXNeahpu3U4vuDGfcxVmU9iWvYtxU3H+iA0ulmIi/PHlGq3AsY/B2tvpgiiv7m74lqaWxopbmWG0z7M2jvaqBoF7ZHFnwglv0vNb3Devlzbw/SBEJQfPpuYcA0ZeesN6eS3SNn6Zme0PMk6kYfkY90h2AJ7Av0BBSdkMjeJE1xxlR5UGUsaWUdpEukXt+cHjkQFmHxkC3biyEbcB+OqzAs37C40X6ZgIKU9hTgEgkjrNdRMKZqltVRwRzhewIpYRMXOJVzUHskkCUjFiCCQNM80NqioCME0MwX6aaF5UJ3llCYv4N/T2sTdBimEeqwUKTRSbjKfuBKvpnljzP/bcNE0UqbzGBplS7MzZxyTai X-Forefront-Antispam-Report: CIP:216.228.118.232; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge1.nvidia.com; CAT:NONE; SFS:(13230031)(36860700004)(1800799015)(82310400014)(376005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Apr 2024 13:22:13.0545 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 363278f5-52ac-48cf-cf9d-08dc5e183a61 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.232]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000042AC.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8950 Cc: Eli Britstein , Maor Dickman Subject: [ovs-dev] [PATCH 1/1] netdev-dpdk: Fix possible memory leak configuring VF MAC address. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Roi Dayan via dev From: Roi Dayan Reply-To: Roi Dayan Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" VLOG_WARN_BUF() is allocating memory for the error string and should e used if the configuration cannot continue and error is being returned so the caller has indication of releasing the pointer. Change to VLOG_WARN() to keep the logic that error is not being returned. Fixes: f4336f504b17 ("netdev-dpdk: Add option to configure VF MAC address.") Signed-off-by: Roi Dayan Acked-by: Gaetan Rivet Acked-by: Eli Britstein Acked-by: Simon Horman --- lib/netdev-dpdk.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 2111f776810b..9249b9e9c646 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -2379,17 +2379,16 @@ netdev_dpdk_set_config(struct netdev *netdev, const struct smap *args, struct eth_addr mac; if (!dpdk_port_is_representor(dev)) { - VLOG_WARN_BUF(errp, "'%s' is trying to set the VF MAC '%s' " - "but 'options:dpdk-vf-mac' is only supported for " - "VF representors.", - netdev_get_name(netdev), vf_mac); + VLOG_WARN("'%s' is trying to set the VF MAC '%s' " + "but 'options:dpdk-vf-mac' is only supported for " + "VF representors.", + netdev_get_name(netdev), vf_mac); } else if (!eth_addr_from_string(vf_mac, &mac)) { - VLOG_WARN_BUF(errp, "interface '%s': cannot parse VF MAC '%s'.", - netdev_get_name(netdev), vf_mac); + VLOG_WARN("interface '%s': cannot parse VF MAC '%s'.", + netdev_get_name(netdev), vf_mac); } else if (eth_addr_is_multicast(mac)) { - VLOG_WARN_BUF(errp, - "interface '%s': cannot set VF MAC to multicast " - "address '%s'.", netdev_get_name(netdev), vf_mac); + VLOG_WARN("interface '%s': cannot set VF MAC to multicast " + "address '%s'.", netdev_get_name(netdev), vf_mac); } else if (!eth_addr_equals(dev->requested_hwaddr, mac)) { dev->requested_hwaddr = mac; netdev_request_reconfigure(netdev);