From patchwork Tue Apr 9 10:02:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?Q2zDqW1lbnQgTMOpZ2Vy?= X-Patchwork-Id: 1921319 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=pV/XYZ42; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=RvZbs7YW; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VDM2s01v8z1yZg for ; Tue, 9 Apr 2024 20:02:44 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=08v8R8mN/0gSztaRlqOe0UzeRNOCTAlrp4OKUrIY1Z0=; b=pV/XYZ42KKkvzn Up2+dUoO0hWmN0pe9t1IXb+IOGm6IHcDp5MKXSWCmcvphRA64esvINHHXUrjsChf1WUdlBuJjWrLY JGq+7s/T54X69Swx6dS5S1kV1/rlgX9IoM9jCadkLIZ6w0Q96w9rr2lp6jZZySLm3UDzdQiPzigA3 mnE+3gBdVnndFRPRoOwoN50okVgO2JVxDg/+P3hUm0g247WCtrHxfO+0HSvr9bMYpm2q3EtyKtdvE 4UmALD4eA4HWERQJvQsBIWcdULKlqxWEhRQdpRpvA08ja9EZ5s6P6Il5LxR/rP3IZY3YSzVNVnppC G9z5Mdm7QvEi4kTPcyuw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru8JI-00000001KSF-26FO; Tue, 09 Apr 2024 10:02:36 +0000 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru8JD-00000001KNt-2OIv for opensbi@lists.infradead.org; Tue, 09 Apr 2024 10:02:33 +0000 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-346407b8c9aso47043f8f.0 for ; Tue, 09 Apr 2024 03:02:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1712656942; x=1713261742; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gOjpKPxEXC124WEvQwFE9yDQ+bk/28aqm8SY3ugJyPA=; b=RvZbs7YWr6y2IW6ROFn/+tbP1dCCac/+GFV1wrhLEstnOeGNFGEnJsRZTRRuNWbCMa oNHqf0uN7SkAwojBT0U85mK9Ug+yCfYnyHn8NjC8D4bjA5zgGjvKJcNJVzyL1vy7gPEw NsPYMYt6cI3+gS2Yiv1WAdSMl0HvmFge4P/7MxXyJ3e71yvnfYJo8IP32JkO98o2A71P +qHNuukyI8mdGNdIj6mWZjH7alyN7fZegPyROQWvXdsXeC4dsNIJVRDqdPecqay70Q6Y ZHH9wET2ymHiGlqohrNa5GcAkGUeRKRS2xVHrK25UmBZCrHRSdcO8Jc1ZYgvQp/GHDPt 67VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712656942; x=1713261742; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gOjpKPxEXC124WEvQwFE9yDQ+bk/28aqm8SY3ugJyPA=; b=AL6JBlwWt8O4i765G75LvTDckQS5hKv1w6viQymSsZ0sL8MaJkgoTsl2/1iLBWNE2f /rEkyiEBJuH53DKzZ60PoJij+my/5iMTX7u6ge2NTZHzRONu+f6PxpIKzwBC964YFJ86 jAqAi2FBY+fPLFBNnXEGTXXxm7rToRGbLbO0s+IVvajM73gZR/BXAgPDvFZ/kpeiL4Yb BEbbIfdMn4PbJhI6zX9CtNN9cQvdxnjTK3rAci1y9INxC8s42m9Y5qVac6d3Hgq+xN5d EevJDvrDStGrHve5Xc8itd0fe41kW6nXYlP81/Kl7qH//jNeUY4nu+4Eb8eh2UOoL5vB HeuA== X-Gm-Message-State: AOJu0YyfLoPKyxB+OfYpqkHqG5Kuz2PkMN0O0WI2KNAj0VH50RpSyAGN 1UYw9RlxfU3cE0tzqsY7bc0YTLSS31Xxx2L/Tg56FC/GWsWJRxig/6hEY/E0VPNZRaGPIADW2k8 4tYg= X-Google-Smtp-Source: AGHT+IEs6DCTNT81y/k5JH/mTgY8mgW6cAUh6ZvQI2/DTBqHdqgyZgFRnbq1xFPltTv4i2nGyH8f8Q== X-Received: by 2002:a05:600c:4f11:b0:416:a71f:6217 with SMTP id l17-20020a05600c4f1100b00416a71f6217mr891993wmq.0.1712656941626; Tue, 09 Apr 2024 03:02:21 -0700 (PDT) Received: from carbon-x1.. ([2a01:e0a:999:a3a0:322c:7eda:35fd:4614]) by smtp.gmail.com with ESMTPSA id a20-20020a05600c349400b00416b28651e1sm862972wmq.36.2024.04.09.03.02.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 03:02:20 -0700 (PDT) From: =?utf-8?b?Q2zDqW1lbnQgTMOpZ2Vy?= To: opensbi@lists.infradead.org Subject: [PATCH 1/7] lib: sbi: sse: fix typos, comments and spacing errors Date: Tue, 9 Apr 2024 12:02:02 +0200 Message-ID: <20240409100216.263256-2-cleger@rivosinc.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240409100216.263256-1-cleger@rivosinc.com> References: <20240409100216.263256-1-cleger@rivosinc.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240409_030231_850241_93CCE9EC X-CRM114-Status: GOOD ( 16.89 ) X-Spam-Score: 0.0 (/) X-Spam-Report: =?unknown-8bit?q?Spam_detection_software=2C_running_on_the_sy?= =?unknown-8bit?q?stem_=22bombadil=2Einfradead=2Eorg=22=2C?= =?unknown-8bit?q?_has_NOT_identified_this_incoming_email_as_spam=2E__The_ori?= =?unknown-8bit?q?ginal?= =?unknown-8bit?q?_message_has_been_attached_to_this_so_you_can_view_it_or_la?= =?unknown-8bit?q?bel?= =?unknown-8bit?q?_similar_future_email=2E__If_you_have_any_questions=2C_see?= =?unknown-8bit?q?_the_administrator_of_that_system_for_details=2E?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_preview=3A__Fix_some_errors_spotted_by_Samuel_whil?= =?unknown-8bit?q?e_reviewing_the_SSE?= =?unknown-8bit?q?_implementation=2E_Signed-off-by=3A_Cl=C3=A9ment_L=C3=A9ger?= =?unknown-8bit?q?_=3Ccleger=40rivosinc=2Ecom=3E_Reported-by=3A?= =?unknown-8bit?q?_Samuel_Holland_=3Csamuel=2Eholland=40sifive=2Ecom=3E_---_i?= =?unknown-8bit?q?nclude/sbi/sbi=5Fecall=5Finterface=2Eh?= =?unknown-8bit?b?IHwgMjQgKysrKysrKysrKysrIGxpYi9zYmkvc2JpX3NzZS5jIHwgMjIg?= =?unknown-8bit?b?Wy4uLl0g?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_analysis_details=3A___=280=2E0_points=2C_5=2E0_req?= =?unknown-8bit?q?uired=29?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_pts_rule_name______________description?= =?unknown-8bit?q?_----_----------------------_------------------------------?= =?unknown-8bit?q?--------------------?= =?unknown-8bit?q?_-0=2E0_RCVD=5FIN=5FDNSWL=5FNONE_____RBL=3A_Sender_listed_a?= =?unknown-8bit?q?t_https=3A//www=2Ednswl=2Eorg/=2C_no?= =?unknown-8bit?q?_trust?= =?unknown-8bit?b?IFsyYTAwOjE0NTA6NDg2NDoyMDowOjA6MDo0MmQgbGlzdGVkIGluXQ==?= =?unknown-8bit?b?IFtsaXN0LmRuc3dsLm9yZ10=?= =?unknown-8bit?q?_0=2E0_SPF=5FHELO=5FNONE__________SPF=3A_HELO_does_not_publ?= =?unknown-8bit?q?ish_an_SPF_Record?= =?unknown-8bit?q?_-0=2E0_SPF=5FPASS_______________SPF=3A_sender_matches_SPF_?= =?unknown-8bit?q?record?= =?unknown-8bit?q?_-0=2E1_DKIM=5FVALID_____________Message_has_at_least_one_v?= =?unknown-8bit?q?alid_DKIM_or_DK_signature?= =?unknown-8bit?q?_0=2E1_DKIM=5FSIGNED____________Message_has_a_DKIM_or_DK_si?= =?unknown-8bit?q?gnature=2C_not_necessarily_valid?= X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anup Patel , =?utf-8?b?Q2zDqW1lbnQgTMOpZ2Vy?= , Atish Patra Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Fix some errors spotted by Samuel while reviewing the SSE implementation. Signed-off-by: Clément Léger Reported-by: Samuel Holland Reviewed-by: Anup Patel --- include/sbi/sbi_ecall_interface.h | 24 ++++++++++++------------ lib/sbi/sbi_sse.c | 22 +++++++++++----------- 2 files changed, 23 insertions(+), 23 deletions(-) diff --git a/include/sbi/sbi_ecall_interface.h b/include/sbi/sbi_ecall_interface.h index a511e0b..2600b66 100644 --- a/include/sbi/sbi_ecall_interface.h +++ b/include/sbi/sbi_ecall_interface.h @@ -344,36 +344,36 @@ enum sbi_sse_attr_id { #define SBI_SSE_ATTR_INTERRUPTED_FLAGS_HSTATUS_SPVP BIT(3) enum sbi_sse_state { - SBI_SSE_STATE_UNUSED = 0, - SBI_SSE_STATE_REGISTERED = 1, - SBI_SSE_STATE_ENABLED = 2, - SBI_SSE_STATE_RUNNING = 3, + SBI_SSE_STATE_UNUSED = 0, + SBI_SSE_STATE_REGISTERED = 1, + SBI_SSE_STATE_ENABLED = 2, + SBI_SSE_STATE_RUNNING = 3, }; /* SBI SSE Event IDs. */ #define SBI_SSE_EVENT_LOCAL_RAS 0x00000000 -#define SBI_SSE_EVENT_LOCAL_PLAT_0_START 0x00004000 +#define SBI_SSE_EVENT_LOCAL_PLAT_0_START 0x00004000 #define SBI_SSE_EVENT_LOCAL_PLAT_0_END 0x00007fff #define SBI_SSE_EVENT_GLOBAL_RAS 0x00008000 -#define SBI_SSE_EVENT_GLOBAL_PLAT_0_START 0x00004000 +#define SBI_SSE_EVENT_GLOBAL_PLAT_0_START 0x00004000 #define SBI_SSE_EVENT_GLOBAL_PLAT_0_END 0x00007fff #define SBI_SSE_EVENT_LOCAL_PMU 0x00010000 -#define SBI_SSE_EVENT_LOCAL_PLAT_1_START 0x00014000 +#define SBI_SSE_EVENT_LOCAL_PLAT_1_START 0x00014000 #define SBI_SSE_EVENT_LOCAL_PLAT_1_END 0x00017fff -#define SBI_SSE_EVENT_GLOBAL_PLAT_1_START 0x0001c000 +#define SBI_SSE_EVENT_GLOBAL_PLAT_1_START 0x0001c000 #define SBI_SSE_EVENT_GLOBAL_PLAT_1_END 0x0001ffff -#define SBI_SSE_EVENT_LOCAL_PLAT_2_START 0x00024000 +#define SBI_SSE_EVENT_LOCAL_PLAT_2_START 0x00024000 #define SBI_SSE_EVENT_LOCAL_PLAT_2_END 0x00027fff -#define SBI_SSE_EVENT_GLOBAL_PLAT_2_START 0x0002c000 +#define SBI_SSE_EVENT_GLOBAL_PLAT_2_START 0x0002c000 #define SBI_SSE_EVENT_GLOBAL_PLAT_2_END 0x0002ffff #define SBI_SSE_EVENT_LOCAL_SOFTWARE 0xffff0000 -#define SBI_SSE_EVENT_LOCAL_PLAT_3_START 0xffff4000 +#define SBI_SSE_EVENT_LOCAL_PLAT_3_START 0xffff4000 #define SBI_SSE_EVENT_LOCAL_PLAT_3_END 0xffff7fff #define SBI_SSE_EVENT_GLOBAL_SOFTWARE 0xffff8000 -#define SBI_SSE_EVENT_GLOBAL_PLAT_3_START 0xffffc000 +#define SBI_SSE_EVENT_GLOBAL_PLAT_3_START 0xffffc000 #define SBI_SSE_EVENT_GLOBAL_PLAT_3_END 0xffffffff #define SBI_SSE_EVENT_GLOBAL_BIT (1 << 15) diff --git a/lib/sbi/sbi_sse.c b/lib/sbi/sbi_sse.c index a686692..39b4588 100644 --- a/lib/sbi/sbi_sse.c +++ b/lib/sbi/sbi_sse.c @@ -128,7 +128,7 @@ struct sse_hart_state { * * When an event is in a state >= ENABLED, then it is inserted in the * this enabled_event_list and thus can only be removed from this - * list upon disable ecall or on complete with ONE_SHOT flag. + * list upon disable ecall or on complete with ONESHOT flag. */ struct sbi_dlist enabled_event_list; @@ -202,7 +202,7 @@ static struct sse_hart_state *sse_get_hart_state(struct sbi_sse_event *e) return sse_get_hart_state_ptr(s); } -static struct sse_global_event *sse_get_global_event(struct sbi_sse_event* e) +static struct sse_global_event *sse_get_global_event(struct sbi_sse_event *e) { return container_of(e, struct sse_global_event, event); } @@ -552,11 +552,11 @@ static bool sse_event_check_inject(struct sbi_sse_event *e, struct sbi_trap_regs *regs) { /* - * List of event is ordered by priority, stop at first running - * event since all other events after this one are of lower - * priority. This means an event of higher priority is already - * running. - */ + * List of event is ordered by priority, stop at first running + * event since all other events after this one are of lower + * priority. This means an event of higher priority is already + * running. + */ if (sse_event_state(e) == SBI_SSE_STATE_RUNNING) { return true; } @@ -882,10 +882,10 @@ int sbi_sse_read_attrs(uint32_t event_id, uint32_t base_attr_id, /* * Copy all attributes at once since struct sse_event_attrs is matching - * the SBI_SSE_ATTR_* attributes. While WRITE_ATTR attribute is not used - * in s-mode sse handling path, READ_ATTR is used to retrieve the value - * of registers when interrupted. Rather than doing multiple SBI calls, - * a single one is done allowing to retrieve them all at once. + * the SBI_SSE_ATTR_* attributes. READ_ATTR is used in SSE handling path + * to retrieve the value of registers when interrupted. Rather than + * doing multiple SBI calls a single one is done allowing to retrieve + * them all at once. */ e_attrs = (unsigned long *)&e->attrs; attrs = (unsigned long *)output_phys_lo; From patchwork Tue Apr 9 10:02:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?Q2zDqW1lbnQgTMOpZ2Vy?= X-Patchwork-Id: 1921324 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=gAJC8GVr; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=TymwzH5g; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VDM2z3ZLwz1yZg for ; Tue, 9 Apr 2024 20:02:51 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JQ5dxIcAcRPGCaUDXBL1si9MHAndJdiu6SlvfubDP1g=; b=gAJC8GVrxsR3B7 iztXBC9tNqZ+5/wv7kzY566oh+sA6p2OGFb9QRHAhzEpdbQhNfw778f0viX9OeZtYY7xC/uvxORPW xFtISODlkpROmQOk1dS1zT7TVLgLilRF5wun94JCp52xt3wBpFHe4lXq3hLF6VA2lPe4qquK7ycre BSXfoHXu+338AOGslr+f3o9zCYvX6MRHqzze8jx2mhzmJ1MTyzfom3CFVKL2J6TspvkMVVC2/sA3W dcxV/+hFPp51UpmqxwuZ33culxW4N/Ogldsipm6PKuw+DA24ichHsfYOTVgZiPSvll+7SooY4Ud+P J03FCA9f/6qwrz/chGZw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru8JQ-00000001KYG-03FY; Tue, 09 Apr 2024 10:02:44 +0000 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru8JH-00000001KNw-2UyL for opensbi@lists.infradead.org; Tue, 09 Apr 2024 10:02:39 +0000 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-4167082dabdso3693405e9.0 for ; Tue, 09 Apr 2024 03:02:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1712656943; x=1713261743; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PU9B9nxvbjcpmceezcOMjumOAa6DaJJlmyX0nNtMT6o=; b=TymwzH5gS40LwPoRKmsf+RA85pxi/BcgljyAB4WVfxakWtvabZKwEhT2p8RNjBbZov 7yIA+PhWeqjAzruJVLAVT5LFFhrV+xaA9e5iZifw3QvcqftNJ7fPMQkQhmKVHfHKUMvh znJOxINRmrZm1Gq6cVSYMvWBHKPPfjAtUVB04JSeuc7DqPiar4hQ/Gal8fFWXMi1NmAr xFVnbB2TKei6C53l/b2thDn0rftb7Uo25WUugK0v+ZlFf8LS23w711VxU8ZzqPZmupyb saoeZ+7HP/v+a181zHdGEycPR7YZOVB3/M8aCPdjxkIbs0sfTvY4QXFiHRSoK8cUtvXq ArmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712656943; x=1713261743; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PU9B9nxvbjcpmceezcOMjumOAa6DaJJlmyX0nNtMT6o=; b=ok2SRYBUp1EYHtIKvYKDHAyauJbCzfZVlLOcbAHKu9gWfN1QIlyLEswcSire7cHn2H U/6e0vvLABQlbZx7e27w7Bv/83KUpeGAVcPP0glNSBwUSJ4YGWYGkCUQm+IxmQNQmlts 0tChGxoBkwuC/LF/mSkwrQDRN8Odt87g9ixh18EhQW8vOn8t85dUVzcArMhDYvzctUy6 si7IEPOAJU6Fyp6ye/0SaODlaxqPCU09o0s/9C9gLdlzioEEKt9opVFa5QkzN1XcE5UB 78VYVOCQzGF/jMHhmEM5JoC+vM0wMOi5xV4WdyIW2lATUpYotOarDhgnsF3mBr1vWKdb gNpw== X-Gm-Message-State: AOJu0YzQ46hup7oN2lKe9hjfgQK9Njr5Vf8SDWhaq0uUJRbpVbKNtbUH qrPq4Lxqxg3UYpgX0IzrmT49zf1ZMY3g3vbOOykeBKXU7ftxOD9HbXhGDtdPgLj8mO1uh5Ha26D s2bM= X-Google-Smtp-Source: AGHT+IGoSO5h+ScG5BqH7TOKGAoCib/COT5YB6jYwt/g+ADL3a14MB0G74GEnoK6OdOba6MMGBIOEQ== X-Received: by 2002:a05:600c:3b26:b0:416:3de5:1367 with SMTP id m38-20020a05600c3b2600b004163de51367mr6798430wms.3.1712656943146; Tue, 09 Apr 2024 03:02:23 -0700 (PDT) Received: from carbon-x1.. ([2a01:e0a:999:a3a0:322c:7eda:35fd:4614]) by smtp.gmail.com with ESMTPSA id a20-20020a05600c349400b00416b28651e1sm862972wmq.36.2024.04.09.03.02.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 03:02:21 -0700 (PDT) From: =?utf-8?b?Q2zDqW1lbnQgTMOpZ2Vy?= To: opensbi@lists.infradead.org Subject: [PATCH 2/7] lib: sbi: sse: rename sse_hart_unlock() to sse_enabled_event_unlock() Date: Tue, 9 Apr 2024 12:02:03 +0200 Message-ID: <20240409100216.263256-3-cleger@rivosinc.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240409100216.263256-1-cleger@rivosinc.com> References: <20240409100216.263256-1-cleger@rivosinc.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240409_030235_768408_AEA30CF6 X-CRM114-Status: GOOD ( 10.47 ) X-Spam-Score: 0.0 (/) X-Spam-Report: =?unknown-8bit?q?Spam_detection_software=2C_running_on_the_sy?= =?unknown-8bit?q?stem_=22bombadil=2Einfradead=2Eorg=22=2C?= =?unknown-8bit?q?_has_NOT_identified_this_incoming_email_as_spam=2E__The_ori?= =?unknown-8bit?q?ginal?= =?unknown-8bit?q?_message_has_been_attached_to_this_so_you_can_view_it_or_la?= =?unknown-8bit?q?bel?= =?unknown-8bit?q?_similar_future_email=2E__If_you_have_any_questions=2C_see?= =?unknown-8bit?q?_the_administrator_of_that_system_for_details=2E?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_preview=3A__There_was_a_naming_incoherency_between?= =?unknown-8bit?q?_enabled_events_list?= =?unknown-8bit?q?_lock/unlock=2E_Rename_sse=5Fhart=5Funlock=28=29_to_sse=5Fe?= =?unknown-8bit?q?nabled=5Fevent=5Funlock=28=29_to_be?= =?unknown-8bit?q?_coherent_and_reword_comments_above_lock=28=29/unlock=28=29?= =?unknown-8bit?q?_functions=2E_Signed-off-by=3A?= =?unknown-8bit?q?_Cl=C3=A9ment_L=C3=A9ger_=3Ccleger=40rivosinc=2Ecom=3E_---_?= =?unknown-8bit?q?lib/sbi/sbi=5Fsse=2Ec_=7C_10_+++++-----?= =?unknown-8bit?q?_1_file_changed=2C_5_insertions=28+=29=2C_5_deletions=28-?= =?unknown-8bit?q?=29_?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_analysis_details=3A___=280=2E0_points=2C_5=2E0_req?= =?unknown-8bit?q?uired=29?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_pts_rule_name______________description?= =?unknown-8bit?q?_----_----------------------_------------------------------?= =?unknown-8bit?q?--------------------?= =?unknown-8bit?q?_-0=2E0_RCVD=5FIN=5FDNSWL=5FNONE_____RBL=3A_Sender_listed_a?= =?unknown-8bit?q?t_https=3A//www=2Ednswl=2Eorg/=2C_no?= =?unknown-8bit?q?_trust?= =?unknown-8bit?b?IFsyYTAwOjE0NTA6NDg2NDoyMDowOjA6MDozMzAgbGlzdGVkIGluXQ==?= =?unknown-8bit?b?IFtsaXN0LmRuc3dsLm9yZ10=?= =?unknown-8bit?q?_0=2E0_SPF=5FHELO=5FNONE__________SPF=3A_HELO_does_not_publ?= =?unknown-8bit?q?ish_an_SPF_Record?= =?unknown-8bit?q?_-0=2E0_SPF=5FPASS_______________SPF=3A_sender_matches_SPF_?= =?unknown-8bit?q?record?= =?unknown-8bit?q?_-0=2E1_DKIM=5FVALID_____________Message_has_at_least_one_v?= =?unknown-8bit?q?alid_DKIM_or_DK_signature?= =?unknown-8bit?q?_0=2E1_DKIM=5FSIGNED____________Message_has_a_DKIM_or_DK_si?= =?unknown-8bit?q?gnature=2C_not_necessarily_valid?= X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anup Patel , =?utf-8?b?Q2zDqW1lbnQgTMOpZ2Vy?= , Atish Patra Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org There was a naming incoherency between enabled events list lock/unlock. Rename sse_hart_unlock() to sse_enabled_event_unlock() to be coherent and reword comments above lock()/unlock() functions. Signed-off-by: Clément Léger Reviewed-by: Anup Patel --- lib/sbi/sbi_sse.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/sbi/sbi_sse.c b/lib/sbi/sbi_sse.c index 39b4588..d54c125 100644 --- a/lib/sbi/sbi_sse.c +++ b/lib/sbi/sbi_sse.c @@ -208,7 +208,7 @@ static struct sse_global_event *sse_get_global_event(struct sbi_sse_event *e) } /** - * If event is global, must be called under global event lock + * If event is global, must be called under enabled event lock */ static void sse_enabled_event_lock(struct sbi_sse_event *e) { @@ -219,9 +219,9 @@ static void sse_enabled_event_lock(struct sbi_sse_event *e) } /** - * If event is global, must be called under global event lock + * If event is global, must be called under enabled event lock */ -static void sse_hart_unlock(struct sbi_sse_event *e) +static void sse_enabled_event_unlock(struct sbi_sse_event *e) { struct sse_hart_state *shs; @@ -753,7 +753,7 @@ int sbi_sse_enable(uint32_t event_id) sse_enabled_event_lock(e); ret = sse_event_enable(e); - sse_hart_unlock(e); + sse_enabled_event_unlock(e); sse_event_put(e); return ret; @@ -770,7 +770,7 @@ int sbi_sse_disable(uint32_t event_id) sse_enabled_event_lock(e); ret = sse_event_disable(e); - sse_hart_unlock(e); + sse_enabled_event_unlock(e); sse_event_put(e); From patchwork Tue Apr 9 10:02:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?Q2zDqW1lbnQgTMOpZ2Vy?= X-Patchwork-Id: 1921322 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=yFH/DRtu; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=b3VHDhYz; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VDM2x021Xz1yYH for ; Tue, 9 Apr 2024 20:02:49 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y2X1kCnZvn8L2D5wbcHRWGvT7AGjww7Lv9p2zdg6/VI=; b=yFH/DRtu7ymIkj ht4Sy6WPI06xCbXOpVLTYcAaLYs7MiucCQxwJM/FtWJHUtAhEIlxejFvMSmo3YiuPmbrMf31WQOZI RJ52Gt921dPOyzGDl1xjfdIPbD+b0Ps1L2UP/C2rtrn4NMEAik3zTd9pLMz8j2Fqu+OOblQxOPZB+ 5Tobserlai4O1145/ASzYinWzRrO5PU2ikkPZ0YECoHfpjEBrKsUQGyAOgGQk1EYk0YrdmBurlHMo 42ZOPOt/SoDAHQtHk1ox9U63VMWmcL/jqnmtWvu9Jka9R0JHTfrMga7FctFeLbSxliOwJuTZFACLg wFA6AgqtyoufX8T6TwKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru8JO-00000001KWw-2h2e; Tue, 09 Apr 2024 10:02:42 +0000 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru8JH-00000001KO5-2UZU for opensbi@lists.infradead.org; Tue, 09 Apr 2024 10:02:38 +0000 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-416463e82fbso4177085e9.1 for ; Tue, 09 Apr 2024 03:02:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1712656944; x=1713261744; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5je7/7GMUOOa8VJe5hjqnz/lVgoozefRpXFllbC0V4I=; b=b3VHDhYzjnOBs6+NfBVC3QwMOhy0AgEiTImJZQKuSwPrgf2kErMM8wkCpG+rghCmbk tm/x5tOiKg1a3To5sNgvGhpigq5/dqwuqasDLAFFk5koBhOs3YUE8SUGK8uxMZZk6ODX b0LPAHh4SK38J7rBGlKauZz2AHDEoLL9GF6dFHalGyZpW5pXq0BSJXxNhDKDqniwG5jE 42IY9V6wOZabXMNvY5eBHYzlXb++sPOGVizpD2enE9vNm9udwYyo5ezRiaSdFttR4uwL e64yFuJM6VQLQMC3/or/ONufZZlWL9fTGzY8oYCfQImwDFE84mU0KZMfHnoYBJouC6Xk c1Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712656944; x=1713261744; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5je7/7GMUOOa8VJe5hjqnz/lVgoozefRpXFllbC0V4I=; b=mN4T5g88ed+l9n7GEPqtyF2iodYw62+DS/N0w421oKHoQoXT3Os6DEglJAd5mo2R5d hHX0pvcU/78XQieYp8Bb1h8SEfTbJUCya9GOa0Z2WY1/NmXOXXGeWKHQvuCM8OvRwFUU jl2piJnzUrRXrDSRXsSCbVqVd0gxRg0LOvNQRnBrl9XzpKkqa4HZuuzG+Wcgkf+Q4Mv9 Df+U7wiEK86go1opXZJvdmbZ5Y7IE+S5LdayQkjzfOfI95DWMNTVl70pDpaQYCHk8PIc pMSzRR26ZrYL0h+lWEm6B8JMBQ449s63JigbxZ9sh8zYRPHLzDcZp0DjHpYhMVkWceR+ WbBg== X-Gm-Message-State: AOJu0Yw4fEimvCsiRXUZmvJ0jfllXsnyNSD4XLGaKjlkdbOcJwq4aVCL N2Kl2MLVrItJ190W4+hUmzXrmkgJVourdeiVWibqjlD7hujUMdcPcfRl0NxzN8y1wJLDqOoTvIr eVwM= X-Google-Smtp-Source: AGHT+IGmKISVjZ1O3vFOM7kzrKXNlDMSFRKe0EeOcfydQbEPjEEcL9szec2ra2NF97+lFIbiGm7TIA== X-Received: by 2002:a05:600c:34d3:b0:416:54f5:d315 with SMTP id d19-20020a05600c34d300b0041654f5d315mr5404808wmq.2.1712656944657; Tue, 09 Apr 2024 03:02:24 -0700 (PDT) Received: from carbon-x1.. ([2a01:e0a:999:a3a0:322c:7eda:35fd:4614]) by smtp.gmail.com with ESMTPSA id a20-20020a05600c349400b00416b28651e1sm862972wmq.36.2024.04.09.03.02.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 03:02:23 -0700 (PDT) From: =?utf-8?b?Q2zDqW1lbnQgTMOpZ2Vy?= To: opensbi@lists.infradead.org Subject: [PATCH 3/7] lib: sbi: sse: simplify 32bits overflow check Date: Tue, 9 Apr 2024 12:02:04 +0200 Message-ID: <20240409100216.263256-4-cleger@rivosinc.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240409100216.263256-1-cleger@rivosinc.com> References: <20240409100216.263256-1-cleger@rivosinc.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240409_030235_793935_14B15E77 X-CRM114-Status: GOOD ( 10.97 ) X-Spam-Score: 0.0 (/) X-Spam-Report: =?unknown-8bit?q?Spam_detection_software=2C_running_on_the_sy?= =?unknown-8bit?q?stem_=22bombadil=2Einfradead=2Eorg=22=2C?= =?unknown-8bit?q?_has_NOT_identified_this_incoming_email_as_spam=2E__The_ori?= =?unknown-8bit?q?ginal?= =?unknown-8bit?q?_message_has_been_attached_to_this_so_you_can_view_it_or_la?= =?unknown-8bit?q?bel?= =?unknown-8bit?q?_similar_future_email=2E__If_you_have_any_questions=2C_see?= =?unknown-8bit?q?_the_administrator_of_that_system_for_details=2E?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_preview=3A__Rather_than_checking_32bits_overflow_w?= =?unknown-8bit?q?ith_some_absolute_value=2C?= =?unknown-8bit?q?_check_the_value_to_be_different_from_the_cast_itself=2E_Si?= =?unknown-8bit?q?gned-off-by=3A_Cl=C3=A9ment?= =?unknown-8bit?q?_L=C3=A9ger_=3Ccleger=40rivosinc=2Ecom=3E_Reported-by=3A_Sa?= =?unknown-8bit?q?muel_Holland_=3Csamuel=2Eholland=40sifive=2Ecom=3E?= =?unknown-8bit?q?_---_lib/sbi/sbi=5Fsse=2Ec_=7C_2_+-_1_file_changed=2C_1_ins?= =?unknown-8bit?q?ertion=28+=29=2C_1_deletion=28-=29?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_analysis_details=3A___=280=2E0_points=2C_5=2E0_req?= =?unknown-8bit?q?uired=29?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_pts_rule_name______________description?= =?unknown-8bit?q?_----_----------------------_------------------------------?= =?unknown-8bit?q?--------------------?= =?unknown-8bit?q?_0=2E0_SPF=5FHELO=5FNONE__________SPF=3A_HELO_does_not_publ?= =?unknown-8bit?q?ish_an_SPF_Record?= =?unknown-8bit?q?_-0=2E0_SPF=5FPASS_______________SPF=3A_sender_matches_SPF_?= =?unknown-8bit?q?record?= =?unknown-8bit?q?_-0=2E1_DKIM=5FVALID_____________Message_has_at_least_one_v?= =?unknown-8bit?q?alid_DKIM_or_DK_signature?= =?unknown-8bit?q?_0=2E1_DKIM=5FSIGNED____________Message_has_a_DKIM_or_DK_si?= =?unknown-8bit?q?gnature=2C_not_necessarily_valid?= =?unknown-8bit?q?_-0=2E0_RCVD=5FIN=5FDNSWL=5FNONE_____RBL=3A_Sender_listed_a?= =?unknown-8bit?q?t_https=3A//www=2Ednswl=2Eorg/=2C_no?= =?unknown-8bit?q?_trust?= =?unknown-8bit?b?IFsyYTAwOjE0NTA6NDg2NDoyMDowOjA6MDozMzAgbGlzdGVkIGluXQ==?= =?unknown-8bit?b?IFtsaXN0LmRuc3dsLm9yZ10=?= X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anup Patel , =?utf-8?b?Q2zDqW1lbnQgTMOpZ2Vy?= , Atish Patra Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Rather than checking 32bits overflow with some absolute value, check the value to be different from the cast itself. Signed-off-by: Clément Léger Reported-by: Samuel Holland Reviewed-by: Anup Patel --- lib/sbi/sbi_sse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/sbi/sbi_sse.c b/lib/sbi/sbi_sse.c index d54c125..cd8a539 100644 --- a/lib/sbi/sbi_sse.c +++ b/lib/sbi/sbi_sse.c @@ -344,7 +344,7 @@ static int sse_event_set_attr_check(struct sbi_sse_event *e, uint32_t attr_id, break; case SBI_SSE_ATTR_PRIO: #if __riscv_xlen > 32 - if (val > 0xFFFFFFFFUL) { + if (val != (uint32_t)val) { ret = SBI_EINVAL; break; } From patchwork Tue Apr 9 10:02:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?Q2zDqW1lbnQgTMOpZ2Vy?= X-Patchwork-Id: 1921321 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=aSQybwZx; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=Se7fzuzO; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VDM2v6Mz3z1yZg for ; Tue, 9 Apr 2024 20:02:47 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8xmGJ5anIT8xaJstHuaFNppy6KmNeiBJKUY3BhVdAFE=; b=aSQybwZx7eHi/c x3ylyHk5SCFMT8YGt6R3wT/nwawPHLF2lIvwWY30pokgSyJ9xInLZywzgvs/UGLrKQXcFNLFbke1B zP54WXDlW+BAXbe7dXQijdbb9ear5OCxMsoD8DnXKUYvmG81akLcOqficeie/ptgnbhpJdN0tKb9h /ewOIZJ24/Ez6Jv5tGDdKxTQxo5jSzbzm6O1xUGNg/TJ4u2zh3rWsI9gVLyH5qw9wcOJ9UxiAsrBI nf5gtbKXyx0O+aEyDk0/SIuNqJhnYLFD1FbyINKm9NNVF5a3u5eTSRT4j2EqdJtj4TIirAzIG3Q0e 6eHsrraqPN02fZlN8Srw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru8JN-00000001KVr-1Gn8; Tue, 09 Apr 2024 10:02:41 +0000 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru8JH-00000001KOA-2V9U for opensbi@lists.infradead.org; Tue, 09 Apr 2024 10:02:37 +0000 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-346407b8c9aso47067f8f.0 for ; Tue, 09 Apr 2024 03:02:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1712656946; x=1713261746; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0T1Y+DolFjrh9XxBihhMneWckO0Q7RRmr3/vCxarlf8=; b=Se7fzuzO1KrDMUq6i2fcJ2fy1Qs+LqDXgdQSMK1wL8Iig6/cWSVGuM0kBTizUi3mE9 0v03ypRpQ0/1id6UdCeYGtM0/hLFdKSVnq3+VSKnWXKQWO+wxH+cQYa7Zv00E6tVWLXU 2CIPSeF6C6oZjQZWYDgb/nE5WtExr6sqMCdFTquoGzsTCbzyQ32mnmm73D/9afzZw8ba joGa9QjbA9ChoaRrQS+T97GzhdZ5B7AjcEA0hlSrnvkWv/hqLWBpcRlHNf3p3bDeMU6g X4dKctpsum1e3Smu/H+FRPMmVqWS1nGUw3GM7ubDbegQ1htlFDx+VdnpI9eMme7xow1r AG6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712656946; x=1713261746; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0T1Y+DolFjrh9XxBihhMneWckO0Q7RRmr3/vCxarlf8=; b=ksF1PohExTRebtauZEnGde7DXQ6mph9FS8H3JoFQ1VjZqt64JOzwlEy3vrESXPry6C Aih93wlU6YEb76UQU1sN8IBNV7DCGiXZgkkOUYmYJqh6SEd1bzmmzASNGtdXRPWgdeDA G4KVLBJduDnVXHpSqkg6hpjNzECzekrOg+jJnsSUq3PjK2M2laWPGekXdt6IaZKFhJS+ I2EOBJBfLawcy38reQy9GjvWbbdG/ubBVBRh31ISV1IOVmxqp8hOvoE/d33/+KaOrEB0 2x7Pqu5ZDCfpW6VAKRmbxzDlZy0hhRaS8S3rSkEUBBYcfvJpnlv07zaO7lXoyzsyRAWb oOOQ== X-Gm-Message-State: AOJu0YxsJBCpUfNpcqgCs3B/EQtm8eivmRfytZDte0UJO6rIFIQBXM7Y EIcj85CvVzTAip1CnL95+U4OuWVn7j+HGMfM2YzUbFrs4dJ/h3iL0gpkT0Gz3XvDWY5rpwj0tAz 6quw= X-Google-Smtp-Source: AGHT+IFQVcvscTC1ctAPTU21bg8nae9P+tUAJr+OPpPScD+uLOs3qvdTmfUOKtntoA6bktg0nqAPBg== X-Received: by 2002:a05:600c:5103:b0:416:b4c9:db2e with SMTP id o3-20020a05600c510300b00416b4c9db2emr382397wms.3.1712656946155; Tue, 09 Apr 2024 03:02:26 -0700 (PDT) Received: from carbon-x1.. ([2a01:e0a:999:a3a0:322c:7eda:35fd:4614]) by smtp.gmail.com with ESMTPSA id a20-20020a05600c349400b00416b28651e1sm862972wmq.36.2024.04.09.03.02.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 03:02:24 -0700 (PDT) From: =?utf-8?b?Q2zDqW1lbnQgTMOpZ2Vy?= To: opensbi@lists.infradead.org Subject: [PATCH 4/7] lib: sbi: sse: remove superfluous sbi_list_empty() check Date: Tue, 9 Apr 2024 12:02:05 +0200 Message-ID: <20240409100216.263256-5-cleger@rivosinc.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240409100216.263256-1-cleger@rivosinc.com> References: <20240409100216.263256-1-cleger@rivosinc.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240409_030235_760753_4CE20EDF X-CRM114-Status: UNSURE ( 8.29 ) X-CRM114-Notice: Please train this message. X-Spam-Score: 0.0 (/) X-Spam-Report: =?unknown-8bit?q?Spam_detection_software=2C_running_on_the_sy?= =?unknown-8bit?q?stem_=22bombadil=2Einfradead=2Eorg=22=2C?= =?unknown-8bit?q?_has_NOT_identified_this_incoming_email_as_spam=2E__The_ori?= =?unknown-8bit?q?ginal?= =?unknown-8bit?q?_message_has_been_attached_to_this_so_you_can_view_it_or_la?= =?unknown-8bit?q?bel?= =?unknown-8bit?q?_similar_future_email=2E__If_you_have_any_questions=2C_see?= =?unknown-8bit?q?_the_administrator_of_that_system_for_details=2E?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_preview=3A__The_list_loop_below_that_check_is_actu?= =?unknown-8bit?q?ally_not_looping_if?= =?unknown-8bit?q?_the_list_is_empty_so_there_was_no_need_for_this_check=2E_S?= =?unknown-8bit?q?igned-off-by=3A_Cl=C3=A9ment?= =?unknown-8bit?q?_L=C3=A9ger_=3Ccleger=40rivosinc=2Ecom=3E_Reported-by=3A_Sa?= =?unknown-8bit?q?muel_Holland_=3Csamuel=2Eholland=40sifive=2Ecom=3E?= =?unknown-8bit?q?_---_lib/sbi/sbi=5Fsse=2Ec_=7C_3_---_1_file_changed=2C_3_de?= =?unknown-8bit?q?letions=28-=29_?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_analysis_details=3A___=280=2E0_points=2C_5=2E0_req?= =?unknown-8bit?q?uired=29?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_pts_rule_name______________description?= =?unknown-8bit?q?_----_----------------------_------------------------------?= =?unknown-8bit?q?--------------------?= =?unknown-8bit?q?_-0=2E0_RCVD=5FIN=5FDNSWL=5FNONE_____RBL=3A_Sender_listed_a?= =?unknown-8bit?q?t_https=3A//www=2Ednswl=2Eorg/=2C_no?= =?unknown-8bit?q?_trust?= =?unknown-8bit?b?IFsyYTAwOjE0NTA6NDg2NDoyMDowOjA6MDo0MmUgbGlzdGVkIGluXQ==?= =?unknown-8bit?b?IFtsaXN0LmRuc3dsLm9yZ10=?= =?unknown-8bit?q?_0=2E0_SPF=5FHELO=5FNONE__________SPF=3A_HELO_does_not_publ?= =?unknown-8bit?q?ish_an_SPF_Record?= =?unknown-8bit?q?_-0=2E0_SPF=5FPASS_______________SPF=3A_sender_matches_SPF_?= =?unknown-8bit?q?record?= =?unknown-8bit?q?_-0=2E1_DKIM=5FVALID_____________Message_has_at_least_one_v?= =?unknown-8bit?q?alid_DKIM_or_DK_signature?= =?unknown-8bit?q?_0=2E1_DKIM=5FSIGNED____________Message_has_a_DKIM_or_DK_si?= =?unknown-8bit?q?gnature=2C_not_necessarily_valid?= X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anup Patel , =?utf-8?b?Q2zDqW1lbnQgTMOpZ2Vy?= , Atish Patra Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The list loop below that check is actually not looping if the list is empty so there was no need for this check. Signed-off-by: Clément Léger Reported-by: Samuel Holland Reviewed-by: Anup Patel --- lib/sbi/sbi_sse.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/sbi/sbi_sse.c b/lib/sbi/sbi_sse.c index cd8a539..61d1f78 100644 --- a/lib/sbi/sbi_sse.c +++ b/lib/sbi/sbi_sse.c @@ -578,9 +578,6 @@ void sbi_sse_process_pending_events(struct sbi_trap_regs *regs) spin_lock(&state->enabled_event_lock); - if (sbi_list_empty(&state->enabled_event_list)) - goto out; - sbi_list_for_each_entry(e, &state->enabled_event_list, node) { ret = sse_event_check_inject(e, regs); if (ret) From patchwork Tue Apr 9 10:02:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?Q2zDqW1lbnQgTMOpZ2Vy?= X-Patchwork-Id: 1921320 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=Sd3CkF13; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=BWLYFavl; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VDM2v4Rxkz1yYH for ; Tue, 9 Apr 2024 20:02:47 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AHvsNwWmrZ917AM6eZ/hekGxkHp5dVfjle4qdPOY3i0=; b=Sd3CkF13wR4uVe bfAcVYA5cQROmN+1bhkTfT0DUu92xAZ5n2ktZt45hNJTZ+3F3ypgNaJjBdInCTBitWOZVFFa1t3/A MHDAyXQKDS268+HONwNSfKM4YDvtOjDp9qaT8eD9G5HEWOERIFg43RF7b5W2Rcw9875j/LsRboVYQ nBiz3t0vTvaamtOa1vugtcyJw3IzgDCEc6/JtJZgf2btIqKpSyEDaUrdUNx3o8FkGVbWXDnIeVW72 iSaW+DkksB4RI/i1PX4/Sdq5PsHuhJVMKIuQRALne545ptLr8A6xOg6+dqS/nEQm8LjYFpVdzQBLu NyQ7VVuix8cFhV3TK06A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru8JL-00000001KUL-20e1; Tue, 09 Apr 2024 10:02:39 +0000 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru8JH-00000001KOI-2W4W for opensbi@lists.infradead.org; Tue, 09 Apr 2024 10:02:37 +0000 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-416463e82fbso4177155e9.1 for ; Tue, 09 Apr 2024 03:02:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1712656947; x=1713261747; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wORAhNzS/jwRC4yXYuFPUIy1IRDY3giDhqJ9orTOEVU=; b=BWLYFavl8nH2Xc9aqqcAxbSmNirAPbUSMxHg6sVMiNfsJHElxIncLVPkPQV4gPRYX6 78FfmGyo0iHfPCMhS8UsMN/1zazRUvHOyZCCj0Phq+xWpqE2RHD5Kpq4Rr9x9LAN7W38 Gv+lwF6lCSJKIuhafDhRPwOchaO2navkZ4qenHKvz/Xn4vjtcfOqlUOSJW+ClDvnhd7x Mv6YEpEGq0xmfFYZ3jSqP58m18Jb+HFmn08FW8Mx4KqnrcWT1BqU9kj4VWugBq7KMXlE yZJV89Por5RO6RKYev28d2G2y/H6B7qStub654s/epCFDdoj40jzKnheNzj6xB3droon u4kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712656947; x=1713261747; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wORAhNzS/jwRC4yXYuFPUIy1IRDY3giDhqJ9orTOEVU=; b=TYf+pgr+FZllZDNAOgoJzpCV5dnIG5H/+yI+Jlbn8WzgGb0Cw27yjuuA3QlIgrDJN+ BpFqsngwcMR5wRNHJQ1FGNPL+t+QihbuwHkpNuCcnBOwfDveTTt+nS6gVu8fGZ78OreY mPg4KfDPCafl2WH5KRPOYfyUQPwO5jeQgcuBevLXT969GRfBAsNtgXweAgbOWOuSSiPM ApW1ecfysLZpdmahXILB8V/HVKK9bnCDDxfk4yWVHmOEZ2aezH9aAYKY1zUNy8c4459e ISFBODTyq9RcipYBqIxPE5AMsZg8jzDJ708sDFs+hdoRpa4RymyYWXLcgSkUF89AO4lY Lsew== X-Gm-Message-State: AOJu0YzxxGlKu9ReBljw2ZbkAI4c4ATU5G86ETdZ+zFxV1rt1cAnM6Or y3EfFT1REUJrvnHXigZt1pGNBZzXGlK5ssEfALE8t5tub/3hMZmGq6Uyq5+j9J8Pi6Ankup36hI mHOU= X-Google-Smtp-Source: AGHT+IGzqdhKJlYELF5H6PBfRPNibI2PHfxgkbZC25HEQwBOemjynZvTyspMrshIbOoG7C1B1eBgCw== X-Received: by 2002:a05:600c:3b96:b0:416:7b2c:df09 with SMTP id n22-20020a05600c3b9600b004167b2cdf09mr3433946wms.1.1712656946953; Tue, 09 Apr 2024 03:02:26 -0700 (PDT) Received: from carbon-x1.. ([2a01:e0a:999:a3a0:322c:7eda:35fd:4614]) by smtp.gmail.com with ESMTPSA id a20-20020a05600c349400b00416b28651e1sm862972wmq.36.2024.04.09.03.02.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 03:02:26 -0700 (PDT) From: =?utf-8?b?Q2zDqW1lbnQgTMOpZ2Vy?= To: opensbi@lists.infradead.org Subject: [PATCH 5/7] lib: sbi: sse: call enable callback before sending IPI Date: Tue, 9 Apr 2024 12:02:06 +0200 Message-ID: <20240409100216.263256-6-cleger@rivosinc.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240409100216.263256-1-cleger@rivosinc.com> References: <20240409100216.263256-1-cleger@rivosinc.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240409_030235_765591_826F5A0E X-CRM114-Status: UNSURE ( 9.36 ) X-CRM114-Notice: Please train this message. X-Spam-Score: 0.0 (/) X-Spam-Report: =?unknown-8bit?q?Spam_detection_software=2C_running_on_the_sy?= =?unknown-8bit?q?stem_=22bombadil=2Einfradead=2Eorg=22=2C?= =?unknown-8bit?q?_has_NOT_identified_this_incoming_email_as_spam=2E__The_ori?= =?unknown-8bit?q?ginal?= =?unknown-8bit?q?_message_has_been_attached_to_this_so_you_can_view_it_or_la?= =?unknown-8bit?q?bel?= =?unknown-8bit?q?_similar_future_email=2E__If_you_have_any_questions=2C_see?= =?unknown-8bit?q?_the_administrator_of_that_system_for_details=2E?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_preview=3A__Move_the_enable_callback_call_before_s?= =?unknown-8bit?q?ending_the_IPI=2E_Even?= =?unknown-8bit?q?_though_the_event_is_locked_and_no_race_condition_can_happe?= =?unknown-8bit?q?n=2C_this_is_more?= =?unknown-8bit?q?_logical=2E_Signed-off-by=3A_Cl=C3=A9ment_L=C3=A9ger_=3Ccle?= =?unknown-8bit?q?ger=40rivosinc=2Ecom=3E_Reported-by=3A?= =?unknown-8bit?q?_Samuel_Holland_=3Csamuel=2Eholland=40sifive=2Ecom=3E_---_l?= =?unknown-8bit?q?ib/sbi/sbi=5Fsse=2Ec_=7C_6_+++---?= =?unknown-8bit?q?_1_file_changed=2C_3_insertions=28+=29=2C_3_deletions=28-?= =?unknown-8bit?q?=29_?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_analysis_details=3A___=280=2E0_points=2C_5=2E0_req?= =?unknown-8bit?q?uired=29?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_pts_rule_name______________description?= =?unknown-8bit?q?_----_----------------------_------------------------------?= =?unknown-8bit?q?--------------------?= =?unknown-8bit?q?_-0=2E0_RCVD=5FIN=5FDNSWL=5FNONE_____RBL=3A_Sender_listed_a?= =?unknown-8bit?q?t_https=3A//www=2Ednswl=2Eorg/=2C_no?= =?unknown-8bit?q?_trust?= =?unknown-8bit?b?IFsyYTAwOjE0NTA6NDg2NDoyMDowOjA6MDozMzEgbGlzdGVkIGluXQ==?= =?unknown-8bit?b?IFtsaXN0LmRuc3dsLm9yZ10=?= =?unknown-8bit?q?_0=2E0_SPF=5FHELO=5FNONE__________SPF=3A_HELO_does_not_publ?= =?unknown-8bit?q?ish_an_SPF_Record?= =?unknown-8bit?q?_-0=2E0_SPF=5FPASS_______________SPF=3A_sender_matches_SPF_?= =?unknown-8bit?q?record?= =?unknown-8bit?q?_-0=2E1_DKIM=5FVALID_____________Message_has_at_least_one_v?= =?unknown-8bit?q?alid_DKIM_or_DK_signature?= =?unknown-8bit?q?_0=2E1_DKIM=5FSIGNED____________Message_has_a_DKIM_or_DK_si?= =?unknown-8bit?q?gnature=2C_not_necessarily_valid?= X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anup Patel , =?utf-8?b?Q2zDqW1lbnQgTMOpZ2Vy?= , Atish Patra Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Move the enable callback call before sending the IPI. Even though the event is locked and no race condition can happen, this is more logical. Signed-off-by: Clément Léger Reported-by: Samuel Holland Reviewed-by: Anup Patel --- lib/sbi/sbi_sse.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/sbi/sbi_sse.c b/lib/sbi/sbi_sse.c index 61d1f78..8b448bf 100644 --- a/lib/sbi/sbi_sse.c +++ b/lib/sbi/sbi_sse.c @@ -686,12 +686,12 @@ static int sse_event_enable(struct sbi_sse_event *e) sse_event_set_state(e, SBI_SSE_STATE_ENABLED); sse_event_add_to_list(e); - if (sse_event_pending(e)) + sse_event_invoke_cb(e, enable_cb); + + if (sse_event_is_global(e) && sse_event_pending(e)) sbi_ipi_send_many(1, e->attrs.hartid, sse_ipi_inject_event, NULL); - sse_event_invoke_cb(e, enable_cb); - return SBI_OK; } From patchwork Tue Apr 9 10:02:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?Q2zDqW1lbnQgTMOpZ2Vy?= X-Patchwork-Id: 1921325 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=VQ9coAK1; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=DDO+l+4m; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=lqAoJsut; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VDM357289z1yYH for ; Tue, 9 Apr 2024 20:02:57 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GOKUuLCDNulFv4O2W7NdfFWvd5bj+muzmr3D7JEmuJA=; b=VQ9coAK14KI5cj sHtndw3D6s4LiSVS9MCG7WpaOdYGFBYferhmsY7iP5Qr/qMMo6lNOjdjbqMXaFiz4pEPXnPdz5qAU zQahH7VJl58IIjZNnPd0E/pwSH1opEiNMyQmZHFju2uPP4rHUtzf9Hxm99yHX9yGcuUOQbGjDdJTD R9aTI5LCKIUofm6yO9QQyijBUcJIqc1X7V2QWj+BwqYlLLRIq3yn71fbTzHBsyUvm4xc71CT0gPNs U2XEF05I8iTHm3PQkgAKhqCfmZ+rlrj0hc+n5cKb+sirOb9lteSWxJrJY8rPckVtcPx3QwZRwYkKW juKT5HRSXOsebo46bjRQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru8JX-00000001Kej-1sJJ; Tue, 09 Apr 2024 10:02:51 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru8JU-00000001Kbs-2WJw for opensbi@bombadil.infradead.org; Tue, 09 Apr 2024 10:02:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=R7ruEtQMANmW+UOE58KcUBbuDPbCoF0zM1TVYqRBJAM=; b=DDO+l+4mtshKCfG2KoOjeO7l5g G8EZ/SdYc1GBDWmtN8WVLSy2MonkY+K1Ld3LsFGFx1/VJOLFB0ss8ZUj30AD55S0/4ZSDiuZtZnLs l6ExQnZJcl+aDE8JyBln7f5OuHX1Y1DGiYvCPw91qqQmv0Mzw3VokGgKZAt7lB8NKy0W+hKmzbS+j Wpm9lwij4K03rW9frnARC/tSoKvsefw3KmejkJVRdT9XTY4XYQcgAk46U2JxOlxX+kRsfFFdg2cY4 IvWMrP6Z0dhOVLKDJDJpMMYiFN+vdS8frL6QG/yqmVffFOy5Ju+56kpxsijNegPUw7djiN8Ez3bpU vK2ghfeA==; Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru8JP-00000007XLS-34PK for opensbi@lists.infradead.org; Tue, 09 Apr 2024 10:02:46 +0000 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-4167739a11bso394095e9.1 for ; Tue, 09 Apr 2024 03:02:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1712656948; x=1713261748; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=R7ruEtQMANmW+UOE58KcUBbuDPbCoF0zM1TVYqRBJAM=; b=lqAoJsutQhFBW8TewevKHISH2fkxlDu8/rSwkdiqBN5tio67cnKbckl+2YLeh8OXvd Sw+xcKqJzdMPiCkh240M/cB/GfmpD+TuRA0kYU9sUY4aJ45S7jLeNpF4zZ28EsDdFeb8 QcX12nRjniP4/gv8OsPOVnac7Ugr9Hj5pN7oac3bhqadyriDPnmmnRPUB9BwGDk/ByIH bkjd/lGav01IkqCtt/58W87tvDWLrUCvZc1nVzyg+brsRV8IzCBw5RPaU00JbvbNwhll wgZFZOgPHHel6yfApnyqbrSGrUIAnwOHyfMacgUR+PKdgqtPnEaocs9j395BcEHbPVIf qA5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712656948; x=1713261748; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=R7ruEtQMANmW+UOE58KcUBbuDPbCoF0zM1TVYqRBJAM=; b=THIQhIq6CGmfCDwTw/v/MH2tBhUbH9AlEci0/dggjVSqiobHQDQtB7kvrcRMtsYZVC LTeKDbXt/F01kLIAk0M+UbBSnHUbq83OKSOS79kan8MKbHakdEhze5TIV+6j/jUPkDiS +QtpjVW76TB7bOTivx1rUVsW6a5zOCZL0Cuophij3wd81+iC9Re/XasBh0LnTdD8SbIO IHGsIZez4neT9izrD/S/uNAZSYWjScfyDZlfW9TxzZSB/ZFu3GrXPCCjpz/BFipC+VVT o5+43QjGXckP59pZpxS8Uvuyku58roeRVQzNXQOG53zlk4r8/GZHTgYc4OumS2x9qtLV hjkg== X-Gm-Message-State: AOJu0Yz2nFOEag/2uMMcGEpbL0/uJJBjEd4qnc+zIm/A+1q6rWXYZyB3 b6qo5EaPVzo3IRMIP0O5YGoqfv2gpxsd7//DJX2u2eDDfIdKHsEsrUYvoRawzad1b5SehL1aVEb 0Tfw= X-Google-Smtp-Source: AGHT+IH/Q42Y8bOeJUkVxw9Zb8HXlfi87Cgf4v+Ae2ry0wX4Oy1yucIHuCMpePif2IhQ5oZQppu+Hg== X-Received: by 2002:a05:600c:198f:b0:416:b9c3:c691 with SMTP id t15-20020a05600c198f00b00416b9c3c691mr9684wmq.4.1712656947813; Tue, 09 Apr 2024 03:02:27 -0700 (PDT) Received: from carbon-x1.. ([2a01:e0a:999:a3a0:322c:7eda:35fd:4614]) by smtp.gmail.com with ESMTPSA id a20-20020a05600c349400b00416b28651e1sm862972wmq.36.2024.04.09.03.02.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 03:02:27 -0700 (PDT) From: =?utf-8?b?Q2zDqW1lbnQgTMOpZ2Vy?= To: opensbi@lists.infradead.org Subject: [PATCH 6/7] lib: sbi: sse: use PRV_S instead of hardcoded value for mode Date: Tue, 9 Apr 2024 12:02:07 +0200 Message-ID: <20240409100216.263256-7-cleger@rivosinc.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240409100216.263256-1-cleger@rivosinc.com> References: <20240409100216.263256-1-cleger@rivosinc.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240409_110244_189279_6572F661 X-CRM114-Status: UNSURE ( 8.93 ) X-CRM114-Notice: Please train this message. X-Spam-Score: 0.0 (/) X-Spam-Report: =?unknown-8bit?q?Spam_detection_software=2C_running_on_the_sy?= =?unknown-8bit?q?stem_=22desiato=2Einfradead=2Eorg=22=2C?= =?unknown-8bit?q?_has_NOT_identified_this_incoming_email_as_spam=2E__The_ori?= =?unknown-8bit?q?ginal?= =?unknown-8bit?q?_message_has_been_attached_to_this_so_you_can_view_it_or_la?= =?unknown-8bit?q?bel?= =?unknown-8bit?q?_similar_future_email=2E__If_you_have_any_questions=2C_see?= =?unknown-8bit?q?_the_administrator_of_that_system_for_details=2E?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_preview=3A__Rather_then_passing_1_to_sbi=5Fdomain?= =?unknown-8bit?q?=5Fcheck=5Faddr=5Frange=28=29_for?= =?unknown-8bit?q?_supervisor_mode=2C_use_PRV=5FS=2E_Signed-off-by=3A_Cl=C3?= =?unknown-8bit?q?=A9ment_L=C3=A9ger_=3Ccleger=40rivosinc=2Ecom=3E?= =?unknown-8bit?q?_---_lib/sbi/sbi=5Fsse=2Ec_=7C_4_++--_1_file_changed=2C_2_i?= =?unknown-8bit?q?nsertions=28+=29=2C_2_deletions=28-=29?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_analysis_details=3A___=280=2E0_points=2C_5=2E0_req?= =?unknown-8bit?q?uired=29?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_pts_rule_name______________description?= =?unknown-8bit?q?_----_----------------------_------------------------------?= =?unknown-8bit?q?--------------------?= =?unknown-8bit?q?_0=2E0_SPF=5FHELO=5FNONE__________SPF=3A_HELO_does_not_publ?= =?unknown-8bit?q?ish_an_SPF_Record?= =?unknown-8bit?q?_-0=2E0_SPF=5FPASS_______________SPF=3A_sender_matches_SPF_?= =?unknown-8bit?q?record?= =?unknown-8bit?q?_0=2E1_DKIM=5FSIGNED____________Message_has_a_DKIM_or_DK_si?= =?unknown-8bit?q?gnature=2C_not_necessarily_valid?= =?unknown-8bit?q?_-0=2E1_DKIM=5FVALID_____________Message_has_at_least_one_v?= =?unknown-8bit?q?alid_DKIM_or_DK_signature?= =?unknown-8bit?q?_-0=2E0_RCVD=5FIN=5FDNSWL=5FNONE_____RBL=3A_Sender_listed_a?= =?unknown-8bit?q?t_https=3A//www=2Ednswl=2Eorg/=2C_no?= =?unknown-8bit?q?_trust?= =?unknown-8bit?b?IFsyYTAwOjE0NTA6NDg2NDoyMDowOjA6MDozMzMgbGlzdGVkIGluXQ==?= =?unknown-8bit?b?IFtsaXN0LmRuc3dsLm9yZ10=?= X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anup Patel , =?utf-8?b?Q2zDqW1lbnQgTMOpZ2Vy?= , Atish Patra Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Rather then passing 1 to sbi_domain_check_addr_range() for supervisor mode, use PRV_S. Signed-off-by: Clément Léger Reviewed-by: Anup Patel --- lib/sbi/sbi_sse.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/sbi/sbi_sse.c b/lib/sbi/sbi_sse.c index 8b448bf..85137c2 100644 --- a/lib/sbi/sbi_sse.c +++ b/lib/sbi/sbi_sse.c @@ -837,8 +837,8 @@ int sbi_sse_attr_check(uint32_t base_attr_id, uint32_t attr_count, return SBI_EINVALID_ADDR; if (!sbi_domain_check_addr_range(sbi_domain_thishart_ptr(), phys_lo, - sizeof(unsigned long) * attr_count, 1, - access)) + sizeof(unsigned long) * attr_count, + PRV_S, access)) return SBI_EINVALID_ADDR; return SBI_OK; From patchwork Tue Apr 9 10:02:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?Q2zDqW1lbnQgTMOpZ2Vy?= X-Patchwork-Id: 1921323 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=rDYBB/6C; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=itnejEM+; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VDM2z2t6Kz1yYH for ; Tue, 9 Apr 2024 20:02:51 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X6Y0DZ8gXi+OKxDTOWsP+h1/eILryvfAYrNScMIb6ec=; b=rDYBB/6Czen496 T2ITtn6xMhWe753HwVDcQJAtfOyBjnpTpAmTvrDpgfsdPsP7piQTeoXViUbYuH+e/tkhN4G7J5JGM RbE8Ii9tGfQqkpLQV7+zMXe+VZA3CrOHCmmKYYYvaFS5VvRKjnOgcfzQmK6U3Iggk8ZZgrfXNUPXO DAW+QK3TaRn12H19Y3HVX0rD+XVcg3HELgWwPIRkd6TwUSoNYP4jjL/cvy5Ezf2N+TP6X0a29WC68 qUPpNci89DJwpEqZVVs8B/RgnjBGZUbHLgJaZ5DCQn4EUAw/iptut/xwPSxfGDSArsb1sTaP0i7f2 4quungj70xQ8LiCd7Jrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru8JR-00000001KZC-0d5N; Tue, 09 Apr 2024 10:02:45 +0000 Received: from mail-wr1-f50.google.com ([209.85.221.50]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru8JH-00000001KPU-2asT for opensbi@lists.infradead.org; Tue, 09 Apr 2024 10:02:38 +0000 Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-34560201517so623504f8f.1 for ; Tue, 09 Apr 2024 03:02:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1712656949; x=1713261749; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nQuNxHzEf4hr+JBIDmx3DrbTSwDj6VZpTrpjj7OdJ9s=; b=itnejEM+WaLGb7O27q7+77DTO8m7ltszHc3232EqJLm3bn58KIFMHAbhC8/SwahJAP T/qQLundqs0kwFWr8+TVyJOl3twX1tk1MfalZF7I76ULsbF9b65mrHaRiVNNP9IXB3mu 0bYrNnf44WZPP4RDn4KwmyjvC/P/VH78qWZWtPASMJnilWcpsv/wswmksYf0U1MAuiqe JVyzCnFmRP8OJQ+jat6i8aU2CMgMvxj/eMbv09ZMV0rmXyTz8iA7LKaZKYVElgEvVTfl i+oZjSUPHdlhnLjQ9lrZUr204Tu3uo2RNbx17NqejleJAi4IuMf3F+GlN++x945siHOC Xr/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712656949; x=1713261749; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nQuNxHzEf4hr+JBIDmx3DrbTSwDj6VZpTrpjj7OdJ9s=; b=fJvDqj0KyVtqAx0ITB17sUeGNmAzSeb9w6MSRJuNBy3ByEkxY66owzpmht7Km9HO09 MUm7s9tm/rGsCsKVuyi9T91PYqnf+mTNjZa+gV/t1bhxhqQCnmgzTP3sRyLUnV4Oy2BG msDdHv2MSaOQaHmnOSdB7JWoFNGmsMxmksO8GO011eNRUhUuL07TmR7G+bg0Ud3EcePz FKkqAtb4JtGlS6JLzj4XZJVNxnOTK8i7ogBwPMV5nfAvsK5xWvY5dsQIm4HeZTlO+hJh gxErScCoGrzvJk6WNMJtpPo02w/q7o9KhBI5QRhQiPou7W7ywxLvYRAR+G//48YxuMQP 1wgg== X-Gm-Message-State: AOJu0YxS3ov/Zo6J2t3asBwv+FpqtXuUJsQKVXAp1X8EEGeKIhvzD5V6 4qVhecv4Rr3Oerzpw4JZvIyrA2int1drjvmDa14vaRHsIoGMlnexOnSl942fyJUnDF214Pw7MiE lHb4= X-Google-Smtp-Source: AGHT+IHOyl4DvXMM0h5B0Rm1Q8zSSGiwCja/qGjdbkF6l/2cRJApXAxFaD6bHl9ChBQNnie4O/eglQ== X-Received: by 2002:a05:600c:198f:b0:416:b9c3:c691 with SMTP id t15-20020a05600c198f00b00416b9c3c691mr9750wmq.4.1712656949291; Tue, 09 Apr 2024 03:02:29 -0700 (PDT) Received: from carbon-x1.. ([2a01:e0a:999:a3a0:322c:7eda:35fd:4614]) by smtp.gmail.com with ESMTPSA id a20-20020a05600c349400b00416b28651e1sm862972wmq.36.2024.04.09.03.02.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 03:02:28 -0700 (PDT) From: =?utf-8?b?Q2zDqW1lbnQgTMOpZ2Vy?= To: opensbi@lists.infradead.org Subject: [PATCH 7/7] lib: sbi: sse: check handler entry to belong to supervisor mode Date: Tue, 9 Apr 2024 12:02:08 +0200 Message-ID: <20240409100216.263256-8-cleger@rivosinc.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240409100216.263256-1-cleger@rivosinc.com> References: <20240409100216.263256-1-cleger@rivosinc.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240409_030235_828098_A2F8D4C9 X-CRM114-Status: UNSURE ( 8.46 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.0 (/) X-Spam-Report: =?unknown-8bit?q?Spam_detection_software=2C_running_on_the_sy?= =?unknown-8bit?q?stem_=22bombadil=2Einfradead=2Eorg=22=2C?= =?unknown-8bit?q?_has_NOT_identified_this_incoming_email_as_spam=2E__The_ori?= =?unknown-8bit?q?ginal?= =?unknown-8bit?q?_message_has_been_attached_to_this_so_you_can_view_it_or_la?= =?unknown-8bit?q?bel?= =?unknown-8bit?q?_similar_future_email=2E__If_you_have_any_questions=2C_see?= =?unknown-8bit?q?_the_administrator_of_that_system_for_details=2E?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_preview=3A__When_registering_an_SSE_event=2C_check?= =?unknown-8bit?q?_for_the_handler=5Fentry=5Fpc?= =?unknown-8bit?q?_to_belong_to_supervisor_mode_domain_using_sbi=5Fdomain=5Fc?= =?unknown-8bit?q?heck=5Faddr=5Frange=28=29=2E?= =?unknown-8bit?q?_Signed-off-by=3A_Cl=C3=A9ment_L=C3=A9ger_=3Ccleger=40rivos?= =?unknown-8bit?q?inc=2Ecom=3E_Reported-by=3A_Samuel_Holland?= =?unknown-8bit?q?_=3Csamuel=2Eholland=40sifive=2Ecom=3E_---_lib/sbi/sbi=5Fss?= =?unknown-8bit?q?e=2Ec_=7C_6_++++++_1_file_changed=2C?= =?unknown-8bit?q?_6_insertions=28+=29_?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_analysis_details=3A___=28-0=2E0_points=2C_5=2E0_re?= =?unknown-8bit?q?quired=29?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_pts_rule_name______________description?= =?unknown-8bit?q?_----_----------------------_------------------------------?= =?unknown-8bit?q?--------------------?= =?unknown-8bit?q?_-0=2E0_RCVD=5FIN=5FDNSWL=5FNONE_____RBL=3A_Sender_listed_a?= =?unknown-8bit?q?t_https=3A//www=2Ednswl=2Eorg/=2C_no?= =?unknown-8bit?q?_trust?= =?unknown-8bit?q?_=5B209=2E85=2E221=2E50_listed_in_list=2Ednswl=2Eorg=5D?= =?unknown-8bit?q?_-0=2E0_RCVD=5FIN=5FMSPIKE=5FH2______RBL=3A_Average_reputat?= =?unknown-8bit?q?ion_=28+2=29?= =?unknown-8bit?q?_=5B209=2E85=2E221=2E50_listed_in_wl=2Emailspike=2Enet=5D?= =?unknown-8bit?q?_0=2E0_SPF=5FHELO=5FNONE__________SPF=3A_HELO_does_not_publ?= =?unknown-8bit?q?ish_an_SPF_Record?= =?unknown-8bit?q?_-0=2E0_SPF=5FPASS_______________SPF=3A_sender_matches_SPF_?= =?unknown-8bit?q?record?= =?unknown-8bit?q?_-0=2E1_DKIM=5FVALID_____________Message_has_at_least_one_v?= =?unknown-8bit?q?alid_DKIM_or_DK_signature?= =?unknown-8bit?q?_0=2E1_DKIM=5FSIGNED____________Message_has_a_DKIM_or_DK_si?= =?unknown-8bit?q?gnature=2C_not_necessarily_valid?= X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anup Patel , =?utf-8?b?Q2zDqW1lbnQgTMOpZ2Vy?= , Atish Patra Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org When registering an SSE event, check for the handler_entry_pc to belong to supervisor mode domain using sbi_domain_check_addr_range(). Signed-off-by: Clément Léger Reported-by: Samuel Holland Reviewed-by: Anup Patel --- lib/sbi/sbi_sse.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lib/sbi/sbi_sse.c b/lib/sbi/sbi_sse.c index 85137c2..8724f76 100644 --- a/lib/sbi/sbi_sse.c +++ b/lib/sbi/sbi_sse.c @@ -959,6 +959,12 @@ int sbi_sse_register(uint32_t event_id, unsigned long handler_entry_pc, if (handler_entry_pc & 0x1) return SBI_EINVAL; + if (!sbi_domain_check_addr_range(sbi_domain_thishart_ptr(), + handler_entry_pc, + sizeof(unsigned long), PRV_S, + SBI_DOMAIN_EXECUTE)) + return SBI_EINVALID_ADDR; + e = sse_event_get(event_id); if (!e) return SBI_EINVAL;