From patchwork Sat Apr 6 12:31:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marc Dietrich X-Patchwork-Id: 1920393 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=gmx.de header.i=marvin24@gmx.de header.a=rsa-sha256 header.s=s31663417 header.b=XHcUZVa2; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2604:1380:40f1:3f00::1; helo=sy.mirrors.kernel.org; envelope-from=linux-tegra+bounces-1499-incoming=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org [IPv6:2604:1380:40f1:3f00::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VBZV731hjz1yYy for ; Sat, 6 Apr 2024 23:31:43 +1100 (AEDT) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 12203B214CB for ; Sat, 6 Apr 2024 12:31:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C27841E52A; Sat, 6 Apr 2024 12:31:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.de header.i=marvin24@gmx.de header.b="XHcUZVa2" X-Original-To: linux-tegra@vger.kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 636122B9B1; Sat, 6 Apr 2024 12:31:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.19 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712406698; cv=none; b=VcMfSUvUkJHJWASBTZ7zgveuUPPZqY2UgA2LSRdEXJ0tJoTy/CElQSxzoefWPqQkXCsA+j/UOwiFWHfEENPWvXCSTZvVbud3VS5d35ycn9Y9jy7HLRwUGCTmsRRqQle9IXJ4CDStaK81wSnhCfmojKbgOHsQpVhGx3/5XHwoGwQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712406698; c=relaxed/simple; bh=7esloikEOlCjR6lSKP6kwfl6x7P4OR1CJJRXemyk9pA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Tcoa3WBq2GUFPxtEAUnd0cGBEz3hG+hmvoKAG98/mbMnOkV/5Io+ZkM1T+c2u+wgznwVXMLF/x2X/7ldGlDGV8dtaauQB11xCjq2Ks2eB3HEf/L+8VCtlhgnkYd4C9T1FhUBtmy01rDOfcXJZnd2qd8FW+jCAD6sM6wUh6G3rmw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de; spf=pass smtp.mailfrom=gmx.de; dkim=pass (2048-bit key) header.d=gmx.de header.i=marvin24@gmx.de header.b=XHcUZVa2; arc=none smtp.client-ip=212.227.15.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1712406691; x=1713011491; i=marvin24@gmx.de; bh=y2Pd4sJ0wVJhVwOZ/lckuMsvsyUk7C/yT45pxyRJf+I=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=XHcUZVa2+JCuhoKxbM0EitpWlm+7ojuDcVuHGzsClCxBS4MN8A9K5M8t5cO0mQ/c 9H9udv6eg+XSaZrsUerUXuybX21ViWaCnnShhC0cLIlzzBRBtM2A8VCwFhuHVLwXT f4RVtYsQhhjo92XNMvHBJqB+EtzRXz/eXBql4jFP1AAjJ5ZBYroM3IEf1bY1ypaKr QAKS0ZJJ1DzXyqonv26hKieOhIGSDPrJnWd1E477fp6SZkt1CWkOKcVT1tQiR5cFH r5IFK6ICazYUJcqhG9f3xu3vTEMaaAqupqkXPBgWrXQxn8uOnb/r8CLYh8HuP0WyV cq356qNjUCYrQr/nsg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from n5219w05.fritz.box ([109.250.53.83]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N6sn7-1srzS82kcZ-018K6n; Sat, 06 Apr 2024 14:31:31 +0200 From: Marc Dietrich To: linux-staging@lists.linux.dev Cc: linux-tegra@vger.kernel.org, gregkh@linuxfoundation.org, thierry.reding@gmail.com, dan.carpenter@linaro.org, Marc Dietrich Subject: [PATCH 1/5] staging: nvec: add ability to ignore EC responses in sync writes Date: Sat, 6 Apr 2024 14:31:19 +0200 Message-ID: <20240406123123.37148-2-marvin24@gmx.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240406123123.37148-1-marvin24@gmx.de> References: <20240406123123.37148-1-marvin24@gmx.de> Precedence: bulk X-Mailing-List: linux-tegra@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:XS0aOK44tsPpKgaciXK7X20/Fq2UZNMTAXWB4jeKxS8c8txvDTy knyW8evAq1IzLojR+Sfqj3cLp1EoVA9tm6RPUy9XEKG0SbF72U1Puf/NESQ8JASMjEZz1TV rsAXA064P7LTpuC53WfI19kHpwH+GDvZx+xZBg74KphmfdBe/Rr9ZE7MVNhCsd1hcWfI92y Kocc36RHjnCjGjEiRnnSQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:CHWLOaj5IYY=;75SixANPSCHxmHRDY7bO5FAPbpn VDBtJxFnsENQvDz4NCRyS1VQAMA3npiLwZ3SpXRe1HU3ABqCVPlMjjCoTVKgXvzotbST+4lCH 5MRgxPsu+hA1D1wCtpXmuW44dYzsTjRxYfyyEFFxPeHH+NJahaqnIiDkFbMpMi6jPd45hJUvg crIXpcWo/KUY/BQtBj1AObSLd4wFldhB8x4Vx5vCnaJx8UrqNoKJldUdAT1Ay6lXax0X2cj+X EdUmJcK/PtuwRrtS3s2JAKS3Vv0b4mE2+yAs8sHbDdcdcEa7x30sQ4z5Y/wbjnUoJBhDO2q4Y U2s/ef4SL7Y60btSsjvvslsUo0xwtbb4avVuC4GvUYIMnTApCB1fuOlJyf34AwdIqllu1qiux Al4KyJl1iwzQXVDrMNIy5JG1YN8+KCkeYaPttMdOyOZteQDPJlWAXE6EjzHbJuzvH2iDu3KaY yJ0p3ERpmbIr7OR36jmEH1SVIaom+CuJUbfM7rDRQAvhp4Hozb0C+JuS106iFe/CGSKiysC1Y YOi4oEQSzUk6rwN4z6rt+U6wRnPORl21JDRx5HmoHWlN3Lqf6dGZjDU/mcVEdgesTj0+Idg6v yVFShN9Avu7DTivix5b9I6O3wgNO6MNHzu7h4kht8BdO9h+m8dmC/Rm/14lk2CCy7MC08oD09 U8VUMTtAUCmmqcZ2WrRw0Ad+tCPenWY8cYmEw2N5c115aunwtebwIwSkio490XH8pwTGXnddh EaCVwbtekWm06TG3It64U/dy3iOe7JOGkNRB8V9Q8pM7Lo2EacEV/TjKgliZYFxOZ06DR2DCS u01Jkn8+o7+10Cfi90ayzKqnntrVgghX99NImUys0B5ZE= In case we just want to submit a message to the EC but are not interested in its response, we can free the response buffer early. Signed-off-by: Marc Dietrich --- drivers/staging/nvec/nvec.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) -- 2.43.0 diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c index 282a664c9176..45df190c2f94 100644 --- a/drivers/staging/nvec/nvec.c +++ b/drivers/staging/nvec/nvec.c @@ -300,7 +300,9 @@ int nvec_write_sync(struct nvec_chip *nvec, { mutex_lock(&nvec->sync_write_mutex); - *msg = NULL; + if (msg != NULL) + *msg = NULL; + nvec->sync_write_pending = (data[1] << 8) + data[0]; if (nvec_write_async(nvec, data, size) < 0) { @@ -320,7 +322,10 @@ int nvec_write_sync(struct nvec_chip *nvec, dev_dbg(nvec->dev, "nvec_sync_write: pong!\n"); - *msg = nvec->last_sync_msg; + if (msg != NULL) + *msg = nvec->last_sync_msg; + else + nvec_msg_free(nvec, nvec->last_sync_msg); mutex_unlock(&nvec->sync_write_mutex); From patchwork Sat Apr 6 12:31:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marc Dietrich X-Patchwork-Id: 1920396 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=gmx.de header.i=marvin24@gmx.de header.a=rsa-sha256 header.s=s31663417 header.b=eYTwZLMI; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2604:1380:45d1:ec00::1; helo=ny.mirrors.kernel.org; envelope-from=linux-tegra+bounces-1503-incoming=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org [IPv6:2604:1380:45d1:ec00::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VBZVB0hH3z1yYy for ; Sat, 6 Apr 2024 23:31:45 +1100 (AEDT) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 348AB1C20DF0 for ; Sat, 6 Apr 2024 12:31:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 151D02E64C; Sat, 6 Apr 2024 12:31:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.de header.i=marvin24@gmx.de header.b="eYTwZLMI" X-Original-To: linux-tegra@vger.kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E54F09445; Sat, 6 Apr 2024 12:31:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712406699; cv=none; b=rgIhGrDujmoO2xfxazV6bpsbgB7j27mABycUOYawbpfG/dwzRYIwyxBSrrD873q9ymmIZGp0lKshnA6/YJ+rh6NZKzqlCpoIGrCWnxEsifcRSmzivNSG5wOG2S3lry4KDLmXngOxhRLLZEvc2v1m8VbQjKNjzWaYq6jPX2/Tq/k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712406699; c=relaxed/simple; bh=e109PeeQY7ZkK9ns8M7H81yb1RyzVLkWxLAiSRGQzCA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aCCk6LaoNfWJjA/jnu728V4eJXytBaea0xjY6ui5KRlH6wsUyYMjTy8Bo5s9ecoKC+Cb3e65b89rXkkq0byGKAjqnazaebq0fTszEctmqjnHyujfY6P37AITpalhQX/3hF/KCOlIdO8EUAHrsxUaoIi3peHU3dOW0bcF7f/ljq0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de; spf=pass smtp.mailfrom=gmx.de; dkim=pass (2048-bit key) header.d=gmx.de header.i=marvin24@gmx.de header.b=eYTwZLMI; arc=none smtp.client-ip=212.227.15.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1712406692; x=1713011492; i=marvin24@gmx.de; bh=YOMRQLk+64/GEb58pUDoVWXe+lIe5RngdF3c37ZYiRk=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=eYTwZLMIHI46A6pFuFlgDCEQvjL45Y/xXY79fpx5nNJupDpUfbUqgTWQjJ5E54IJ /4HYdSM9aEr7DWqhU9+pcGo7bDA3eZy4tafF2tC6FvZ5MDoh8inaInp6evUZadWT8 BSY/fUyTSOLjm3ExFC1HLljgluLC97LG7rSmZZEaUCscgWZdkN+D4B/JZ7SHI4eTt mtO0h8TLroXCzklwqRaSXf03k/VrFW1SZ6aoz4c3zXmewPrtv43Qzw8aWEc5OfKqz 7WtXmfSnvFz7IL2M8U6GGI9+tXMLmj8Z0FZr/2Js0H72stM1olqyAHxUJLPencEFT T7DdVOomD3E8paHExw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from n5219w05.fritz.box ([109.250.53.83]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MHG8g-1rxXBD3c6y-00DJwQ; Sat, 06 Apr 2024 14:31:31 +0200 From: Marc Dietrich To: linux-staging@lists.linux.dev Cc: linux-tegra@vger.kernel.org, gregkh@linuxfoundation.org, thierry.reding@gmail.com, dan.carpenter@linaro.org, Marc Dietrich Subject: [PATCH 2/5] staging: nvec: make keyboard init synchronous Date: Sat, 6 Apr 2024 14:31:20 +0200 Message-ID: <20240406123123.37148-3-marvin24@gmx.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240406123123.37148-1-marvin24@gmx.de> References: <20240406123123.37148-1-marvin24@gmx.de> Precedence: bulk X-Mailing-List: linux-tegra@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:SjKeThz53C/GTxuuiUNzkvMaJfiPuLspShHGtg8GNJWImL+nGWi dVHJJEz99khIKuykvKWu5Be+bdTQi6TNKd6Pk7Ps5N6135V/RCGGs7XZpTN6gHC7KerHnEj 8AQ5eUKvWoK1ffdMhA+Uoz/2o/tmNcUEZw1T9B4b71Fz+Am7qJb9kMuSJgF1lkqRSch6Wg3 lAKoTkuO2PP2BUGOFKyzA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:lhhkze1z5x8=;6p0Fb2gIpjKO6eLK+4UMzvu1Led lNarYsz0jZlavCuQklzJGEhgP393YDiUNJb+hPeMckI4wGeJ4YVz5s710ZkSuoNwmwMhGz3JH gAH7VibmJy6Yi8u4Bi9ISlgQQS3oSN5ZfyzL8AgayG6ZkcPh7bz/pzBoIfcSOY1zKgBvgtS8b m8J9kfgEi2g5Swkq9O684djTO4bMr2BUvPP8kE3XOLTHi1uAMYHmX7ZyJk/EGiREv+09ZvdQC spFwx/i3J8KgmGryCWLlYeJ3pmNJjOvUo0asUqJmYHD4sgc9lXGesd4TXbSAjMS1o+arr7qVz H0gnNH+lE7ebmxoVLKv5H21vjjA5yDvk4bMElMjMuLteD+BzOSdKqjdb2KcyIAjP1LlK7ArxZ N8oa4L9GFX+HRbjgo1DG/3knQJ+0QpDZlVvAOLa5foWGaFPQGPUkws+K/jcj4BDdwPwFEDh7m +SRQd20Wf4KelAucqMAMpfDFzCanxp1xoUZwXXzkJawFc6Zsop5nKxtuZflWCQt1mq+g2KnY0 11e1WSzrcfmVvx/emWcLap87KivanZpEeJCr7PabbNWbZHlRsvYE2qxDKI+dh5mgbIpC1/qTA V1ZAZ0n+JTduHFsxokhPE4FgTbYPQ6Sc4G/Sk95HiJ0MDmg1e5y9QuQckBdK1vEkt5n7wKi6Q 6qwYCR+oapj5UmSxnrCj2fZTktlrdTFsqZfOA6zFNOKLwCDiT4m2xoeuoc/Z1I9uaWl6Mrmg4 FRCGbM7beAaqEVnxcZdNMJXpNyhFVnLS/ZSYhovBdBYlj8+MpyfAiPCIM7G2fbOhDGJuDFQrX /a9ppDSH3GR4Z5ezGXCnXkdj+y7Rvf1fyGhP3Y3qT7u6k= Currently, we are constantly sending commands to the EC without waiting for them to be executed. This can lead to confusion, especially if we initialize several different devices one after the other. To avoid this, we are switching from asynchronous to synchronous command transmission. Signed-off-by: Marc Dietrich --- drivers/staging/nvec/nvec_kbd.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) -- 2.43.0 diff --git a/drivers/staging/nvec/nvec_kbd.c b/drivers/staging/nvec/nvec_kbd.c index f9a1da952c0a..d0259c80f810 100644 --- a/drivers/staging/nvec/nvec_kbd.c +++ b/drivers/staging/nvec/nvec_kbd.c @@ -148,15 +148,16 @@ static int nvec_kbd_probe(struct platform_device *pdev) nvec_register_notifier(nvec, &keys_dev.notifier, 0); /* Enable keyboard */ - nvec_write_async(nvec, enable_kbd, 2); + nvec_write_sync(nvec, enable_kbd, 2, NULL); /* configures wake on special keys */ - nvec_write_async(nvec, cnfg_wake, 4); + nvec_write_sync(nvec, cnfg_wake, 4, NULL); + /* enable wake key reporting */ - nvec_write_async(nvec, cnfg_wake_key_reporting, 3); + nvec_write_sync(nvec, cnfg_wake_key_reporting, 3, NULL); /* Disable caps lock LED */ - nvec_write_async(nvec, clear_leds, sizeof(clear_leds)); + nvec_write_sync(nvec, clear_leds, sizeof(clear_leds), NULL); return 0; } From patchwork Sat Apr 6 12:31:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Marc Dietrich X-Patchwork-Id: 1920398 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=gmx.de header.i=marvin24@gmx.de header.a=rsa-sha256 header.s=s31663417 header.b=nq0YVb8u; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2604:1380:45d1:ec00::1; helo=ny.mirrors.kernel.org; envelope-from=linux-tegra+bounces-1504-incoming=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org [IPv6:2604:1380:45d1:ec00::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VBZVB5PjLz1yZH for ; Sat, 6 Apr 2024 23:31:46 +1100 (AEDT) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id D7AD41C20DC9 for ; Sat, 6 Apr 2024 12:31:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 369C09445; Sat, 6 Apr 2024 12:31:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.de header.i=marvin24@gmx.de header.b="nq0YVb8u" X-Original-To: linux-tegra@vger.kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 635F3652; Sat, 6 Apr 2024 12:31:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.19 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712406700; cv=none; b=ppF3NahQGhauGBwCn7UgYQeCCLywcTeLf5K6SYjRzHMHGXVNg38lFAJO6aAgNCQXOIE8UQhvZlksPcW8LOx3kytHfaLory2pp8XlvacqhG8p2APZRWYJwq6V6xbaHDSDcIGxeFrcfxxMjYUj6TkC3i8tq59WfOJdk1K6zepSH04= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712406700; c=relaxed/simple; bh=z/2B8L75ElAdlZu9/d5OQo4+Ma+flVQgNOWf1kdi3TU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TyjoGBvndsHSK1jRGqpQShiqMwm23iOHIdAGfMSnPy44kLLpUIiAqnG+SGn2MilClT9C0LVjZeeL8QCuuTkMLWC8QiDhUFg6RostNpIBeGFxXiDauGlMW9oFsmQK79bWeBh4ClCTGoaXJ+J194UV3RstHaKqgall32G2aGFBHzw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de; spf=pass smtp.mailfrom=gmx.de; dkim=pass (2048-bit key) header.d=gmx.de header.i=marvin24@gmx.de header.b=nq0YVb8u; arc=none smtp.client-ip=212.227.15.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1712406692; x=1713011492; i=marvin24@gmx.de; bh=ySJVgxfVsG9tqUI9Cc53ih2r48axjGHjrzWApTXISgg=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=nq0YVb8uxoYTO/bnFH4rgPi79Tq4rDI6ZVCnY0bjJlABSmquls4ou8x6C0E4ns1f JFVE88akYSckKG5QA0MPO0z2Y5Oazvk62QEoHyRINnravFYNg1smrV49tRQULj8zz byr9eb9BRCd3oBb/B53SKvvuptQwZGSVKAGWEyABIoe2E/8GcCXea//ASVRJZOjp0 zwbFOkssS4rt46oKrcFtRQK33UlQZLMIcsQTOfMccQl9okqf+qwLEHaqIivlV2h8Y F0GMsFU7nDQKUjpivBaLGPo1DSW8ninoXTzFuRQfvCsrOdbdi15+pKtvlaQEwwGSR D/qQ6lpTvHQH+Zg2kA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from n5219w05.fritz.box ([109.250.53.83]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MXp5a-1sINS40Ojs-00YAD8; Sat, 06 Apr 2024 14:31:32 +0200 From: Marc Dietrich To: linux-staging@lists.linux.dev Cc: linux-tegra@vger.kernel.org, gregkh@linuxfoundation.org, thierry.reding@gmail.com, dan.carpenter@linaro.org, Marc Dietrich Subject: [PATCH 3/5] staging: nvec: make touchpad init synchronous Date: Sat, 6 Apr 2024 14:31:21 +0200 Message-ID: <20240406123123.37148-4-marvin24@gmx.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240406123123.37148-1-marvin24@gmx.de> References: <20240406123123.37148-1-marvin24@gmx.de> Precedence: bulk X-Mailing-List: linux-tegra@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:A48dcqQpIxD+tNmxEf6Ktc+3AdevQkFGzMugU0qYIRf2jTbSXAB ADrdeQQZO/26raQfyi8VRU9x6Vjv+Q/vaLamctxewuLnvwEx5k7rCrG/ljTVsuMA8YX69sV kmJu4IDEPAsSCIvyMaymDQ7e6VMKeIff1snISYu22E/2iClBygDBFcx1p/6leOgIWeCVKxz h4nE+myyack8+ecijOK8A== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:IOUV+YS+9ig=;+avWqWeBCzXjhGfi9lEu+jZZy13 RRvAu5K9qNiMLrjMVJSMFksB8CDuFgPB52lI6N1HDgVVm+ynlRmIbnwQz0DzT1nidUgoIHVUx lQy1tGgCn1677BQPpOWk1+L6pbxt9YL6cwuhs9FmaMveAct9eY2RsvE1IhkO5WVsBi5sG0Tdn YoBEvIqHcJh63TT0AlC5+rDUlDfdfUqQ4mMKvgZRi+ioFnxJY+SVz2BFupyodFkWUhA0SkIfk 530SfMAsb4rGOgCbDJETQcqgsX/qmjqqilaX4whsqoccmgaVLc/sowutYl1gkOGZjct5s6c8+ mIZzfl7DzLHdlsbP3oepYFL2fPEc/UcTIDWozkxQGi8wwHTdj49VU1GUhr5gx16Jam815bRsY H2LB8tOaaUWskn1+QdURLemoktBq/Iuv2SEw2YWVKzV4YZJ126GDZUCjO5GqEAPkQ5RpFb+8X ndYxlzqzYE6kAZyi9uyZ2elehiRuG6zzNN+9Ab+q5PAfYbooCgu3vs5/QMtvcDe+A8LYBjkMR as5f5239aiy0k6krCy94B7sbgGusfBo0uK5clklw+rYj/8vP/DlOogH5mQUP2rJgiNf7r9Zbi ETzbdjjdlCKl8DZBE0EopYiNXYHh68XJJpmXxpMrdpJARXhPR+rMypOJ03+Aa3chv0AzcdL4y G+W13ifsg+XpPqqn0bHvRxTEAwve/4a15vRMDES61BVfLZfZZD1PYA15Utj+o9PPKj5EhDuVU k86X1AuO32uiIaqjNKzsCu2mjfti/x04fv3kQYz0a6C/HO4qmD2jaXMeRwJiRpbxyeaPXK7g1 vmYklPMVTBYnW1kQe1tN4UREvevwrY0RmNNMCvvTBHQAg= Currently, we are constantly sending commands to the EC without waiting for them to be executed. For the touchpad initialization this only worked because we were waiting 200 µs between each submitted command byte, so the EC had enough time to execute. In the furture we like to avoid this delay, so we need to wait for each command to be executed first. Do this by switching from asynchronous to synchronous command transmission. Signed-off-by: Marc Dietrich --- drivers/staging/nvec/nvec_ps2.c | 31 +++++++++++++++++++++---------- 1 file changed, 21 insertions(+), 10 deletions(-) -- 2.43.0 diff --git a/drivers/staging/nvec/nvec_ps2.c b/drivers/staging/nvec/nvec_ps2.c index cb6d71b8dc83..f34016c4a26b 100644 --- a/drivers/staging/nvec/nvec_ps2.c +++ b/drivers/staging/nvec/nvec_ps2.c @@ -60,16 +60,6 @@ static void ps2_stopstreaming(struct serio *ser_dev) nvec_write_async(ps2_dev.nvec, buf, sizeof(buf)); } -static int ps2_sendcommand(struct serio *ser_dev, unsigned char cmd) -{ - unsigned char buf[] = { NVEC_PS2, SEND_COMMAND, ENABLE_MOUSE, 1 }; - - buf[2] = cmd & 0xff; - - dev_dbg(&ser_dev->dev, "Sending ps2 cmd %02x\n", cmd); - return nvec_write_async(ps2_dev.nvec, buf, sizeof(buf)); -} - static int nvec_ps2_notifier(struct notifier_block *nb, unsigned long event_type, void *data) { @@ -98,6 +88,27 @@ static int nvec_ps2_notifier(struct notifier_block *nb, return NOTIFY_DONE; } +static int ps2_sendcommand(struct serio *ser_dev, unsigned char cmd) +{ + unsigned char buf[] = { NVEC_PS2, SEND_COMMAND, ENABLE_MOUSE, 1 }; + struct nvec_msg *msg; + int ret; + + buf[2] = cmd & 0xff; + + dev_dbg(&ser_dev->dev, "Sending ps2 cmd %02x\n", cmd); + + ret = nvec_write_sync(ps2_dev.nvec, buf, sizeof(buf), &msg); + if (ret < 0) + return ret; + + nvec_ps2_notifier(NULL, NVEC_PS2, msg->data); + + nvec_msg_free(ps2_dev.nvec, msg); + + return 0; +} + static int nvec_mouse_probe(struct platform_device *pdev) { struct nvec_chip *nvec = dev_get_drvdata(pdev->dev.parent); From patchwork Sat Apr 6 12:31:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marc Dietrich X-Patchwork-Id: 1920395 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=gmx.de header.i=marvin24@gmx.de header.a=rsa-sha256 header.s=s31663417 header.b=gw4mezeK; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2604:1380:45e3:2400::1; helo=sv.mirrors.kernel.org; envelope-from=linux-tegra+bounces-1502-incoming=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org [IPv6:2604:1380:45e3:2400::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VBZV90SfNz1yZH for ; Sat, 6 Apr 2024 23:31:44 +1100 (AEDT) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 5351C28279F for ; Sat, 6 Apr 2024 12:31:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B42332DF92; Sat, 6 Apr 2024 12:31:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.de header.i=marvin24@gmx.de header.b="gw4mezeK" X-Original-To: linux-tegra@vger.kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 446E82C6B0; Sat, 6 Apr 2024 12:31:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.19 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712406699; cv=none; b=qjHn0PusPDKD51z+lzr2uezXiz0qrceak6bKJveRx0xl9KhTIbP7OCL/RVo1hzNLYoKdcz2DfHjOr9GNUe/qv2MbBtZw6xGbKIdEujpAUOc0y9ZS7KUUtVImnlWCT2ObZK0PaHxIqeFDiSas8/AiwAaO8O3wninQW6j77/2E2CM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712406699; c=relaxed/simple; bh=SM/pSeREcZxRJBymGBgr2b/gAtaWPSkVvJa2VB2F504=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=j7ksOd3Cl5Y03WW9GCb2zmYLs1s9e/J/5M4t6Sq1II55ce2nb5q7YFE8ND/JqNRWzFOggQfPIz7XOrmk+vbS8O8d42JJnVJ7Fe8Cicy1xkEr5vZFxLvoFanOpudPJS8z0sB2I+eGbCNHYuA83pLc1w6UFE/8WhfYDv5T9bpHjHM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de; spf=pass smtp.mailfrom=gmx.de; dkim=pass (2048-bit key) header.d=gmx.de header.i=marvin24@gmx.de header.b=gw4mezeK; arc=none smtp.client-ip=212.227.15.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1712406692; x=1713011492; i=marvin24@gmx.de; bh=HS2Lxlwc46+n1BOtuy4NlhsXKSmp87WkMscTM0DvPJ4=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=gw4mezeKNttoWaGgh7SBmNGLtKXuTR9Jezf4zjzgCgWbRuXy4xTx80S11ejxB0Zw aj4OP4BzgudTclEYwpInNWzQ4oHk1tpzVLa4IDiuIkmkHCM0d3F6QD3N0qQDhMwC8 Xfc1TcDiEyMggrbdwiwLeFYQpkb3cGGu3iKl79t7LYAUx7PoJhs8nOxWvaBWjN/By rY2DiCop8bSOHmwL9OxvGM6H7UIDUdwEyOFCgkOqspZYsWrwR+JCYB+sDIThr0wwh 6AMFDjcxg6wdwQoX1hZXyhA2EmYRJ6zom+N6TDR9JPZFiGmYyh1dI1s/Gi21LzWta u/I83xmujAAg5N7ktQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from n5219w05.fritz.box ([109.250.53.83]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MvK4Z-1sjfrJ1DRB-00rDEB; Sat, 06 Apr 2024 14:31:32 +0200 From: Marc Dietrich To: linux-staging@lists.linux.dev Cc: linux-tegra@vger.kernel.org, gregkh@linuxfoundation.org, thierry.reding@gmail.com, dan.carpenter@linaro.org, Marc Dietrich Subject: [PATCH 4/5] staging: nvec: make i2c controller register writes robust Date: Sat, 6 Apr 2024 14:31:22 +0200 Message-ID: <20240406123123.37148-5-marvin24@gmx.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240406123123.37148-1-marvin24@gmx.de> References: <20240406123123.37148-1-marvin24@gmx.de> Precedence: bulk X-Mailing-List: linux-tegra@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:h1WTYvTjzxoB5q61KOXyDiiVqBrlmiXQZANtfZwu39QmUOF3v55 qjeVVc5/dW9P1+GTFmv2atmAgTJFQgsZQa3BOKGVdUcZLwNDmaGwruWAzcIV9Fj45F3u6kU 23/fg+V+PTU5Ix0+VupNAVfGl6IL6wwzuTD5+KHvABrbzctw4utBRUq5GFJypKa19FT+FoX VhzMOwLpyRopxqdJ0looQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:ZyQciNQTkNk=;tnP6u4U3H2T2QjimPhga7DDuMd5 rtjyanzeuq/EcRDAxKR+GbwxEPROP9UIeDdl8oGbLRgoBdMcFvKzjlgq2P+OBLcqm/VbvaDaR tJaJUuoyNOm0bsk6KUQ4sN4NTKrF5LP+EARkQyKW05ggwH4a5zHtZntCCZE8yGh8LQFklJjRE 9JpnMY1I+31uZ43CV+KKptE9pfbEzyB1Pfz99aHqtq+pH7O3y26xyf/RX+IP34t3inWuPL/Fe 9EGBj3oHC0u/CpKjuUf/I14F1Ix2eAERU2k4vIByasKWpnRa250jnuF82zrY8OuDklc9Wqan/ E4CtpmuQj+gdlGQXMxLLzdKjDdim8tmgBHKEW9q1IGbl9Rye4IBEDnUdmOAyti6kwC9OQvB0x eJUL4jbkfTfjEhGVYYYGG5R4aEraMnsYwK2xqE6ZLcVxcVrEmza4u2WQTiNri0MY41RutPBIL 1op7Jm7ywoPUP9OEiuAO6WJLBoHD1bLFf+5SPjxLns3jw0CcY+bj6PCNv617chD4pSwTjnAQF /Yc3ITHAZe5PtS20OvJJfael/xKbqphjP6zD5k7lP5xJkZkAiY2N5lW5p6w61cNulX50rGwC2 sHQ3v4tqHix3CD3ML04BqL9TsukQ1NYS2zSEDhX4x8GzC0hR+UXwlXYqPCIhTmxGUvG1WoeWT FKWtWe/Y/uxOBlm8ZvkujYEhl4O76bdGvNypUF2JzXZ9Nqh7fINGoacfBC1ahmKfohLuIemPY 8LpJujxGwk/wKDRNCvOWnd1fQWYhHOVIWzsUAcBsIV2HG93nxUfIs6yG5fRimJE26wGGpkdrw BbFgytIfr9PCdt3TILn5wyr7ONJH3lai1z+NaBEV0qAyc= The i2c controller needs to read back the data written to its registers. This way we can avoid the long delay in the interrupt handler. Signed-off-by: Marc Dietrich --- drivers/staging/nvec/nvec.c | 41 ++++++++++++++++++++++--------------- 1 file changed, 24 insertions(+), 17 deletions(-) -- 2.43.0 diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c index 45df190c2f94..214839f51048 100644 --- a/drivers/staging/nvec/nvec.c +++ b/drivers/staging/nvec/nvec.c @@ -570,6 +570,22 @@ static void nvec_tx_set(struct nvec_chip *nvec) (uint)nvec->tx->size, nvec->tx->data[1]); } +/** + * i2c_writel - safely write to an I2C client controller register + * @val: value to be written + * @reg: register to write to + * + * A write to an I2C controller register needs to be read back to make sure + * that the value has arrived. + */ +static void i2c_writel(u32 val, void *reg) +{ + writel_relaxed(val, reg); + + /* read back register to make sure that register writes completed */ + readl_relaxed(reg); +} + /** * nvec_interrupt - Interrupt handler * @irq: The IRQ @@ -604,7 +620,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev) if ((status & RNW) == 0) { received = readl(nvec->base + I2C_SL_RCVD); if (status & RCVD) - writel(0, nvec->base + I2C_SL_RCVD); + i2c_writel(0, nvec->base + I2C_SL_RCVD); } if (status == (I2C_SL_IRQ | RCVD)) @@ -696,7 +712,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev) /* Send data if requested, but not on end of transmission */ if ((status & (RNW | END_TRANS)) == RNW) - writel(to_send, nvec->base + I2C_SL_RCVD); + i2c_writel(to_send, nvec->base + I2C_SL_RCVD); /* If we have send the first byte */ if (status == (I2C_SL_IRQ | RNW | RCVD)) @@ -713,15 +729,6 @@ static irqreturn_t nvec_interrupt(int irq, void *dev) status & RCVD ? " RCVD" : "", status & RNW ? " RNW" : ""); - /* - * TODO: replace the udelay with a read back after each writel above - * in order to work around a hardware issue, see i2c-tegra.c - * - * Unfortunately, this change causes an intialisation issue with the - * touchpad, which needs to be fixed first. - */ - udelay(100); - return IRQ_HANDLED; } @@ -737,15 +744,15 @@ static void tegra_init_i2c_slave(struct nvec_chip *nvec) val = I2C_CNFG_NEW_MASTER_SFM | I2C_CNFG_PACKET_MODE_EN | (0x2 << I2C_CNFG_DEBOUNCE_CNT_SHIFT); - writel(val, nvec->base + I2C_CNFG); + i2c_writel(val, nvec->base + I2C_CNFG); clk_set_rate(nvec->i2c_clk, 8 * 80000); - writel(I2C_SL_NEWSL, nvec->base + I2C_SL_CNFG); - writel(0x1E, nvec->base + I2C_SL_DELAY_COUNT); + i2c_writel(I2C_SL_NEWSL, nvec->base + I2C_SL_CNFG); + i2c_writel(0x1E, nvec->base + I2C_SL_DELAY_COUNT); - writel(nvec->i2c_addr >> 1, nvec->base + I2C_SL_ADDR1); - writel(0, nvec->base + I2C_SL_ADDR2); + i2c_writel(nvec->i2c_addr >> 1, nvec->base + I2C_SL_ADDR1); + i2c_writel(0, nvec->base + I2C_SL_ADDR2); enable_irq(nvec->irq); } @@ -754,7 +761,7 @@ static void tegra_init_i2c_slave(struct nvec_chip *nvec) static void nvec_disable_i2c_slave(struct nvec_chip *nvec) { disable_irq(nvec->irq); - writel(I2C_SL_NEWSL | I2C_SL_NACK, nvec->base + I2C_SL_CNFG); + i2c_writel(I2C_SL_NEWSL | I2C_SL_NACK, nvec->base + I2C_SL_CNFG); clk_disable_unprepare(nvec->i2c_clk); } #endif From patchwork Sat Apr 6 12:31:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marc Dietrich X-Patchwork-Id: 1920397 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=gmx.de header.i=marvin24@gmx.de header.a=rsa-sha256 header.s=s31663417 header.b=WfoZX8Yu; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2604:1380:4601:e00::3; helo=am.mirrors.kernel.org; envelope-from=linux-tegra+bounces-1500-incoming=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from am.mirrors.kernel.org (am.mirrors.kernel.org [IPv6:2604:1380:4601:e00::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VBZVB0k3cz1yZM for ; Sat, 6 Apr 2024 23:31:46 +1100 (AEDT) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 17B431F219E6 for ; Sat, 6 Apr 2024 12:31:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E63B32869B; Sat, 6 Apr 2024 12:31:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.de header.i=marvin24@gmx.de header.b="WfoZX8Yu" X-Original-To: linux-tegra@vger.kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91CD02B9B8; Sat, 6 Apr 2024 12:31:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712406698; cv=none; b=cg4A55pVFStRwnQpGIDi4kgqKJxWa+HKSclwcyvqWrF3DbfIRtV2j/BMNVCaeJw8Usb/0UiGHPhb3hHLE6dvSci5vIVJYS7BFIjuVBSzDa/OvSUFqDXZHG+x/rWkPtEkHC3H5Y0A2crY18oWwHRLQhps1J5LHMPhMarpOHgiOC4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712406698; c=relaxed/simple; bh=sFlm1yr8QHBMC+fbR1n42X3cTsM+zkDTCoOOBneR5W8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bEwWn35LhFNUXxcghGjFbBbjLaBKQwoXxBiH7e+7DgGBP3omIMAZ+gOKgSEcCearpJwOim9xpN+J7JpgUrsEpMzJVVifwL59cJrJWzCwTGX2PWKHfJil6cFrfmSvzp8gwrQLEAjpOFWYI6u8PmnqSoGJaRYiOJflCGRPivV28Hc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de; spf=pass smtp.mailfrom=gmx.de; dkim=pass (2048-bit key) header.d=gmx.de header.i=marvin24@gmx.de header.b=WfoZX8Yu; arc=none smtp.client-ip=212.227.15.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1712406692; x=1713011492; i=marvin24@gmx.de; bh=T9RmlrBoBBqGuJ6qhTMJOlWL9+8tVpgg41ahOo+E5Wk=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=WfoZX8Yuiv1sOM6Rj2Gtj7hITQAraQ8mMtqszRQHSrlkHqzpXDtr5MmNtTyK3CvJ yFARnsQf66ci7iOGj25nRQvq/p5ukcqOXvewhWkVM1IeAwtaOwb7NcAJkppOppi+3 Q76UdsKtJnXzI5wQz3XHTXrfWY9yS8ZqkpFf7kmcM/4GHmHFYojAnvKPdVX05m5qi KvxRxAivIJg0Wlg55/rgl1XLDrM+xyH6FGF6w2DDzjHkCmjrKNXPLaxc5uS9Kfy+j G4SfoX7a1n+CCUoY8jQXokcxkkvNvQSdQBxlaLxqsg6htHEDyg4sGJKgqx8ok+VTC 9C9K621qRcnGfUVcrQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from n5219w05.fritz.box ([109.250.53.83]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M8hZD-1roQVh2Bvd-004lMx; Sat, 06 Apr 2024 14:31:32 +0200 From: Marc Dietrich To: linux-staging@lists.linux.dev Cc: linux-tegra@vger.kernel.org, gregkh@linuxfoundation.org, thierry.reding@gmail.com, dan.carpenter@linaro.org, Marc Dietrich Subject: [PATCH 5/5] staging: nvec: update TODO Date: Sat, 6 Apr 2024 14:31:23 +0200 Message-ID: <20240406123123.37148-6-marvin24@gmx.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240406123123.37148-1-marvin24@gmx.de> References: <20240406123123.37148-1-marvin24@gmx.de> Precedence: bulk X-Mailing-List: linux-tegra@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:FhvmhrI96KdwIBa23m9XyyBai3ylAXNxJcnCEB6hR8gW4WnhHsR 3BAojpp6mczKaSbLQX3Ps3NImIeo0eRbdiN/7UHfRAQt5ySC67/ZwUiTh4PHkRfGzD+892z o5YcpdctxB0TKzVAEaVJ8AYerhr0C/x8/84xSaTkrnM57MfOPdNYDbWoTAjq6UyS7RUFWf8 OMD4bLvegjOe5Eg7Jkd+g== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:uephw+Fw0KI=;+LgL7JZpvW8Xn7C0/+XZTgstq+f 4j8PkujKzRme66yBbfPoVfXwabvu5j3XcivbX90EQ7zG2TNSMn84RdO5R8Q+o19kyIOwGUPht 6B8USdbP1uXcsJ4hL2XaL0ExOg90XWPoK16msmDDCN215VVAyNB0oPZj17Z6r7Aie1El5GBiJ w7h0WetBAkLkQIE/Af6tIJsG5QevKLZ88/VVKO7j/0V983MVueRumbqxquxlDN981i2pzLbzl syUkHTfSZduznGnalgbHlpmGDftX0np/wqBA07qFfAbN9uVF8Oy70iIbB7a4HR9AjBKPxYFFx v2z2zgrANs6j2RCUr+lRKvBaBUKakmoPzR93B+3VooYWLD49IBXYjFHOUaS3uL1tAA62Qe+s6 /GJSSNUMhEO6Gpnzp9czDD4NTp1qqaEMQDH3e+yAWcD3Dtwut3iS6QgrXTkSKFq4dSCS1eYkX WRkTAzVYEOenqrBVZnOnZD2zKX4QKh2Y68W558fvFDwtc9IdW+MS3NlynqS5Q2WOVodU6AjR9 /DwNxc4JQOn7r1OeFRzmM7Iqg4Xvw29JKwOMPFx8KaRXLxkLIlkLoVzqzOdaFpzsFii0IoCIk oAszt40j+rBrbyRqUwVkD6OVacKIF5iGSi4vnUeQWsG+/Kqx1LPfP2htXeZyuRfVrZzhxJwrm AXRJoaCN5xUrJ94uO/Ti3/vulsiJRXsZB/CQnmWuuQuI6fX7UeAuhERtNmO0hl1+LhLAN7HzO 3Bq0iLmyR3oaXcJlY1A3J6L9Qd7owGgT0giEnVFF7HqKEaLlWAMTiTx2z02itbTvHqBFXbDqB +qi4DcEJJoE74dYWSJXNF/+vVo/PUcb8eZ95VwJj/+0m4= Remove isr delay from the bill. Signed-off-by: Marc Dietrich --- drivers/staging/nvec/TODO | 1 - 1 file changed, 1 deletion(-) -- 2.43.0 diff --git a/drivers/staging/nvec/TODO b/drivers/staging/nvec/TODO index 8afde3ccc960..33f9ebe6d59b 100644 --- a/drivers/staging/nvec/TODO +++ b/drivers/staging/nvec/TODO @@ -1,5 +1,4 @@ ToDo list (incomplete, unordered) - move the driver to the new i2c slave framework - finish suspend/resume support - - fix udelay in the isr - add atomic ops in order to fix shutoff/reboot problems