From patchwork Wed Mar 13 06:37:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?0JTQuNC70Y/QvSDQn9Cw0LvQsNGD0LfQvtCy?= X-Patchwork-Id: 1911536 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (4096-bit key; secure) header.d=aegee.org header.i=dkim+sm-localhost@aegee.org header.a=rsa-sha256 header.s=k4096 header.b=jYJkcGaM; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Tvgn06lz4z1ydl for ; Wed, 13 Mar 2024 17:37:54 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1DA353858021 for ; Wed, 13 Mar 2024 06:37:50 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail.aegee.org (mail.aegee.org [144.76.142.78]) by sourceware.org (Postfix) with ESMTPS id 52A7B3858D1E for ; Wed, 13 Mar 2024 06:37:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 52A7B3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=aegee.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=aegee.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 52A7B3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=144.76.142.78 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710311850; cv=none; b=WQHzQn51GfeTWDiUelU6mRbyFhEgYDQ9tXlseiBzDezxFyUWXs38R0QjpEnhlhJ7dK6zwxqeW7TbbtHI1Natc93lER9y5hJoxndj7K4e9MMFRq06TPOrCl8pLddGG7mykqLV92rs69si5SHi6I8AItWgmDnpi97tmN5nxY9u8kQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710311850; c=relaxed/simple; bh=oCY0vXyvmP/jtbHx6XOz+zl6X+oiL4+vOAhYDSau1yo=; h=DKIM-Signature:MIME-Version:Date:From:To:Subject:Message-ID; b=csXkYeShVXtyw6BjdUcCvzn7pjwNKs3Nn5PfGKJpgkTo7okE9j0yZBMrTTmoIs4eCqUXBv+FdwJbw/IQ/NOcj8DydeNBcPgwcIWedQ7S4OihL3YIyOvtMWS5ZQ2W3sjT4VlZ1vgNg9S3fc279GVPbuERkCbti6M64bjwRSIJC2U= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from webmail.aegee.org (localhost [127.0.0.1]) by mail.aegee.org (8.18.1/8.18.1) with ESMTP id 42D6bQnt2570319 for ; Wed, 13 Mar 2024 06:37:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aegee.org; s=k4096; t=1710311846; i=dkim+sm-localhost@aegee.org; bh=oCY0vXyvmP/jtbHx6XOz+zl6X+oiL4+vOAhYDSau1yo=; h=Date:From:To:Subject; b=jYJkcGaM/ced5+1KtmqZIHdqsU5sDMLkCun/dhY0+pExchIgJEnqJ7+B1kZbVzanW OLYqEunbb2P7tYMwI5RLnGMujUSU2XZhvbIYKiiYuT05Yygr0Cda6BWxwDmGhH0SMd g7oCP8LlCnfQ6N4GVVO/Psd6uMFGw1LdmPhwENmwt4SJKoGQhHDhFiswcijptwqzVS JfkYqqtWnXZ5UowZdOkNUiVDp60JKbHel8nMbr586+xdg4KYcHFqkWaAl/E8ES3LMy VFtTVXqJOq0ZWBDEzmIIHf55WjJ/oyyHvnmrrJvuXDTvdE/NbLntztjlw4oWrqIhSw 3db8Ton8spAijWpbO+TiWxtvkfX/sWTh6ScPcHH/7vWhPV58vFmXzUlAbtBtVseUV3 wfFfruxnDSBs/zkB7J1QvcjcQ4lnRSB9xJy7BProCEwt/OpD39Yc4dSyd8fbXXidSg bKsR89MRz/g5fi9j5HvAlef52Dpovoam9Ii5tcRPH37um17EWiyaCtrnar6Oe70QfX pXK5TfX2K6UDNXJAJSKd0YOdpeEPcluiyiKpBcESWJ6oeq9sNKjfa1dx5fktMTrc1L AjYkIwTnU2E5PYLyARu7QpfQnyYWv0B7K5/4tYTNwadlPQdrdROpSOI5Zgu8Q6T6LY JHr3OWSTVGoD4R+AefynYiJU= Authentication-Results: mail.aegee.org/42D6bQnt2570319; dkim=none MIME-Version: 1.0 Date: Wed, 13 Mar 2024 07:37:26 +0100 From: =?utf-8?b?0JTQuNC70Y/QvSDQn9Cw0LvQsNGD0LfQvtCy?= To: gcc-patches@gcc.gnu.org Subject: No rule to make target '../libbacktrace/libbacktrace.la', needed by 'libgo.la'. [PR106472] Message-ID: X-Sender: dilyan.palauzov@aegee.org X-Spam-Status: No, score=-14.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, SPF_HELO_PASS, SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Non-parallel build can fail, depending on the ./configure parameters - https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106472 . The change below does fix the problem. I do not understand the build system to say, that this is the best approach, so if there are questions I might or might not be able to answer them. I tried different things, this worked on the releases/gcc-13 branch. On the master branch last weekend the problem was that stage2 and stage3 results are not equal, so I have not verified this change there. depend= in Makefile.def seem to have only effect if bootstrapping is involved and gcc/go/config-lang.in does not have boot_language=yes . The lines below are present in the Makefile.in:@unless gcc-bootstrap snippet. Actually I think ./configure --enable-languages=all and then serial build work, because this implied D and it does imply bootstrapping for libbacktrace and libatomic. I also do not want to invest much more time on this. I do not know, if 2×`maybe-` is necessary. ENDFOR dependencies +]@endif gcc-bootstrap diff --git a/Makefile.in b/Makefile.in index 06a9398e172..236e5cda942 100644 --- a/Makefile.in +++ b/Makefile.in @@ -66481,6 +66481,7 @@ configure-target-libgfortran: maybe-all-target-libquadmath @if gcc-bootstrap +all-target-libgo: maybe-all-target-libbacktrace maybe-all-target-libatomic configure-gnattools: stage_last configure-libcc1: stage_last configure-c++tools: stage_last diff --git a/Makefile.tpl b/Makefile.tpl index dfbd74b68f8..98160c7626b 100644 --- a/Makefile.tpl +++ b/Makefile.tpl @@ -1952,7 +1952,7 @@ configure-target-[+module+]: maybe-all-gcc[+ (define dep-maybe (lambda () (if (exist? "hard") "" "maybe-"))) - ;; dep-kind returns returns "prebootstrap" for configure or build + ;; dep-kind returns "prebootstrap" for configure or build ;; dependencies of bootstrapped modules on a build module ;; (e.g. all-gcc on all-build-bison); "normal" if the dependency is ;; on an "install" target, or if the dependence module is not @@ -2017,6 +2017,7 @@ configure-target-[+module+]: maybe-all-gcc[+ [+ ESAC +][+ ENDFOR dependencies +] @if gcc-bootstrap +all-target-libgo: maybe-all-target-libbacktrace maybe-all-target-libatomic [+ FOR dependencies +][+ CASE (dep-kind) +] [+ == "postbootstrap" +][+ (make-postboot-dep) +][+ ESAC +][+