From patchwork Mon Mar 11 07:49:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 1910343 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=E7v86tOJ; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TtTWx6h6Xz1yWy for ; Mon, 11 Mar 2024 18:52:29 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DE3683861024 for ; Mon, 11 Mar 2024 07:52:27 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id C7BF43856975 for ; Mon, 11 Mar 2024 07:52:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C7BF43856975 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C7BF43856975 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710143529; cv=none; b=gs6QXTFTxatfqPz/jcOZ9tO9HlfIHP99w9bnWonAnlE8Vn1nR5NyWLr2igzOZjXa75y0x7GiO3AfzL/7DmqJOmlLEReRqBGtXlyctmX3AsKyWsnjhv2Dha/s+JwRR4krtFWYk8UpIJTEmNbrpiwozlzI9fJv4mfMDl7IBrHSJ1E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710143529; c=relaxed/simple; bh=MrtZXhrpfYbzC9gAk3xkKg/UoUjo3CcaiBpUiTsw9ZA=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=Ke6YhqjLpyXhgu0CGF0sHsn72cYVpcEkdBLwZ9+Jfc052wS3CuaeQKTDDxNsdxzjkxu2EpgR8b3x5Ct9qysRl8aY5Q8tHLP6dp8uFCtfgcL6cZ875D3xfK9q7xf8/Q4YUNfkEx0l5TDadP30KDPjal93Vkq33qXRKmxze7oHTA4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710143526; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vmp3OrAXNmyft1Vn4zKWrsFaAAH1zKJLidOztG6mtj0=; b=E7v86tOJaDisgpTwvJoBN45KN/7ZOdzP93QCPqI8fBXocQCpSFKV4SUB9Aeo87cNfMkE3n 7/Wtn5eVC1gSQrA0H5A0i+JCSTRh3P517GxmSxWHoAQbmWvRggF3j6vfPsp7QidWtoYcxL 31YuukoPhOo0GzsaFeGSlLcV3pD/MwA= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-428-GyBSlBYDOhyIX97NCJVkdQ-1; Mon, 11 Mar 2024 03:52:02 -0400 X-MC-Unique: GyBSlBYDOhyIX97NCJVkdQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4F8803CBD4E4; Mon, 11 Mar 2024 07:52:02 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.45.225.36]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 14CC12166B4F; Mon, 11 Mar 2024 07:52:01 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 42B7nxWF224993 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 11 Mar 2024 08:51:56 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 42B7nYiM224992; Mon, 11 Mar 2024 08:49:34 +0100 Date: Mon, 11 Mar 2024 08:49:29 +0100 From: Jakub Jelinek To: Richard Biener Cc: gcc-patches@gcc.gnu.org Subject: [PATCH] bitint, v2: Avoid rewriting large/huge _BitInt vars into SSA after bitint lowering [PR114278] Message-ID: References: <75DCD6B5-A571-46F4-B735-F5C9DE2F0949@suse.de> MIME-Version: 1.0 In-Reply-To: <75DCD6B5-A571-46F4-B735-F5C9DE2F0949@suse.de> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Jakub Jelinek Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org On Sat, Mar 09, 2024 at 12:25:42PM +0100, Richard Biener wrote: > Ideally we’d clear TREE_ADDRESSABLE but set DECL_NOT_GIMPLE_REG, > I think the analysis where we check the base would be a more > appropriate place to enforce that. So like this? Bootstrapped/regtested on x86_64-linux and i686-linux. 2024-03-11 Jakub Jelinek PR tree-optimization/114278 * tree-ssa.cc (maybe_optimize_var): If large/huge _BitInt vars are no longer addressable, set DECL_NOT_GIMPLE_REG_P on them. * gcc.dg/bitint-99.c: New test. Jakub --- gcc/tree-ssa.cc.jj 2024-01-03 11:51:39.902615009 +0100 +++ gcc/tree-ssa.cc 2024-03-09 23:34:12.469223987 +0100 @@ -1785,6 +1785,20 @@ maybe_optimize_var (tree var, bitmap add fprintf (dump_file, "\n"); } } + else if (TREE_CODE (TREE_TYPE (var)) == BITINT_TYPE + && (cfun->curr_properties & PROP_gimple_lbitint) != 0 + && TYPE_PRECISION (TREE_TYPE (var)) > MAX_FIXED_MODE_SIZE) + { + /* Don't rewrite large/huge _BitInt vars after _BitInt lowering + into SSA form. */ + DECL_NOT_GIMPLE_REG_P (var) = 1; + if (dump_file) + { + fprintf (dump_file, "_BitInt var after its lowering: "); + print_generic_expr (dump_file, var); + fprintf (dump_file, "\n"); + } + } else if (DECL_NOT_GIMPLE_REG_P (var)) { maybe_reg = true; --- gcc/testsuite/gcc.dg/bitint-99.c.jj 2024-03-08 14:26:17.658069942 +0100 +++ gcc/testsuite/gcc.dg/bitint-99.c 2024-03-08 14:25:36.292645965 +0100 @@ -0,0 +1,26 @@ +/* PR tree-optimization/114278 */ +/* { dg-do compile { target bitint } } */ +/* { dg-options "-O2 -fno-tree-dce -fno-tree-dse -fno-tree-ccp" } */ +/* { dg-additional-options "-mavx2" { target i?86-*-* x86_64-*-* } } */ + +void +foo (void *p) +{ + _BitInt(64) b = *(_BitInt(64) *) __builtin_memmove (&b, p, sizeof (_BitInt(64))); +} + +#if __BITINT_MAXWIDTH__ >= 128 +void +bar (void *p) +{ + _BitInt(128) b = *(_BitInt(128) *) __builtin_memmove (&b, p, sizeof (_BitInt(128))); +} +#endif + +#if __BITINT_MAXWIDTH__ >= 256 +void +baz (void *p) +{ + _BitInt(256) b = *(_BitInt(256) *) __builtin_memmove (&b, p, sizeof (_BitInt(256))); +} +#endif