From patchwork Wed Apr 18 17:52:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Darrell Ball X-Patchwork-Id: 900292 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ocVQ/j9K"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40R8qG3RTrz9s4l for ; Thu, 19 Apr 2018 03:53:14 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 32574110FA; Wed, 18 Apr 2018 17:53:11 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 33E07110DB for ; Wed, 18 Apr 2018 17:53:10 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-pl0-f67.google.com (mail-pl0-f67.google.com [209.85.160.67]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id E04B26B6 for ; Wed, 18 Apr 2018 17:53:09 +0000 (UTC) Received: by mail-pl0-f67.google.com with SMTP id w21-v6so1563322plq.2 for ; Wed, 18 Apr 2018 10:53:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=HnDuMuzozA0IssCwy0tXl8uI/HgUELoT0eJ/Cz7I+Xo=; b=ocVQ/j9KMkqZjt2P3fKBCpW7ArSU10XrPQwqLuYgV6Abvx/2uhljlbOxW5W6VLD6CV b1uDKnFFOYPPVS2N1g0/NcQk1kLtwWwg3anGFg3QURNqKKXtnviwJ1LDZjG1uNJvmdon G+Ifo4UxkxGtCefPysE2clqlaylnjBUbBdb9+Un9UjM9F4g8EM8LALUcyet1/chCa7jt 3o8nTvqxuvNUoJSPBEK9vmvT1cbE11Zu1r0W8YLnngqfWYJUbfStlBFLiODYklZBeksW vVvssnjXzVu9nCnQk6ARXOUBJXfL1oOKE8sT5KYHi9hyEolR/efvk2Vw9vOS8o7StQsM 1evQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=HnDuMuzozA0IssCwy0tXl8uI/HgUELoT0eJ/Cz7I+Xo=; b=YF5hgGpfP6lnitT1m70HgZ7l4wFN8LZT5jU8Dm+nSzNigBwCis0bAmcoUmPvebebGJ qgM9/pJ1Acfn120g3EQ9rrxVSzihwt25hLAKVRo21s3SYTqGw7Jvy+8k5dhBGlQTPylV jw+RjvCQVHLfyICUYZo6a64m9qtl21Ho49jKb0MMw5LxKvsj0J5rWHf1cVg81gm6Ezri kc2SiEFcxKoT0zMpC11Sb35aZ4Efx3MOb12Vu6Qcu6b+gaKUH7gxFMUyx9YV8cMSAz6m HT9zfemQdn7Z4HqZe3zr62HxdUSAUdizjxKD7oKVYOOV0zoX6JuIyJPIqP7JT6dW8VAj CZOQ== X-Gm-Message-State: ALQs6tDTmiLAsB8CD3i5DIhUVquQwoS3OuLnep9lXW3L9biBzARhFh2s jc9YganTdmu2ewMATgl/WM3yig== X-Google-Smtp-Source: AIpwx49PNQ/3GspPY6qiaxqq/xYp99wjckGOfR6OwQuN44jFnRxTU0KJ0nasLvmlK1HQIPTyaFT7TQ== X-Received: by 2002:a17:902:8c91:: with SMTP id t17-v6mr3008098plo.182.1524073989439; Wed, 18 Apr 2018 10:53:09 -0700 (PDT) Received: from ubuntu.localdomain (c-73-162-236-45.hsd1.ca.comcast.net. [73.162.236.45]) by smtp.gmail.com with ESMTPSA id n83sm7245105pfi.183.2018.04.18.10.53.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 18 Apr 2018 10:53:08 -0700 (PDT) From: Darrell Ball To: dlu998@gmail.com, dev@openvswitch.org Date: Wed, 18 Apr 2018 10:52:58 -0700 Message-Id: <1524073978-66929-1-git-send-email-dlu998@gmail.com> X-Mailer: git-send-email 1.9.1 X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [patch v1] netdev: If MTU set fails, issue warn log. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org Recently, an issue was debugged that was thought to be a bond failover triggered issue. It turned out to an vlan interface MTU set issue that had nothing to do with bonding or most other likely possibilities. Besides the effect of not setting the MTU to the desired value, this can result in increased netlink traffic and processing with associated wasted work. Let us flag a configuration issue at warn level (rather than dbg) to catch the problem early. Signed-off-by: Darrell Ball --- lib/netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/netdev.c b/lib/netdev.c index a418d9a..8f09004 100644 --- a/lib/netdev.c +++ b/lib/netdev.c @@ -951,7 +951,7 @@ netdev_set_mtu(struct netdev *netdev, int mtu) error = class->set_mtu ? class->set_mtu(netdev, mtu) : EOPNOTSUPP; if (error && error != EOPNOTSUPP) { - VLOG_DBG_RL(&rl, "failed to set MTU for network device %s: %s", + VLOG_WARN_RL(&rl, "failed to set MTU for network device %s: %s", netdev_get_name(netdev), ovs_strerror(error)); }