From patchwork Fri Feb 2 20:12:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mario Limonciello X-Patchwork-Id: 1894761 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=185.125.189.65; helo=lists.ubuntu.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=patchwork.ozlabs.org) Received: from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TRRmL4J2mz1yhq for ; Sat, 3 Feb 2024 07:13:21 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=lists.ubuntu.com) by lists.ubuntu.com with esmtp (Exim 4.86_2) (envelope-from ) id 1rVzuT-0005gN-L2; Fri, 02 Feb 2024 20:13:13 +0000 Received: from mail-bn1nam02on2064.outbound.protection.outlook.com ([40.107.212.64] helo=NAM02-BN1-obe.outbound.protection.outlook.com) by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1rVzuK-0005Zp-Cp for fwts-devel@lists.ubuntu.com; Fri, 02 Feb 2024 20:13:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jT3Wj9rRWOTIj4ZJHpyLTn0NJB7L6omT9GqdC0XfkDLeuJNol7QokuRQr7/zqWCmPlgVVsif0poTS33BAIO3KnzzC70IvIDSLQKtw5/woXmoynFarokez1+c9JctPgdeEPR507CY+S6wLtjLRt3owpzRMALc2maqGekkM2l1Rboka7ed9PaztIzkytocpoaVju3/HKq7U42hNjMKe/DBA2hmRGodvoPm3eyNHp+6I1wiXJqRzPW6J9eWIz0rHVwtqDA5/Ai45nPVS/AMw9nCf84a1hAbaGvvhdqX/uhsJM6Is2hrEdrxKn3yS5QmC80xRSBFcKlMrAbJ3KPncXu7gA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MJQ9FEBOSx2g1RdxuMq67PftT28X7yBvvEZpAjyMfLU=; b=YampChpmMSB4jDgCts4u3577nBVOIHDPo7v0Rdb1I5xu7t13AfpWIgjdG3+nHjJWr5jkdwqzy5gN/rf8+3qAaDoGvwaJ49pKySpK4sqVNLJtmQ0g3vxZe3BMgnw5mAhUhYy57rNpY6ghjnKxEx9a27frI4piy6hsv8JbckgH9emEf4lIc1SWZ1LQGvq2ngTMCFFjLLlGGcpNIZegXQn+Y2jUVeNSYuW40nzHdOJPF5YR28Du1MolshM6Eo7c087Ay55XVXm8Ub0El2672A93k+s/N9wSkLOkYbPeqCy5Oez3y2p914Z6u51bCue5d3+gwjyFvozNRfy3OPCOMRw55Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.ubuntu.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) Received: from BN9PR03CA0757.namprd03.prod.outlook.com (2603:10b6:408:13a::12) by IA1PR12MB7520.namprd12.prod.outlook.com (2603:10b6:208:42f::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.34; Fri, 2 Feb 2024 20:13:01 +0000 Received: from BN3PEPF0000B06E.namprd21.prod.outlook.com (2603:10b6:408:13a:cafe::60) by BN9PR03CA0757.outlook.office365.com (2603:10b6:408:13a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.31 via Frontend Transport; Fri, 2 Feb 2024 20:13:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN3PEPF0000B06E.mail.protection.outlook.com (10.167.243.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7292.0 via Frontend Transport; Fri, 2 Feb 2024 20:13:01 +0000 Received: from AUS-P9-MLIMONCI.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 2 Feb 2024 14:13:01 -0600 From: Mario Limonciello To: Subject: [PATCH] dmicheck: Don't check firmware version on anything but NVDIMM devices Date: Fri, 2 Feb 2024 14:12:15 -0600 Message-ID: <20240202201215.373-1-mario.limonciello@amd.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B06E:EE_|IA1PR12MB7520:EE_ X-MS-Office365-Filtering-Correlation-Id: 745718fe-3741-4e8a-fbe3-08dc242b5b72 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: R0qFiYdIPT3zbaDavzOuhPPnjfOLeAAUeOxC/lE/qgAU2gkXtZK/vC0f1mfHZf9/lyKPB6nlPl4HFOPB0RSmrcKqRvNG4MdfaccnDdgk0lRV8q7yFr/EpYR7PmkW4H/Y0vBaMlgXy6jR6sbfTWazFi0Kx36IIRqx60m2ZTxX21JTm2dOMcbDfxlBKztQnuySYYBktSWsX2hu9HIZmHfln6mm96IumWPNSwp5MOKhUYj2LGr67V8EmeRiJkIDr64YyzKV7ZEQzF9onQSyezF1m0bd54YFofComPZjnycEJyn+aV0NR7zCE5fZzr0HTGoelo20uaQQSa0WqgAwfowqF9e5r2v3ATol8vzyW3pX93WeUa6TD0ptN6LGGGC819PJVcUhbSd9m4fFIlxToY23e4RuJ1AGdxdzikUCDEfO99oSQUCOzWZ7Kg9TZE2qdZORNVSydKHDPfNqtlVsVu06Hd24QmzkrqOWaMQljwKL4JqYzaAVZAxwWOq1GOEKR8p5pH9ao/uClV/sqHhosmd4ifGRv9fJ2wBLhBQf4MzQ7iZN9YdNx/tG8ANLSC3H1KJCGIeTBZvzFOZ2Yn005A3NnplyX/oIzymbarpHwUlynTVupYL9Qa2jMEny9Zx5ZPFON66UKXN8hpO8vupS5DTT7wVkiKtZ1rSjJWcUhAu6QJPmH3fykeACTfiits6UlFZ8CoNJr2bIPCdkr115nEiZxSSsQ8G6TYtjT7CY7mCJhAtYft9zibwIlU0oVaQTYMFXaYALImk1RFOBczZnLSAMDg== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(4636009)(396003)(136003)(39860400002)(346002)(376002)(230922051799003)(1800799012)(451199024)(186009)(82310400011)(64100799003)(36840700001)(40470700004)(46966006)(2906002)(5660300002)(44832011)(47076005)(81166007)(86362001)(478600001)(8676002)(36756003)(26005)(1076003)(36860700001)(426003)(83380400001)(336012)(41300700001)(2616005)(7696005)(6666004)(16526019)(356005)(82740400003)(6916009)(8936002)(4326008)(316002)(70206006)(966005)(40480700001)(40460700003)(70586007)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2024 20:13:01.5754 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 745718fe-3741-4e8a-fbe3-08dc242b5b72 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B06E.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7520 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mario Limonciello Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" The firmware version offset is only valid for NVDIMM. Link: https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.7.0.pdf Signed-off-by: Mario Limonciello Acked-by: Ivan Hu --- src/dmi/dmicheck/dmicheck.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c index b7cca5e4..49d33ce3 100644 --- a/src/dmi/dmicheck/dmicheck.c +++ b/src/dmi/dmicheck/dmicheck.c @@ -1678,7 +1678,15 @@ static void dmicheck_entry(fwts_framework *fw, dmi_min_max_uint8_check(fw, table, addr, "Memory Technology", hdr, 0x28, 0x1, 0x7); dmi_reserved_bits_check(fw, table, addr, "Memory Operating Mode Cap", hdr, sizeof(uint16_t), 0x29, 0, 0); dmi_reserved_bits_check(fw, table, addr, "Memory Operating Mode Cap", hdr, sizeof(uint16_t), 0x29, 6, 15); - dmi_str_check(fw, table, addr, "Firmware Version", hdr, 0x2b); + switch(hdr->data[0x28]) { + case 0x04: + case 0x05: + case 0x06: + dmi_str_check(fw, table, addr, "Firmware Version", hdr, 0x2b); + break; + default: + break; + } if (hdr->length < 0x54) break; dmi_reserved_bits_check(fw, table, addr, "Extended Speed", hdr, sizeof(uint32_t), 0x54, 31, 31);